Re: [PATCH v5 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-09-18 Thread Corentin Labbe
On Thu, Sep 14, 2017 at 09:19:49PM +0200, Andrew Lunn wrote: > > > Is the MDIO controller "allwinner,sun8i-h3-emac" or "snps,dwmac-mdio"? > > > If the latter, then I think the node is fine, but then the mux should be > > > a child node of it. IOW, the child of an MDIO controller should either >

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-18 Thread Richard Cochran
On Mon, Sep 18, 2017 at 04:06:28PM -0700, Vinicius Costa Gomes wrote: > That's the point, the application does not need to know that, and asking > that would be stupid. On the contrary, this information is essential to the application. Probably you have never seen an actual Ethernet field bus in

[PATCH net-next] net: sk_buff rbnode reorg

2017-09-18 Thread Eric Dumazet
From: Eric Dumazet skb->rbnode shares space with skb->next, skb->prev and skb->tstamp Current uses (TCP receive ofo queue and netem) need to save/restore tstamp. Since we might use an RB tree for TCP retransmit queue at some point to speedup SACK processing with large

linux-next: Signed-off-by missing for commit in the net tree

2017-09-18 Thread Stephen Rothwell
Hi all, Commit 129c6cda2de2 ("8139too: revisit napi_complete_done() usage") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell

Re: [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum

2017-09-18 Thread David Miller
From: Tom Herbert Date: Mon, 18 Sep 2017 17:39:02 -0700 > Add configuration to control use of zero checksums on transmit for both > IPv4 and IPv6, and control over accepting zero IPv6 checksums on > receive. > > Signed-off-by: Tom Herbert I thought we

Re: [PATCH net-next 11/14] net: Add a facility to support application defined GSO

2017-09-18 Thread David Miller
From: Tom Herbert Date: Mon, 18 Sep 2017 17:39:01 -0700 > Allow applications or encapsulation protocols to register a GSO segment > function to their specific protocol. To faciliate this I reserved the > upper four bits in the gso_type to indicate the application specific

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-18 Thread David Miller
From: Tom Herbert Date: Mon, 18 Sep 2017 17:38:58 -0700 > Allow peers to be specified by IPv6 addresses. > > Signed-off-by: Tom Herbert Hmmm, can you just check the socket family or something like that?

Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets

2017-09-18 Thread David Miller
From: Tom Herbert Date: Mon, 18 Sep 2017 17:38:57 -0700 > @@ -98,6 +104,7 @@ static void pdp_context_delete(struct pdp_ctx *pctx); > static inline u32 gtp0_hashfn(u64 tid) > { > u32 *tid32 = (u32 *) > + > return jhash_2words(tid32[0], tid32[1], gtp_h_initval);

Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel routes and add dst_cache

2017-09-18 Thread David Miller
From: Tom Herbert Date: Mon, 18 Sep 2017 17:38:53 -0700 > Call ip_tunnel_get_route and dst_cache to pdp context which should > improve performance by obviating the need to perform a route lookup > on every packet. > > Signed-off-by: Tom Herbert Not

Re: RFC: Audit Kernel Container IDs

2017-09-18 Thread Richard Guy Briggs
On 2017-09-18 21:45, Eric W. Biederman wrote: > Richard Guy Briggs writes: > > > On 2017-09-14 12:33, Eric W. Biederman wrote: > >> Richard Guy Briggs writes: > >> > >> > The trigger is a pseudo filesystem (proc, since PID tree already exists) > >> > write of

Re: [PATCH net] net: systemport: Fix 64-bit statistics dependency

2017-09-18 Thread David Miller
From: Florian Fainelli Date: Mon, 18 Sep 2017 16:31:30 -0700 > There are several problems with commit 10377ba7673d ("net: systemport: > Support 64bit statistics", first one got fixed in 7095c973453e ("net: > systemport: Fix 64-bit stats deadlock"). > > The second problem

Re: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC

2017-09-18 Thread Leon Romanovsky
On Tue, Sep 19, 2017 at 02:06:21AM +0100, Salil Mehta wrote: > This patch set presents some bug fixes for the HNS3 Ethernet driver, > identified > during internal testing & stabilization efforts. > > This patch series is meant for Linux 4.14 kernel. > > Lipeng (6): > net: hns3: get phy addr

Re: [PATCH net] 8139too: revisit napi_complete_done() usage

2017-09-18 Thread David Miller
From: Eric Dumazet Date: Mon, 18 Sep 2017 13:03:43 -0700 > From: Eric Dumazet > > It seems we have to be more careful in napi_complete_done() > use. This patch is not a revert, as it seems we can > avoid bug that Ville reported by moving the

Re: [PATCHv2 iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

2017-09-18 Thread Hangbin Liu
Hi Michal, On Mon, Sep 18, 2017 at 09:55:05AM +0200, Michal Kubecek wrote: > > +static int rtnl_recvmsg(int fd, struct msghdr *msg, char **answer) > > +{ > > + struct iovec *iov; > > + int len = -1, buf_len = 32768; > > + char *bufp, *buf = NULL; > > + > > + int flag = MSG_PEEK |

Re: RFC: Audit Kernel Container IDs

2017-09-18 Thread Eric W. Biederman
Richard Guy Briggs writes: > On 2017-09-14 12:33, Eric W. Biederman wrote: >> Richard Guy Briggs writes: >> >> > The trigger is a pseudo filesystem (proc, since PID tree already exists) >> > write of a u64 representing the container ID to a file representing a

[PATCH net-next v2 12/12] net: dsa: bcm_sf2: Utilize b53_{enable,disable}_port

2017-09-18 Thread Florian Fainelli
Export b53_{enable,disable}_port and use these two functions in bcm_sf2_port_setup and bcm_sf2_port_disable. The generic functions cannot be used without wrapping because we need to manage additional switch integration details (PHY, Broadcom tag etc.). Signed-off-by: Florian Fainelli

[PATCH net-next v2 07/12] net: dsa: b53: Define EEE register page

2017-09-18 Thread Florian Fainelli
In preparation for migrating the EEE code from bcm_sf2 to b53, define the full EEE register page and offsets within that page. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_regs.h | 41 + 1 file changed, 41

[PATCH net-next v2 11/12] net: dsa: bcm_sf2: Use SF2_NUM_EGRESS_QUEUES for CFP

2017-09-18 Thread Florian Fainelli
The magic number 8 in 3 locations in bcm_sf2_cfp.c actually designates the number of switch port egress queues, so use that define instead of open-coding it. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2_cfp.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH net-next v2 10/12] net: dsa: b53: Export b53_imp_vlan_setup()

2017-09-18 Thread Florian Fainelli
bcm_sf2 and b53 do exactly the same thing, so share that piece. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 3 ++- drivers/net/dsa/b53/b53_priv.h | 1 + drivers/net/dsa/bcm_sf2.c| 23 +-- 3 files changed, 4

[PATCH net-next v2 05/12] net: dsa: b53: Use a macro to define I/O operations

2017-09-18 Thread Florian Fainelli
Instead of repeating the same pattern: acquire mutex, read/write, release mutex, define a macro: b53_build_op() which takes the type (read|write), I/O size, and value (scalar or pointer). This helps with fixing bugs that could exist (e.g: missing barrier, lock etc.). Reviewed-by: Vivien Didelot

[PATCH net-next v2 06/12] net: dsa: b53: Move Broadcom header setup to b53

2017-09-18 Thread Florian Fainelli
The code to enable Broadcom tags/headers is largely switch independent, and in preparation for enabling it for multiple devices with b53, move the code we have in bcm_sf2.c to b53_common.c Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli

[PATCH net-next v2 09/12] net: dsa: b53: Wire-up EEE

2017-09-18 Thread Florian Fainelli
Add support for enabling and disabling EEE, as well as re-negotiating it in .adjust_link() and in .port_enable(). Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH net-next v2 08/12] net: dsa: b53: Move EEE functions to b53

2017-09-18 Thread Florian Fainelli
Move the bcm_sf2 EEE-related functions to the b53 driver because this is shared code amongst Gigabit capable switch, only 5325 and 5365 are too old to support that. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 63

Re: [PATCH net-next] net_sched: sch_htb: add per class overlimits counter

2017-09-18 Thread David Miller
From: Eric Dumazet Date: Mon, 18 Sep 2017 12:36:22 -0700 > From: Eric Dumazet > > HTB qdisc overlimits counter is properly increased, but we have no per > class counter, meaning it is difficult to diagnose HTB problems. > > This patch adds this

[PATCH net-next v2 04/12] net: dsa: bcm_sf2: Defer port enabling to calling port_enable

2017-09-18 Thread Florian Fainelli
There is no need to configure the enabled ports once in bcm_sf2_sw_setup() and then a second time around when dsa_switch_ops::port_enable is called, just do it when port_enable is called which is better in terms of power consumption and correctness. Reviewed-by: Vivien Didelot

[PATCH net-next v2 03/12] net: dsa: b53: Defer port enabling to calling port_enable

2017-09-18 Thread Florian Fainelli
There is no need to configure the enabled ports once in b53_setup() and then a second time around when dsa_switch_ops::port_enable is called, just do it when port_enable is called which is better in terms of power consumption and correctness. Reviewed-by: Vivien Didelot

[PATCH net-next v2 02/12] net: dsa: b53: Make b53_enable_cpu_port() take a port argument

2017-09-18 Thread Florian Fainelli
In preparation for future changes allowing the configuring of multiple CPU ports, make b53_enable_cpu_port() take a port argument. Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 11

[PATCH net-next v2 01/12] net: dsa: b53: Remove is_cpu_port()

2017-09-18 Thread Florian Fainelli
This is not used anywhere, so remove it. Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_priv.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/dsa/b53/b53_priv.h

[PATCH net-next v2 00/12] net: dsa: b53/bcm_sf2 cleanups

2017-09-18 Thread Florian Fainelli
Hi all, This patch series is a first pass set of clean-ups to reduce the number of LOCs between b53 and bcm_sf2 and sharing as many functions as possible. There is a number of additional cleanups queued up locally that require more thorough testing. Thanks! Changes in v2: - added Reviewed-by

Re: [PATCH net] bpf: fix ri->map prog pointer on bpf_prog_realloc

2017-09-18 Thread Alexei Starovoitov
On Tue, Sep 19, 2017 at 03:16:44AM +0200, Daniel Borkmann wrote: > Commit 109980b894e9 ("bpf: don't select potentially stale > ri->map from buggy xdp progs") passed the pointer to the prog > itself to be loaded into r4 prior on bpf_redirect_map() helper > call, so that we can store the owner into

Re: cross namespace interface notification for tun devices

2017-09-18 Thread Jason A. Donenfeld
On Mon, Sep 18, 2017 at 8:47 PM, Jason A. Donenfeld wrote: > The best I've come up with is, in a sleep loop, writing to the tun > device's fd something with a NULL or invalid payload. If the interface > is down, the kernel returns -EIO. If the interface is up, the kernel >

[PATCH net] bpf: fix ri->map prog pointer on bpf_prog_realloc

2017-09-18 Thread Daniel Borkmann
Commit 109980b894e9 ("bpf: don't select potentially stale ri->map from buggy xdp progs") passed the pointer to the prog itself to be loaded into r4 prior on bpf_redirect_map() helper call, so that we can store the owner into ri->map_owner out of the helper. Issue with that is that the actual

[PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC

2017-09-18 Thread Salil Mehta
This patch set presents some bug fixes for the HNS3 Ethernet driver, identified during internal testing & stabilization efforts. This patch series is meant for Linux 4.14 kernel. Lipeng (6): net: hns3: get phy addr from NCL_config net: hns3: fix the command used to unmap ring from vector

[PATCH net 3/7] net: hns3: Fix ring and vector map command

2017-09-18 Thread Salil Mehta
From: Lipeng This patch add INT_GL and VF id to vector configure when bind ring with vector. INT_GL means Interrupt Gap Limiting. Vector id starts from 0 in each VF, so the bind command must specify VF id. Signed-off-by: Lipeng Signed-off-by:

[PATCH net 5/7] net: hns3: fixes the ether address copy with more appropriate API

2017-09-18 Thread Salil Mehta
This patch replaces the ethernet address copy instance with more appropriate ether_addr_copy() function. Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH net 4/7] net: hns3: fix a bug of set mac address

2017-09-18 Thread Salil Mehta
From: Lipeng HNS3 driver get mac address from NCL_config file and set the mac address to HW. If the mac address in NCL_config is invalid, driver will set a random mac address, and use this address. The current code will set random mac address to HW, but will not set the

[PATCH net 7/7] net: hns3: Fixes the premature exit of loop when matching clients

2017-09-18 Thread Salil Mehta
From: Lipeng When register/unregister ae_dev, ae_dev should match all client in the client_list. Enet and roce can co-exists together so we should continue checking for enet and roce presence together. So break should not be there. Above caused problems in loading and

RE: [PATCH V2] tipc: Use bsearch library function

2017-09-18 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Joe Perches > Sent: Sunday, September 17, 2017 23:15 > To: Jon Maloy ; Thomas Meyer > > Cc: Ying Xue ;

[PATCH net 6/7] net: hns3: set default vlan id to PF

2017-09-18 Thread Salil Mehta
From: Lipeng When there is no vlan id in the packets, hardware will treat the vlan id as 0 and look for the mac_vlan table. This patch set the default vlan id of PF as 0. Without this config, it will fail when look for mac_vlan table, and hardware will drop packets.

[PATCH net 1/7] net: hns3: get phy addr from NCL_config

2017-09-18 Thread Salil Mehta
From: Lipeng NCL_config file defines phy address for every port. Driver should get phy address from NCL_config file.If do not get the right phy address, every port will use the default phy address 0, different port use the same phy address will cause error. Signed-off-by:

[PATCH net 2/7] net: hns3: fix the command used to unmap ring from vector

2017-09-18 Thread Salil Mehta
From: Lipeng When unmap ring from vector, it use wrong command, this will cause error if the unmap action need multi command description. This patch fix the error. Signed-off-by: Lipeng Signed-off-by: Salil Mehta ---

RE: [PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers

2017-09-18 Thread Tristram.Ha
> I am not really sure why this is such a concern for you so soon when > your driver is not even included yet. You should really aim for baby > steps here: get the basic driver(s) included, with a limited set of > features, and gradually add more features to the driver. When > fwd_offload_mark and

ipv4 ID calculation

2017-09-18 Thread Harsha Chenji
Hi all, Where is the ID field of the IPv4 header created when the DF flag is set? I am looking at ip_build_and_send_pkt. The code seems to have changed in 4.4-rc1: if (ip_dont_fragment(sk, >dst)) { iph->frag_off = htons(IP_DF); iph->id = 0; } else { iph->frag_off = 0;

[PATCH net-next 06/14] gtp: Eliminate pktinfo and add port configuration

2017-09-18 Thread Tom Herbert
The gtp pktinfo structure is unnecessary and needs a lot of code to manage it. Remove it. Also, add per pdp port configuration for transmit. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 167 ---

[PATCH net-next 09/14] gtp: Allow configuring GTP interface as standalone

2017-09-18 Thread Tom Herbert
Add new configuration of GTP interfaces that allow specifying a port to listen on (as opposed to having to get sockets from a userspace control plane). This allows GTP interfaces to be configured and the data path tested without requiring a GTP-C daemon. Signed-off-by: Tom Herbert

[PATCH net-next 03/14] gtp: Call common functions to get tunnel routes and add dst_cache

2017-09-18 Thread Tom Herbert
Call ip_tunnel_get_route and dst_cache to pdp context which should improve performance by obviating the need to perform a route lookup on every packet. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 59 ++- 1 file

[PATCH net-next 13/14] gtp: Support for GRO

2017-09-18 Thread Tom Herbert
Populate GRO receive and GRO complete functions for GTP-Uv0 and v1. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 204 ++ 1 file changed, 204 insertions(+) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index

[PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-18 Thread Tom Herbert
Allow peers to be specified by IPv6 addresses. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 198 +-- include/uapi/linux/gtp.h | 1 + include/uapi/linux/if_link.h | 3 + 3 files changed, 158 insertions(+), 44

[PATCH net-next 14/14] gtp: GSO support

2017-09-18 Thread Tom Herbert
Need to define a gtp_gso_segment since the GTP header includes a length field that must be set per packet. Also, GPv0 header includes a sequence number that is incremented per packet. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 176

[PATCH net-next 10/14] gtp: Add support for devnet

2017-09-18 Thread Tom Herbert
Add a net field to gtp that is derived from src_net. Use net_eq to make cross net argument for transmit functions. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/gtp.c

[PATCH net-next 12/14] gtp: Configuration for zero UDP checksum

2017-09-18 Thread Tom Herbert
Add configuration to control use of zero checksums on transmit for both IPv4 and IPv6, and control over accepting zero IPv6 checksums on receive. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 35 +--

[PATCH net-next 02/14] vxlan: Call common functions to get tunnel routes

2017-09-18 Thread Tom Herbert
Call ip_tunnel_get_route and ip6_tnl_get_route to handle getting a route and dealing with the dst_cache. Signed-off-by: Tom Herbert --- drivers/net/vxlan.c | 84 - 1 file changed, 5 insertions(+), 79 deletions(-) diff

[PATCH net-next 05/14] gtp: Remove special mtu handling

2017-09-18 Thread Tom Herbert
Removes MTU handling in gtp_build_skb_ip4. This is non standard relative to how other tunneling protocols handle MTU. The model espoused is that the inner interface should set it's MTU to be less than the expected path MTU on the overlay network. Path MTU discovery is not typically used for

[PATCH net-next 11/14] net: Add a facility to support application defined GSO

2017-09-18 Thread Tom Herbert
Allow applications or encapsulation protocols to register a GSO segment function to their specific protocol. To faciliate this I reserved the upper four bits in the gso_type to indicate the application specific GSO type. Zero in these bits indicates no application GSO, so there are fifteen

[PATCH net-next 00/14] gtp: Additional feature support

2017-09-18 Thread Tom Herbert
This patch set builds upon the initial GTP implementation to make support closer to that enjoyed by other encapsulation protocols. The major items are: - IPv6 support - Configurable networking interfaces so that GTP kernel can be used and tested without needing GSN network emulation

[PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets

2017-09-18 Thread Tom Herbert
Allow IPv6 mobile subscriber packets. This entails adding an IPv6 mobile subscriber address to pdp context and IPv6 specific variants to find pdp contexts by address. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 259

[PATCH net-next 04/14] gtp: udp recv clean up

2017-09-18 Thread Tom Herbert
Create separate UDP receive functions for GTP version 0 and version 1. Set encap_rcv appropriately when configuring a socket. Also, convert to using gro_cells. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 130 +- 1

[PATCH net-next 01/14] iptunnel: Add common functions to get a tunnel route

2017-09-18 Thread Tom Herbert
ip_tunnel_get_route and ip6_tnl_get_route are create to return routes for a tunnel. These functions are derived from the VXLAN functions. Signed-off-by: Tom Herbert --- include/net/ip6_tunnel.h | 33 + include/net/ip_tunnels.h | 33

Re: [PATCH net] tcp: remove two unused functions

2017-09-18 Thread David Miller
From: Yuchung Cheng Date: Mon, 18 Sep 2017 11:05:16 -0700 > remove tcp_may_send_now and tcp_snd_test that are no longer used > > Fixes: 840a3cbe8969 ("tcp: remove forward retransmit feature") > Signed-off-by: Yuchung Cheng > Signed-off-by: Neal Cardwell

Re: [PATCH net 1/3] net: mvpp2: fix the dma_mask and coherent_dma_mask settings for PPv2.2

2017-09-18 Thread David Miller
From: Antoine Tenart Date: Mon, 18 Sep 2017 15:04:06 +0200 > The dev->dma_mask usually points to dev->coherent_dma_mask. This is an > issue as setting both of them will override the other. This is > problematic here as the PPv2 driver uses a 32-bit-mask for

RE: [Intel-wired-lan] [PATCH 2/5] e1000e: Fix wrong comment related to link detection

2017-09-18 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Benjamin Poirier > Sent: Friday, July 21, 2017 11:36 AM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org; Lennart

Re: [PATCH] bpf: devmap: pass on return value of bpf_map_precharge_memlock

2017-09-18 Thread David Miller
From: Tobias Klauser Date: Mon, 18 Sep 2017 15:03:46 +0200 > If bpf_map_precharge_memlock in dev_map_alloc, -ENOMEM is returned > regardless of the actual error produced by bpf_map_precharge_memlock. > Fix it by passing on the error returned by bpf_map_precharge_memlock. >

Re: [net PATCH] bnxt_en: check for ingress qdisc in flower offload

2017-09-18 Thread David Miller
From: Sathya Perla Date: Mon, 18 Sep 2017 17:05:37 +0530 > Check for ingress-only qdisc for flower offload, as other qdiscs > are not supported for flower offload. > > Suggested-by: Jiri Pirko > Signed-off-by: Sathya Perla

Re: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm

2017-09-18 Thread David Miller
From: Colin King Date: Mon, 18 Sep 2017 12:40:38 +0100 > From: Colin Ian King > > Pointer tcm is being initialized and is never read, it is only being used > to determine the size of struct tcmsg. Clean this up by removing > variable tcm and

Re: [PATCH net-next v2 0/7] korina: performance fixes and cleanup

2017-09-18 Thread David Miller
From: Roman Yeryomin Date: Sun, 17 Sep 2017 20:23:53 +0300 > Changes from v1: > - use GRO instead of increasing ring size > - use NAPI_POLL_WEIGHT instead of defining own NAPI_WEIGHT > - optimize rx descriptor flags processing Series applied, thank you.

Re: [PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers

2017-09-18 Thread Florian Fainelli
On 09/18/2017 04:44 PM, tristram...@microchip.com wrote: >>> In the old DSA implementation all the ports are partitioned into its own >> device >>> and the bridge joining them will do all the forwarding. This is useful for >> quick >>> testing with some protocols like RSTP but it is probably

RE: [PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers

2017-09-18 Thread Tristram.Ha
> > In the old DSA implementation all the ports are partitioned into its own > device > > and the bridge joining them will do all the forwarding. This is useful for > quick > > testing with some protocols like RSTP but it is probably useless for real > > operation. > > It is a good minimal

Re: [PATCH] hamradio: baycom: use new parport device model

2017-09-18 Thread David Miller
From: Sudip Mukherjee Date: Sun, 17 Sep 2017 12:46:20 +0100 > Modify baycom driver to use the new parallel port device model. > > Signed-off-by: Sudip Mukherjee Applied to net-next, thanks.

Re: [PATCH] Documentation: networking: fix ASCII art in switchdev.txt

2017-09-18 Thread David Miller
From: Randy Dunlap Date: Sat, 16 Sep 2017 13:10:06 -0700 > From: Randy Dunlap > > Fix ASCII art in Documentation/networking/switchdev.txt: > > Change non-ASCII "spaces" to ASCII spaces. > > Change 2 erroneous '+' characters in ASCII art to '-'

[PATCH net] bpf: one perf event close won't free bpf program attached by another perf event

2017-09-18 Thread Yonghong Song
This patch fixes a bug exhibited by the following scenario: 1. fd1 = perf_event_open with attr.config = ID1 2. attach bpf program prog1 to fd1 3. fd2 = perf_event_open with attr.config = ID1 4. user program closes fd2 and prog1 is detached from the tracepoint. 5. user program with

Re: [PATCH net] net/sched: cls_matchall: fix crash when used with classful qdisc

2017-09-18 Thread David Miller
From: Davide Caratti Date: Sat, 16 Sep 2017 14:02:21 +0200 > this script, edited from Linux Advanced Routing and Traffic Control guide > > tc q a dev en0 root handle 1: htb default a > tc c a dev en0 parent 1: classid 1:1 htb rate 6mbit burst 15k > tc c a dev en0 parent

Re: [PATCH net] ip6_tunnel: do not allow loading ip6_tunnel if ipv6 is disabled in cmdline

2017-09-18 Thread David Miller
From: Xin Long Date: Fri, 15 Sep 2017 15:58:33 +0800 > If ipv6 has been disabled from cmdline since kernel started, it makes > no sense to allow users to create any ip6 tunnel. Otherwise, it could > some potential problem. > > Jianlin found a kernel crash caused by this in

Re: [PATCH net] net: phy: Fix mask value write on gmii2rgmii converter speed register

2017-09-18 Thread David Miller
From: Fahad Kunnathadi Date: Fri, 15 Sep 2017 12:01:58 +0530 > To clear Speed Selection in MDIO control register(0x10), > ie, clear bits 6 and 13 to zero while keeping other bits same. > Before AND operation,The Mask value has to be perform with bitwise NOT >

[PATCH net] net: systemport: Fix 64-bit statistics dependency

2017-09-18 Thread Florian Fainelli
There are several problems with commit 10377ba7673d ("net: systemport: Support 64bit statistics", first one got fixed in 7095c973453e ("net: systemport: Fix 64-bit stats deadlock"). The second problem is that this specific code updates the stats64.tx_{packets,bytes} from ndo_get_stats64() and

Re: [PATCH net-next 00/12] net: dsa: b53/bcm_sf2 cleanups

2017-09-18 Thread David Miller
From: Florian Fainelli Date: Mon, 18 Sep 2017 14:46:48 -0700 > On 09/18/2017 02:41 PM, Florian Fainelli wrote: >> Hi all, >> >> This patch series is a first pass set of clean-ups to reduce the number of >> LOCs >> between b53 and bcm_sf2 and sharing as many functions as

Re: [PATCH 16/16] thunderbolt: Add support for networking over Thunderbolt cable

2017-09-18 Thread Andrew Lunn
On Mon, Sep 18, 2017 at 06:30:49PM +0300, Mika Westerberg wrote: > From: Amir Levy > > ThunderboltIP is a protocol created by Apple to tunnel IP/ethernet > traffic over a Thunderbolt cable. The protocol consists of configuration > phase where each side sends

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-18 Thread Vinicius Costa Gomes
Hi Richard, Richard Cochran writes: > On Thu, Aug 31, 2017 at 06:26:20PM -0700, Vinicius Costa Gomes wrote: >> * Time-aware shaper (802.1Qbv): > > I just posted a working alternative showing how to handle 802.1Qbv and > many other Ethernet field buses. > >>The

[PATCH net-next v3 2/4] bpf: add a test case for helper bpf_perf_event_read_value

2017-09-18 Thread Yonghong Song
The bpf sample program tracex6 is enhanced to use the new helper to read enabled/running time as well. Signed-off-by: Yonghong Song --- samples/bpf/tracex6_kern.c| 26 ++ samples/bpf/tracex6_user.c| 13 -

[PATCH net-next v3 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

2017-09-18 Thread Yonghong Song
Hardware pmu counters are limited resources. When there are more pmu based perf events opened than available counters, kernel will multiplex these events so each event gets certain percentage (but not 100%) of the pmu time. In case that multiplexing happens, the number of samples or counter value

[PATCH net-next v3 3/4] bpf: add helper bpf_perf_prog_read_value

2017-09-18 Thread Yonghong Song
This patch adds helper bpf_perf_prog_read_cvalue for perf event based bpf programs, to read event counter and enabled/running time. The enabled/running time is accumulated since the perf event open. The typical use case for perf event based bpf program is to attach itself to a single event. In

[PATCH net-next v3 0/4] bpf: add two helpers to read perf event enabled/running time

2017-09-18 Thread Yonghong Song
Hardware pmu counters are limited resources. When there are more pmu based perf events opened than available counters, kernel will multiplex these events so each event gets certain percentage (but not 100%) of the pmu time. In case that multiplexing happens, the number of samples or counter value

[PATCH net-next v3 4/4] bpf: add a test case for helper bpf_perf_prog_read_value

2017-09-18 Thread Yonghong Song
The bpf sample program trace_event is enhanced to use the new helper to print out enabled/running time. Signed-off-by: Yonghong Song --- samples/bpf/trace_event_kern.c| 10 ++ samples/bpf/trace_event_user.c| 13 -

Re: [PATCH net-next 3/3] bpf: Test deletion in BPF_MAP_TYPE_LPM_TRIE

2017-09-18 Thread Alexei Starovoitov
On 9/18/17 12:30 PM, Craig Gallek wrote: From: Craig Gallek Extend the 'random' operation tests to include a delete operation (delete half of the nodes from both lpm implementions and ensure that lookups are still equivalent). Also, add a simple IPv4 test which verifies

Re: [PATCH net-next 2/3] bpf: Add uniqueness invariant to trivial lpm test implementation

2017-09-18 Thread Alexei Starovoitov
On 9/18/17 12:30 PM, Craig Gallek wrote: From: Craig Gallek The 'trivial' lpm implementation in this test allows equivalent nodes to be added (that is, nodes consisting of the same prefix and prefix length). For lookup operations, this is fine because insertion happens at

Re: [PATCH net-next 1/3] bpf: Implement map_delete_elem for BPF_MAP_TYPE_LPM_TRIE

2017-09-18 Thread Alexei Starovoitov
On 9/18/17 12:30 PM, Craig Gallek wrote: From: Craig Gallek This is a simple non-recursive delete operation. It prunes paths of empty nodes in the tree, but it does not try to further compress the tree as nodes are removed. Signed-off-by: Craig Gallek ---

Re: [PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers

2017-09-18 Thread Andrew Lunn
> In the old DSA implementation all the ports are partitioned into its own > device > and the bridge joining them will do all the forwarding. This is useful for > quick > testing with some protocols like RSTP but it is probably useless for real > operation. It is a good minimal driver, to get

Re: [PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers

2017-09-18 Thread Andrew Lunn
On Mon, Sep 18, 2017 at 08:55:17PM +, tristram...@microchip.com wrote: > > > > This is ugly. We have a clean separation between a switch driver and a > > > > tag driver. Here you are mixing them together. Don't. Look at the > > > > mailing lists for what Florian and I suggested to Pavel. It

Re: [PATCH net-next 09/12] net: dsa: b53: Wire-up EEE

2017-09-18 Thread Florian Fainelli
On 09/18/2017 03:29 PM, Vivien Didelot wrote: > Hi Florian, > > Florian Fainelli writes: > >> @@ -1000,6 +1005,9 @@ static void b53_adjust_link(struct dsa_switch *ds, int >> port, >> b53_write8(dev, B53_CTRL_PAGE, po_reg, gmii_po); >> }

Re: [PATCH net-next 08/12] net: dsa: b53: Move EEE functions to b53

2017-09-18 Thread Florian Fainelli
On 09/18/2017 03:27 PM, Vivien Didelot wrote: > Hi Florian, > > Florian Fainelli writes: > >> @@ -649,7 +595,7 @@ static void bcm_sf2_sw_adjust_link(struct dsa_switch >> *ds, int port, >> core_writel(priv, reg, offset); >> >> if (!phydev->is_pseudo_fixed_link)

Re: [PATCH net-next 09/12] net: dsa: b53: Wire-up EEE

2017-09-18 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > @@ -1000,6 +1005,9 @@ static void b53_adjust_link(struct dsa_switch *ds, int > port, > b53_write8(dev, B53_CTRL_PAGE, po_reg, gmii_po); > } > } > + > + /* Re-negotiate EEE if it was

Re: [PATCH net-next 08/12] net: dsa: b53: Move EEE functions to b53

2017-09-18 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > @@ -649,7 +595,7 @@ static void bcm_sf2_sw_adjust_link(struct dsa_switch *ds, > int port, > core_writel(priv, reg, offset); > > if (!phydev->is_pseudo_fixed_link) > - p->eee_enabled = bcm_sf2_eee_init(ds,

Re: [PATCH net-next 06/12] net: dsa: b53: Move Broadcom header setup to b53

2017-09-18 Thread Vivien Didelot
Florian Fainelli writes: > The code to enable Broadcom tags/headers is largely switch independent, > and in preparation for enabling it for multiple devices with b53, move > the code we have in bcm_sf2.c to b53_common.c > > Signed-off-by: Florian Fainelli

Re: [PATCH net-next 05/12] net: dsa: b53: Use a macro to define I/O operations

2017-09-18 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Instead of repeating the same pattern: acquire mutex, read/write, release > mutex, define a macro: b53_build_op() which takes the type (read|write), I/O > size, and value (scalar or pointer). This helps with fixing bugs that could >

Re: [PATCH 2/3] selftests: actually run the various net selftests

2017-09-18 Thread Shuah Khan
On 09/18/2017 11:32 AM, jo...@toxicpanda.com wrote: > From: Josef Bacik > > These self tests are just self contained binaries, they are not run by > any of the scripts in the directory. This means they need to be marked > with TEST_GEN_PROGS to actually be run, not

Re: RACK not getting disabled

2017-09-18 Thread Yuchung Cheng
On Mon, Sep 18, 2017 at 2:55 PM, hiren panchasara wrote: > On 09/18/17 at 02:46P, Yuchung Cheng wrote: >> On Mon, Sep 18, 2017 at 2:29 PM, hiren panchasara >> wrote: >> > On 09/18/17 at 02:18P, Eric Dumazet wrote: >> >> On Mon, 2017-09-18

Re: [PATCH net-next 04/12] net: dsa: bcm_sf2: Defer port enabling to calling port_enable

2017-09-18 Thread Vivien Didelot
Florian Fainelli writes: > There is no need to configure the enabled ports once in bcm_sf2_sw_setup() and > then a second time around when dsa_switch_ops::port_enable is called, just do > it when port_enable is called which is better in terms of power consumption > and >

Re: [PATCH v2] net/ethernet/freescale: fix warning for ucc_geth

2017-09-18 Thread David Miller
From: Valentin Longchamp Date: Fri, 15 Sep 2017 07:58:47 +0200 > uf_info.regs is resource_size_t i.e. phys_addr_t that can be either u32 > or u64 according to CONFIG_PHYS_ADDR_T_64BIT. > > The printk format is thus adaptet to u64 and the regs value cast to u64 >

Re: [PATCH net-next 03/12] net: dsa: b53: Defer port enabling to calling port_enable

2017-09-18 Thread Vivien Didelot
Florian Fainelli writes: > There is no need to configure the enabled ports once in b53_setup() and then a > second time around when dsa_switch_ops::port_enable is called, just do it when > port_enable is called which is better in terms of power consumption and >

Re: RACK not getting disabled

2017-09-18 Thread hiren panchasara
On 09/18/17 at 02:46P, Yuchung Cheng wrote: > On Mon, Sep 18, 2017 at 2:29 PM, hiren panchasara > wrote: > > On 09/18/17 at 02:18P, Eric Dumazet wrote: > >> On Mon, 2017-09-18 at 13:14 -0700, hiren panchasara wrote: > >> > Hi all, I am trying to disable rack to see

Re: [PATCH 1/1] ipv6_skip_exthdr: use ipv6_authlen for AH header length computation

2017-09-18 Thread David Miller
From: Xiang Gao Date: Fri, 15 Sep 2017 01:04:27 -0400 > From 09cf2e3cf09cf591283785aaa8159baf39ac2e08 Mon Sep 17 00:00:00 2001 > From: Xiang Gao > Date: Fri, 15 Sep 2017 00:44:12 -0400 > Subject: [PATCH] ipv6_skip_exthdr: use ipv6_authlen for AH

  1   2   3   >