Re: [PATCH 3/3] [NETFILTER] ip6tables: whitespace and indent cosmetic cleanup

2006-01-17 Thread David S. Miller
All 3 applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tg3: Refine nvram locking

2006-01-17 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 16 Jan 2006 14:36:34 -0800 Add nvram lock count so that calls to tg3_nvram_lock()/unlock() can be nested. Add error checking to all callers of tg3_nvram_lock() where appropriate. To prevent nvram lock failures after halting the firmware, it is

Re: [PATCH] [IPV4] : rt_cache_stat can be statically defined

2006-01-17 Thread David S. Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 10:56:13 +0100 x86_64 code before patch mov1237577(%rip),%rax# 803e5990 rt_cache_stat not%rax # part of per_cpu machinery mov%gs:0x3c,%edx # get cpu number movslq %edx,%rdx # extend 32 bits cpu number

Re: [PATCH 1/1] LSM-IPsec SELinux Authorize

2006-01-17 Thread David S. Miller
From: Trent Jaeger [EMAIL PROTECTED] Date: Mon, 16 Jan 2006 21:54:13 -0500 We want to limit the modification of security contexts only to the minimal set of programs (e.g., setkey and racoon). SELinux generally restricts root programs to least privilege rights, such that a root program

Re: linux networking kernel layer and STREAMS

2006-01-17 Thread David S. Miller
From: Willem de Bruijn [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 11:55:44 +0100 About your remark: I have studied linux networking so far as it has crossed my path. IPSEC, the only place for which XFRM is being used it seems, was scheduled for later. You don't expect to see a different

Re: [PKT_SCHED]: Handle SCTP/DCCP in sfq_hash

2006-01-17 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 12 Jan 2006 06:53:01 +0100 Handle SCTP/DCCP in sfq_hash to make it recognize seperate connections. Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [EBTABLES]: Handle SCTP/DCCP in ebt_{ip,log}

2006-01-17 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 12 Jan 2006 06:53:57 +0100 This patch adds SCTP/DCCP support to ebt_ip.c and ebt_log.c. The ebt_ipt.c change needs a userspace change as well, this is the second attached patch. Kernel side applied, thanks Patrick. - To unsubscribe from this

Re: [PATCH] Replacing with (compare|is_zero)_ether_addr() and ETH_ALEN in pktgen.c

2006-01-17 Thread David S. Miller
From: Kris Katterjohn [EMAIL PROTECTED] Date: Sun, 15 Jan 2006 19:50:47 -0800 This replaces some tests with is_zero_ether_addr(), memcmp(one, two, 6) with compare_ether_addr(one, two), and 6 with ETH_ALEN where appropriate. Signed-off-by: Kris Katterjohn [EMAIL PROTECTED] Applied, thanks. -

Re: IPSEC Offload

2006-01-17 Thread David S. Miller
From: Dave Dillow [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 11:45:04 -0500 Would this still be interesting to anyone? If I can get a good framework in place, maybe we can get Intel to open up their cards to work with it as well. I feel like support for this is inevitable, personally. It's not

Re: TIPC needs some cleanup

2006-01-17 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 21:42:38 +0100 On Tuesday 17 January 2006 21:31, jamal wrote: the TIPC tree has been open for months now for review. That is not how Linux code review works - the code is supposed to get posted to the appropiate mailing lists so

Re: NIP6_FMT breaks ifconfig

2006-01-17 Thread David S. Miller
From: Kumar Gala [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 16:35:01 -0600 The use of NIP6_FMT from kernel.h in net/ipv6/addrconf.c changes how / proc/net/if_inet6 format's IPv6 addresses and thus breaks ifconfig's ability to display IPv6 addresses. I'm not sure if this is acceptable

Re: TIPC needs some cleanup

2006-01-17 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 15:04:34 -0800 Also, let's work with the current code. It is a lot easier to let others clean it up, if the changes are against the mainline (or -mm) rather than having to send it off to get put into yet another git repo. I

Re: [PATCH] Use is_zero_ether_addr() in net/core/netpoll.c

2006-01-17 Thread David S. Miller
From: Kris Katterjohn [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 13:51:11 -0800 This replaces a memcmp() with is_zero_ether_addr(). Signed-off-by: Kris Katterjohn [EMAIL PROTECTED] Applied, thanks Kris. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH] Remove MANY unneeded header files in net/core/filter.c

2006-01-17 Thread David S. Miller
From: Kris Katterjohn [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 09:03:22 -0800 Are there any headers I'm deleting that _should_ be there, but not necessarily required for a clean compilation? If so, let me know and I'll redo the patch. If the build still works, that doesn't mean much :-)

Re: [GIT PATCHES] SCTP bugfixes for 2.6.16

2006-01-17 Thread David S. Miller
From: Sridhar Samudrala [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 15:20:50 -0800 Please pull the following SCTP bugfixes from master.kernel.org:/pub/scm/linux/kernel/git/sridhar/lksctp-2.6.git Looks good. Pulled, thanks Sridhar. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/1] double xfrm_state_put bug fix

2006-01-17 Thread David S. Miller
From: James Morris [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 21:27:05 -0500 (EST) This is confusing code, how about a comment? There is a big comment in __xfrm_state_delete(), would you like something more? :-) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: net 2.6.16-rc1: multiple ipv6 failures

2006-01-17 Thread David S. Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 21:39:20 -0500 2) bind fails (which everyone on my network immediately noticed, and complained about). Jan 17 21:29:04 pretzel named[5110]: loading configuration from '/etc/named.conf' Jan 17 21:29:04 pretzel named[5110]:

Re: [PATCH] Remove MANY unneeded header files in net/core/filter.c

2006-01-18 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 19 Jan 2006 07:26:12 +1100 On Wed, Jan 18, 2006 at 06:42:06AM -0800, Kris Katterjohn wrote: Since it can't be a module and is always built in, we can just remove the EXPORT_SYMBOL()s, right? No, these are there so that other modules can use

Re: IRDA maintainer status

2006-01-18 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 18 Jan 2006 10:52:26 -0800 Dave, Jean says he really doesn't have time to much IRDA any more. The following would help motivate someone who has more time. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied. We need to find some

Re: Questions on Chelsio NICs

2006-01-18 Thread David S. Miller
From: Ben Greear [EMAIL PROTECTED] Date: Wed, 18 Jan 2006 11:12:54 -0800 Well, to answer myself: I found the problem. Pktgen's multi-skb trick only works if the device makes no change to the skb. But, the cxgb driver pushes a header on the front of the skb... So, you just can't use the

Re: Questions on Chelsio NICs

2006-01-18 Thread David S. Miller
From: Ben Greear [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 17:01:46 -0800 int rsrv = (odev-hard_header_len + 16) ~0xF; skb = alloc_skb(info-cur_pkt_size + 64 + rsrv, GFP_ATOMIC); /* Make some extra space, align on 16-byte boundary * (helps Chelsio)

Re: [PATCH] Fix multiple bugs in IGMPv3

2006-01-18 Thread David S. Miller
From: David Stevens [EMAIL PROTECTED] Date: Wed, 18 Jan 2006 15:17:24 -0700 The below jumbo patch fixes the following problems in IGMPv3. Looks good, applied. Thanks David. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: e1000 breakage in Jeff's tree

2006-01-18 Thread David S. Miller
From: Jesse Brandeburg [EMAIL PROTECTED] Date: Wed, 18 Jan 2006 14:20:28 -0800 (Pacific Standard Time) The root cause of the bug is that the receive routine was in a bad state because we didn't submit our prefetch patch, which unfortunately didn't have just prefetchy things in it. So did

Re: [GIT PATCHES] TIPC fixes

2006-01-18 Thread David S. Miller
From: Per Liden [EMAIL PROTECTED] Date: Wed, 18 Jan 2006 01:52:40 +0100 (CET) Here is a set of patches in response to the initial criticism/comments that TIPC received. The reason why these patches touch so many files is the fix to avoid namespace pullution. Please see diffstat and commit

Re: IRDA maintainer status

2006-01-18 Thread David S. Miller
From: Jean Tourrilhes [EMAIL PROTECTED] Date: Wed, 18 Jan 2006 14:24:24 -0800 They are mostly using BlueTooth nowadays :-( This is not strictly the case, especially in Asia. Most of the current LG and Samsung phones out in South Korea are still IRDA. In fact my USA Samsung E635 is IRDA

Re: [PATCH] bonding: allow bond to use TSO if slaves support it

2006-01-18 Thread David S. Miller
From: Arthur Kepner [EMAIL PROTECTED] Date: Wed, 18 Jan 2006 14:37:57 -0800 (PST) Add NETIF_F_TSO to BOND_INTERSECT_FEATURES so that it can be used by a bonding device iff all its slave devices support TSO. Signed-off-by: Arthur Kepner [EMAIL PROTECTED] I thought we had fixed this already?

Re: [patch 2/2] MAINTAINERS: add entry for wireless networking

2006-01-18 Thread David S. Miller
Both applied, thanks John. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: e1000 breakage in Jeff's tree

2006-01-18 Thread David S. Miller
From: Ronciak, John [EMAIL PROTECTED] Date: Wed, 18 Jan 2006 15:46:24 -0800 What was tested was the entire patch set which included the pre-fetch patch. Therefore, you sent patches you know you had to make major surgery to before submission compared to what you actually tested. You submitted

Re: e1000 breakage in Jeff's tree

2006-01-18 Thread David S. Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Wed, 18 Jan 2006 19:10:32 -0500 Its just plain inefficient. I think part of this has to do with Intel's internal legal policies for public code release. It's time consuming and highly encourages the engineers to batch code releases so that they

Re: 32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-18 Thread David S. Miller
From: Arnd Bergmann [EMAIL PROTECTED] Date: Thu, 19 Jan 2006 01:57:37 +0100 I'm not that familiar with the process for non-driver patches for netdev (nor for device drivers as it seems ;-)), but my understanding is that you should address those to Jeff Garzik as well, asking for inclusion in

Re: Badness in cache_free_debugcheck at mm/slab.c:2315

2006-01-18 Thread David S. Miller
From: Dave Jones [EMAIL PROTECTED] Date: Thu, 19 Jan 2006 01:38:24 -0500 FWIW, the original bug reporter has followed up to report that this is still present in a kernel based on 2.6.16rc1 I wonder if this is another -Os miscompile... I'll try to have a look. - To unsubscribe from this list:

Re: ip_finish_output2: No header cache and no neighbour! in 2.6.15-git7

2006-01-19 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Fri, 20 Jan 2006 08:15:39 +0100 On Tuesday 17 January 2006 10:42, Patrick McHardy wrote: You're absolutely right. Using ip_route_output for local outgoing packets in POST_ROUTING should fix this problem. Andi, can you please try this patch?

Re: documentation of the Linux networking

2006-01-20 Thread David S. Miller
From: Irek Szczesniak [EMAIL PROTECTED] Date: Fri, 20 Jan 2006 00:10:46 -0800 I would like to learn in general how the networking works in Linux. Ideally, I would like to find a book about Linux similar to the book about BSD: TCP/IP Illustrated, Volume 2 by Gary R. Wright and W. Richard

net-2.6.17 openned up

2006-01-20 Thread David S. Miller
It's at: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.17.git Currently it has the net device operstate stuff and Yoshifuji's IPV6 updates (mostly RFC4191 support). Enjoy. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] core: add RFC2863 operstate

2006-01-20 Thread David S. Miller
From: Stefan Rompf [EMAIL PROTECTED] Date: Thu, 8 Dec 2005 00:13:35 +0100 Signed-Off-By: Stefan Rompf [EMAIL PROTECTED] This looks fine, patch applied to net-2.6.17 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] vlan: translate IF_OPER_DORMANT to netif_dormant_on()

2006-01-20 Thread David S. Miller
From: Stefan Rompf [EMAIL PROTECTED] Date: Thu, 8 Dec 2005 00:19:56 +0100 this patch adds support to the VLAN driver to translate IF_OPER_DORMANT of the underlying device to netif_dormant_on(). Beside clean state forwarding, this allows running independant userspace supplicants on both the

Re: any way to easily map struct socket * to userspace fd?

2006-01-20 Thread David S. Miller
From: Christopher Friesen [EMAIL PROTECTED] Date: Fri, 20 Jan 2006 17:06:36 -0600 I've been asked if there is any way to map a struct socket * in kernelspace, to the userspace fd that corresponds to it. I came up with looping through current-files-fd[i] and matching it against

Re: any way to easily map struct socket * to userspace fd?

2006-01-22 Thread David S. Miller
From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Sat, 21 Jan 2006 13:15:49 +0300 On Fri, Jan 20, 2006 at 05:06:36PM -0600, Christopher Friesen ([EMAIL PROTECTED]) wrote: I've been asked if there is any way to map a struct socket * in kernelspace, to the userspace fd that corresponds to

Re: [PATCH] net: Move destructor from neigh-ops to neigh_params

2006-01-23 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 23 Jan 2006 13:27:32 -0800 I'd like to get an ACK or NAK of it from Dave Dave is in New Zealand at linux.conf.au, don't expect him to be too active for at least a week... - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH] Fix more whitespace issues in net/core/filter.c

2006-01-23 Thread David S. Miller
From: Kris Katterjohn [EMAIL PROTECTED] Date: Fri, 20 Jan 2006 17:26:43 -0800 This fixes some whitespace issues in net/core/filter.c Signed-off-by: Kris Katterjohn [EMAIL PROTECTED] Applied, thanks Kris. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH 9/9] bnx2: Update version and copyright year

2006-01-23 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Thu, 19 Jan 2006 15:58:29 -0800 Update version to 1.4.31 and add 2006 copyright. Skip the last digit when reporting the firmware version. Signed-off-by: Michael Chan [EMAIL PROTECTED] All 9 patches applied (in New Zealand :-)). The hw interrupt

Re: [PATCH] Fix some whitespace issues in af_packet.c

2006-01-23 Thread David S. Miller
From: Kris Katterjohn [EMAIL PROTECTED] Date: Fri, 20 Jan 2006 22:07:06 -0800 Those changes and a couple more just like them. Signed-off-by: Kris Katterjohn [EMAIL PROTECTED] Applied, thanks Kris. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: driver skb reuse

2006-01-24 Thread David S. Miller
From: Ben Greear [EMAIL PROTECTED] Date: Tue, 24 Jan 2006 12:25:21 -0800 That 16 is probably the same bug as broke pktgen for chelsio NICs. Shouldn't we take the netdev-hard_header_len into account?? Ben, this code is in the e1000 driver... don't be rediculious :) - To unsubscribe from this

Re: driver skb reuse

2006-01-24 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Tue, 24 Jan 2006 15:58:27 -0500 Instead of doing a completely separate skb reuse path, what happens if you remove the memset() from __alloc_skb() and instead do it in a slab ctor? I remember seeing that in the profiles for af_unix. Dave, could

Re: [PATCH] fix MLDv2 change records when transitioning to/from inactive

2006-01-24 Thread David S. Miller
From: David Stevens [EMAIL PROTECTED] Date: Thu, 19 Jan 2006 15:30:02 -0700 The following patch fixes these problems in MLDv2: 1) Add/remove delete records for sending change reports when addition of a filter results in that filter transitioning to/from inactive. [same as

Re: fib_rules w. RCU lock [PATCH]

2006-01-26 Thread David S. Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Thu, 22 Dec 2005 10:51:46 +0100 @@ -219,28 +230,27 @@ if (rta[RTA_FLOW-1]) memcpy(new_r-r_tclassid, RTA_DATA(rta[RTA_FLOW-1]), 4); #endif - - rp = fib_rules; + r = (struct fib_rule *) fib_rules.first; if

Re: [Bug 5672] New: cannot get socket once accept(2) has failed due to EMFILE/ENFILE

2006-01-26 Thread David S. Miller
From: David S. Miller [EMAIL PROTECTED] Date: Thu, 01 Dec 2005 18:51:19 -0800 (PST) From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 1 Dec 2005 10:51:55 -0800 Detail of issue is old: http://oss.sgi.com/archives/netdev/2004-11/msg00573.html Once accept fails on EMFILE/ENFILE

Re: net-2.6.17.git crashes

2006-01-29 Thread David S. Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Sat, 28 Jan 2006 17:22:40 -0800 David, your tree git+ssh://master.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.17.git is oopsing all over the place. Reverting [NET]: Do not lose accepted socket when -ENFILE/-EMFILE. makes it stop: Ok, I just

Re: net-2.6.17.git crashes

2006-01-29 Thread David S. Miller
checked in the following fix, thanks for the report. diff-tree e6b303b1b4b890772f9c45f790deb1cfb49e295c (from dc326c4936f41911046b2dc72cbe04053e9680d6) Author: David S. Miller [EMAIL PROTECTED] Date: Sun Jan 29 21:08:25 2006 -0800 [NET] sys_accept: Pass correct socket to sock_attach_fd

Re: [PATCH]Enhancements of ip_options_fragment()

2006-01-29 Thread David S. Miller
From: Wei Yongjun [EMAIL PROTECTED] Date: Mon, 30 Jan 2006 16:29:18 -0800 I think this problem should not occurred because the patch make the ipv4 header of a 32 bit alignment. I still think the complicated new code is not justified. Show a real life example where this results in breakage and

Re: [PATCH]ip_options_fragment() has no effect on fragmentation

2006-01-29 Thread David S. Miller
From: Wei Yongjun [EMAIL PROTECTED] Date: Fri, 27 Jan 2006 09:35:02 -0800 [1]Summary of the problem: ip_options_fragment() has no effect on fragmentation [2]Full description of the problem: When I send IPv4 packet(contain Record Route Option) which need to be fragmented to the router, the

Re: [NETFILTER] NAT sequence adjustment: Save eight bytes per conntrack

2006-01-30 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 00:22:09 +0100 [NETFILTER] NAT sequence adjustment: Save eight bytes per conntrack This patch reduces the size of 'struct ip_conntrack' on systems with NAT by eight bytes. The sequence number delta values can be int16_t, since we

Re: [PATCH] [NETFILTER] nfnetlink_log: add sequence numbers for log events

2006-01-30 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 00:23:48 +0100 [NETFILTER] nfnetlink_log: add sequence numbers for log events By using a sequence number for every logged netfilter event, we can determine from userspace whether logging information was lots somewhere downstream.

Re: Sendfile implementation details

2006-01-30 Thread David S. Miller
From: Chase Douglas [EMAIL PROTECTED] Date: Mon, 30 Jan 2006 13:55:21 -0500 I have a question about the implementation of sendfile. In my current configuration of a server, when requests are made for a file, a new thread is spawned and sendfile is called to complete the request (We realize

Re: [PATCH] [SCTP]: heartbeats exceed maximum retransmssion limit

2006-01-30 Thread David S. Miller
From: Sridhar Samudrala [EMAIL PROTECTED] Date: Mon, 30 Jan 2006 11:53:58 -0800 The number of HEARTBEAT chunks that an association may transmit is limited by Association.Max.Retrans count; however, the code allows us to send one extra heartbeat. This patch limits the number of heartbeats to

Re: [PATCH] [SCTP]: correct the number of INIT retransmissions

2006-01-30 Thread David S. Miller
From: Sridhar Samudrala [EMAIL PROTECTED] Date: Mon, 30 Jan 2006 11:52:03 -0800 We currently count the initial INIT/COOKIE_ECHO chunk toward the retransmit count and thus sends a total of sctp_max_retrans_init chunks. The correct behavior is to retransmit the chunk sctp_max_retrans_init in

Re: [RFC] TCP MTU probing

2006-01-30 Thread David S. Miller
From: John Heffner [EMAIL PROTECTED] Date: Tue, 06 Dec 2005 14:42:53 -0500 I'd like to get a few people at least to look this over, and maybe give it a try. One remaining item to consider is how best to cache the state between connections. Are there any major concerns or reservations about

Re: [patch] SFQ noports and nosrcip support and hash revamp

2006-01-30 Thread David S. Miller
From: dean gaudet [EMAIL PROTECTED] Date: Sat, 17 Dec 2005 18:22:40 -0800 (PST) let me know what you think... i'd like to get something like this patch included upstream so i can eliminate a patch from several of my kernels. The RTA length check is a little hackish. Maybe use a new attribute?

Re: remove pointless printk in igmp

2006-01-30 Thread David S. Miller
From: Dave Jones [EMAIL PROTECTED] Date: Mon, 30 Jan 2006 23:22:29 -0500 This is easily triggerable by sending bogus packets, allowing a malicious user to flood remote logs. Signed-off-by: Dave Jones [EMAIL PROTECTED] Applied, thanks Dave. I'll push this to -stable once Linus eats it. - To

Re: [PATCH] net: Fix H-TCP accounting

2006-01-30 Thread David S. Miller
From: Baruch Even [EMAIL PROTECTED] Date: Thu, 26 Jan 2006 17:17:56 +0200 This fixes the accounting in H-TCP, the ccount variable is also adjusted a few lines above this one. This line was not supposed to be there and wasn't there in the patches originally submitted, the four patches

Re: wrong IP being logged in bogus icmp checker.

2006-01-30 Thread David S. Miller
From: Dave Jones [EMAIL PROTECTED] Date: Mon, 30 Jan 2006 23:47:44 -0500 I'm curious why the broadcast address is ending up as what seem to be random numbers. What am I missing ? That's the destination address of the IPv4 header encapsulated inside the ICMP, not the one from the outer IPv4

Re: Presentation question^^.

2006-01-31 Thread David S. Miller
From: Giacomo Succi [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 09:20:15 +0100 How can I send a packet? How can I enumerate the net interfaces in a machine? Please don't subscribe to 3 different mailing lists, one of which has absolutely nothing to do with your question (git@vger.kernel.org) and

Re: [RFC] TCP/IPV4 and e1000 does not grow window

2006-01-31 Thread David S. Miller
From: Jesse Brandeburg [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 16:27:59 -0800 (Pacific Standard Time) Assuming a 1500 mtu, This appears to be due to e1000 allocating 2k buffers for hardware + 2 bytes of alignment to align the ip header (NET_IP_ALIGN), to which then dev_alloc_skb adds 16

Re: [PATCH 3/4] bnx2: Support larger rx ring sizes

2006-01-31 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 13:09:41 -0800 Increase maximum receive ring size from 255 to 4080 by supporting up to 16 linked pages of receive descriptors. To accomodate the higher memory usage, each physical descriptor page is allocated separately and the

Re: [PATCH] ARP: Update Kconfig to allow configuration of CONFIG_IP_ACCEPT_UNSOLICITED_ARP

2006-01-31 Thread David S. Miller
From: Neil Horman [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 15:05:54 -0500 Patch to add CONFIG_IP_ACCEPT_UNSOLICITED_ARP to Kconfig. Currently we have code in place to accept gratuitous arp replies, but the code is disabled by the above config option, and there is no way to turn it on. This

Re: [PATCH 3/4] bnx2: Support larger rx ring sizes

2006-01-31 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 15:30:05 -0800 Agreed in general. That's why the default is still 100 with one ring of 255 descriptors. Most users will not change this default setting. How about we compromise and cap the limit at 512 (or 511) max RX descriptors?

Re: [PATCH] ipv6 tcp_v6_send_synack: release the destination

2006-01-31 Thread David S. Miller
From: David S. Miller [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 17:29:10 -0800 (PST) Regardless, since everyone passes NULL as the dst argument to -rtx_syn_ack() I am going to kill that argument off now before it causes any troubles and then put in Eric's fix (after thinking about it some more

Re: [PATCH] net: do not export inet_bind_bucket_create twice

2006-01-31 Thread David S. Miller
From: Sam Ravnborg [EMAIL PROTECTED] Date: Mon, 23 Jan 2006 21:14:51 +0100 inet_bind_bucket_create was exported twice. Keep the export in the file where inet_bind_bucket_create is defined. Signed-off-by: Sam Ravnborg [EMAIL PROTECTED] Applied, thanks Sam. - To unsubscribe from this list:

Re: [PATCH] ipv6 tcp_v6_send_synack: release the destination

2006-01-31 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 1 Feb 2006 12:53:02 +1100 In that case, every rtx_syn_ack function needs to do a dst_release on the supplied dst if it's not NULL. So we need Eric's fix plus the same fix applied to dccp6. I've done that in my net-2.6 tree. - To unsubscribe from

Re: [PATCH] bridge: fix device delete race.

2006-01-31 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 1 Feb 2006 12:53:45 +1100 Sorry which original fix is this? The very first one is still open to the same race that started this thread. The one adding the deleted flag and removing the del_timer_sync() calls which you said was fine. - To

Re: [RFC] TCP/IPV4 and e1000 does not grow window

2006-01-31 Thread David S. Miller
From: Jesse Brandeburg [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 18:59:37 -0800 (Pacific Standard Time) 21: rcv_ssthresh = 63712 window_clamp: 98464 winfrmspc: 1404 = skblen: 1448 incr: 2896 21: rcv_ssthresh = 66608 window_clamp: 98464 winfrmspc: 1404 = skblen: 1448 incr: 2896 21:

Re: [PATCH 3/4] bnx2: Support larger rx ring sizes

2006-01-31 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 21:58:23 -0800 How about 1024 (actually 1020)? tg3 has a max. of 511 standard plus 255 jumbo rx descriptors. bnx2 runs at a higher maximum line speed of 2.5Gbps so I think it's reasonable to allow a little more for bnx2. Ok. - To

Re: net-2.6.17.git crashes

2006-02-01 Thread David S. Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 23:40:33 -0800 It's still oopsing, with slab poisoning enabled. Does this patch help? diff --git a/net/socket.c b/net/socket.c index 1ec0168..a2c3b07 100644 --- a/net/socket.c +++ b/net/socket.c @@ -420,7 +420,7 @@ int

Re: net-2.6.17.git crashes

2006-02-01 Thread David S. Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Wed, 1 Feb 2006 00:30:40 -0800 David S. Miller [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 23:40:33 -0800 It's still oopsing, with slab poisoning enabled. Does this patch help? yup. Thanks

Re: [patch 09/11] sungem: Make PM of PHYs more reliable (#2)

2006-02-01 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Wed, 01 Feb 2006 00:54:39 -0800 From: Benjamin Herrenschmidt [EMAIL PROTECTED] On my latest laptop, I've had occasional PHY dead on wakeup from sleep... the PHY would be totally unresponsive even to toggling the hard reset line until the machine is powered

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Wed, 1 Feb 2006 19:28:46 +0100 http://www.lemis.com/grog/Documentation/vj/lca06vj.pdf I did a writeup in my blog about all of this, another good reason to actively follow my blog: http://vger.kernel.org/~davem/cgi-bin/blog.cgi/index.html Go

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Wed, 1 Feb 2006 20:50:31 +0100 On Wednesday 01 February 2006 20:37, Jeff Garzik wrote: To have a fully async, zero copy network receive, POSIX read(2) is inadequate. Agreed, but POSIX aio is adequate. No, it's a joke. To do this stuff right

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Wed, 01 Feb 2006 14:37:46 -0500 So, I am not concerned with slideware. These are two good ideas that are worth pursuing, even if Van produces zero additional output. Right. And, to all of you having trouble imagining how else you'd apply these net

Re: IPSec DUMP issue

2006-02-01 Thread David S. Miller
From: Venkat Yekkirala [EMAIL PROTECTED] Date: Wed, 1 Feb 2006 10:43:09 -0500 I see this uses netlink which uses wait queues. Could using wait queues be a solution to the PF_KEY problem? PF_KEY is always going to do badly here because it wants to stuff the entire response into the socket in

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Wed, 1 Feb 2006 23:55:11 +0100 On Wednesday 01 February 2006 21:26, Jeff Garzik wrote: Andi Kleen wrote: But I don't think Van's design is supposed to be exposed to user space. It is supposed to be exposed to userspace AFAICS. Then it's

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Mitchell Blank Jr [EMAIL PROTECTED] Date: Wed, 1 Feb 2006 15:37:04 -0800 So I agree that this would have to be CAP_NET_ADMIN only. I'm drowning in all of this pessimism folks. Why not concentrate your thinking on how to make it can be made to _work_ instead of punching holes in the idea?

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Rick Jones [EMAIL PROTECTED] Date: Wed, 01 Feb 2006 15:50:38 -0800 [ What sucks about this whole thread is that only folks like Jeff and myself are attempting to think and use our imagination to consider how some roadblocks might be overcome ] If the TCP processing is put in the

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 1 Feb 2006 16:12:14 -0800 The bigger problem I see is scalability. All those mmap rings have to be pinned in memory to be useful. It's fine for a single smart application per server environment, but in real world with many dumb thread

Re: [Bug 5990] New: call to socket(AF_INET, SOCK_RAW, IPPROTO_IP);

2006-02-01 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 1 Feb 2006 16:15:04 -0800 Is this supposed to work? Or is it a just something linux doesn't implement? Protocol number zero is reserved, that's f.e. why nothing takes up that slot in /etc/services. This is how you represent any protocol

Re: [PATCH RESEND] net: Move destructor from neigh-ops to neigh_params

2006-02-01 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Wed, 01 Feb 2006 17:28:10 -0800 Sorry to distract everyone from the VJ channel discussion, but on the other hand it looks like Dave is back... I'm resending this because I'd really like to get this problem fixed but I want to make sure we're doing

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Greg Banks [EMAIL PROTECTED] Date: Thu, 02 Feb 2006 12:53:14 +1100 I got the impression that his code was dynamically changing the e1000 interrupt mitigation registers in response to load, in other words using the capabilities of the hardware in a way that NAPI deliberately avoids

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Greg Banks [EMAIL PROTECTED] Date: Thu, 02 Feb 2006 14:06:06 +1100 On Thu, 2006-02-02 at 13:46, David S. Miller wrote: I know SAMBA is using sendfile() (when the client has the oplock held, which basically is always), is NFS doing so as well? NFS is an in-kernel server, and uses

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Greg Banks [EMAIL PROTECTED] Date: Thu, 02 Feb 2006 14:19:43 +1100 Multiple trips down through TCP, qdisc, and the driver for each NFS packet sent: one for the header and one for each page. Lots of locks need to be taken and dropped, all this while multiple nfds on multiple CPUs are

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Thu, 2 Feb 2006 07:45:26 +0100 Don't think it was ever implemented though. In the end we just eat the slowdown in that particular load. The tg3 driver uses the chip interrupt mitigation to help deal with the SGI NUMA issues resulting from NAPI. - To

Re: Van Jacobson net channels

2006-02-01 Thread David S. Miller
From: Greg Banks [EMAIL PROTECTED] Date: Thu, 02 Feb 2006 18:31:49 +1100 On Thu, 2006-02-02 at 17:45, Andi Kleen wrote: Normally TSO was supposed to fix that. Sure, except that the last time SGI looked at TSO it was extremely flaky. I gather that's much better now, but TSO still has a

Re: [Bugme-new] [Bug 5999] New: Iptables modules fail to load on Alpha arch

2006-02-02 Thread David S. Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Thu, 2 Feb 2006 16:34:54 -0800 Odd. Not sure what the Could not allocate 60 bytes percpu data is due to, either. As the user indicates this problem goes all the way back to 2.6.9, I really think it's likely some Alpha specific problem wrt. percpu

Re: [PATCH] [IPV4] Document icmp_errors_use_inbound_ifaddr sysctl

2006-02-02 Thread David S. Miller
From: Horms [EMAIL PROTECTED] Date: Wed, 1 Feb 2006 17:32:18 +0900 Taken largely from the commit of the patch that added this feature http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1c2fb7f93cb20621772bf304f3dba0849942e5db I'm not sure about the ordering of

Re: tg3 bug noticed

2006-02-02 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 27 Jan 2006 09:32:09 -0800 [TG3]: Flush tg3_reset_task() Make sure tg3_reset_task() is flushed in the close and suspend paths as noted by Jeff Garzik. In the close path, calling flush_scheduled_work() may cause deadlock if linkwatch_event()

Re: fib_rules w. RCU lock [PATCH]

2006-02-02 Thread David S. Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Fri, 27 Jan 2006 14:20:39 +0100 The preempts are removed and an updated version of the patch is enclosed. Applied to net-2.6.17, thanks Robert. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: Van Jacobson net channels

2006-02-02 Thread David S. Miller
From: Greg Banks [EMAIL PROTECTED] Date: Fri, 03 Feb 2006 12:08:54 +1100 So, given 2.6.16 on tg3 hardware, would your advice be to enable TSO by default? Yes. In fact I've been meaning to discuss with Michael Chan enabling it in the driver by default. - To unsubscribe from this list: send the

Re: [PATCH] ipv6: addrconf_ifdown fix dst refcounting.

2006-02-02 Thread David S. Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Fri, 03 Feb 2006 11:32:13 +0900 (JST) BTW, David, would you mind sending your addrconf patches to me? I'd like to look into it deeply. I used to have clone, but I happened to remove that tree... I intended to review my patches in small pieces,

Re: [PATCH] add CONFIG_NETDEBUG to suppress bad packet messages

2006-02-02 Thread David S. Miller
From: Dave Jones [EMAIL PROTECTED] Date: Thu, 2 Feb 2006 23:23:03 -0500 On Thu, Feb 02, 2006 at 04:35:01PM -0800, Stephen Hemminger wrote: If you are on a hostile network, or are running protocol tests, you can easily get the logged swamped by messages about bad UDP and ICMP packets.

Fw: genetlink or connector interface for delay accounting patches ?

2006-02-03 Thread David S. Miller
Can someone look into the holes found in the genetlink code Andrew mentions below? Thanks. ---BeginMessage--- David S. Miller [EMAIL PROTECTED] wrote: Or do you think people working on networking should have to shift through 300 postings a day about the copyrights of dead authors and the bi

Re: [Patch] 2.4.32 - Neighbour Cache (ARP) State machine bug Fixed

2006-02-03 Thread David S. Miller
From: Pradeep Vincent [EMAIL PROTECTED] Date: Fri, 3 Feb 2006 18:06:53 -0800 Resending.. Your email client has tab and newline mangled the patch so it cannot be applied. Please fix this up and also supply an appropriate Signed-off-by: line. Thanks. - To unsubscribe from this list: send the

Re: slab corruption in 2.6.16rc1-git4

2006-02-04 Thread David S. Miller
-off-by: David S. Miller [EMAIL PROTECTED] diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 6bc0887..4d1c409 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c @@ -524,7 +524,7 @@ void icmp_send(struct sk_buff *skb_in, i iph-tos

<    3   4   5   6   7   8   9   10   11   12   >