Re: [netmod] derived-from-or-self leads to circular import

2016-08-31 Thread Balazs Lengyel
Hello Bart, A nice solution could be to separate ietf-entity into 2 yang modules (YAMs). One handling only generic entity stuff and another handling sensor related stuff. If  ietf-entity does not include any entity-type specific stuff it does not need to import

Re: [netmod] derived-from-or-self leads to circular import

2016-08-30 Thread Ladislav Lhotka
intended recipient, you should >> delete this message. Any disclosure, copying, or distribution of this >> message, or the taking of any action based on it, is strictly >> prohibited without the prior consent of its author. >>>> >> >> >> -Origin

Re: [netmod] derived-from-or-self leads to circular import

2016-08-29 Thread Ladislav Lhotka
> On 29 Aug 2016, at 12:42, William Lupton wrote: > > Regardless of whether circular import is permitted, isn’t it best avoided > from a layering point of view? In general I would think that a module should > be importing things that (a) it needs, and (b) don’t need it. W. If possible, yes. H

Re: [netmod] derived-from-or-self leads to circular import

2016-08-29 Thread Bogaert, Bart (Nokia - BE)
any action based on it, is strictly > prohibited without the prior consent of its author. >>> > > > -Original Message- > From: Martin Bjorklund [mailto:m...@tail-f.com] > Sent: 26 August 2016 14:33 > To: j.schoenwael...@jacobs-university.de > Cc: Bogaert, Ba

Re: [netmod] derived-from-or-self leads to circular import

2016-08-29 Thread William Lupton
Regardless of whether circular import is permitted, isn’t it best avoided from a layering point of view? In general I would think that a module should be importing things that (a) it needs, and (b) don’t need it. W. > On 29 Aug 2016, at 11:34, Ladislav Lhotka wrote: > >> On 29 Aug 2016, at 09:

Re: [netmod] derived-from-or-self leads to circular import

2016-08-29 Thread Ladislav Lhotka
ssage, or the taking of any > action based on it, is strictly prohibited without the prior consent of its > author. >>> > > > -Original Message- > From: Martin Bjorklund [mailto:m...@tail-f.com] > Sent: 26 August 2016 14:33 > To: j.schoenwael...@jacobs-uni

Re: [netmod] derived-from-or-self leads to circular import

2016-08-29 Thread Bogaert, Bart (Nokia - BE)
o: Bogaert, Bart (Nokia - BE) Cc: Martin Bjorklund; netmod@ietf.org Subject: Re: [netmod] derived-from-or-self leads to circular import I fail to see what this thread has to do with circular imports. /js On Mon, Aug 29, 2016 at 07:17:58AM +, Bogaert, Bart (Nokia - BE) wrote: > Just taking

Re: [netmod] derived-from-or-self leads to circular import

2016-08-29 Thread Juergen Schoenwaelder
ginal Message- > From: Martin Bjorklund [mailto:m...@tail-f.com] > Sent: 26 August 2016 14:33 > To: j.schoenwael...@jacobs-university.de > Cc: Bogaert, Bart (Nokia - BE); netmod@ietf.org > Subject: Re: [netmod] derived-from-or-self leads to circular import > > Juergen Sch

Re: [netmod] derived-from-or-self leads to circular import

2016-08-29 Thread Bogaert, Bart (Nokia - BE)
its author. >> -Original Message- From: Martin Bjorklund [mailto:m...@tail-f.com] Sent: 26 August 2016 14:33 To: j.schoenwael...@jacobs-university.de Cc: Bogaert, Bart (Nokia - BE); netmod@ietf.org Subject: Re: [netmod] derived-from-or-self leads to circular import Juergen Schoenwaelder

Re: [netmod] derived-from-or-self leads to circular import

2016-08-26 Thread Mahesh Jethanandani
Don’t we have something similar with iana-if-types importing ietf-interfaces? Not circular, but definitely odd. The base identity of interface-type is defined in ietf-interfaces, but the interface-types are defined in iana-if-type.yang. For anyone, including openconfig-interfaces, wanting to us

Re: [netmod] derived-from-or-self leads to circular import

2016-08-26 Thread Martin Bjorklund
Juergen Schoenwaelder wrote: > On Fri, Aug 26, 2016 at 12:43:04PM +0200, Martin Bjorklund wrote: > > Juergen Schoenwaelder wrote: > > > On Fri, Jul 29, 2016 at 12:50:13PM +, Bogaert, Bart (Nokia - BE) > > > wrote: > > > > > > [...] > > > > > > > In order to correctly compile (using confdc

Re: [netmod] derived-from-or-self leads to circular import

2016-08-26 Thread Juergen Schoenwaelder
On Fri, Aug 26, 2016 at 12:43:04PM +0200, Martin Bjorklund wrote: > Juergen Schoenwaelder wrote: > > On Fri, Jul 29, 2016 at 12:50:13PM +, Bogaert, Bart (Nokia - BE) wrote: > > > > [...] > > > > > In order to correctly compile (using confdc) we also need to import > > > iana-entity for the

Re: [netmod] derived-from-or-self leads to circular import

2016-08-26 Thread Martin Bjorklund
Juergen Schoenwaelder wrote: > On Fri, Jul 29, 2016 at 12:50:13PM +, Bogaert, Bart (Nokia - BE) wrote: > > [...] > > > In order to correctly compile (using confdc) we also need to import > > iana-entity for the identities defined in there. However this is leading a > > circular dependency:

Re: [netmod] derived-from-or-self leads to circular import

2016-08-01 Thread Rob Shakir
> On Jul 29, 2016, at 07:32, Juergen Schoenwaelder > wrote: > > I think moving the definition of entity-physical-class into > iana-entity makes sense. Perhaps this is generally a good pattern to > follow for base identities for which IANA maintains derived > identities. The required import sho

Re: [netmod] derived-from-or-self leads to circular import

2016-07-29 Thread Bogaert, Bart (Nokia - BE)
29 July 2016 15:33 To: Bogaert, Bart (Nokia - BE) Cc: netmod@ietf.org Subject: Re: [netmod] derived-from-or-self leads to circular import On Fri, Jul 29, 2016 at 12:50:13PM +, Bogaert, Bart (Nokia - BE) wrote: [...] > In order to correctly compile (using confdc) we also need to impo

Re: [netmod] derived-from-or-self leads to circular import

2016-07-29 Thread Juergen Schoenwaelder
On Fri, Jul 29, 2016 at 12:50:13PM +, Bogaert, Bart (Nokia - BE) wrote: [...] > In order to correctly compile (using confdc) we also need to import > iana-entity for the identities defined in there. However this is leading a > circular dependency: > > 1. Iana-entity imports ietf-enti

[netmod] derived-from-or-self leads to circular import

2016-07-29 Thread Bogaert, Bart (Nokia - BE)
Hi, The IETF draft entity model has added the following: container sensor-data { when 'derived-from-or-self(../class, "iana-entity", "sensor")' { We already know that derived-from-or-self actually only has 2 parameters so it is expec