Re: [Nfs-ganesha-devel] UDP duplicate cache in both Ganesha and ntirpc?

2017-03-10 Thread Matt Benjamin
Hi, - Original Message - > From: "William Allen Simpson" > To: "Matt Benjamin" > Cc: d...@redhat.com, nfs-ganesha-devel@lists.sourceforge.net > Sent: Friday, March 10, 2017 2:21:41 PM > Subject: Re: [Nfs-ganesha-devel] UDP duplicate cache in both Gane

Re: [Nfs-ganesha-devel] UDP duplicate cache in both Ganesha and ntirpc?

2017-03-10 Thread William Allen Simpson
On 3/9/17 1:44 PM, Matt Benjamin wrote: > But, isn't su_cache...NULL? > Aha, I see that you are correct. It is only set non-NULL in svc_dg_enablecache(), and that's never called. Anywhere. So we have this useless facility that I (and Malahal) have been trying to keep up-to-date with changes, an

Re: [Nfs-ganesha-devel] UDP duplicate cache in both Ganesha and ntirpc?

2017-03-09 Thread Matt Benjamin
But, isn't su_cache...NULL? Matt - Original Message - > From: "William Allen Simpson" > To: d...@redhat.com, nfs-ganesha-devel@lists.sourceforge.net > Sent: Thursday, March 9, 2017 1:19:21 PM > Subject: Re: [Nfs-ganesha-devel] UDP duplicate cache in both Ganes

Re: [Nfs-ganesha-devel] UDP duplicate cache in both Ganesha and ntirpc?

2017-03-09 Thread William Allen Simpson
On 3/9/17 10:12 AM, Daniel Gryniewicz wrote: > It probably should stay. ntirpc is intended to be useful to more than > Ganesha, and this seems like a useful feature for potential users. It's > not the codepaths called by Ganesha, so it doesn't cause any problems. > It *is* the codepaths called by

Re: [Nfs-ganesha-devel] UDP duplicate cache in both Ganesha and ntirpc?

2017-03-09 Thread Daniel Gryniewicz
It probably should stay. ntirpc is intended to be useful to more than Ganesha, and this seems like a useful feature for potential users. It's not the codepaths called by Ganesha, so it doesn't cause any problems. Daniel On 03/09/2017 09:21 AM, William Allen Simpson wrote: > Anybody have any o

Re: [Nfs-ganesha-devel] UDP duplicate cache in both Ganesha and ntirpc?

2017-03-09 Thread Matt Benjamin
Hi Bill, As I explained in detail, this code path is used in svc_run, but nfs-ganesha doesn't use it. Matt - Original Message - > From: "William Allen Simpson" > To: "NFS Ganesha Developers" > Sent: Thursday, March 9, 2017 9:21:38 AM > Subject: [N

[Nfs-ganesha-devel] UDP duplicate cache in both Ganesha and ntirpc?

2017-03-09 Thread William Allen Simpson
Anybody have any objections to my removing the ntirpc version? Clearly, this is done in RPCAL/nfs_duprec.c, so why is it also in libntirpc/src/svc_dg.c? According to blame, Matt, Malahal, and Frank have all worked on this, but not since early 2015. ---