[GitHub] [apisix-dashboard] juzhiyuan commented on issue #458: bug: When creating a route, host should not be required

2020-09-12 Thread GitBox
juzhiyuan commented on issue #458: URL: https://github.com/apache/apisix-dashboard/issues/458#issuecomment-691616454 please modify this one when you update the Route module This is an automated message from the Apache Git Se

[GitHub] [apisix-dashboard] membphis commented on issue #458: bug: When creating a route, host should not be required

2020-09-12 Thread GitBox
membphis commented on issue #458: URL: https://github.com/apache/apisix-dashboard/issues/458#issuecomment-691612264 only `uri` is the required option. the `host` is optional option. This is an automated message from the Apac

[GitHub] [apisix] spacewander commented on issue #2186: bug: The log keeps printing "wait for more time, context: ngx.timer"

2020-09-12 Thread GitBox
spacewander commented on issue #2186: URL: https://github.com/apache/apisix/issues/2186#issuecomment-690923235 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix] gy09535 edited a comment on issue #2169: feature: how use apisix send log to aliyun sls

2020-09-12 Thread GitBox
gy09535 edited a comment on issue #2169: URL: https://github.com/apache/apisix/issues/2169#issuecomment-690824661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream

2020-09-12 Thread GitBox
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-12 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan closed pull request #421: test: add test case for docker compose

2020-09-12 Thread GitBox
juzhiyuan closed pull request #421: URL: https://github.com/apache/apisix-dashboard/pull/421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #470: Proposal: Health Checks for Upstream

2020-09-12 Thread GitBox
liuxiran edited a comment on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828 > How about this design? Agree with ui design 👍 , I have a question about interaction logic: refer to the [upstream health-check doc:](https://github.co

[GitHub] [apisix] spacewander commented on pull request #1979: bugfix: empty `allow_admin` means that any IP is allowed to access Ad…

2020-09-12 Thread GitBox
spacewander commented on pull request #1979: URL: https://github.com/apache/apisix/pull/1979#issuecomment-690913327 Need to update apisix_cli_test.sh before merge. This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #421: test: add test case for docker compose

2020-09-12 Thread GitBox
juzhiyuan commented on pull request #421: URL: https://github.com/apache/apisix-dashboard/pull/421#issuecomment-691470596 feel free to reopen this PR, closed currently. This is an automated message from the Apache Git Service

[GitHub] [apisix] gy09535 commented on issue #2220: How to get the parameters of the post request in the log plugins

2020-09-12 Thread GitBox
gy09535 commented on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-691413887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #448: Proposal: improve the PluginModule

2020-09-12 Thread GitBox
juzhiyuan commented on issue #448: URL: https://github.com/apache/apisix-dashboard/issues/448#issuecomment-690994976 @bzp2010 @LiteSun @liuxiran Any ideas about this proposal? This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #463: Custom plug-in profiles and links

2020-09-12 Thread GitBox
juzhiyuan commented on issue #463: URL: https://github.com/apache/apisix-dashboard/issues/463#issuecomment-690995547 related issue #448 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #471: Proposal: Service

2020-09-12 Thread GitBox
juzhiyuan commented on issue #471: URL: https://github.com/apache/apisix-dashboard/issues/471#issuecomment-691028684 @membphis Please take a look once more, thanks! This is an automated message from the Apache Git Service. T

[GitHub] [apisix-dashboard] juzhiyuan closed issue #212: Feature: Service module

2020-09-12 Thread GitBox
juzhiyuan closed issue #212: URL: https://github.com/apache/apisix-dashboard/issues/212 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix-dashboard] juzhiyuan closed issue #194: bug: dashboard does not support healcheck config

2020-09-12 Thread GitBox
juzhiyuan closed issue #194: URL: https://github.com/apache/apisix-dashboard/issues/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix] membphis commented on a change in pull request #2092: bug: removed default access token for Admin API.

2020-09-12 Thread GitBox
membphis commented on a change in pull request #2092: URL: https://github.com/apache/apisix/pull/2092#discussion_r486965508 ## File path: bin/apisix ## @@ -637,6 +637,45 @@ local function read_yaml_conf() merge_conf(default_conf, user_conf) end +-- check the

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #448: Proposal: improve the PluginModule

2020-09-12 Thread GitBox
juzhiyuan edited a comment on issue #448: URL: https://github.com/apache/apisix-dashboard/issues/448#issuecomment-690994976 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] dickens7 commented on a change in pull request #2174: optimize set nginx conf env

2020-09-12 Thread GitBox
dickens7 commented on a change in pull request #2174: URL: https://github.com/apache/apisix/pull/2174#discussion_r487361283 ## File path: conf/config-default.yaml ## @@ -115,6 +115,8 @@ nginx_config: # config for render the template to genarate n worker_

[GitHub] [apisix-dashboard] ShiningRush commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-12 Thread GitBox
ShiningRush commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-690887432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix-dashboard] moonming commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-12 Thread GitBox
moonming commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-690929281 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #470: Proposal: Health Checks for Upstream

2020-09-12 Thread GitBox
juzhiyuan edited a comment on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #450: feat: add publish status to route in manager api

2020-09-12 Thread GitBox
juzhiyuan commented on pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#issuecomment-691470306 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix] zwwhub commented on issue #2220: How to get the parameters of the post request in the log plugins

2020-09-12 Thread GitBox
zwwhub commented on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-690996936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] Firstsawyou commented on pull request #467: draft: License ci test

2020-09-12 Thread GitBox
Firstsawyou commented on pull request #467: URL: https://github.com/apache/apisix-dashboard/pull/467#issuecomment-690850651 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] moonming commented on a change in pull request #2168: bugfix: clear all cached object when got `delete` action, and removing stale boolean data in table `self.values` with a safer wa

2020-09-12 Thread GitBox
moonming commented on a change in pull request #2168: URL: https://github.com/apache/apisix/pull/2168#discussion_r486902889 ## File path: apisix/core/config_etcd.lua ## @@ -314,36 +316,44 @@ local function sync_data(self) res.value.id = key self.values

[GitHub] [apisix] spacewander commented on pull request #2218: bugfix: load yaml config in privileged agent

2020-09-12 Thread GitBox
spacewander commented on pull request #2218: URL: https://github.com/apache/apisix/pull/2218#issuecomment-691504706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-12 Thread GitBox
juzhiyuan commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-690857688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] membphis closed pull request #2219: ONLY FOR TEST, DO NOT MERGE ME

2020-09-12 Thread GitBox
membphis closed pull request #2219: URL: https://github.com/apache/apisix/pull/2219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] membphis commented on a change in pull request #2168: bugfix: clear all cached object when got `delete` action, and removing stale boolean data in table `self.values` with a safer wa

2020-09-12 Thread GitBox
membphis commented on a change in pull request #2168: URL: https://github.com/apache/apisix/pull/2168#discussion_r486876889 ## File path: apisix/core/config_etcd.lua ## @@ -314,36 +316,44 @@ local function sync_data(self) res.value.id = key self.values

[GitHub] [apisix] gy09535 edited a comment on issue #2220: How to get the parameters of the post request in the log plugins

2020-09-12 Thread GitBox
gy09535 edited a comment on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-691413887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #212: Feature: Service module

2020-09-12 Thread GitBox
juzhiyuan commented on issue #212: URL: https://github.com/apache/apisix-dashboard/issues/212#issuecomment-691029074 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #469: Feature: debug a route online

2020-09-12 Thread GitBox
juzhiyuan commented on issue #469: URL: https://github.com/apache/apisix-dashboard/issues/469#issuecomment-690996064 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] swayamraina commented on issue #2196: feature(kafka-logger): need to read the request body data if it was cached to local file

2020-09-12 Thread GitBox
swayamraina commented on issue #2196: URL: https://github.com/apache/apisix/issues/2196#issuecomment-691269807 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix] juzhiyuan closed issue #997: doc(FAQ): Why is the ID displayed on the dashboard not the original value of etcd?

2020-09-12 Thread GitBox
juzhiyuan closed issue #997: URL: https://github.com/apache/apisix/issues/997 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

2020-09-12 Thread GitBox
juzhiyuan commented on pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-690846699 Please resolve those conflicts :D This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #194: bug: dashboard does not support healcheck config

2020-09-12 Thread GitBox
juzhiyuan commented on issue #194: URL: https://github.com/apache/apisix-dashboard/issues/194#issuecomment-691016672 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] membphis commented on pull request #2209: draft: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-12 Thread GitBox
membphis commented on pull request #2209: URL: https://github.com/apache/apisix/pull/2209#issuecomment-691020500 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] masahills edited a comment on issue #2165: request help: multi-tenancy/multi-workspace feature

2020-09-12 Thread GitBox
masahills edited a comment on issue #2165: URL: https://github.com/apache/apisix/issues/2165#issuecomment-689367235 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

2020-09-12 Thread GitBox
liuxiran commented on a change in pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r486745396 ## File path: src/pages/Route/typing.d.ts ## @@ -113,6 +116,7 @@ declare namespace RouteModule { // Request Body or Response Data for API ty

[GitHub] [apisix-dashboard] juzhiyuan closed issue #463: Custom plug-in profiles and links

2020-09-12 Thread GitBox
juzhiyuan closed issue #463: URL: https://github.com/apache/apisix-dashboard/issues/463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix] haifeng9414 commented on pull request #2218: bugfix: load yaml config in privileged agent

2020-09-12 Thread GitBox
haifeng9414 commented on pull request #2218: URL: https://github.com/apache/apisix/pull/2218#issuecomment-691407782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix] spacewander commented on issue #2188: request help: url_block.lua plugin: Is there any performance bottleneck if there are many block rules, say 1000000 url rules in production envi

2020-09-12 Thread GitBox
spacewander commented on issue #2188: URL: https://github.com/apache/apisix/issues/2188#issuecomment-690843717 There is also a library to match plain text in parallel: https://github.com/cloudflare/lua-aho-corasick. @fankeke Can we divide the 1+ million block urls into groups acc

[GitHub] [apisix] spacewander commented on issue #2213: can router support uri+params style

2020-09-12 Thread GitBox
spacewander commented on issue #2213: URL: https://github.com/apache/apisix/issues/2213#issuecomment-690844313 You can route via Nginx builtin variable: https://github.com/apache/apisix/blob/master/doc/router-radixtree.md#how-to-filter-route-by-nginx-builtin-variable -

[GitHub] [apisix-dashboard] juzhiyuan closed pull request #421: test: add test case for docker compose

2020-09-12 Thread GitBox
juzhiyuan closed pull request #421: URL: https://github.com/apache/apisix-dashboard/pull/421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #448: Proposal: improve the PluginModule

2020-09-12 Thread GitBox
juzhiyuan commented on issue #448: URL: https://github.com/apache/apisix-dashboard/issues/448#issuecomment-690994976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #421: test: add test case for docker compose

2020-09-12 Thread GitBox
juzhiyuan commented on pull request #421: URL: https://github.com/apache/apisix-dashboard/pull/421#issuecomment-691470596 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #463: Custom plug-in profiles and links

2020-09-12 Thread GitBox
juzhiyuan commented on issue #463: URL: https://github.com/apache/apisix-dashboard/issues/463#issuecomment-690846935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] spacewander commented on pull request #1979: bugfix: empty `allow_admin` means that any IP is allowed to access Ad…

2020-09-12 Thread GitBox
spacewander commented on pull request #1979: URL: https://github.com/apache/apisix/pull/1979#issuecomment-690913327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #470: Proposal: Health Checks for Upstream

2020-09-12 Thread GitBox
liuxiran edited a comment on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #471: Proposal: Service

2020-09-12 Thread GitBox
juzhiyuan commented on issue #471: URL: https://github.com/apache/apisix-dashboard/issues/471#issuecomment-691028684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #467: draft: License ci test

2020-09-12 Thread GitBox
juzhiyuan commented on pull request #467: URL: https://github.com/apache/apisix-dashboard/pull/467#issuecomment-690847170 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix-dashboard] juzhiyuan closed issue #194: bug: dashboard does not support healcheck config

2020-09-12 Thread GitBox
juzhiyuan closed issue #194: URL: https://github.com/apache/apisix-dashboard/issues/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix] griffenliu edited a comment on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

2020-09-12 Thread GitBox
griffenliu edited a comment on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-690836227 I have the same problem, see #2194. > ### Issue description > when route not found and `return core.response.exit(404, {error_msg = "failed to match any routes"})`,

[GitHub] [apisix-dashboard] juzhiyuan closed issue #212: Feature: Service module

2020-09-12 Thread GitBox
juzhiyuan closed issue #212: URL: https://github.com/apache/apisix-dashboard/issues/212 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix] membphis commented on a change in pull request #2092: bug: removed default access token for Admin API.

2020-09-12 Thread GitBox
membphis commented on a change in pull request #2092: URL: https://github.com/apache/apisix/pull/2092#discussion_r486965508 ## File path: bin/apisix ## @@ -637,6 +637,45 @@ local function read_yaml_conf() merge_conf(default_conf, user_conf) end +-- check the

[GitHub] [apisix] tokers commented on issue #2188: request help: url_block.lua plugin: Is there any performance bottleneck if there are many block rules, say 1000000 url rules in production enviromen

2020-09-12 Thread GitBox
tokers commented on issue #2188: URL: https://github.com/apache/apisix/issues/2188#issuecomment-690842830 > Improving performance mainly depends on the quality of the rules. > > === > thanks for reply > > In our system, there are already 1+ million block urls, if every r

[GitHub] [apisix] dickens7 commented on a change in pull request #2174: optimize set nginx conf env

2020-09-12 Thread GitBox
dickens7 commented on a change in pull request #2174: URL: https://github.com/apache/apisix/pull/2174#discussion_r487361283 ## File path: conf/config-default.yaml ## @@ -115,6 +115,8 @@ nginx_config: # config for render the template to genarate n worker_

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #448: Proposal: improve the PluginModule

2020-09-12 Thread GitBox
juzhiyuan edited a comment on issue #448: URL: https://github.com/apache/apisix-dashboard/issues/448#issuecomment-690994976 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] griffenliu commented on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

2020-09-12 Thread GitBox
griffenliu commented on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-690836227 I have the same problem, see #2194. > ### Issue description > when route not found and `return core.response.exit(404, {error_msg = "failed to match any routes"})`, the ap

[GitHub] [apisix-dashboard] moonming commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-12 Thread GitBox
moonming commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-690929281 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] spacewander commented on issue #2208: Is Apache APISIX support strip_path in Kong?

2020-09-12 Thread GitBox
spacewander commented on issue #2208: URL: https://github.com/apache/apisix/issues/2208#issuecomment-690844475 Consider solved. This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [apisix-dashboard] ShiningRush commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-12 Thread GitBox
ShiningRush commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-690887432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #470: Proposal: Health Checks for Upstream

2020-09-12 Thread GitBox
juzhiyuan edited a comment on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] liuxiran commented on issue #417: Get routeInfo [websocket] field is not match the value enterd

2020-09-12 Thread GitBox
liuxiran commented on issue #417: URL: https://github.com/apache/apisix-dashboard/issues/417#issuecomment-690832706 update master, Api can return the right protocols now. close it. This is an automated message from the Apac

[GitHub] [apisix-dashboard] liubinqi2007 commented on issue #463: Custom plug-in profiles and links

2020-09-12 Thread GitBox
liubinqi2007 commented on issue #463: URL: https://github.com/apache/apisix-dashboard/issues/463#issuecomment-690835352 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [apisix] spacewander commented on issue #2186: bug: The log keeps printing "wait for more time, context: ngx.timer"

2020-09-12 Thread GitBox
spacewander commented on issue #2186: URL: https://github.com/apache/apisix/issues/2186#issuecomment-690923235 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix] gy09535 edited a comment on issue #2169: feature: how use apisix send log to aliyun sls

2020-09-12 Thread GitBox
gy09535 edited a comment on issue #2169: URL: https://github.com/apache/apisix/issues/2169#issuecomment-690824661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] gy09535 commented on issue #2220: How to get the parameters of the post request in the log plugins

2020-09-12 Thread GitBox
gy09535 commented on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-691413887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [apisix-dashboard] maxluo1992 commented on issue #464: request help: 401 when using apisix in k8s

2020-09-12 Thread GitBox
maxluo1992 commented on issue #464: URL: https://github.com/apache/apisix-dashboard/issues/464#issuecomment-690813400 Yes,my dashboard version is v1.0. This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream

2020-09-12 Thread GitBox
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] mlick commented on issue #2208: Is Apache APISIX support strip_path in Kong?

2020-09-12 Thread GitBox
mlick commented on issue #2208: URL: https://github.com/apache/apisix/issues/2208#issuecomment-690833024 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] spacewander closed issue #2208: Is Apache APISIX support strip_path in Kong?

2020-09-12 Thread GitBox
spacewander closed issue #2208: URL: https://github.com/apache/apisix/issues/2208 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-12 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #460: feat: support ungroup in manager api

2020-09-12 Thread GitBox
juzhiyuan merged pull request #460: URL: https://github.com/apache/apisix-dashboard/pull/460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] Firstsawyou commented on pull request #467: draft: License ci test

2020-09-12 Thread GitBox
Firstsawyou commented on pull request #467: URL: https://github.com/apache/apisix-dashboard/pull/467#issuecomment-690850651 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] moonming commented on issue #2125: request help: move etcd cluster in docker for CI

2020-09-12 Thread GitBox
moonming commented on issue #2125: URL: https://github.com/apache/apisix/issues/2125#issuecomment-690828117 @EnableAsync Apache APISIX only supports etcd v2 now, so the latest version of etcd not pass all test cases is expected. @membphis please take a look at tengine failed test cas

[GitHub] [apisix] moonming commented on a change in pull request #2168: bugfix: clear all cached object when got `delete` action, and removing stale boolean data in table `self.values` with a safer wa

2020-09-12 Thread GitBox
moonming commented on a change in pull request #2168: URL: https://github.com/apache/apisix/pull/2168#discussion_r486902889 ## File path: apisix/core/config_etcd.lua ## @@ -314,36 +316,44 @@ local function sync_data(self) res.value.id = key self.values

[GitHub] [apisix] swayamraina commented on issue #2196: feature(kafka-logger): need to read the request body data if it was cached to local file

2020-09-12 Thread GitBox
swayamraina commented on issue #2196: URL: https://github.com/apache/apisix/issues/2196#issuecomment-691269807 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix] fankeke commented on issue #2188: request help: url_block.lua plugin: Is there any performance bottleneck if there are many block rules, say 1000000 url rules in production envirome

2020-09-12 Thread GitBox
fankeke commented on issue #2188: URL: https://github.com/apache/apisix/issues/2188#issuecomment-690832270 Improving performance mainly depends on the quality of the rules. === thanks for reply In our system, there are already 1+ million block urls, if every request sho

[GitHub] [apisix] spacewander commented on pull request #2218: bugfix: load yaml config in privileged agent

2020-09-12 Thread GitBox
spacewander commented on pull request #2218: URL: https://github.com/apache/apisix/pull/2218#issuecomment-691504706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix] membphis closed pull request #2219: ONLY FOR TEST, DO NOT MERGE ME

2020-09-12 Thread GitBox
membphis closed pull request #2219: URL: https://github.com/apache/apisix/pull/2219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-12 Thread GitBox
juzhiyuan commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-690857688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #464: request help: 401 when using apisix in k8s

2020-09-12 Thread GitBox
juzhiyuan commented on issue #464: URL: https://github.com/apache/apisix-dashboard/issues/464#issuecomment-690831752 Please use the latest (master or 1.5 branches) if possible. This is an automated message from the Apache Gi

[GitHub] [apisix] gy09535 edited a comment on issue #2220: How to get the parameters of the post request in the log plugins

2020-09-12 Thread GitBox
gy09535 edited a comment on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-691413887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] membphis commented on a change in pull request #2168: bugfix: clear all cached object when got `delete` action, and removing stale boolean data in table `self.values` with a safer wa

2020-09-12 Thread GitBox
membphis commented on a change in pull request #2168: URL: https://github.com/apache/apisix/pull/2168#discussion_r486876889 ## File path: apisix/core/config_etcd.lua ## @@ -314,36 +316,44 @@ local function sync_data(self) res.value.id = key self.values

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #212: Feature: Service module

2020-09-12 Thread GitBox
juzhiyuan commented on issue #212: URL: https://github.com/apache/apisix-dashboard/issues/212#issuecomment-691029074 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #469: Feature: debug a route online

2020-09-12 Thread GitBox
juzhiyuan commented on issue #469: URL: https://github.com/apache/apisix-dashboard/issues/469#issuecomment-690996064 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] juzhiyuan closed issue #997: doc(FAQ): Why is the ID displayed on the dashboard not the original value of etcd?

2020-09-12 Thread GitBox
juzhiyuan closed issue #997: URL: https://github.com/apache/apisix/issues/997 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

2020-09-12 Thread GitBox
juzhiyuan commented on pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-690846699 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #194: bug: dashboard does not support healcheck config

2020-09-12 Thread GitBox
juzhiyuan commented on issue #194: URL: https://github.com/apache/apisix-dashboard/issues/194#issuecomment-691016672 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] membphis commented on pull request #2209: draft: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-12 Thread GitBox
membphis commented on pull request #2209: URL: https://github.com/apache/apisix/pull/2209#issuecomment-691020500 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] masahills edited a comment on issue #2165: request help: multi-tenancy/multi-workspace feature

2020-09-12 Thread GitBox
masahills edited a comment on issue #2165: URL: https://github.com/apache/apisix/issues/2165#issuecomment-689367235 We have hundreds of internal API endpoints which go through a cluster of API gateway servers. It is a typical micro-service architecture and each API is developed and owned b

[GitHub] [apisix-dashboard] liuxiran closed issue #417: Get routeInfo [websocket] field is not match the value enterd

2020-09-12 Thread GitBox
liuxiran closed issue #417: URL: https://github.com/apache/apisix-dashboard/issues/417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #463: Custom plug-in profiles and links

2020-09-12 Thread GitBox
juzhiyuan closed issue #463: URL: https://github.com/apache/apisix-dashboard/issues/463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

2020-09-12 Thread GitBox
liuxiran commented on a change in pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r486745396 ## File path: src/pages/Route/typing.d.ts ## @@ -113,6 +116,7 @@ declare namespace RouteModule { // Request Body or Response Data for API ty

[GitHub] [apisix] haifeng9414 commented on pull request #2218: bugfix: load yaml config in privileged agent

2020-09-12 Thread GitBox
haifeng9414 commented on pull request #2218: URL: https://github.com/apache/apisix/pull/2218#issuecomment-691407782 Privileged processes do not process user requests, I think there is no need to create a timer in init_worker phase. -

[GitHub] [apisix-dashboard] moonming merged pull request #465: feature:Independent license check operation file.

2020-09-12 Thread GitBox
moonming merged pull request #465: URL: https://github.com/apache/apisix-dashboard/pull/465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix] spacewander commented on issue #2213: can router support uri+params style

2020-09-12 Thread GitBox
spacewander commented on issue #2213: URL: https://github.com/apache/apisix/issues/2213#issuecomment-690844313 You can route via Nginx builtin variable: https://github.com/apache/apisix/blob/master/doc/router-radixtree.md#how-to-filter-route-by-nginx-builtin-variable -

[GitHub] [apisix-dashboard] juzhiyuan closed pull request #421: test: add test case for docker compose

2020-09-12 Thread GitBox
juzhiyuan closed pull request #421: URL: https://github.com/apache/apisix-dashboard/pull/421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

  1   2   >