nickva commented on issue #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#issuecomment-305611951
@iilyak
On the stats idea, we could keep a few stats in there to help debug and
monitor issues. Some of the things like total bytes in and out can be found out
from
nickva commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119705003
##
File path: src/couch/src/couch_file.erl
##
@@ -338,12 +339,33 @@ init_status_error(ReturnPid, Ref, Error) ->
ReturnPid ! {Ref, sel
nickva commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119705003
##
File path: src/couch/src/couch_file.erl
##
@@ -338,12 +339,33 @@ init_status_error(ReturnPid, Ref, Error) ->
ReturnPid ! {Ref, sel
nickva commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119774560
##
File path: src/couch/src/couch_db_updater.erl
##
@@ -314,30 +320,46 @@ handle_info({update_docs, Client, GroupedDocs,
NonRepDocs, Merg
sagelywizard commented on issue #477: Add LRU for view groups
URL: https://github.com/apache/couchdb/pull/477#issuecomment-305655282
Could add that. Not necessary though. We'd still need to do the manual
`get_index` and `close` in some places.
-
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/7/
iilyak commented on issue #477: Add LRU for view groups
URL: https://github.com/apache/couchdb/pull/477#issuecomment-305650761
I noticed that we often do something like the following:
```
{ok, Pid, Mon, Args} = get_index(...),
couch_index_server:close(Mon)
```
Did yo
millayr commented on issue #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#issuecomment-305646631
Oh, other general comment is consistency with ES6 arrow functions :)
This is an automated m
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119750823
##
File path: app/core/router.js
##
@@ -108,12 +103,12 @@ export default Backbone.Router.extend({
}, this);
},
-
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119750751
##
File path: app/core/router.js
##
@@ -10,8 +10,8 @@
// License for the specific language governing permissions and limi
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119750591
##
File path: app/core/authentication.js
##
@@ -0,0 +1,43 @@
+// Licensed under the Apache License, Version 2.0 (the "Lice
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119750295
##
File path: app/addons/replication/__tests__/newreplication.test.js
##
@@ -21,7 +21,7 @@ const {assert, restore} = util
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119749986
##
File path: app/addons/documents/changes/components.react.jsx
##
@@ -0,0 +1,352 @@
+// Licensed under the Apache License
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119749986
##
File path: app/addons/documents/changes/components.react.jsx
##
@@ -0,0 +1,352 @@
+// Licensed under the Apache License
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119749710
##
File path: app/addons/auth/session.js
##
@@ -0,0 +1,135 @@
+// Licensed under the Apache License, Version 2.0 (the "Lic
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119749679
##
File path: app/addons/auth/session.js
##
@@ -0,0 +1,135 @@
+// Licensed under the Apache License, Version 2.0 (the "Lic
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/6/
nickva commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119747523
##
File path: src/couch/src/couch_file.erl
##
@@ -338,12 +339,33 @@ init_status_error(ReturnPid, Ref, Error) ->
ReturnPid ! {Ref, sel
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119747125
##
File path: app/addons/auth/session.js
##
@@ -0,0 +1,135 @@
+// Licensed under the Apache License, Version 2.0 (the "Lic
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119745304
##
File path: app/addons/auth/components/changepasswordform.js
##
@@ -0,0 +1,97 @@
+// Licensed under the Apache License,
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119745304
##
File path: app/addons/auth/components/changepasswordform.js
##
@@ -0,0 +1,97 @@
+// Licensed under the Apache License,
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119745384
##
File path: app/addons/auth/components/createadminform.js
##
@@ -0,0 +1,116 @@
+// Licensed under the Apache License, Ve
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119745304
##
File path: app/addons/auth/components/changepasswordform.js
##
@@ -0,0 +1,97 @@
+// Licensed under the Apache License,
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119743183
##
File path: app/addons/auth/stores/changepasswordstore.js
##
@@ -0,0 +1,58 @@
+// import FauxtonAPI from "../../../core/
iilyak commented on a change in pull request #538: Catch Database Do Not Exist
Error
URL: https://github.com/apache/couchdb/pull/538#discussion_r119734074
##
File path: src/mem3/src/mem3_sync_security.erl
##
@@ -44,10 +44,20 @@ maybe_sync_int(#shard{name=Name}=Src, Dst) ->
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119733564
##
File path: app/addons/auth/actions.js
##
@@ -10,148 +10,157 @@
// License for the specific language governing permissi
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119732705
##
File path: app/addons/auth/actions.js
##
@@ -10,148 +10,157 @@
// License for the specific language governing permissi
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119730387
##
File path: app/addons/auth/actions.js
##
@@ -10,148 +10,157 @@
// License for the specific language governing permissi
millayr commented on a change in pull request #923: Clean up Auth section
URL: https://github.com/apache/couchdb-fauxton/pull/923#discussion_r119730329
##
File path: app/addons/auth/actions.js
##
@@ -10,148 +10,157 @@
// License for the specific language governing permissi
iilyak commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119726561
##
File path: src/couch/src/couch_file.erl
##
@@ -338,12 +339,33 @@ init_status_error(ReturnPid, Ref, Error) ->
ReturnPid ! {Ref, sel
nickva commented on issue #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#issuecomment-305611951
@iilyak
On the stats idea, we could keep a few stats in there to help debug and
monitor issues. Some of the things like total bytes in and out can be found out
from
nickva commented on issue #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#issuecomment-305605762
I did think about special casing _nodes and _dbs but from what I remember
`_dbs` for example had change feeds hanging of it so it wasn't idle. I'll have
to double check but
nickva commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119715063
##
File path: src/couch/src/couch_db_updater.erl
##
@@ -314,30 +320,46 @@ handle_info({update_docs, Client, GroupedDocs,
NonRepDocs, Merg
ondra-novak opened a new issue #927: Script language selector is missing
URL: https://github.com/apache/couchdb-fauxton/issues/927
In the Futon, i can specify the language of the script. I can write scripts
in C++, because I developed the C++ query server (couchcpp project). But, there
is
iilyak commented on issue #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#issuecomment-305598624
Would it be a good idea to prevent `sysdb` (things like `_dbs` or `_nodes`)
from closing?
This is an autom
iilyak commented on issue #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#issuecomment-305596346
I know it is out of the scope of this PR but I want to mention the
possibility anyway.
We could store extend statistics in the process dictionary. For example we
could
iilyak commented on issue #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#issuecomment-305596346
I know it is out of the scope of this PR but I want to mention the
possibility anyway.
We could store extend statistics in the process dictionary. For example we
could
nickva commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119705003
##
File path: src/couch/src/couch_file.erl
##
@@ -338,12 +339,33 @@ init_status_error(ReturnPid, Ref, Error) ->
ReturnPid ! {Ref, sel
iilyak commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119703241
##
File path: src/couch/src/couch_file.erl
##
@@ -338,12 +339,33 @@ init_status_error(ReturnPid, Ref, Error) ->
ReturnPid ! {Ref, sel
nickva commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119702404
##
File path: src/couch/src/couch_db_updater.erl
##
@@ -199,24 +202,24 @@ handle_call({purge_docs, IdRevs}, _From, Db) ->
ok = gen_
nickva commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119702326
##
File path: src/couch/src/couch_file.erl
##
@@ -338,12 +339,33 @@ init_status_error(ReturnPid, Ref, Error) ->
ReturnPid ! {Ref, sel
iilyak commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119700451
##
File path: src/couch/src/couch_file.erl
##
@@ -338,12 +339,33 @@ init_status_error(ReturnPid, Ref, Error) ->
ReturnPid ! {Ref, sel
iilyak commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119697827
##
File path: src/couch/src/couch_db_updater.erl
##
@@ -199,24 +202,24 @@ handle_call({purge_docs, IdRevs}, _From, Db) ->
ok = gen_
iilyak commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119696992
##
File path: src/couch/src/couch_db_updater.erl
##
@@ -314,30 +320,46 @@ handle_info({update_docs, Client, GroupedDocs,
NonRepDocs, Merg
eiri commented on a change in pull request #496: Couchdb 3287 pluggable storage
engines
URL: https://github.com/apache/couchdb/pull/496#discussion_r119694870
##
File path: src/couch/src/couch_server.erl
##
@@ -559,6 +596,115 @@ db_closed(Server, Options) ->
true -
davisp closed pull request #558: Fix compatibility with master local document
revisions
URL: https://github.com/apache/couchdb/pull/558
This is an automated message from the Apache Git Service.
To respond to the message, pl
gabrielmancini commented on issue #926: Extension and plugin
URL: https://github.com/apache/couchdb-fauxton/issues/926#issuecomment-305527019
but how i add an addon out of this structure.
i wanna add this new addon just configuring the settings.json and point to
other folder,
i other
gabrielmancini commented on issue #926: Extension and plugin
URL: https://github.com/apache/couchdb-fauxton/issues/926#issuecomment-305527019
but how i add an addon out of this structure.
i wanna add this new addon just configuring the settings.json and point to
other folder,
i other
garrensmith commented on issue #926: Extension and plugin
URL: https://github.com/apache/couchdb-fauxton/issues/926#issuecomment-305524932
@gabrielmancini best to look at any folder
[here](https://github.com/apache/couchdb-fauxton/tree/master/app/addons). They
are all plugins.
--
eiri commented on a change in pull request #560: Fix broken eunit test in
changes_since_test_ test suite
URL: https://github.com/apache/couchdb/pull/560#discussion_r119605504
##
File path: src/couch_mrview/src/couch_mrview.erl
##
@@ -708,5 +708,5 @@ make_view_changes_opts(
eiri commented on a change in pull request #560: Fix broken eunit test in
changes_since_test_ test suite
URL: https://github.com/apache/couchdb/pull/560#discussion_r119608076
##
File path: src/couch_mrview/src/couch_mrview_test_util.erl
##
@@ -53,7 +53,8 @@ ddoc(changes) -
eiri commented on a change in pull request #560: Fix broken eunit test in
changes_since_test_ test suite
URL: https://github.com/apache/couchdb/pull/560#discussion_r119602569
##
File path: src/couch_mrview/src/couch_mrview_util.erl
##
@@ -344,6 +344,9 @@ get_view_changes_c
gabrielmancini opened a new issue #926: Extension and plugin
URL: https://github.com/apache/couchdb-fauxton/issues/926
Hello everyone.
There is some example or tutorial, to create plugins or extensions to a
stand alone version?
--
jiangphcn opened a new pull request #560: Fix broken eunit test in
changes_since_test_ test suite
URL: https://github.com/apache/couchdb/pull/560
## Overview
Prior to the change in this PR, most test cases in two test suites
`changes_since_test_` and `changes_index_test
nickva commented on issue #558: Fix compatibility with master local document
revisions
URL: https://github.com/apache/couchdb/pull/558#issuecomment-305401844
Also wondering if this PR also would make this clause obsolete:
https://github.com/apache/couchdb/blob/f1db277d407ac293fb99ca
nickva commented on a change in pull request #496: Couchdb 3287 pluggable
storage engines
URL: https://github.com/apache/couchdb/pull/496#discussion_r119537749
##
File path: src/couch/src/couch_bt_engine.erl
##
@@ -0,0 +1,954 @@
+% Licensed under the Apache License, Versio
56 matches
Mail list logo
