Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/419#discussion_r79297434
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -8928,6 +8932,27 @@ public int compare(Map.Entry<K, V> e1, Map.E
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/419#discussion_r79297452
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -8966,20 +8991,24 @@ public int compare(Map.Entry<K, V> e1, Map.E
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/419#discussion_r79297398
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -8928,6 +8932,27 @@ public int compare(Map.Entry<K, V> e1, Map.E
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/419#discussion_r79297378
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -8913,11 +8913,15 @@ public int compare(Map.Entry<K, V> e1, Map.E
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/419#discussion_r79297442
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -8928,6 +8932,27 @@ public int compare(Map.Entry<K, V> e1, Map.E
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/420
GROOVY-7940: @Lazy not generating "is" property accessor for booleans
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwa
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/9be5459c906ba106f235d40ebe0f25b7193a0467#commitcomment-18975680
In src/main/org/apache/groovy/metaclass/Realm.java:
In src/main/org/apache/groovy/metaclass/Realm.java on line 43
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/416#discussion_r78228482
--- Diff: src/main/org/codehaus/groovy/transform/trait/TraitComposer.java
---
@@ -293,7 +293,8 @@ private static void createForwarderMethod
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/409
GROOVY-4018: Make the Groovy truth value of NaN be false
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwagenleitner/groovy
GROOVY
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/403#discussion_r76540119
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -10563,13 +10563,21 @@ private void prepare
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/403
GROOVY-7611: java.util.Optional should evaluate to false if empty
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwagenleitner/groovy
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/389
findbugs fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwagenleitner/groovy findbugs
Alternatively you can review and apply
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/388#discussion_r75499884
--- Diff: src/main/groovy/lang/IntRange.java ---
@@ -415,4 +415,14 @@ public void step(int step, Closure closure) {
step(step, adapter
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/381#discussion_r74691103
--- Diff: src/main/org/codehaus/groovy/ast/tools/ClassNodeUtils.java ---
@@ -65,4 +73,122 @@ public static void
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/381#discussion_r74690791
--- Diff: src/main/org/codehaus/groovy/control/StaticImportVisitor.java ---
@@ -317,6 +337,10 @@ protected Expression
transformMethodCallExpression
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/584d4d405061a08c317ea1297c2833f93445bcb7#commitcomment-18598788
In src/spec/test/SyntaxTest.groovy:
In src/spec/test/SyntaxTest.groovy on line 169:
I removed the unused tags
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/584d4d405061a08c317ea1297c2833f93445bcb7#commitcomment-18561203
In src/spec/test/SyntaxTest.groovy:
In src/spec/test/SyntaxTest.groovy on line 169:
Thanks for pointing that out. I
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/377
GROOVY-7884: GroovyScriptEngineImpl usage of CompilerConfiguration can lead
to memory leaks
Also includes some minor refactoring/cleanup as separate commits.
You can merge this pull request
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/376#discussion_r72905143
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -5169,12 +5170,13 @@ public static Map groupBy(Object[] self,
List
Github user jwagenleitner closed the pull request at:
https://github.com/apache/groovy/pull/331
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/371
Serialization options for JsonOutput
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwagenleitner/groovy Json-JsonOutput
Alternatively
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/366#discussion_r71829235
--- Diff: src/main/groovy/lang/NumberRange.java ---
@@ -0,0 +1,603 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/369
test cleanup: remove println calls
In many cases asserts were already in place to ensure the expected
output. In places were asserts did not already exist, the println
calls were
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/366#discussion_r70922392
--- Diff: src/main/groovy/lang/NumberRange.java ---
@@ -0,0 +1,603 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/366#discussion_r70831843
--- Diff: src/main/groovy/lang/NumberRange.java ---
@@ -0,0 +1,603 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/366#discussion_r70829938
--- Diff: src/main/groovy/lang/NumberRange.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/366#discussion_r70646058
--- Diff: src/main/groovy/lang/NumberRange.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/366#discussion_r70638231
--- Diff: src/main/groovy/lang/NumberRange.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/366#discussion_r70638150
--- Diff: src/main/groovy/lang/NumberRange.java ---
@@ -0,0 +1,536 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/365
GROOVY-5985 - Invalid hash key serialVersionUID
Using a map key with the same name as a read-only property on the Map
class would throw a groovy.lang.ReadOnlyPropertyException. The fix
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/363
Security Tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwagenleitner/groovy SecurityTests
Alternatively you can review and apply
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/358
GROOVY-7842 - MarkupTemplateEngine Totally Broken
When running under a Security Manager an exception would be thrown because
the empty codebase value was added as a Permission name which
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/356
GROOVY-7873 - Regression performance issue in string methods
In order to implement CharSequence the GString implementation must call
toString each time a CharSequence method is invoked
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/331
GROOVY-7291 - Declaration of double variable without value assignment
referrenced in closure
Commit e08c389d67809a421f4f33c27012c54294f98259 made the change that broke
this by resolving
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/219#discussion_r61834705
--- Diff: src/main/org/codehaus/groovy/util/ManagedReference.java ---
@@ -46,7 +46,6 @@ public final T get() {
public final void
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/219#discussion_r61764947
--- Diff: src/main/org/codehaus/groovy/reflection/ClassInfo.java ---
@@ -35,13 +36,13 @@
*
* @author Alex.Tkachman
*/
-public
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/219#discussion_r61764022
--- Diff: src/main/org/codehaus/groovy/util/ManagedReference.java ---
@@ -46,7 +46,6 @@ public final T get() {
public final void
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/325
GROOVY-7646 - Classes generated by Eval() never collected from
Permgen/Metaspace
This is also fixed by PR #219 but that requires SoftReferences to be
collected (because of beaninfocache
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/324
Remove unused utility classes
These are public classes but under the `org.codehaus.groovy.util` package
so am not sure if that makes them eligible to be removed or if they must be
deprecated
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/322
GROOVY-7728 - LAX parser: Commenting out key/val pairs doesn't work
Changed loop to process comments and end of object marker after processing
key/values because skipWhitespace leaves
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/314
GROOVY-7783 - Redundant computation in ObservableList
Patch provided thanks to Monika Dhok.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/313
GROOVY-7816 - ObservableList addAll method property change event index off
by one
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/302
GROOVY-7781 - Cannot retrieve XML attribute with namespace
This change broke another test that asserted that an unprefixed attribute's
namespace is the default namespace, but default
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/301
GROOVY-7806 - @interface has too-stringent requirement for newline
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwagenleitner/groovy
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/297
GROOVY- - groovysh cannot load script with shebang
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwagenleitner/groovy GROOVY-
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/292#discussion_r56734729
--- Diff: src/main/org/codehaus/groovy/runtime/ProcessGroovyMethods.java ---
@@ -433,7 +433,7 @@ public static Process or(final Process left, final
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/292#discussion_r56734403
--- Diff: src/main/org/codehaus/groovy/ast/expr/GStringExpression.java ---
@@ -32,13 +32,15 @@
*/
public class GStringExpression extends
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/292#discussion_r56733877
--- Diff:
subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/matcher/internal/MatchingConstraintsBuilder.groovy
---
@@ -24,7 +24,7
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/290#discussion_r56243773
--- Diff:
subprojects/groovy-jsr223/src/main/java/org/codehaus/groovy/jsr223/GroovyScriptEngineImpl.java
---
@@ -427,7 +427,7 @@ private Object
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/290#discussion_r56243450
--- Diff:
subprojects/groovy-jsr223/src/main/java/org/codehaus/groovy/jsr223/GroovyScriptEngineImpl.java
---
@@ -427,7 +427,7 @@ private Object
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/290#discussion_r56242514
--- Diff:
subprojects/groovy-jsr223/src/main/java/org/codehaus/groovy/jsr223/GroovyScriptEngineImpl.java
---
@@ -427,7 +427,7 @@ private Object
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/292#discussion_r56097572
--- Diff:
subprojects/groovy-sql/src/main/java/groovy/sql/BatchingStatementWrapper.java
---
@@ -34,10 +34,10 @@
* automatically. If batchSize
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/292#discussion_r56096947
--- Diff:
src/main/org/codehaus/groovy/control/MultipleCompilationErrorsException.java ---
@@ -27,7 +27,7 @@
public class
Github user jwagenleitner closed the pull request at:
https://github.com/apache/groovy/pull/269
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/269
Update asciidoctor gradle plugin
Upgrading from 1.5.2. to 1.5.3 allows the asciidoctor tasks to
run successfully on jdk9, which failed with:
java.lang.RuntimeException
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/263
GROOVY-7751 - CallableStatement leak in Sql.call() method
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwagenleitner/groovy GROOVY
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/253#discussion_r52127643
--- Diff: src/test/groovy/transform/stc/GenericsSTCTest.groovy ---
@@ -1800,6 +1800,19 @@ assert result == 'ok
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/247#discussion_r51361938
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -16045,6 +16048,51 @@ public void remove
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/247#discussion_r51361900
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -16045,6 +16048,51 @@ public void remove
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/247#discussion_r51361896
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -16045,6 +16048,51 @@ public void remove
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/249
Remove duplicate ReferenceBundle definitions
Removed static initialization of default Soft/Weak bundles in
ReferenceManager class. The methods in that class were not used in the
codebase
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/2e7c69dc4d185dc790b7d15857235458ef3eb7a6#commitcomment-15661136
No problem, just hope I didn't introduce any new issues. :smile:
---
If your project is set up for it, you can reply
Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/606891d85bedbda8139882f41eef531f5752d99f#commitcomment-15437822
I think so. I've gone ahead and pushed to 2_4_X. Thanks.
---
If your project is set up for it, you can reply
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/236
GROOVY-6327 - normalize line endings
Use `.gitattributes` to normalize line endings
(http://git-scm.com/docs/gitattributes). Besides adding the `.gitattributes`
file also had it identify
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/237
Safely publish MetaClass so threads wont see a partially constructed
instance
Added final where appropriate and limited plugin variable scope in invoke
method.
Related to PR #226
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/230#discussion_r48680741
--- Diff:
subprojects/groovy-jsr223/src/main/java/org/codehaus/groovy/jsr223/GroovyScriptEngineImpl.java
---
@@ -275,6 +238,19 @@ public Object
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/230
GROOVY-7150 - Redirection of output in
javax.script.ScriptEngine.invokeFunction() doesn't work
Instead of adding `context` and `out` to the engine context this change
provides access
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/225
GROOVY-7716 - groovy.json.internal.FastStringUtils fails on jdk9
JDK 9 Compat Strings enhancement changed the internal representation of the
value field from a char[] to a combination
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/226
GROOVY-7709 - ConvertedClosure/ConvertedMap do not work with interface
extending GroovyObject
Just posting for discussion and acknowledge that there is probably a better
fix and lots here
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/226#discussion_r48451502
--- Diff: src/main/org/codehaus/groovy/runtime/ConversionHandler.java ---
@@ -189,4 +202,15 @@ public static boolean isCoreObjectMethod(Method
method
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/222
Removed unused Local ClassInfo cache objects (ThreadLocalMapHandler and
LocalMap)
Related to PR #219, this removes unused ThreadLocal caching from ClassInfo.
Because the `localMapRef
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/206
GROOVY-7703 - Add support for Iterable with Closure to
JsonBuilder/StreamingJsonBuilder
This applies similar changes from PR #203 to the JsonBuilder
(non-Streaming) class.
You can merge
101 - 172 of 172 matches
Mail list logo
