[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1083927134 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortAggregateNode.java: ## @@ -159,6 +161,10 @@ public void end() throws Exception

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1083924778 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSortAggregateTest.java: ## @@ -67,8 +70,134 @@ public void mapReduceAggregate() {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1083913680 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSortAggregateTest.java: ## @@ -67,8 +70,134 @@ public void mapReduceAggregate() {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1083913316 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSortAggregateTest.java: ## @@ -48,12 +53,10 @@ static void initTestData() {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1083908015 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortAggregateNode.java: ## @@ -119,7 +124,11 @@ public void push(RowT row) throws

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1083907403 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortAggregateNode.java: ## @@ -83,6 +84,10 @@ public SortAggregateNode(

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1082427170 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortAggregateNode.java: ## @@ -159,6 +161,10 @@ public void end() throws Exception

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1082404654 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortAggregateNode.java: ## @@ -76,7 +75,6 @@ public SortAggregateNode(

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1082304386 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rule/SortAggregateConverterRule.java: ## @@ -36,6 +36,7 @@ import

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

korlov42 commented on code in PR #1524: URL: https://github.com/apache/ignite-3/pull/1524#discussion_r1082303971 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rule/AbstractIgniteConverterRule.java: ## @@ -24,6 +24,7 @@ import