[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-20 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082417133 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java: ## @@ -126,10 +135,14 @@ protected CompletableFuture

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-20 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082415745 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java: ## @@ -88,8 +93,12 @@ public IgniteBiTuple

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-20 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082415277 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java: ## @@ -126,10 +135,14 @@ protected CompletableFuture

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-20 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1082413152 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java: ## @@ -88,8 +93,12 @@ public IgniteBiTuple

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-15 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1070922231 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java: ## @@ -101,23 +105,13 @@ public void rollback() throws

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-15 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1070922077 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java: ## @@ -87,9 +82,18 @@ public void commit() throws

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-13 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1069161791 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -959,14 +959,20 @@ private

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-11 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1066963298 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientTransactionsTest.java: ## @@ -199,21 +200,23 @@ void

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-11 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1066963853 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -981,7 +989,7 @@ private

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-11 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1066963011 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java: ## @@ -34,11 +34,8 @@ public class ClientTransaction implements