[GitHub] [logging-log4cxx] rm5248 commented on a diff in pull request #132: Use std::make_shared to create std::shared_ptr instances

2022-09-19 Thread GitBox
rm5248 commented on code in PR #132: URL: https://github.com/apache/logging-log4cxx/pull/132#discussion_r974816672 ## src/main/include/log4cxx/hierarchy.h: ## @@ -66,15 +66,10 @@ class LOG4CXX_EXPORT Hierarchy : LOG4CXX_CAST_ENTRY(spi::LoggerRepository)

[GitHub] [logging-log4cxx] rm5248 commented on a diff in pull request #132: Use std::make_shared to create std::shared_ptr instances

2022-09-19 Thread GitBox
rm5248 commented on code in PR #132: URL: https://github.com/apache/logging-log4cxx/pull/132#discussion_r974812641 ## src/main/include/log4cxx/helpers/threadutility.h: ## @@ -69,15 +69,14 @@ LOG4CXX_PTR_DEF(ThreadUtility); class LOG4CXX_EXPORT ThreadUtility { private:

[GitHub] [logging-log4cxx] swebb2066 commented on a diff in pull request #132: Use std::make_shared to create std::shared_ptr instances

2022-09-19 Thread GitBox
swebb2066 commented on code in PR #132: URL: https://github.com/apache/logging-log4cxx/pull/132#discussion_r974769603 ## src/main/include/log4cxx/hierarchy.h: ## @@ -66,15 +66,10 @@ class LOG4CXX_EXPORT Hierarchy : LOG4CXX_CAST_ENTRY(spi::LoggerRepository)

[GitHub] [logging-log4cxx] swebb2066 commented on a diff in pull request #132: Use std::make_shared to create std::shared_ptr instances

2022-09-19 Thread GitBox
swebb2066 commented on code in PR #132: URL: https://github.com/apache/logging-log4cxx/pull/132#discussion_r974766904 ## src/main/include/log4cxx/helpers/threadutility.h: ## @@ -69,15 +69,14 @@ LOG4CXX_PTR_DEF(ThreadUtility); class LOG4CXX_EXPORT ThreadUtility { privat

[jira] [Commented] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606784#comment-17606784 ] Ralph Goers commented on LOG4J2-3601: - [~pkarwasz] I originally thought the log4j-co

[jira] [Comment Edited] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606783#comment-17606783 ] Piotr Karwasz edited comment on LOG4J2-3601 at 9/19/22 10:09 PM: -

[jira] [Commented] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606783#comment-17606783 ] Piotr Karwasz commented on LOG4J2-3601: --- [~ctubbsii], The reason I didn't put {{l

[jira] [Updated] (LOG4J2-3602) Don't output ERROR level stacktrace in getLogger() call when there is no network available

2022-09-19 Thread Louis Bergelson (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Louis Bergelson updated LOG4J2-3602: Description: If there is no network adaptor trying to get a new logger using `LogManager.

[jira] [Created] (LOG4J2-3602) Don't output ERROR level stacktrace in getLogger() call when there is no network available

2022-09-19 Thread Louis Bergelson (Jira)
Louis Bergelson created LOG4J2-3602: --- Summary: Don't output ERROR level stacktrace in getLogger() call when there is no network available Key: LOG4J2-3602 URL: https://issues.apache.org/jira/browse/LOG4J2-3602

[jira] [Commented] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Christopher Tubbs (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606750#comment-17606750 ] Christopher Tubbs commented on LOG4J2-3601: --- [~pkarwasz] It does not make sens

[jira] [Commented] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606725#comment-17606725 ] Piotr Karwasz commented on LOG4J2-3601: --- [~andy], Thank you for reporting this is

[jira] [Commented] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606714#comment-17606714 ] Ralph Goers commented on LOG4J2-3601: - Note that we don't assign fix versions until

[jira] [Updated] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers updated LOG4J2-3601: Affects Version/s: 2.19.0 > log4j-slf4j2: change of dependency scope for log4j-core >

[jira] [Updated] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers updated LOG4J2-3601: Fix Version/s: (was: 2.19.0) > log4j-slf4j2: change of dependency scope for log4j-core > -

[jira] [Commented] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Christopher Tubbs (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606713#comment-17606713 ] Christopher Tubbs commented on LOG4J2-3601: --- FWIW, the fix version is incorrec

[jira] [Comment Edited] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Christopher Tubbs (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606710#comment-17606710 ] Christopher Tubbs edited comment on LOG4J2-3601 at 9/19/22 6:37 PM: --

[jira] [Commented] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Christopher Tubbs (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606710#comment-17606710 ] Christopher Tubbs commented on LOG4J2-3601: --- This bit us when we tried to upda

[GitHub] [logging-log4cxx] rm5248 commented on a diff in pull request #132: Use std::make_shared to create std::shared_ptr instances

2022-09-19 Thread GitBox
rm5248 commented on code in PR #132: URL: https://github.com/apache/logging-log4cxx/pull/132#discussion_r974279067 ## src/main/include/log4cxx/hierarchy.h: ## @@ -66,15 +66,10 @@ class LOG4CXX_EXPORT Hierarchy : LOG4CXX_CAST_ENTRY(spi::LoggerRepository)

[GitHub] [logging-log4cxx] rm5248 commented on a diff in pull request #132: Use std::make_shared to create std::shared_ptr instances

2022-09-19 Thread GitBox
rm5248 commented on code in PR #132: URL: https://github.com/apache/logging-log4cxx/pull/132#discussion_r974276552 ## src/main/include/log4cxx/helpers/threadutility.h: ## @@ -69,15 +69,14 @@ LOG4CXX_PTR_DEF(ThreadUtility); class LOG4CXX_EXPORT ThreadUtility { private:

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #1057: Bump github/codeql-action from 2.1.22 to 2.1.23

2022-09-19 Thread GitBox
dependabot[bot] closed pull request #1057: Bump github/codeql-action from 2.1.22 to 2.1.23 URL: https://github.com/apache/logging-log4j2/pull/1057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request, #1068: Bump github/codeql-action from 2.1.22 to 2.1.24

2022-09-19 Thread GitBox
dependabot[bot] opened a new pull request, #1068: URL: https://github.com/apache/logging-log4j2/pull/1068 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.22 to 2.1.24. Changelog Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #1057: Bump github/codeql-action from 2.1.22 to 2.1.23

2022-09-19 Thread GitBox
dependabot[bot] commented on PR #1057: URL: https://github.com/apache/logging-log4j2/pull/1057#issuecomment-1250855995 Superseded by #1068. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Updated] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Andy Seaborne (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated LOG4J2-3601: -- Description: The artifact {{log4j-slf4j-impl}} has a scope=runtime dependency on log4j-core.

[jira] [Updated] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Andy Seaborne (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated LOG4J2-3601: -- Description: The artifact {{log4j-slf4j-impl}} has a scope=runtime dependency on log4j-core.

[jira] [Updated] (LOG4J2-3601) log4j-slf4j2: change of dependency scope for log4j-core

2022-09-19 Thread Andy Seaborne (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated LOG4J2-3601: -- Description: The artifact {{log4j-slf4j-impl}} has a scope=runtime dependency on log4j-core.

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #928: Bump apache-rat-plugin from 0.13 to 0.14

2022-09-19 Thread GitBox
dependabot[bot] closed pull request #928: Bump apache-rat-plugin from 0.13 to 0.14 URL: https://github.com/apache/logging-log4j2/pull/928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #928: Bump apache-rat-plugin from 0.13 to 0.14

2022-09-19 Thread GitBox
dependabot[bot] commented on PR #928: URL: https://github.com/apache/logging-log4j2/pull/928#issuecomment-1250819543 Superseded by #1067. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request, #1067: Bump apache-rat-plugin from 0.13 to 0.15

2022-09-19 Thread GitBox
dependabot[bot] opened a new pull request, #1067: URL: https://github.com/apache/logging-log4j2/pull/1067 Bumps apache-rat-plugin from 0.13 to 0.15. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.rat

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #979: Bump groovy.version from 3.0.10 to 3.0.12

2022-09-19 Thread GitBox
dependabot[bot] closed pull request #979: Bump groovy.version from 3.0.10 to 3.0.12 URL: https://github.com/apache/logging-log4j2/pull/979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #979: Bump groovy.version from 3.0.10 to 3.0.12

2022-09-19 Thread GitBox
dependabot[bot] commented on PR #979: URL: https://github.com/apache/logging-log4j2/pull/979#issuecomment-1250817193 Superseded by #1066. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request, #1066: Bump groovy.version from 3.0.10 to 3.0.13

2022-09-19 Thread GitBox
dependabot[bot] opened a new pull request, #1066: URL: https://github.com/apache/logging-log4j2/pull/1066 Bumps `groovy.version` from 3.0.10 to 3.0.13. Updates `groovy-jsr223` from 3.0.10 to 3.0.13 Commits See full diff in https://github.com/apache/groovy/commits";>compare vi

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request, #1065: Bump kafka-clients from 1.1.1 to 3.2.3

2022-09-19 Thread GitBox
dependabot[bot] opened a new pull request, #1065: URL: https://github.com/apache/logging-log4j2/pull/1065 Bumps kafka-clients from 1.1.1 to 3.2.3. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.kafka

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #1047: Bump kafka-clients from 1.1.1 to 3.2.2

2022-09-19 Thread GitBox
dependabot[bot] closed pull request #1047: Bump kafka-clients from 1.1.1 to 3.2.2 URL: https://github.com/apache/logging-log4j2/pull/1047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #1047: Bump kafka-clients from 1.1.1 to 3.2.2

2022-09-19 Thread GitBox
dependabot[bot] commented on PR #1047: URL: https://github.com/apache/logging-log4j2/pull/1047#issuecomment-1250815795 Superseded by #1065. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [logging-log4cxx] swebb2066 opened a new pull request, #132: Use std::make_shared to create std::shared_ptr instances

2022-09-19 Thread GitBox
swebb2066 opened a new pull request, #132: URL: https://github.com/apache/logging-log4cxx/pull/132 This is a performance improvement as std::make_shared makes only one allocation. Some previously private constructors have been made public as std::make_shared needs access to the const