Re: [PR] Infinitelifetime [logging-log4cxx]

2023-10-11 Thread via GitHub
swebb2066 commented on PR #271: URL: https://github.com/apache/logging-log4cxx/pull/271#issuecomment-1758962544 > This looks good to me; if it fixes the "my program crashes because I'm logging after calling exit()" problem with no bad side > effects it sounds good to me and could be some

Re: [PR] Infinitelifetime [logging-log4cxx]

2023-10-11 Thread via GitHub
swebb2066 commented on PR #271: URL: https://github.com/apache/logging-log4cxx/pull/271#issuecomment-1758816350 I suggest multithreadtest needs to use a layout to properly test this PR. For example ```diff --git a/src/test/cpp/multithreadtest.cpp b/src/test/cpp/multithreadtest.cpp

Re: [PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.9 [logging-log4j-samples]

2023-10-11 Thread via GitHub
github-actions[bot] commented on PR #75: URL: https://github.com/apache/logging-log4j-samples/pull/75#issuecomment-1758739364 Changes are applied by CI in 795f3f2a00e98df938e624fd19a514f3a21deb82 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.9 [logging-log4j-samples]

2023-10-11 Thread via GitHub
dependabot[bot] commented on PR #75: URL: https://github.com/apache/logging-log4j-samples/pull/75#issuecomment-1758739398 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor v

Re: [PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.9 [logging-log4j-samples]

2023-10-11 Thread via GitHub
github-actions[bot] closed pull request #75: Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.9 URL: https://github.com/apache/logging-log4j-samples/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.9 [logging-log4j-samples]

2023-10-11 Thread via GitHub
dependabot[bot] opened a new pull request, #75: URL: https://github.com/apache/logging-log4j-samples/pull/75 Bumps org.slf4j:slf4j-api from 1.7.36 to 2.0.9. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.sl

Re: [PR] Infinitelifetime [logging-log4cxx]

2023-10-11 Thread via GitHub
rm5248 commented on PR #271: URL: https://github.com/apache/logging-log4cxx/pull/271#issuecomment-1758684795 The segfault on crash is rather sporadic, you can run the following to stress it: ``` while [ 1 ]; do make test ARGS="-R multithreadtest"; if [ $? -ne 0 ]; then break; fi;

Re: [PR] Bump org.eclipse.jetty:jetty-bom from 9.4.52.v20230823 to 9.4.53.v20231009 (logging-log4j2)

2023-10-11 Thread via GitHub
ppkarwasz commented on PR #1852: URL: https://github.com/apache/logging-log4j2/pull/1852#issuecomment-1758213776 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump org.apache.cassandra:cassandra-all from 3.11.16 to 4.0.10 in /log4j-parent (logging-log4j2)

2023-10-11 Thread via GitHub
ppkarwasz closed pull request #1858: Bump org.apache.cassandra:cassandra-all from 3.11.16 to 4.0.10 in /log4j-parent URL: https://github.com/apache/logging-log4j2/pull/1858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Bump io.netty:netty-bom from 4.1.97.Final to 4.1.100.Final (logging-log4j2)

2023-10-11 Thread via GitHub
ppkarwasz commented on PR #1857: URL: https://github.com/apache/logging-log4j2/pull/1857#issuecomment-1758212497 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Support for ZSTD Compression (logging-log4j2)

2023-10-11 Thread via GitHub
anuragagarwal561994 commented on PR #1514: URL: https://github.com/apache/logging-log4j2/pull/1514#issuecomment-1758017705 Thanks @vy can finally remove a tech debt from our projects :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Issue 1501: increase default StatusLogger level to warn (logging-log4j2)

2023-10-11 Thread via GitHub
lukaszspyra commented on PR #1592: URL: https://github.com/apache/logging-log4j2/pull/1592#issuecomment-1758014731 > I am not in favor of this. We should fix the original problem that a JSON or YAML configuration is found but dependencies are missing to log at error instead. Looking

Re: [I] (doc) Missing taglib documentation (logging-log4j2)

2023-10-11 Thread via GitHub
vy commented on issue #1230: URL: https://github.com/apache/logging-log4j2/issues/1230#issuecomment-1757795435 The page is available under [https://logging.apache.org/log4j/2.x/log4j-taglib.html], which is linked from the menu. That should be good enough for this hardly ever used component

Re: [PR] Support for ZSTD Compression (logging-log4j2)

2023-10-11 Thread via GitHub
vy commented on PR #1514: URL: https://github.com/apache/logging-log4j2/pull/1514#issuecomment-1757782564 @anuragagarwal561994, I have merged this. Thanks for the contribution. This will be available in the `2.21.0` release that should come out sometime this week. -- This is an automated

Re: [I] Zstd compression support (logging-log4j2)

2023-10-11 Thread via GitHub
vy closed issue #1508: Zstd compression support URL: https://github.com/apache/logging-log4j2/issues/1508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] Support for ZSTD Compression (logging-log4j2)

2023-10-11 Thread via GitHub
vy merged PR #1514: URL: https://github.com/apache/logging-log4j2/pull/1514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] Javadoc is broken (logging-log4j2)

2023-10-11 Thread via GitHub
vy commented on issue #1275: URL: https://github.com/apache/logging-log4j2/issues/1275#issuecomment-1757448766 Thanks to hard work of @lukaszspyra in #1753, the situation is improved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Javadoc is broken (logging-log4j2)

2023-10-11 Thread via GitHub
vy closed issue #1275: Javadoc is broken URL: https://github.com/apache/logging-log4j2/issues/1275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

Re: [PR] Issue 1275 broken javadoc (logging-log4j2)

2023-10-11 Thread via GitHub
vy merged PR #1753: URL: https://github.com/apache/logging-log4j2/pull/1753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Issue 1275 broken javadoc (logging-log4j2)

2023-10-11 Thread via GitHub
vy commented on PR #1753: URL: https://github.com/apache/logging-log4j2/pull/1753#issuecomment-1757399973 @lukaszspyra, you know what, nevermind. I will implement the requested changes myself. We are on a roll with `2.21.0` release and I want to get your changes in before we seal it. --

[jira] [Work logged] (LOG4J2-3672) Avoid invoking DateFormatSymbols.getZoneStrings() in FastDateParser

2023-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3672?focusedWorklogId=884445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-884445 ] ASF GitHub Bot logged work on LOG4J2-3672: -- Author: ASF GitHub Bot

Re: [PR] LOG4J2-3672 Avoid invoking `DateFormatSymbols.getZoneStrings()` in `FastDateParser` (logging-log4j2)

2023-10-11 Thread via GitHub
tristantarrant commented on PR #1848: URL: https://github.com/apache/logging-log4j2/pull/1848#issuecomment-1757250950 Hi @vy, I agree we need a better solution. - avoid constructing that ridiculous regex with all the timezone names anyway. A simple `[A-Za-z0-9\+\-/\s]+` should be enou

Re: [PR] Bump spring-boot.version from 2.7.15 to 2.7.16 [logging-log4j-samples]

2023-10-11 Thread via GitHub
dependabot[bot] commented on PR #70: URL: https://github.com/apache/logging-log4j-samples/pull/70#issuecomment-1757207571 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a de

Re: [PR] Bump spring-boot.version from 2.7.15 to 2.7.16 [logging-log4j-samples]

2023-10-11 Thread via GitHub
vy closed pull request #70: Bump spring-boot.version from 2.7.15 to 2.7.16 URL: https://github.com/apache/logging-log4j-samples/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Support for disruptor-4.0.0 (logging-log4j2)

2023-10-11 Thread via GitHub
ppkarwasz commented on PR #1856: URL: https://github.com/apache/logging-log4j2/pull/1856#issuecomment-1757166532 @Dreeam-qwq, Take your time. We won't be able to include this PR into `2.21.0` anyway, since the release process is already in motion. You can also resubmit this PR

Re: [PR] Infinitelifetime [logging-log4cxx]

2023-10-11 Thread via GitHub
vopl commented on PR #271: URL: https://github.com/apache/logging-log4cxx/pull/271#issuecomment-1757159734 > Have you tried this with the multithread test enabled? The CMake option is ENABLE_MULTITHREAD_TEST. That test should provide a decent test to see if this actually changes anything.

Re: [PR] Bump spring-boot.version from 2.7.15 to 2.7.16 [logging-log4j-samples]

2023-10-11 Thread via GitHub
vy commented on PR #70: URL: https://github.com/apache/logging-log4j-samples/pull/70#issuecomment-1757136096 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.16 to 10.0.17 [logging-log4j-samples]

2023-10-11 Thread via GitHub
dependabot[bot] commented on PR #74: URL: https://github.com/apache/logging-log4j-samples/pull/74#issuecomment-1757114640 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor v

Re: [PR] Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.16 to 10.0.17 [logging-log4j-samples]

2023-10-11 Thread via GitHub
github-actions[bot] closed pull request #74: Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.16 to 10.0.17 URL: https://github.com/apache/logging-log4j-samples/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.16 to 10.0.17 [logging-log4j-samples]

2023-10-11 Thread via GitHub
github-actions[bot] commented on PR #74: URL: https://github.com/apache/logging-log4j-samples/pull/74#issuecomment-1757114512 Changes are applied by CI in d94a0aeb48e9fea8256519ef527d47eaabd31cd1 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.16 to 10.0.17 [logging-log4j-samples]

2023-10-11 Thread via GitHub
vy commented on PR #74: URL: https://github.com/apache/logging-log4j-samples/pull/74#issuecomment-1757100613 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Bump spring-boot.version from 2.7.15 to 2.7.16 [logging-log4j-samples]

2023-10-11 Thread via GitHub
vy commented on PR #70: URL: https://github.com/apache/logging-log4j-samples/pull/70#issuecomment-1757099151 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

2023-10-11 Thread via GitHub
vy commented on issue #1365: URL: https://github.com/apache/logging-log4j2/issues/1365#issuecomment-1757095162 @garydgregory, I see the points you raise. We already expect users to implement `RolloverStrategy`s, which is a public interface. In *all* of our own implementations of `RolloverS

Re: [PR] Support for disruptor-4.0.0 (logging-log4j2)

2023-10-11 Thread via GitHub
Dreeam-qwq closed pull request #1856: Support for disruptor-4.0.0 URL: https://github.com/apache/logging-log4j2/pull/1856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Support for disruptor-4.0.0 (logging-log4j2)

2023-10-11 Thread via GitHub
Dreeam-qwq commented on PR #1856: URL: https://github.com/apache/logging-log4j2/pull/1856#issuecomment-1757093891 I'm sorry that I have no enough time to do this recently, I'll close this pr, sorry to waste your time to review it, also thanks for you to give explanation to me. -- This i

Re: [I] Request to expose certain protected APIs as public (logging-log4j2)

2023-10-11 Thread via GitHub
vy closed issue #1365: Request to expose certain protected APIs as public URL: https://github.com/apache/logging-log4j2/issues/1365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Open `FileExtension` accessors (#1365) (logging-log4j2)

2023-10-11 Thread via GitHub
vy merged PR #1683: URL: https://github.com/apache/logging-log4j2/pull/1683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Open `FileExtension` accessors (#1365) (logging-log4j2)

2023-10-11 Thread via GitHub
vy commented on PR #1683: URL: https://github.com/apache/logging-log4j2/pull/1683#issuecomment-1757031463 @Karthi1711, I am fine with these changes; except the `length()`. Let's keep the opened up methods to minimum: `createCompressAction()` and `getExtension()` are fine, but we don't need

Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]

2023-10-11 Thread via GitHub
github-actions[bot] commented on PR #73: URL: https://github.com/apache/logging-log4j-samples/pull/73#issuecomment-1757005932 Changes are applied by CI in cedcc932e3181a4f4a8b9664d382b3d71516f123 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]

2023-10-11 Thread via GitHub
dependabot[bot] commented on PR #73: URL: https://github.com/apache/logging-log4j-samples/pull/73#issuecomment-1757005992 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor v

Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]

2023-10-11 Thread via GitHub
github-actions[bot] closed pull request #73: Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre URL: https://github.com/apache/logging-log4j-samples/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Resolved] (LOG4J2-3595) Supporting disruptor 4.x

2023-10-11 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz resolved LOG4J2-3595. --- Resolution: Duplicate Issue moved to [Github Issues|https://github.com/apache/logging-log4j

Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]

2023-10-11 Thread via GitHub
vy commented on PR #73: URL: https://github.com/apache/logging-log4j-samples/pull/73#issuecomment-1756995018 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]

2023-10-11 Thread via GitHub
dependabot[bot] commented on PR #73: URL: https://github.com/apache/logging-log4j-samples/pull/73#issuecomment-1756989701 Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. --

Re: [PR] Bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [logging-log4j-samples]

2023-10-11 Thread via GitHub
vy commented on PR #73: URL: https://github.com/apache/logging-log4j-samples/pull/73#issuecomment-1756989627 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Fix Spotbugs alerts up to rank 9 (logging-log4j2)

2023-10-11 Thread via GitHub
ppkarwasz merged PR #1855: URL: https://github.com/apache/logging-log4j2/pull/1855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc