wu-sheng commented on issue #3844: What is the order defining for Segment at
the same level ?
URL: https://github.com/apache/skywalking/issues/3844#issuecomment-553281754
This could be resolved in the backend. Try to find this
`TraceQueryService#findRoots` and order the result list,
bnubobby edited a comment on issue #3844: What is the order defining for
Segment at the same level ?
URL: https://github.com/apache/skywalking/issues/3844#issuecomment-553281402
@wu-sheng
This multiple segments.
But in terms of start time, api "/home/test210" should be ahead
bnubobby commented on issue #3844: What is the order defining for Segment at
the same level ?
URL: https://github.com/apache/skywalking/issues/3844#issuecomment-553281402
@wu-sheng
This multiple segments.
But in terms of start time, api "/home/test210" should be ahead of
wu-sheng commented on issue #3844: What is the order defining for Segment at
the same level ?
URL: https://github.com/apache/skywalking/issues/3844#issuecomment-553277499
Could you work on this? @bnubobby This should be an easy PR.
wu-sheng commented on issue #3844: What is the order defining for Segment at
the same level ?
URL: https://github.com/apache/skywalking/issues/3844#issuecomment-553277292
`TraceQueryService#findRoots` should order the return list, by start time.
wu-sheng commented on issue #3844: What is the order defining for Segment at
the same level ?
URL: https://github.com/apache/skywalking/issues/3844#issuecomment-553277145
This seems like multiple segments, rather than multiple spans. Right?
Right now it is not ordered from my
wu-sheng closed pull request #3726: Improve visibility for DataCarrier.
URL: https://github.com/apache/skywalking/pull/3726
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wu-sheng commented on issue #3726: Improve visibility for DataCarrier.
URL: https://github.com/apache/skywalking/pull/3726#issuecomment-553274566
For following all these tests, unless we have very specific evidence showing
there is across threads visibility issue, I think we should close
wu-sheng commented on issue #3726: Improve visibility for DataCarrier.
URL: https://github.com/apache/skywalking/pull/3726#issuecomment-553273524
Furthermore, by using the master codes of DataCarrier, we have much higher
throughput. The following result is using the master code as
wu-sheng commented on issue #3726: Improve visibility for DataCarrier.
URL: https://github.com/apache/skywalking/pull/3726#issuecomment-553263718
I dig more into the ArrayBlockingQueue source code, I noticed there is a
misguide from the user feedback. `ArrayBlockingQueue` didn't ever deal
aderm commented on a change in pull request #3838: [test/plugin] immigrate test
feign scenario.
URL: https://github.com/apache/skywalking/pull/3838#discussion_r345583047
##
File path: test/plugin/scenarios/feign-scenario/support-version.list
##
@@ -0,0 +1,20 @@
+#
wu-sheng commented on issue #3726: Improve visibility for DataCarrier.
URL: https://github.com/apache/skywalking/pull/3726#issuecomment-553253716
As @yantaowu told me offline, they are using `Queue#offer` with accepting
queue is full and data lost tradeoff. The result is not so different,
wu-sheng commented on issue #3838: [test/plugin] immigrate test feign scenario.
URL: https://github.com/apache/skywalking/pull/3838#issuecomment-553252120
Please use the prototype script to generate the test project skeleton. We
have added them to the documentation.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 3fbaec4 Move to 6.6.0 SNAPSHOT (#3839)
add e11d207 Add elasticsearch 6.x plugin & elasticsearch 6.x test
wu-sheng merged pull request #3803: Add elasticsearch 6.x plugin &
elasticsearch 6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803
This is an automated message from the Apache Git Service.
To respond to
bnubobby opened a new issue #3844: What is the order defining for span at the
same level ?
URL: https://github.com/apache/skywalking/issues/3844
### Question
What is the order defining for span at the same level ?
**My display:**
dmsolr commented on a change in pull request #3838: [test/plugin] immigrate
test feign scenario.
URL: https://github.com/apache/skywalking/pull/3838#discussion_r345567241
##
File path: test/plugin/scenarios/feign-scenario/src/main/resources/log4j2.xml
##
@@ -0,0 +1,31 @@
dmsolr commented on a change in pull request #3838: [test/plugin] immigrate
test feign scenario.
URL: https://github.com/apache/skywalking/pull/3838#discussion_r345566833
##
File path: test/plugin/scenarios/feign-scenario/support-version.list
##
@@ -0,0 +1,20 @@
+#
wu-sheng commented on issue #3726: Improve visibility for DataCarrier.
URL: https://github.com/apache/skywalking/pull/3726#issuecomment-553231355
When I changed the codes to insert more data, interesting things happened.
I inserted 1200 records to 2000 size queu for both
```
for
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch
6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803#issuecomment-553228717
yes, unit test is very useful.
This is an automated
wu-sheng commented on issue #3726: Improve visibility for DataCarrier.
URL: https://github.com/apache/skywalking/pull/3726#issuecomment-553227414
@hanahmily @kezhenxu94 @dmsolr I run a local benchmark, and YES. In blocking
mode(the OAP is using this mode now), the ArrayBlockingQueue has
wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch
6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803#issuecomment-553226437
@aderm I think you miss your test case change? CI fails.
aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin
& elasticsearch 6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803#discussion_r345549623
##
File path:
wu-sheng commented on a change in pull request #3803: Add elasticsearch 6.x
plugin & elasticsearch 6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803#discussion_r345546510
##
File path:
wu-sheng commented on a change in pull request #3726: Improve visibility for
DataCarrier.
URL: https://github.com/apache/skywalking/pull/3726#discussion_r345544547
##
File path:
wu-sheng opened a new issue #3843: Provide ES 7.x storage in a separated dist
URL: https://github.com/apache/skywalking/issues/3843
With several times discussion between me and @kezhenxu94, we are going to
provide a compatible way to support ES7 in OAP storage for making it easier for
wu-sheng commented on issue #3842: which way deploy in clust mode best?
URL: https://github.com/apache/skywalking/issues/3842#issuecomment-553191652
This depends on your network strategy. Different companies have different
requirements.
wu-sheng closed issue #3842: which way deploy in clust mode best?
URL: https://github.com/apache/skywalking/issues/3842
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wu-sheng removed a comment on issue #3838: [test/plugin] immigrate test feign
scenario.
URL: https://github.com/apache/skywalking/pull/3838#issuecomment-553167122
/run agent-plugin-test-1
This is an automated message from
wu-sheng commented on issue #3838: [test/plugin] immigrate test feign scenario.
URL: https://github.com/apache/skywalking/pull/3838#issuecomment-553167122
/run agent-plugin-test-1
This is an automated message from the Apache
wu-sheng commented on issue #3840: [test/plugin] immigrate grpc scenario
URL: https://github.com/apache/skywalking/pull/3840#issuecomment-553166843
Test fails. Please recheck.
This is an automated message from the Apache Git
webb2019 opened a new issue #3842: which way deploy in clust mode best?
URL: https://github.com/apache/skywalking/issues/3842
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [x] Question or discussion
- [ ] Bug
- [ ] Requirement
wu-sheng commented on issue #3788: Rabbitmq plugin test migration
URL: https://github.com/apache/skywalking/pull/3788#issuecomment-552954726
>I am away from my computer for couple of days. If someone can take that
final comment and fix, they can. Or I will send update in two days.
wu-sheng commented on issue #3841: Does suport agent upload data cache to MQ ,
oap pick data from MQ?
URL: https://github.com/apache/skywalking/issues/3841#issuecomment-552954346
But with that, the value of a monitoring system is keeping reduce. With
several minutes latency to trigger
webb2019 commented on issue #3841: Does suport agent upload data cache to MQ ,
oap pick data from MQ?
URL: https://github.com/apache/skywalking/issues/3841#issuecomment-552952712
> No, even it is, don't help the CPU payload. It will only make you cost
more CPU.
I think the benefit of
viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
URL: https://github.com/apache/skywalking/pull/3788#issuecomment-552946737
I am away from my computer for couple of days. If someone can take that
final comment and fix, they can. Or I will send update in two days.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch queue-visibility
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 7b3e55a Merge branch 'master' into queue-visibility
add a407819 [plugin]support log4j2
wu-sheng closed issue #3841: Does suport agent upload data cache to MQ , oap
pick data from MQ?
URL: https://github.com/apache/skywalking/issues/3841
This is an automated message from the Apache Git Service.
To respond to
wu-sheng commented on issue #3841: Does suport agent upload data cache to MQ ,
oap pick data from MQ?
URL: https://github.com/apache/skywalking/issues/3841#issuecomment-552940495
No, even it is, don't help the CPU payload. It will only make you cost more
CPU.
wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch
6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803#issuecomment-552935624
Version is required to update to 6.6.0-SNAPSHOT.
webb2019 opened a new issue #3841: Does suport agent upload data cache to MQ ,
oap pick data from MQ?
URL: https://github.com/apache/skywalking/issues/3841
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [x] Question or discussion
wu-sheng commented on issue #3788: Rabbitmq plugin test migration
URL: https://github.com/apache/skywalking/pull/3788#issuecomment-552930391
@viswaramamoorthy Code frozen is over. Please keep the update, after all
checked, this could be merged.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 3fbaec4 Move to 6.6.0 SNAPSHOT (#3839)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch 6.5.0
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at 3e22848 [maven-release-plugin] prepare for next development iteration
No new revisions were added by this
wu-sheng merged pull request #3839: Move to 6.6.0 SNAPSHOT
URL: https://github.com/apache/skywalking/pull/3839
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
arugal commented on issue #3838: [test/plugin] immigrate test feign scenario.
URL: https://github.com/apache/skywalking/pull/3838#issuecomment-552915321
refer #3583
This is an automated message from the Apache Git Service.
arugal edited a comment on issue #3583: Plugin test-cases immigrate plan
URL: https://github.com/apache/skywalking/issues/3583#issuecomment-552164244
grpc scenario for me #3840
This is an automated message from the Apache Git
arugal commented on a change in pull request #3840: [test/plugin] immigrate
grpc scenario
URL: https://github.com/apache/skywalking/pull/3840#discussion_r345232165
##
File path:
test/plugin/archetypes/jvm/src/main/resources/archetype-resources/pom.xml
##
@@ -73,7 +73,6
arugal opened a new pull request #3840: [test/plugin] immigrate grpc scenario
URL: https://github.com/apache/skywalking/pull/3840
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ]
aderm commented on issue #3838: [test/plugin] immigrate test feign scenario.
URL: https://github.com/apache/skywalking/pull/3838#issuecomment-552902300
/run agent-plugin-test-1
This is an automated message from the Apache Git
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to tag v6.5.0
in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git.
at c970b19 (commit)
No new revisions were added by this update.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to tag v6.5.0
in repository
https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git.
at 7b244ff (commit)
No new revisions were added by this update.
wu-sheng opened a new pull request #3839: Move to 6.6.0 SNAPSHOT
URL: https://github.com/apache/skywalking/pull/3839
Waiting for 6.5.0 release, after that, the version moves to 6.6.0-SNAPSHOT
This is an automated message from
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch 6.5.0
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/6.5.0 by this push:
new 3e22848 [maven-release-plugin] prepare for
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to annotated tag v6.5.0
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
*** WARNING: tag v6.5.0 was modified! ***
from 4d4ca9c (commit)
to fb6437e (tag)
tagging
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch 6.5.0
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at 4d4ca9c [maven-release-plugin] prepare release v6.5.0
This branch includes the following new commits:
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch 6.5.0
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 4d4ca9c5173ea4caad6155e047ace86f550e
Author: Wu Sheng
AuthorDate: Tue Nov 12 13:22:27 2019 +
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to annotated tag v6.5.0
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
*** WARNING: tag v6.5.0 was modified! ***
from 1731130 (commit)
to 929a447 (tag)
tagging
wu-sheng commented on issue #3837: Support spring-tx in optional plugin
URL: https://github.com/apache/skywalking/issues/3837#issuecomment-552874851
Optional is OK if you want.
This is an automated message from the Apache
aderm opened a new pull request #3838: [test/plugin] immigrate test feign
scenario.
URL: https://github.com/apache/skywalking/pull/3838
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [
cyejing commented on issue #3805: The webflux-plugin is not working properly
URL: https://github.com/apache/skywalking/issues/3805#issuecomment-552829488
I have a idea, can use Mono ``doFinally`` method , and put TraceContext
into SkyWalkingDynamicField of ServerWebExchange . collect
zhaoyuguang opened a new issue #3837: Support spring-tx in optional plugin
URL: https://github.com/apache/skywalking/issues/3837
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ]
zhaoyuguang commented on issue #3805: The webflux-plugin is not working properly
URL: https://github.com/apache/skywalking/issues/3805#issuecomment-552799265
Indeed, as @cyejing said, The webflux plugin doesn't perform well after
using reactive improvements, I am thinking about whether
63 matches
Mail list logo
