wu-sheng commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723541870
Let's release our operator
This is an automated message from the Apache Git Service.
To respond to the
wu-sheng merged pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-swck.git
The following commit(s) were added to refs/heads/master by this push:
new 96fe630 Update README.md (#5)
hanahmily commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519260908
##
File path: README.md
##
@@ -1,3 +1,78 @@
-# skywalking-swck
-
Apache SkyWalking Cloud on Kubernetes
+
+
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723533887
I was very excited about the moment of code merging! ! I'm inspired and
proud to be the 281st contributor to the main repo!
Thanks to the SkyWalking community,
arugal edited a comment on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723532402
Basically LGTM.
```bash
$ kubectl get all -n skywalking-swck-system
NAME READY STATUS
arugal commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723532402
Basically LGTM.
```bash
$ kubectl get all -n skywalking-swck-system
NAME READY STATUS
RESTARTS
arugal commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519257523
##
File path: README.md
##
@@ -1,3 +1,78 @@
-# skywalking-swck
-
Apache SkyWalking Cloud on Kubernetes
+
+
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
arugal commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519244934
##
File path: controllers/oapserver_controller.go
##
@@ -52,6 +52,7 @@ type OAPServerReconciler struct {
//
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`master@bc7afa6`).
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
arugal commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723519207
> > > We can set namespace by `cd config/default && kustomize edit set
namespace ` or just edit `config/default/kustomization.yaml`. And I
mentioned how to customize it in
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
kezhenxu94 merged pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 1c55781 Catch all exception when consume kafka record (#5760)
add bc7afa6 add support for dbcp 2.x
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a change to branch feature/als-mx
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 17a0f3c Merge branch 'master' into feature/als-mx
add bc7afa6 add support for dbcp 2.x plugin
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723514860
> One last thing, `CHANGES.md` is not updated. You are adding a new plugin.
Ok sir, I have updated CHANGES.md.
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
hanahmily commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723466498
> > We can set namespace by `cd config/default && kustomize edit set
namespace ` or just edit `config/default/kustomization.yaml`. And I
mentioned how to customize it in
hanahmily commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723465595
> @hanahmily Why these files were not detected by your script? This seems
more important.
Licenses tool only checks files in the config directory, that are updated
hanahmily merged pull request #7:
URL: https://github.com/apache/skywalking-swck/pull/7
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-swck.git
The following commit(s) were added to refs/heads/master by this push:
new b7cf4a0 Give a explicit check
wu-sheng commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723463453
One last thing, `CHANGES.md` is not updated. You are adding a new plugin.
This is an automated message from
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
arugal edited a comment on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723462359
> We can set namespace by `cd config/default && kustomize edit set namespace
` or just edit `config/default/kustomization.yaml`. And I mentioned how
to customize it in
kezhenxu94 commented on pull request #6:
URL: https://github.com/apache/skywalking-swck/pull/6#issuecomment-723462358
> > Seems the context is wrong
>
> @kezhenxu94 What is the issue?
here is the problem, I fix it in #7
arugal commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723462359
> We can set namespace by `cd config/default && kustomize edit set namespace
` or just edit `config/default/kustomization.yaml`. And I mentioned how
to customize it in
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a change to branch kezhenxu94-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking-swck.git.
at 44dad02 Give a explicit check context
No new revisions were added by this update.
wu-sheng commented on pull request #6:
URL: https://github.com/apache/skywalking-swck/pull/6#issuecomment-723461576
> Seems the context is wrong
@kezhenxu94 What is the issue?
This is an automated message from the
kezhenxu94 opened a new pull request #7:
URL: https://github.com/apache/skywalking-swck/pull/7
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wu-sheng commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723461420
@hanahmily Why these files were not detected by your script? This seems more
important.
This is an
kezhenxu94 commented on pull request #6:
URL: https://github.com/apache/skywalking-swck/pull/6#issuecomment-723461270
Seems the context is wrong
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-swck.git.
from 8e435eb Merge pull request #3 from hanahmily/oap-crds
add 893474a Add branch protection and
wu-sheng merged pull request #6:
URL: https://github.com/apache/skywalking-swck/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
hanahmily commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723460742
> > > > @wu-sheng @kezhenxu94 I intend to pick up this PR as the final
collection of release 0.1.0. Pls, check what to be fixed before the release.
> > >
> > >
>
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
hanahmily commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723459638
> 1. `kustomize` cannot modify the name of `namesapce`
>
![image](https://user-images.githubusercontent.com/26432832/98440887-60bece00-2136-11eb-804c-7cca59aff83d.png)
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723457900
> Add `Pool` catalog.
Got it.
This is an automated message from the Apache Git Service.
To respond
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr=h1)
Report
> Merging
kezhenxu94 commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723451480
> > > @wu-sheng @kezhenxu94 I intend to pick up this PR as the final
collection of release 0.1.0. Pls, check what to be fixed before the release.
> >
> >
> > If
wu-sheng commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723451353
> Dear sir, Is cache classification appropriate?or create a new
classification named DBCP?
Add `Pool` catalog.
Jargon96 edited a comment on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723450985
> Seems you forgot to update this
https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Supported-list.md
Dear sir, Is cache
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723450985
> Seems you forgot to update this
https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Supported-list.md
Dear sir, Is cache
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
hanahmily commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723450333
> > @wu-sheng @kezhenxu94 I intend to pick up this PR as the final
collection of release 0.1.0. Pls, check what to be fixed before the release.
>
> If this is the
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr=h1)
Report
> Merging
1 - 100 of 358 matches
Mail list logo