[GitHub] [skywalking] wu-sheng merged pull request #10566: Sync UI.

2023-03-20 Thread via GitHub
wu-sheng merged PR #10566: URL: https://github.com/apache/skywalking/pull/10566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking] branch master updated: Sync UI. (#10566)

2023-03-20 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new bb1ea0ddd7 Sync UI. (#10566) bb1ea0ddd7 is

[GitHub] [skywalking] wu-sheng opened a new pull request, #10566: Sync UI.

2023-03-20 Thread via GitHub
wu-sheng opened a new pull request, #10566: URL: https://github.com/apache/skywalking/pull/10566 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

[skywalking] branch sync created (now b0e687b09e)

2023-03-20 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch sync in repository https://gitbox.apache.org/repos/asf/skywalking.git at b0e687b09e Sync UI. This branch includes the following new commits: new b0e687b09e Sync UI. The 1

[skywalking] 01/01: Sync UI.

2023-03-20 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch sync in repository https://gitbox.apache.org/repos/asf/skywalking.git commit b0e687b09e18aab283f9cf11bb4daf508ed3046d Author: Wu Sheng AuthorDate: Tue Mar 21 09:39:29 2023 +0800 Sync UI.

[skywalking-booster-ui] branch main updated: revert: cpm5d (#245)

2023-03-20 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new 8031c1b revert: cpm5d (#245)

[GitHub] [skywalking-booster-ui] wu-sheng merged pull request #245: revert: `cpm5d` and `cpm5dAvg` calculations

2023-03-20 Thread via GitHub
wu-sheng merged PR #245: URL: https://github.com/apache/skywalking-booster-ui/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking-booster-ui] Fine0830 opened a new pull request, #245: revert: `cpm5d` and `cpm5dAvg` calculations

2023-03-20 Thread via GitHub
Fine0830 opened a new pull request, #245: URL: https://github.com/apache/skywalking-booster-ui/pull/245 Reverts `cpm5d` and `cpm5dAvg` calculations. Signed-off-by: Qiuxia Fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking-query-protocol] wu-sheng commented on a diff in pull request #110: Add isEmptyValue flag to indicate clear meaning for value

2023-03-20 Thread via GitHub
wu-sheng commented on code in PR #110: URL: https://github.com/apache/skywalking-query-protocol/pull/110#discussion_r1142809824 ## metric.graphqls: ## @@ -50,6 +50,8 @@ type KVInt { # 1. If ask for cpm metric, the unit and result should be count. # 2. If ask for

[GitHub] [skywalking] Fine0830 commented on issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled

2023-03-20 Thread via GitHub
Fine0830 commented on issue #10419: URL: https://github.com/apache/skywalking/issues/10419#issuecomment-1477144513 > @Fine0830 Could you remove that? I noticed it mixed with another change. Sure -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking-query-protocol] toffentoffen commented on a diff in pull request #110: Add isEmptyValue flag to indicate clear meaning for value

2023-03-20 Thread via GitHub
toffentoffen commented on code in PR #110: URL: https://github.com/apache/skywalking-query-protocol/pull/110#discussion_r1142410342 ## metric.graphqls: ## @@ -50,6 +50,8 @@ type KVInt { # 1. If ask for cpm metric, the unit and result should be count. # 2. If ask for

[GitHub] [skywalking-query-protocol] toffentoffen commented on a diff in pull request #110: Add isEmptyValue flag to indicate clear meaning for value

2023-03-20 Thread via GitHub
toffentoffen commented on code in PR #110: URL: https://github.com/apache/skywalking-query-protocol/pull/110#discussion_r1142410342 ## metric.graphqls: ## @@ -50,6 +50,8 @@ type KVInt { # 1. If ask for cpm metric, the unit and result should be count. # 2. If ask for

[GitHub] [skywalking] wu-sheng commented on issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled

2023-03-20 Thread via GitHub
wu-sheng commented on issue #10419: URL: https://github.com/apache/skywalking/issues/10419#issuecomment-1476568101 @Fine0830 Could you remove that? I noticed it mixed with another change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] wu-sheng commented on issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled

2023-03-20 Thread via GitHub
wu-sheng commented on issue #10419: URL: https://github.com/apache/skywalking/issues/10419#issuecomment-1476565316 I think we should to keep consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] toffentoffen commented on issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled

2023-03-20 Thread via GitHub
toffentoffen commented on issue #10419: URL: https://github.com/apache/skywalking/issues/10419#issuecomment-1476542060 Should we revert UI committed changes for the CPM5D function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] wu-sheng commented on issue #10565: [Feature] Monitoring Redis Server

2023-03-20 Thread via GitHub
wu-sheng commented on issue #10565: URL: https://github.com/apache/skywalking/issues/10565#issuecomment-1476477497 Just read it. I think it makes sense. Those are important metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] yswdqz commented on issue #10565: [Feature] Monitoring Redis Server

2023-03-20 Thread via GitHub
yswdqz commented on issue #10565: URL: https://github.com/apache/skywalking/issues/10565#issuecomment-1476473203 Got it, I have edited the permission -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [skywalking] wu-sheng commented on issue #10565: [Feature] Monitoring Redis Server

2023-03-20 Thread via GitHub
wu-sheng commented on issue #10565: URL: https://github.com/apache/skywalking/issues/10565#issuecomment-1476470198 > @wu-sheng I think these metrics is enough: [metric doc](https://docs.google.com/document/d/1E975HrSey7Yj_4bWIqcXK9DQxMcLGFA2e1OsILdIDcY/edit) Please make the docs

[GitHub] [skywalking] yswdqz commented on issue #10565: [Feature] Monitoring Redis Server

2023-03-20 Thread via GitHub
yswdqz commented on issue #10565: URL: https://github.com/apache/skywalking/issues/10565#issuecomment-1476460728 @wu-sheng I think these metrics is enough: [metric doc](https://docs.google.com/document/d/1E975HrSey7Yj_4bWIqcXK9DQxMcLGFA2e1OsILdIDcY/edit) -- This is an automated

[GitHub] [skywalking] wu-sheng commented on issue #10565: [Feature] Monitoring Redis Server

2023-03-20 Thread via GitHub
wu-sheng commented on issue #10565: URL: https://github.com/apache/skywalking/issues/10565#issuecomment-1476289673 About `SkyWalking OpenCensus Receiver`, please stay on OLTP receiver only. OC will end soon. BTW, Redis could be cataloged inside Database. For now, I don't think we

[GitHub] [skywalking] yswdqz opened a new issue, #10565: [Feature] Monitoring Redis Server

2023-03-20 Thread via GitHub
yswdqz opened a new issue, #10565: URL: https://github.com/apache/skywalking/issues/10565 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration

2023-03-20 Thread via GitHub
wu-sheng commented on issue #10461: URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1476209716 Ref https://github.com/apache/skywalking/pull/10476#issuecomment-1476208961 We haven't finished this for now. -- This is an automated message from the Apache Git Service.

[GitHub] [skywalking] wu-sheng closed issue #10461: [Feature] DCS supports global configuration

2023-03-20 Thread via GitHub
wu-sheng closed issue #10461: [Feature] DCS supports global configuration URL: https://github.com/apache/skywalking/issues/10461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking] wu-sheng commented on pull request #10476: Feature DCS supports global configuration

2023-03-20 Thread via GitHub
wu-sheng commented on PR #10476: URL: https://github.com/apache/skywalking/pull/10476#issuecomment-1476208961 Close for now, as this has not been updated for a week. If you want to continuous on this, please polish the codes, the logic is clear, we just need the codes better. Thanks. --

[GitHub] [skywalking] wu-sheng closed pull request #10476: Feature DCS supports global configuration

2023-03-20 Thread via GitHub
wu-sheng closed pull request #10476: Feature DCS supports global configuration URL: https://github.com/apache/skywalking/pull/10476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking] wu-sheng commented on issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled

2023-03-20 Thread via GitHub
wu-sheng commented on issue #10419: URL: https://github.com/apache/skywalking/issues/10419#issuecomment-1476206376 Ref https://github.com/apache/skywalking/pull/10420#issuecomment-1476205729 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] wu-sheng closed issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled

2023-03-20 Thread via GitHub
wu-sheng closed issue #10419: [Feature] Add a new cpm aggregation function that does not lose precision when downsampled URL: https://github.com/apache/skywalking/issues/10419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [skywalking] wu-sheng commented on pull request #10420: Add cpm5d aggregation function

2023-03-20 Thread via GitHub
wu-sheng commented on PR #10420: URL: https://github.com/apache/skywalking/pull/10420#issuecomment-1476205729 Close for now. As this is no update for a while, and this will break many metrics from an integration perspective. Let's see whether we really need this. -- This is an automated

[GitHub] [skywalking] wu-sheng closed pull request #10420: Add cpm5d aggregation function

2023-03-20 Thread via GitHub
wu-sheng closed pull request #10420: Add cpm5d aggregation function URL: https://github.com/apache/skywalking/pull/10420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [skywalking-query-protocol] wu-sheng commented on a diff in pull request #110: Add isEmptyValue flag to indicate clear meaning for value

2023-03-20 Thread via GitHub
wu-sheng commented on code in PR #110: URL: https://github.com/apache/skywalking-query-protocol/pull/110#discussion_r1142037090 ## metric.graphqls: ## @@ -50,6 +50,8 @@ type KVInt { # 1. If ask for cpm metric, the unit and result should be count. # 2. If ask for

[GitHub] [skywalking] wu-sheng merged pull request #10473: Support continuous profiling feature

2023-03-20 Thread via GitHub
wu-sheng merged PR #10473: URL: https://github.com/apache/skywalking/pull/10473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking] xiaozaiyuji commented on a diff in pull request #10557: modify the service query and query by group and layer and modify the elasticsearch scroll queryMaxSize

2023-03-20 Thread via GitHub
xiaozaiyuji commented on code in PR #10557: URL: https://github.com/apache/skywalking/pull/10557#discussion_r1141981700 ## oap-server/server-query-plugin/query-graphql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/resolver/MetadataQueryV2.java: ## @@ -67,6 +67,10

[GitHub] [skywalking-query-protocol] toffentoffen commented on a diff in pull request #110: Add isEmptyValue flag to indicate clear meaning for value

2023-03-20 Thread via GitHub
toffentoffen commented on code in PR #110: URL: https://github.com/apache/skywalking-query-protocol/pull/110#discussion_r1141989257 ## metric.graphqls: ## @@ -50,6 +50,8 @@ type KVInt { # 1. If ask for cpm metric, the unit and result should be count. # 2. If ask for

[GitHub] [skywalking] xiaozaiyuji commented on a diff in pull request #10557: modify the service query and query by group and layer and modify the elasticsearch scroll queryMaxSize

2023-03-20 Thread via GitHub
xiaozaiyuji commented on code in PR #10557: URL: https://github.com/apache/skywalking/pull/10557#discussion_r1141981700 ## oap-server/server-query-plugin/query-graphql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/resolver/MetadataQueryV2.java: ## @@ -67,6 +67,10

[GitHub] [skywalking] mrproliu commented on a diff in pull request #10473: Support continuous profiling feature

2023-03-20 Thread via GitHub
mrproliu commented on code in PR #10473: URL: https://github.com/apache/skywalking/pull/10473#discussion_r1141949406 ##

[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #10473: Support continuous profiling feature

2023-03-20 Thread via GitHub
kezhenxu94 commented on code in PR #10473: URL: https://github.com/apache/skywalking/pull/10473#discussion_r1141943177 ##

[GitHub] [skywalking] mrproliu commented on a diff in pull request #10473: Support continuous profiling feature

2023-03-20 Thread via GitHub
mrproliu commented on code in PR #10473: URL: https://github.com/apache/skywalking/pull/10473#discussion_r1141840298 ##

[GitHub] [skywalking-rover] mrproliu merged pull request #82: Improve the performance when getting `goid` in eBPF

2023-03-20 Thread via GitHub
mrproliu merged PR #82: URL: https://github.com/apache/skywalking-rover/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking] branch master updated: [BUG] otel k8s-cluster rule, add namespace dimension for MAL aggregation calculation(Deployment Status,Deployment Spec Replicas) (#10563)

2023-03-20 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 3662b01365 [BUG] otel k8s-cluster rule,

[GitHub] [skywalking] wu-sheng merged pull request #10563: [BUG] otel k8s-cluster rule add namespace dimension for MAL aggregation calculation(Deployment Status,Deployment Spec Replicas)

2023-03-20 Thread via GitHub
wu-sheng merged PR #10563: URL: https://github.com/apache/skywalking/pull/10563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking] wu-sheng closed issue #10564: [Bug] When the data of the last point is 0, there will be problems when displaying the table.

2023-03-20 Thread via GitHub
wu-sheng closed issue #10564: [Bug] When the data of the last point is 0, there will be problems when displaying the table. URL: https://github.com/apache/skywalking/issues/10564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] wu-sheng commented on issue #10564: [Bug] When the data of the last point is 0, there will be problems when displaying the table.

2023-03-20 Thread via GitHub
wu-sheng commented on issue #10564: URL: https://github.com/apache/skywalking/issues/10564#issuecomment-1475800844 We don't have plan to exclude the latest value actually. Read https://github.com/apache/skywalking/issues/10501, that is the right way to do so. 0 sometimes means 0, it is

[GitHub] [skywalking] innerpeacez opened a new issue, #10564: [Bug] When the data of the last point is 0, there will be problems when displaying the table.

2023-03-20 Thread via GitHub
innerpeacez opened a new issue, #10564: URL: https://github.com/apache/skywalking/issues/10564 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking

[GitHub] [skywalking-python] Superskyyy commented on a diff in pull request #297: [feat]Build multi-architecture Docker images for Python agent

2023-03-20 Thread via GitHub
Superskyyy commented on code in PR #297: URL: https://github.com/apache/skywalking-python/pull/297#discussion_r1141749629 ## docker/Dockerfile: ## @@ -21,7 +21,9 @@ FROM ${BASE_PYTHON_IMAGE} ARG SW_PYTHON_AGENT_PROTOCOL ARG SW_PYTHON_AGENT_VERSION -RUN pip install

[GitHub] [skywalking] innerpeacez commented on pull request #10563: [BUG] otel k8s-cluster rule add namespace dimension for MAL aggregation calculation(Deployment Status,Deployment Spec Replicas)

2023-03-20 Thread via GitHub
innerpeacez commented on PR #10563: URL: https://github.com/apache/skywalking/pull/10563#issuecomment-1475766883 > > There may be deployment with the same name under different namespace. > > @innerpeacez Are you going to merge them? Could you be more clear about what was before and

[GitHub] [skywalking] wu-sheng commented on pull request #10563: [BUG] otel k8s-cluster rule add namespace dimension for MAL aggregation calculation(Deployment Status,Deployment Spec Replicas)

2023-03-20 Thread via GitHub
wu-sheng commented on PR #10563: URL: https://github.com/apache/skywalking/pull/10563#issuecomment-1475759676 > There may be deployment with the same name under different namespace. @innerpeacez Are you going to merge them? Could you be more clear about what was before and what is

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10563: [BUG] otel k8s-cluster rule add namespace dimension for MAL aggregation calculation(Deployment Status,Deployment Spec Replica

2023-03-20 Thread via GitHub
wu-sheng commented on code in PR #10563: URL: https://github.com/apache/skywalking/pull/10563#discussion_r1141730975 ## docs/en/changes/changes.md: ## @@ -13,7 +13,7 @@ * Fix component ID of topology overlap due to storage layer bugs. * [Breaking Change] Enhance JDBC storage

[GitHub] [skywalking] innerpeacez opened a new pull request, #10563: [BUG] otel k8s-cluster rule add namespace dimension for MAL aggregation calculation(Deployment Status,Deployment Spec Replicas)

2023-03-20 Thread via GitHub
innerpeacez opened a new pull request, #10563: URL: https://github.com/apache/skywalking/pull/10563 ### Fix - [ ] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. There may be deployment with the same name

[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #10473: Support continuous profiling feature

2023-03-20 Thread via GitHub
kezhenxu94 commented on code in PR #10473: URL: https://github.com/apache/skywalking/pull/10473#discussion_r1141708766 ##

[GitHub] [skywalking-banyandb] HHoflittlefish777 commented on pull request #261: Implement Write-ahead Logging

2023-03-20 Thread via GitHub
HHoflittlefish777 commented on PR #261: URL: https://github.com/apache/skywalking-banyandb/pull/261#issuecomment-1475736958 > @HHoflittlefish777 Please fix test failures. > @HHoflittlefish777 Please fix test failures. > @HHoflittlefish777 Please fix test

[GitHub] [skywalking-python] kezhenxu94 commented on a diff in pull request #297: [feat]Build multi-architecture Docker images for Python agent

2023-03-20 Thread via GitHub
kezhenxu94 commented on code in PR #297: URL: https://github.com/apache/skywalking-python/pull/297#discussion_r1141700680 ## .github/workflows/publish-docker.yaml: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [skywalking-banyandb] HHoflittlefish777 commented on pull request #261: Implement Write-ahead Logging

2023-03-20 Thread via GitHub
HHoflittlefish777 commented on PR #261: URL: https://github.com/apache/skywalking-banyandb/pull/261#issuecomment-1475729014 > > There are some things that need help: > > > > * During disk flushing, in order to avoid blocking writes, I cloned the buffer so that I can continue to

[GitHub] [skywalking-rover] mrproliu opened a new pull request, #82: Improve the performance when getting `goid` in eBPF

2023-03-20 Thread via GitHub
mrproliu opened a new pull request, #82: URL: https://github.com/apache/skywalking-rover/pull/82 Inspired by pixie, we can no longer use `runtime.casgstatus` to get `goid`. Instead, get it directly from the local storage of the current thread. -- This is an automated message from the

[GitHub] [skywalking] lujiajing1126 opened a new issue, #10562: [GSoC] [Feature] Unify query planner and executor in BanyanDB

2023-03-20 Thread via GitHub
lujiajing1126 opened a new issue, #10562: URL: https://github.com/apache/skywalking/issues/10562 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ###