Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
wu-sheng commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507152617 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
peachisai commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507136415 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
peachisai commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507136415 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

[I] [Feature] Remove `Column#function` mechanims in the kernel [skywalking]

2024-02-28 Thread via GitHub
wu-sheng opened a new issue, #11960: URL: https://github.com/apache/skywalking/issues/11960 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
wu-sheng commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507114027 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
peachisai commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507092996 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

[I] [Bug] Persistency timer took a long time [skywalking]

2024-02-28 Thread via GitHub
hanahmily opened a new issue, #11959: URL: https://github.com/apache/skywalking/issues/11959 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking

[I] [Bug] Panic when querying measure data [skywalking]

2024-02-28 Thread via GitHub
hanahmily opened a new issue, #11958: URL: https://github.com/apache/skywalking/issues/11958 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
wu-sheng commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507055945 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
peachisai commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507053749 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
peachisai commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507043756 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
wu-sheng commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507047700 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
peachisai commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507043756 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
peachisai commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507043756 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [I] [Bug] banyandb web-ui console error logs [skywalking]

2024-02-28 Thread via GitHub
hanahmily commented on issue #11273: URL: https://github.com/apache/skywalking/issues/11273#issuecomment-1970449579 @sksDonni To merge the issue, please open two tabs and switch between them. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] [Bug] banyandb web-ui console error logs [skywalking]

2024-02-28 Thread via GitHub
hailin0 commented on issue #11273: URL: https://github.com/apache/skywalking/issues/11273#issuecomment-1970447403 https://github.com/apache/skywalking/assets/14371345/110a3137-0563-45fd-8f0c-194a738d0b0e;> -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Added unit test for string.go in convert package [skywalking-banyandb]

2024-02-28 Thread via GitHub
codecov-commenter commented on PR #392: URL: https://github.com/apache/skywalking-banyandb/pull/392#issuecomment-1970437654 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/392?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

[I] [Bug] Panic when closing banyand [skywalking]

2024-02-28 Thread via GitHub
hanahmily opened a new issue, #11957: URL: https://github.com/apache/skywalking/issues/11957 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking

Re: [PR] Added unit test for string.go in convert package [skywalking-banyandb]

2024-02-28 Thread via GitHub
sivasathyaseeelan commented on PR #392: URL: https://github.com/apache/skywalking-banyandb/pull/392#issuecomment-1970403468 > Please fix the CI. Lint check fails. > Please fix the CI. Lint check fails. Hello @wu-sheng, I have updated this PR. Could you please review it

Re: [I] [Bug] When querying topn, there seems to be a problem with the indicator aggregation calculation method. [skywalking]

2024-02-28 Thread via GitHub
wu-sheng closed issue #11955: [Bug] When querying topn, there seems to be a problem with the indicator aggregation calculation method. URL: https://github.com/apache/skywalking/issues/11955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[I] [Bug] When querying topn, there seems to be a problem with the indicator aggregation calculation method. [skywalking]

2024-02-28 Thread via GitHub
bbcdabao opened a new issue, #11955: URL: https://github.com/apache/skywalking/issues/11955 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
wu-sheng commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1506958386 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
peachisai commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1506957913 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
wu-sheng commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1506956509 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
peachisai commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1506955632 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
wankai123 commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1506953031 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
wu-sheng commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1506951724 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

Re: [PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
wu-sheng commented on code in PR #11954: URL: https://github.com/apache/skywalking/pull/11954#discussion_r1506951419 ## docs/en/concepts-and-designs/service-hierarchy.md: ## @@ -162,6 +164,22 @@ If you want to customize it according to your own needs, please refer to [Servic

[PR] Add kafka hierarchy [skywalking]

2024-02-28 Thread via GitHub
peachisai opened a new pull request, #11954: URL: https://github.com/apache/skywalking/pull/11954 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

Re: [PR] Added unit test for string.go in convert package [skywalking-banyandb]

2024-02-28 Thread via GitHub
wu-sheng commented on PR #392: URL: https://github.com/apache/skywalking-banyandb/pull/392#issuecomment-1970154843 Please fix the CI. Lint check fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Bug] banyandb web-ui console error logs [skywalking]

2024-02-28 Thread via GitHub
hanahmily commented on issue #11273: URL: https://github.com/apache/skywalking/issues/11273#issuecomment-1970102049 I couldn't find any errors upon double-checking. Could you verify, @hailin0? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] [Bug] banyandb web-ui console error logs [skywalking]

2024-02-28 Thread via GitHub
sksDonni commented on issue #11273: URL: https://github.com/apache/skywalking/issues/11273#issuecomment-1969545095 Hi @hanahmily and @hailin0, would like to take this up. But not sure why, but I am not able to reproduce this in my local setup. I am using a M1 mac running the standalone

[PR] Added unit test for string.go in convert package [skywalking-banyandb]

2024-02-28 Thread via GitHub
sivasathyaseeelan opened a new pull request, #392: URL: https://github.com/apache/skywalking-banyandb/pull/392 ### Fix This PR adds unit test for string.go in convert package and partially fixes https://github.com/apache/skywalking/issues/11942 - [x] Add a unit test to verify

[PR] Fix loading customized BTF not take effect [skywalking-rover]

2024-02-28 Thread via GitHub
caiwc opened a new pull request, #114: URL: https://github.com/apache/skywalking-rover/pull/114 Because the btf space is not loaded from the customized BTF file, customized btf path not work. Since commit #65 -- This is an automated message from the Apache Git Service. To respond to

(skywalking) branch master updated: Enhance the instruction about the kafka and gRPC exporters. (#11951)

2024-02-28 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 2aed50e861 Enhance the instruction about

Re: [PR] enhance the instruction about the kafka exporter function. [skywalking]

2024-02-28 Thread via GitHub
wu-sheng merged PR #11951: URL: https://github.com/apache/skywalking/pull/11951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] enhance the instruction about the kafka exporter function. [skywalking]

2024-02-28 Thread via GitHub
wu-sheng commented on code in PR #11951: URL: https://github.com/apache/skywalking/pull/11951#discussion_r1505769772 ## docs/en/setup/backend/exporter.md: ## @@ -26,9 +26,10 @@ service MetricExportService { } ``` -To activate the exporter, you should set

Re: [PR] enhance the instruction about the kafka exporter function. [skywalking]

2024-02-28 Thread via GitHub
wu-sheng commented on PR #11951: URL: https://github.com/apache/skywalking/pull/11951#issuecomment-1968675857 gRPC is not supporting multiple addresses, it should be one address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] enhance the instruction about the kafka exporter function. [skywalking]

2024-02-28 Thread via GitHub
wankai123 commented on PR #11951: URL: https://github.com/apache/skywalking/pull/11951#issuecomment-1968509336 Please help to enhance the gRPC exporter config part as well, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] enhance the instruction about the kafka exporter function. [skywalking]

2024-02-28 Thread via GitHub
wu-sheng commented on code in PR #11951: URL: https://github.com/apache/skywalking/pull/11951#discussion_r1505571971 ## docs/en/setup/backend/exporter.md: ## @@ -72,9 +72,10 @@ message SegmentObject { } ``` -To activate the exporter, you should set

[PR] enhance the instruction about the kafka exporter function. [skywalking]

2024-02-28 Thread via GitHub
Henry75m39 opened a new pull request, #11951: URL: https://github.com/apache/skywalking/pull/11951 A. change the instruction about how to activate export function: To activate the export program, you should set "${SW_exporter: nefault}" and "${SW_exporterENABLE_KAFKALOG: true}", configure