[GitHub] [skywalking-swck] hanahmily commented on pull request #5: Update README.md

2020-11-07 Thread GitBox
hanahmily commented on pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723460742 > > > > @wu-sheng @kezhenxu94 I intend to pick up this PR as the final collection of release 0.1.0. Pls, check what to be fixed before the release. > > > > > > > >

[GitHub] [skywalking-swck] wu-sheng merged pull request #6: Add branch protection and requires checks/reviews before merging

2020-11-07 Thread GitBox
wu-sheng merged pull request #6: URL: https://github.com/apache/skywalking-swck/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[skywalking-swck] branch master updated (8e435eb -> 893474a)

2020-11-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-swck.git. from 8e435eb Merge pull request #3 from hanahmily/oap-crds add 893474a Add branch protection and requires

[GitHub] [skywalking-swck] kezhenxu94 commented on pull request #6: Add branch protection and requires checks/reviews before merging

2020-11-07 Thread GitBox
kezhenxu94 commented on pull request #6: URL: https://github.com/apache/skywalking-swck/pull/6#issuecomment-723461270 Seems the context is wrong This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [skywalking-swck] wu-sheng commented on pull request #5: Update README.md

2020-11-07 Thread GitBox
wu-sheng commented on pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723461420 @hanahmily Why these files were not detected by your script? This seems more important. This is an automated

[GitHub] [skywalking-swck] kezhenxu94 opened a new pull request #7: Give a explicit check context

2020-11-07 Thread GitBox
kezhenxu94 opened a new pull request #7: URL: https://github.com/apache/skywalking-swck/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [skywalking-swck] wu-sheng commented on pull request #6: Add branch protection and requires checks/reviews before merging

2020-11-07 Thread GitBox
wu-sheng commented on pull request #6: URL: https://github.com/apache/skywalking-swck/pull/6#issuecomment-723461576 > Seems the context is wrong @kezhenxu94 What is the issue? This is an automated message from the Apac

[skywalking-swck] branch kezhenxu94-patch-1 created (now 44dad02)

2020-11-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-swck.git. at 44dad02 Give a explicit check context No new revisions were added by this update.

[GitHub] [skywalking-swck] arugal commented on pull request #5: Update README.md

2020-11-07 Thread GitBox
arugal commented on pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723462359 > We can set namespace by `cd config/default && kustomize edit set namespace ` or just edit `config/default/kustomization.yaml`. And I mentioned how to customize it in https:/

[GitHub] [skywalking-swck] kezhenxu94 commented on pull request #6: Add branch protection and requires checks/reviews before merging

2020-11-07 Thread GitBox
kezhenxu94 commented on pull request #6: URL: https://github.com/apache/skywalking-swck/pull/6#issuecomment-723462358 > > Seems the context is wrong > > @kezhenxu94 What is the issue? here is the problem, I fix it in #7 ![image](https://user-images.githubusercontent.co

[GitHub] [skywalking-swck] arugal edited a comment on pull request #5: Update README.md

2020-11-07 Thread GitBox
arugal edited a comment on pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723462359 > We can set namespace by `cd config/default && kustomize edit set namespace ` or just edit `config/default/kustomization.yaml`. And I mentioned how to customize it in

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&el=h1) Report > Merging [#5550](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&e

[GitHub] [skywalking] wu-sheng commented on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
wu-sheng commented on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723463453 One last thing, `CHANGES.md` is not updated. You are adding a new plugin. This is an automated message from

[GitHub] [skywalking-swck] hanahmily merged pull request #7: Give a explicit check context

2020-11-07 Thread GitBox
hanahmily merged pull request #7: URL: https://github.com/apache/skywalking-swck/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[skywalking-swck] branch master updated: Give a explicit check context (#7)

2020-11-07 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-swck.git The following commit(s) were added to refs/heads/master by this push: new b7cf4a0 Give a explicit check conte

[GitHub] [skywalking-swck] hanahmily commented on pull request #5: Update README.md

2020-11-07 Thread GitBox
hanahmily commented on pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723465595 > @hanahmily Why these files were not detected by your script? This seems more important. Licenses tool only checks files in the config directory, that are updated fr

[GitHub] [skywalking-swck] hanahmily commented on pull request #5: Update README.md

2020-11-07 Thread GitBox
hanahmily commented on pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723466498 > > We can set namespace by `cd config/default && kustomize edit set namespace ` or just edit `config/default/kustomization.yaml`. And I mentioned how to customize it in ht

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&el=h1) Report > Merging [#5550](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&e

[GitHub] [skywalking] Jargon96 commented on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
Jargon96 commented on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723514860 > One last thing, `CHANGES.md` is not updated. You are adding a new plugin. Ok sir, I have updated CHANGES.md. ---

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&el=h1) Report > Merging [#5550](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&el=h1) Report > Merging [#5550](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&el=h1) Report > Merging [#5550](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&el=h1) Report > Merging [#5550](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&el=h1) Report > Merging [#5550](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&el=h1) Report > Merging [#5550](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&el=h1) Report > Merging [#5550](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698303582 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&el=h1) Report > Merging [#5550](https://codecov.io/gh/apache/skywalking/pull/5550?src=pr&e

[GitHub] [skywalking] kezhenxu94 merged pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
kezhenxu94 merged pull request #5550: URL: https://github.com/apache/skywalking/pull/5550 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[skywalking] branch master updated (1c55781 -> bc7afa6)

2020-11-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 1c55781 Catch all exception when consume kafka record (#5760) add bc7afa6 add support for dbcp 2.x plu

[skywalking] branch feature/als-mx updated (17a0f3c -> 6644cd4)

2020-11-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch feature/als-mx in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 17a0f3c Merge branch 'master' into feature/als-mx add bc7afa6 add support for dbcp 2.x plugin

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking-swck] arugal commented on pull request #5: Update README.md

2020-11-07 Thread GitBox
arugal commented on pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723519207 > > > We can set namespace by `cd config/default && kustomize edit set namespace ` or just edit `config/default/kustomization.yaml`. And I mentioned how to customize it in htt

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@bc7afa6`

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking-swck] arugal commented on a change in pull request #5: Update README.md

2020-11-07 Thread GitBox
arugal commented on a change in pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519244934 ## File path: controllers/oapserver_controller.go ## @@ -52,6 +52,7 @@ type OAPServerReconciler struct { // +kubebuilder:rbac:groups=operator.skywalkin

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5800: ALS analyzer based on Envoy metadata exchange

2020-11-07 Thread GitBox
codecov[bot] edited a comment on pull request #5800: URL: https://github.com/apache/skywalking/pull/5800#issuecomment-722488115 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&el=h1) Report > Merging [#5800](https://codecov.io/gh/apache/skywalking/pull/5800?src=pr&e

[GitHub] [skywalking-swck] arugal commented on a change in pull request #5: Update README.md

2020-11-07 Thread GitBox
arugal commented on a change in pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519257523 ## File path: README.md ## @@ -1,3 +1,78 @@ -# skywalking-swck - Apache SkyWalking Cloud on Kubernetes + + +![](https://github.com/apache/sk

[GitHub] [skywalking-swck] arugal commented on pull request #5: Update README.md

2020-11-07 Thread GitBox
arugal commented on pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723532402 Basically LGTM. ```bash $ kubectl get all -n skywalking-swck-system NAME READY STATUS RESTARTS A

[GitHub] [skywalking-swck] arugal edited a comment on pull request #5: Update README.md

2020-11-07 Thread GitBox
arugal edited a comment on pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723532402 Basically LGTM. ```bash $ kubectl get all -n skywalking-swck-system NAME READY STATUS RESTA

[GitHub] [skywalking] Jargon96 commented on pull request #5550: add support for dbcp 2.x plugin

2020-11-07 Thread GitBox
Jargon96 commented on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723533887 I was very excited about the moment of code merging! ! I'm inspired and proud to be the 281st contributor to the main repo! Thanks to the SkyWalking community, espec

[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #5: Update README.md

2020-11-07 Thread GitBox
hanahmily commented on a change in pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519260908 ## File path: README.md ## @@ -1,3 +1,78 @@ -# skywalking-swck - Apache SkyWalking Cloud on Kubernetes + + +![](https://github.com/apache

[GitHub] [skywalking-swck] wu-sheng merged pull request #5: Update README.md

2020-11-07 Thread GitBox
wu-sheng merged pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[skywalking-swck] branch master updated: Update README.md (#5)

2020-11-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-swck.git The following commit(s) were added to refs/heads/master by this push: new 96fe630 Update README.md (#5) 96fe630

[GitHub] [skywalking-swck] wu-sheng commented on pull request #5: Update README.md

2020-11-07 Thread GitBox
wu-sheng commented on pull request #5: URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723541870 Let's release our operator😀 This is an automated message from the Apache Git Service. To respond to the messa

<    1   2   3   4