Re: [PR] fix: default logging [superset]

2024-06-23 Thread via GitHub
rusackas commented on PR #2: URL: https://github.com/apache/superset/pull/2#issuecomment-2182988120 Re-running CI 爛 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] fix: default logging [superset]

2024-06-21 Thread via GitHub
jessie-ross commented on code in PR #2: URL: https://github.com/apache/superset/pull/2#discussion_r1648418971 ## superset/utils/logging_configurator.py: ## @@ -41,19 +41,11 @@ def configure_logging( if app_config["SILENCE_FAB"]:

Re: [PR] fix: default logging [superset]

2024-06-21 Thread via GitHub
jessie-ross commented on PR #2: URL: https://github.com/apache/superset/pull/2#issuecomment-2182017060 @mistercrunch Thanks for the quick review! I've rebased and addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] fix: default logging [superset]

2024-05-22 Thread via GitHub
jessie-ross commented on PR #2: URL: https://github.com/apache/superset/pull/2#issuecomment-2124784023 @dpgaspar Just a friendly reminder this PR is waiting for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] fix: default logging [superset]

2024-03-30 Thread via GitHub
jessie-ross commented on code in PR #2: URL: https://github.com/apache/superset/pull/2#discussion_r1545358461 ## superset/utils/logging_configurator.py: ## @@ -41,19 +41,11 @@ def configure_logging( if app_config["SILENCE_FAB"]:

Re: [PR] fix: default logging [superset]

2024-03-30 Thread via GitHub
jessie-ross commented on code in PR #2: URL: https://github.com/apache/superset/pull/2#discussion_r1545360981 ## superset/config.py: ## @@ -841,7 +841,7 @@ class D3Format(TypedDict, total=False): # Console Log Settings LOG_FORMAT =

Re: [PR] fix: default logging [superset]

2024-03-30 Thread via GitHub
jessie-ross commented on code in PR #2: URL: https://github.com/apache/superset/pull/2#discussion_r1545358461 ## superset/utils/logging_configurator.py: ## @@ -41,19 +41,11 @@ def configure_logging( if app_config["SILENCE_FAB"]:

Re: [PR] fix: default logging [superset]

2024-03-30 Thread via GitHub
jessie-ross commented on code in PR #2: URL: https://github.com/apache/superset/pull/2#discussion_r1545358461 ## superset/utils/logging_configurator.py: ## @@ -41,19 +41,11 @@ def configure_logging( if app_config["SILENCE_FAB"]:

Re: [PR] fix: default logging [superset]

2024-03-30 Thread via GitHub
jessie-ross commented on code in PR #2: URL: https://github.com/apache/superset/pull/2#discussion_r1545358461 ## superset/utils/logging_configurator.py: ## @@ -41,19 +41,11 @@ def configure_logging( if app_config["SILENCE_FAB"]:

Re: [PR] fix: default logging [superset]

2024-03-29 Thread via GitHub
john-bodley commented on code in PR #2: URL: https://github.com/apache/superset/pull/2#discussion_r1544720655 ## superset/config.py: ## @@ -841,7 +841,7 @@ class D3Format(TypedDict, total=False): # Console Log Settings LOG_FORMAT =