revised patch for gmime init, with test.

On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet wrote: > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner > wrote: > with differing hashes), this has the potential of causing confusion > and/or quite some extra work when debugging using git-bisect(1), so > I'd like to propose that bugfixes

[PATCH v4 2/5] cli: add support for replying just to the sender in "notmuch reply"

LGTM Best wishes Mark

[PATCH] test: cli: getting/setting/removing config values

On Thu, 12 Jan 2012 18:30:01 +0100, Pieter Praet wrote: > Should have come before commit 1df71b55 This doesn't seem like an especially helpful commit message. Editorializing is ok, I guess, but maybe keep it below the '---' ? d

[PATCH v4 5/5] test: add tests for "notmuch reply" --reply-to=sender

From: Mark Walters --- test/notmuch-test|1 + test/reply-to-sender | 209 ++ 2 files changed, 210 insertions(+), 0 deletions(-) create mode 100755 test/reply-to-sender diff --git a/test/notmuch-test

[PATCH v4 4/5] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all

Change the default reply key bindings, making 'r' reply-to-sender and 'R' reply-to-all. Signed-off-by: Jani Nikula --- There were mixed feelings about this. This as a separate patch so it's easy to drop if needed. --- emacs/notmuch-show.el |4 ++-- emacs/notmuch.el |4 ++-- 2

[PATCH v4 3/5] emacs: add support for replying just to the sender

Provide reply to sender counterparts to the search and show reply functions. Add key binding 'R' to reply to sender, while keeping 'r' as reply to all, both in search and show views. Signed-off-by: Jani Nikula --- emacs/notmuch-mua.el |9 ++--- emacs/notmuch-show.el | 10 --

[PATCH v4 2/5] cli: add support for replying just to the sender in "notmuch reply"

Add new option --reply-to=(all|sender) to "notmuch reply" to select whether to reply to all (sender and all recipients), or just sender. Reply to all remains the default. Credits to Mark Walters for his similar earlier work where I picked up the basic idea of handling reply-to-sender in

[PATCH v4 1/5] cli: slightly refactor "notmuch reply" address scanning functions

Slightly refactor "notmuch reply" recipient and user from address scanning functions in preparation for reply-to-sender feature. Add support for not adding messages at all (just scan for user from address), and returning the number of messages added. No externally visible functional changes.

[PATCH v4 0/5] reply to sender

Hi all, changes since v3: Split the first patch into two, the first one refactoring the reply/from address scanning, and the second one adding the actual reply-to-sender feature. This addresses Austins comments in id:"20120112033146.GU20796 at mit.edu" (and does improve the code). Patches 3-5

[PATCH v2] emacs: logically group def{custom,face}s

On Thu, 12 Jan 2012 18:12:16 +0100, Pieter Praet wrote: > To allow for expansion whilst keeping everything tidy and organized, > move all defcustom/defface variables to the following subgroups, > defined in notmuch-lib.el: > > - Hello > - Search > - Show > - Send > - Crypto > - Hooks > -

[PATCH v4 1/5] cli: slightly refactor "notmuch reply" address scanning functions

This is nice. Two very minor nits: In your commit message you say > Add support for not adding messages at all (just scan for user from > address), and returning the number of messages added. and I think both "messages" should "recipients". > + * If 'user_from' is non-NULL and *user_from is

[PATCH v2] Output unmodified Content-Type header value for JSON format.

On Thu, 12 Jan 2012 18:08:08 +0100, Pieter Praet wrote: > > > - The previous point is a bit of a counterargument to this, but in > > I couls separate it. I made is a single patch to avoid having a > > revision with broken emacs UI (and tests). > > > I'd like to propose to always apply patch

0.11 is frozen, please update NEWS

Hi, Maybe it is inappropriate, but do you have any idea when you plan to release the so-expected 0.11 release ? Anyway, keep up the good job guys ! /Xavier

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

On Thu, 12 Jan 2012 18:06:14 +0100, Pieter Praet wrote: > That would indeed have been the most sensible thing to do. > > Could someone (who -unlike me- has already submitted his/her public SSH > key for commit access) add something along those lines to the Patch > Formatting guidelines [1] ?

[PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet wrote: > Less code, same results, without sacrificing readability. +1 /Xavier

[PATCH] emacs: whitespace-cleanup for emacs/*.el files

On Wed, 11 Jan 2012 17:13:35 +0200, Tomi Ollila wrote: > Executed > for f in emacs/*.el > do emacs -q --batch --eval \ > "(progn (find-file \"$f\") (whitespace-cleanup) (save-buffer))" > done > > which > removed trailing whitespace and empty lines at the end of file >

[PATCH v2] emacs: Helpers for notmuch developers.

On Mon, 09 Jan 2012 11:16:20 +, David Edmondson wrote: > On Mon, 09 Jan 2012 06:38:54 -0400, David Bremner > wrote: > Could you try running > (notmuch-dev-delete-branch > "review/patch-emacs-don't-signal-an-error-when-reaching-the-end-of-the-search-results") > when inside that

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

On Tue, 10 Jan 2012 10:15:28 +, David Edmondson wrote: > Inserting spaces to pad out columns is good, except when the padding > makes the line wider than the window. This looks particularly bad on a > tty where there is no fringe. Pushed, d

[PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet wrote: > Less code, same results, without sacrificing readability. > +1 Regards, Dmitry > --- > emacs/notmuch-address.el |6 +++--- > emacs/notmuch-hello.el | 20 ++-- > emacs/notmuch-show.el| 12 ++-- >

[PATCH] test: don't bail out of `run_emacs' too early when missing prereqs

On Thu, 12 Jan 2012 18:16:59 +0100, Pieter Praet wrote: > When running the Emacs tests in verbose mode, only the first missing > prereq is reported because the `run_emacs' function is short-circuited > early: > > #+begin_example > emacs: Testing emacs interface > missing

Emacs: Crypto: How to get automatic encryption?

Hi Jameson, * Jameson Graef Rollins [12. Jan. 2012]: > On Tue, 03 Jan 2012 13:45:14 -0800, Jameson Graef Rollins finestructure.net> wrote: >> Unfortunately, auto encrypting of replies to encrypted emails is not yet >> implemented. It is desperately needed, though, obviously. So this is a >>

Emacs: Crypto: How to get automatic encryption?

ize: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120112/2519662c/attachment.pgp>

[PATCH v2] notmuch/emacs: Observe the charset of text/html parts, where known.

-- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120112/785a16bd/attachment-0001.pgp>

[PATCH] notmuch/emacs: Observe the charset of encoded parts, where known.

On Thu, 12 Jan 2012 14:42:49 +, David Edmondson wrote: > On Thu, 12 Jan 2012 18:17:44 +0400, Dmitry Kurochkin gmail.com> wrote: > > I think there is a record of useful features and fixes that were not > > accepted to notmuch because of some implementation issues. And > > interested people

[PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

Less code, same results, without sacrificing readability. --- emacs/notmuch-address.el |6 +++--- emacs/notmuch-hello.el | 20 ++-- emacs/notmuch-show.el| 12 ++-- emacs/notmuch.el |8 4 files changed, 23 insertions(+), 23 deletions(-)

[PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script

On Mon, 12 Dec 2011 22:50:04 +0200, Jani Nikula wrote: > Support nil value for notmuch-poll-script to run "notmuch new" instead of > an external script, and make this the new default. "notmuch new" is run > using the configured notmuch-command. > > This allows taking better advantage of the

[PATCH] test: cli: getting/setting/removing config values

Should have come before commit 1df71b55 --- test/config | 88 + test/notmuch-test |1 + 2 files changed, 89 insertions(+), 0 deletions(-) create mode 100755 test/config diff --git a/test/config b/test/config new file mode 100755

[PATCH] cli: factor out config handling code to get/set lists.

On Mon, 12 Dec 2011 14:26:21 -0400, David Bremner wrote: > On Sun, 11 Dec 2011 20:41:53 +0400, Dmitry Kurochkin gmail.com> wrote: > > Hi David. > > > > On Sun, 11 Dec 2011 12:07:51 -0400, David Bremner > > wrote: > > > From: David Bremner > > > > > > Two new internal routines are created

revised patch for gmime init, with test.

On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner wrote: > It turns out that our existing (trivial) python test is enough to > catch this bug, but the corpus needs to be augmented. This > augmentation is a bit intrusive so I'm thinking of cherry-picking only > the actual fix to the release

[PATCH 3/3] emacs: colorize buttonized 'id:' links depending on the target message's state

* emacs/notmuch-show.el (notmuch-show-buttonized-link-present), * emacs/notmuch-show.el (notmuch-show-buttonized-link-present-and-unread), * emacs/notmuch-show.el (notmuch-show-buttonized-link-missing): new faces for buttonized id: links. * emacs/notmuch-show.el (notmuch-show-found-target-p):

[PATCH 2/3] emacs: `notmuch-show-buttonize-links' only `notmuch-show's a message if it exists

* emacs/notmuch-show.el (notmuch-show-found-target-p): new predicate function that uses notmuch(1) 'count' to see if a query turns up any results. * emacs/notmuch-show.el (notmuch-show-if-found): new function that only shows a message/thread if present in the database and otherwise returns an

[PATCH 1/3] emacs: s/buttonise/buttonize/g

"Worldwide, -ize endings prevail in scientific writing and are commonly used by many international organizations, such as the ISO and the WHO. The European Union switched from -ize to -ise some years ago in its English language publications, and this resulted in the coexistence of the -ize

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins wrote: > Since message-ids necessarily match just a single message, there's no > reason to do a search for the id before viewing the actual message; > the search just becomes an extra screen to click through. Clicking on > an id: links

RFC: use the XDG Base Directory Specification for configuration data

On Wed, 21 Dec 2011 11:35:37 -0800, Jameson Graef Rollins wrote: > On Wed, 21 Dec 2011 07:44:16 -0400, David Bremner > wrote: > [SNIP] > > > On my machine all of the programs (except nottoomuch ;) ) that use > > ~/.config are gui based, and a bunch of them store binary blobs (or not > > plain

Code Style Bikeshed 1/n: Break before Brace or Brace before Break?

On Sun, 18 Dec 2011 20:18:03 +0400, Dmitry Kurochkin wrote: > On Sun, 18 Dec 2011 18:12:51 +0200, Tomi Ollila wrote: > > On Sun, 18 Dec 2011 19:50:52 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > +1 for the former. > > > > +1 > > > > > How about indenting with spaces+tabs vs indenting

[PATCH] notmuch/emacs: Observe the charset of encoded parts, where known.

Hi David. On Thu, 12 Jan 2012 12:00:14 +, David Edmondson wrote: > On Wed, 11 Jan 2012 22:34:45 +0400, Dmitry Kurochkin gmail.com> wrote: > > -1 > > Which puts me back to 0 :-( > > > One particular issue with your patch is that it adds (incorrect) charset > > parameter to plain/text parts

[PATCH] Set fill column to 70 in .dir-locals.el.

This controls where comments and other text wraps. 70 is the default value, so this simply returns it to the default for people who have overridden it. Most notmuch code already adheres to this. --- .dir-locals.el |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[PATCH] test: don't bail out of `run_emacs' too early when missing prereqs

When running the Emacs tests in verbose mode, only the first missing prereq is reported because the `run_emacs' function is short-circuited early: #+begin_example emacs: Testing emacs interface missing prerequisites: [0] emacs(1) skipping test: [0] Basic notmuch-hello view in

[PATCH v3 00/7] test: (hopefully) better test prerequisites

On Sun, 27 Nov 2011 22:36:12 +0400, Dmitry Kurochkin wrote: > Changes: > > v3 since v2: > > * rebased the remaining patches on current master > > v2 since v1: > > * Add test_require_external_prereq function to explicitly check for > external dependencies, use it in test_emacs. > > *

[PATCH v2] emacs: logically group def{custom,face}s

To allow for expansion whilst keeping everything tidy and organized, move all defcustom/defface variables to the following subgroups, defined in notmuch-lib.el: - Hello - Search - Show - Send - Crypto - Hooks - Appearance - External Commands As an added benefit, defcustom keyword args are now

[PATCH v2] Output unmodified Content-Type header value for JSON format.

On Sun, 20 Nov 2011 22:35:42 +0400, Dmitry Kurochkin wrote: > On Sat, 19 Nov 2011 08:59:29 -0400, David Bremner > wrote: > > On Sat, 19 Nov 2011 08:18:41 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > Before the change, notmuch used g_mime_content_type_to_string(3) > > > function to output

[PATCH] Output unmodified Content-Type header value for JSON format.

On Tue, 22 Nov 2011 22:40:21 -0500, Austin Clements wrote: > Quoth Jameson Graef Rollins on Nov 20 at 12:10 pm: > > The open question seems to be how we handle the content encoding > > parameters. My argument is that those should either be used by notmuch > > to properly encode the content for

[PATCH 0/6] Rebase of Pieter's "set test prereqs"

On Thu, 17 Nov 2011 11:14:11 +0100, Thomas Jost wrote: > On Wed, 16 Nov 2011 21:50:17 +0100, Pieter Praet wrote: > > On Wed, 16 Nov 2011 15:33:49 +0100, Thomas Jost > > wrote: > > > Hello list, > > > > > > This is another rebased version of Pieter's series to add GPG and Emacs > > > as test

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

On Thu, 17 Nov 2011 08:21:59 +0200, Jani Nikula wrote: > On Nov 16, 2011 11:39 PM, "Pieter Praet" wrote: > > > > On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila > wrote: > > > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet > wrote: > > > > No further explanation needed. > > > > --- > > > >

[PATCH] emacs: breakout notmuch-show-advance functionality from notmuch-show-advance-and-archive

On Wed, 16 Nov 2011 23:47:53 +0100, Pieter Praet wrote: > On Sun, 13 Nov 2011 13:16:48 -0800, Jameson Graef Rollins finestructure.net> wrote: > > This patch breaks out much of the functionality of > > notmuch-show-advance-and-archive into a new function: > > notmuch-show-advance. This new

0.11 is frozen, please update NEWS

On Sun, 25 Dec 2011 15:55:43 -0400, David Bremner wrote: > > Well, it's -19C outside, so guess that is appropriate. > > I have merged master to release in preparation for release. There should > only be additions to NEWS or fixes for serious bugs for branch release > until 0.11 is out the door.

[PATCH v4 2/5] cli: add support for replying just to the sender in "notmuch reply"

LGTM. Again, one minor nit below, but not enough to hold up this patch. Quoth Jani Nikula on Jan 12 at 11:40 pm: > Add new option --reply-to=(all|sender) to "notmuch reply" to select whether > to reply to all (sender and all recipients), or just sender. Reply to all > remains the default. > >

[PATCH v4 1/5] cli: slightly refactor "notmuch reply" address scanning functions

LGTM. One thing you could fix below (and a few comments), but not enough alone to warrant a new version. Quoth Jani Nikula on Jan 12 at 11:40 pm: > Slightly refactor "notmuch reply" recipient and user from address scanning > functions in preparation for reply-to-sender feature. > > Add support

[PATCH 2/2] notmuch-reply.c: uncrustify

On Thu, 12 Jan 2012 09:08:18 -0400, David Bremner wrote: > > > All of the other format fixes look very reasonable to me. I think you > > managed to find one of the least canonical source files in the tree. > > Was that intentional? > > Yes, I expect there would be less changes elsewhere.

[PATCH 4/4] emacs: Use the new JSON reply format.

On Thu, 12 Jan 2012 12:07:40 +, David Edmondson wrote: > On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin gmail.com> wrote: > > I did not follow the rest of the discussion, so sorry if I missed > > something obvious. But why can't we render HTML parts in replies the > > same way we do

[PATCH v3 4/4] test: add tests for "notmuch reply" --reply-to=sender

On Wed, 11 Jan 2012 22:50:32 -0500, Austin Clements wrote: > I'm not sure what the point of the last test is, but this patch > covered everything I could think of, so LGTM. Maybe checking that long subject line (possibly split/join sometimes in the process) keeps it's original form (?) LGTM

[PATCH] notmuch/emacs: Observe the charset of encoded parts, where known.

ame: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120112/13e6dd87/attachment.pgp>

Regarding notmuch and Fedora 16

On Tue, 03 Jan 2012 22:36:59 +, Darren McGuicken wrote: > On Tue, 03 Jan 2012 17:09:39 -0500, Peter Portante gmail.com> wrote: > > I am interested in using notmuch from within emacs, but have not been > > able to get the latest version of notmuch (0.10.2) to compile under > > Fedora 16. >

[PATCH v2] notmuch/emacs: Observe the charset of text/html parts, where known.

Quoth David Edmondson on Jan 12 at 1:31 pm: > Add the charset of text/html parts to the JSON output of 'notmuch > -show' when it is known. Observe the encoding when rendering such > parts in emacs. This seems like a fine interim solution to me, though I'd like to see a comment above the change

[PATCH 4/4] emacs: Use the new JSON reply format.

s broken for everyone. With the proposed changes it will be fixed for some people. Further improvements will, of course, be possible. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120112/47b4fc2d/attachment.pgp>

[PATCH v2] notmuch/emacs: Observe the charset of text/html parts, where known.

Add the charset of text/html parts to the JSON output of 'notmuch -show' when it is known. Observe the encoding when rendering such parts in emacs. --- Add the charset only for text/html parts to avoid incorrectly declaring the charset for JSON inline text/plain parts (as they have already been

[PATCH 2/2] notmuch-reply.c: uncrustify

On Thu, 12 Jan 2012 09:08:18 -0400, David Bremner wrote: > The corresponding diff for notmuch-search.c follows > - > - notmuch_filenames_destroy( filenames ); > + > + notmuch_filenames_destroy ( filenames ); Can you make it remove the extra spaces after ( and before )

[PATCH 4/4] emacs: Use the new JSON reply format.

Hi Adam. On Mon, 9 Jan 2012 19:10:48 -0700, Adam Wolfe Gordon wrote: > Hi David, > > Thanks for the review. Most of the things you've suggested are easy > changes, and I think obvious improvements, so I'll change them for the > next version. A bit of discussion on the more involved things

[PATCH 4/4] emacs: Use the new JSON reply format.

ame: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120112/dbfcbfad/attachment.pgp>

[PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

Quoth Tomi Ollila on Jan 12 at 10:51 am: > On Wed, 11 Jan 2012 23:13:44 -0500, Austin Clements > wrote: > > This is important to fix, but this solution seems needlessly > > roundabout. What about using an after-advice and simply delq'ing > > whatever the offending hook is? That wouldn't even

[PATCH] notmuch/emacs: Observe the charset of encoded parts, where known.

7 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120112/bc4f9c7c/attachment.pgp>

Emacs: Crypto: How to get automatic encryption?

ch specific. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120112/c4582fc9/attachment.pgp>

[PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

On Wed, 11 Jan 2012 23:13:44 -0500, Austin Clements wrote: > This is important to fix, but this solution seems needlessly > roundabout. What about using an after-advice and simply delq'ing > whatever the offending hook is? That wouldn't even need a version > check. delq could work -- thanks

Emacs: Crypto: How to get automatic encryption?

email-awg+notmuch at xvx.ca" -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120112/42337ce5/attachment.pgp>

[PATCH 2/2] notmuch-reply.c: uncrustify

Quoth David Bremner on Jan 12 at 9:08 am: > @@ -425,7 +420,7 @@ notmuch_search_command (void *ctx, int argc, char *argv[]) > int limit = -1; /* unlimited */ > > enum { NOTMUCH_FORMAT_JSON, NOTMUCH_FORMAT_TEXT } > - format_sel = NOTMUCH_FORMAT_TEXT; > +format_sel =

[PATCH 2/2] notmuch-reply.c: uncrustify

On Wed, 11 Jan 2012 22:57:39 -0500, Austin Clements wrote: > > From: David Bremner > > > > This patch shows the raw result of running uncrustify on notmuch-reply.c. > > The re-indenting of "format_reply" would probably not be desirable. > > The good news is that that structure is on its way

[PATCH v3 2/4] emacs: add support for replying just to the sender

On Wed, 11 Jan 2012 16:15:30 -0500, Aaron Ecay wrote: > On Wed, 11 Jan 2012 08:20:56 +, David Edmondson wrote: > > On Tue, 10 Jan 2012 21:54:02 +0200, Jani Nikula wrote: > > > -(defun notmuch-mua-reply (query-string sender) > > > +(defun notmuch-mua-reply (query-string sender reply-all) >

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

Hi Adam. On Mon, 9 Jan 2012 19:10:48 -0700, Adam Wolfe Gordon a...@xvx.ca wrote: Hi David, Thanks for the review. Most of the things you've suggested are easy changes, and I think obvious improvements, so I'll change them for the next version. A bit of discussion on the more involved

Re: [PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

On Wed, 11 Jan 2012 23:13:44 -0500, Austin Clements amdra...@mit.edu wrote: This is important to fix, but this solution seems needlessly roundabout. What about using an after-advice and simply delq'ing whatever the offending hook is? That wouldn't even need a version check. delq could work

Re: [PATCH] notmuch/emacs: Observe the charset of encoded parts, where known.

On Wed, 11 Jan 2012 22:34:45 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: -1 Which puts me back to 0 :-( One particular issue with your patch is that it adds (incorrect) charset parameter to plain/text parts which are converted to UTF-8 in JSON output. Patches that break

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I did not follow the rest of the discussion, so sorry if I missed something obvious. But why can't we render HTML parts in replies the same way we do in notmuch-show (using `mm-display-part')? That should

Re: Regarding notmuch and Fedora 16

On Tue, 03 Jan 2012 22:36:59 +, Darren McGuicken mailing-notm...@fernseed.info wrote: On Tue, 03 Jan 2012 17:09:39 -0500, Peter Portante peter.a.porta...@gmail.com wrote: I am interested in using notmuch from within emacs, but have not been able to get the latest version of notmuch

Re: [PATCH v3 4/4] test: add tests for notmuch reply --reply-to=sender

On Wed, 11 Jan 2012 22:50:32 -0500, Austin Clements amdra...@mit.edu wrote: I'm not sure what the point of the last test is, but this patch covered everything I could think of, so LGTM. Maybe checking that long subject line (possibly split/join sometimes in the process) keeps it's original form

Re: [PATCH 2/2] notmuch-reply.c: uncrustify

On Wed, 11 Jan 2012 22:57:39 -0500, Austin Clements amdra...@mit.edu wrote: From: David Bremner brem...@debian.org This patch shows the raw result of running uncrustify on notmuch-reply.c. The re-indenting of format_reply would probably not be desirable. The good news is that that

Re: [PATCH 2/2] notmuch-reply.c: uncrustify

On Thu, 12 Jan 2012 09:08:18 -0400, David Bremner da...@tethera.net wrote: The corresponding diff for notmuch-search.c follows - - notmuch_filenames_destroy( filenames ); + + notmuch_filenames_destroy ( filenames ); Can you make it remove the extra spaces after (

[PATCH v2] notmuch/emacs: Observe the charset of text/html parts, where known.

Add the charset of text/html parts to the JSON output of 'notmuch -show' when it is known. Observe the encoding when rendering such parts in emacs. --- Add the charset only for text/html parts to avoid incorrectly declaring the charset for JSON inline text/plain parts (as they have already been

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

On Thu, 12 Jan 2012 12:07:40 +, David Edmondson d...@dme.org wrote: On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I did not follow the rest of the discussion, so sorry if I missed something obvious. But why can't we render HTML parts in replies

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

On Thu, 12 Jan 2012 15:36:07 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Thu, 12 Jan 2012 12:07:40 +, David Edmondson d...@dme.org wrote: On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I did not follow the rest of the discussion, so sorry if

Re: [PATCH 2/2] notmuch-reply.c: uncrustify

On Thu, 12 Jan 2012 09:08:18 -0400, David Bremner da...@tethera.net wrote: All of the other format fixes look very reasonable to me. I think you managed to find one of the least canonical source files in the tree. Was that intentional? Yes, I expect there would be less changes

Re: [PATCH] notmuch/emacs: Observe the charset of encoded parts, where known.

Hi David. On Thu, 12 Jan 2012 12:00:14 +, David Edmondson d...@dme.org wrote: On Wed, 11 Jan 2012 22:34:45 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: -1 Which puts me back to 0 :-( One particular issue with your patch is that it adds (incorrect) charset parameter

Re: [PATCH] notmuch/emacs: Observe the charset of encoded parts, where known.

On Thu, 12 Jan 2012 18:17:44 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I think there is a record of useful features and fixes that were not accepted to notmuch because of some implementation issues. And interested people were using them in private repos for years. (I do not

Re: [PATCH] notmuch/emacs: Observe the charset of encoded parts, where known.

On Thu, 12 Jan 2012 14:42:49 +, David Edmondson d...@dme.org wrote: On Thu, 12 Jan 2012 18:17:44 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I think there is a record of useful features and fixes that were not accepted to notmuch because of some implementation issues. And

Re: [PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

Quoth Tomi Ollila on Jan 12 at 10:51 am: On Wed, 11 Jan 2012 23:13:44 -0500, Austin Clements amdra...@mit.edu wrote: This is important to fix, but this solution seems needlessly roundabout. What about using an after-advice and simply delq'ing whatever the offending hook is? That wouldn't

Re: [PATCH] Output unmodified Content-Type header value for JSON format.

On Tue, 22 Nov 2011 22:40:21 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Jameson Graef Rollins on Nov 20 at 12:10 pm: The open question seems to be how we handle the content encoding parameters. My argument is that those should either be used by notmuch to properly encode the

Re: [PATCH] cli: factor out config handling code to get/set lists.

On Mon, 12 Dec 2011 14:26:21 -0400, David Bremner da...@tethera.net wrote: On Sun, 11 Dec 2011 20:41:53 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi David. On Sun, 11 Dec 2011 12:07:51 -0400, David Bremner da...@tethera.net wrote: From: David Bremner brem...@debian.org

Re: [PATCH] Output unmodified Content-Type header value for JSON format.

Quoth Pieter Praet on Jan 12 at 6:07 pm: On Tue, 22 Nov 2011 22:40:21 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Jameson Graef Rollins on Nov 20 at 12:10 pm: The open question seems to be how we handle the content encoding parameters. My argument is that those should either be

[PATCH] test: cli: getting/setting/removing config values

Should have come before commit 1df71b55 --- test/config | 88 + test/notmuch-test |1 + 2 files changed, 89 insertions(+), 0 deletions(-) create mode 100755 test/config diff --git a/test/config b/test/config new file mode 100755

Re: [PATCH v3] emacs: support notmuch new as a notmuch-poll-script

On Mon, 12 Dec 2011 22:50:04 +0200, Jani Nikula j...@nikula.org wrote: Support nil value for notmuch-poll-script to run notmuch new instead of an external script, and make this the new default. notmuch new is run using the configured notmuch-command. This allows taking better advantage of

[PATCH] emacs: globally replace non-branching (if (not ... with (unless ...

Less code, same results, without sacrificing readability. --- emacs/notmuch-address.el |6 +++--- emacs/notmuch-hello.el | 20 ++-- emacs/notmuch-show.el| 12 ++-- emacs/notmuch.el |8 4 files changed, 23 insertions(+), 23 deletions(-)

Re: [PATCH] test: don't bail out of `run_emacs' too early when missing prereqs

On Thu, 12 Jan 2012 18:16:59 +0100, Pieter Praet pie...@praet.org wrote: When running the Emacs tests in verbose mode, only the first missing prereq is reported because the `run_emacs' function is short-circuited early: #+begin_example emacs: Testing emacs interface missing

Re: [PATCH] emacs: globally replace non-branching (if (not ... with (unless ...

On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet pie...@praet.org wrote: Less code, same results, without sacrificing readability. +1 Regards, Dmitry --- emacs/notmuch-address.el |6 +++--- emacs/notmuch-hello.el | 20 ++-- emacs/notmuch-show.el| 12

Re: Emacs: Crypto: How to get automatic encryption?

On Tue, 03 Jan 2012 13:45:14 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Unfortunately, auto encrypting of replies to encrypted emails is not yet implemented. It is desperately needed, though, obviously. So this is a good excuse to start a discussion about how we could

Re: [PATCH v2] notmuch/emacs: Observe the charset of text/html parts, where known.

Quoth David Edmondson on Jan 12 at 1:31 pm: Add the charset of text/html parts to the JSON output of 'notmuch -show' when it is known. Observe the encoding when rendering such parts in emacs. This seems like a fine interim solution to me, though I'd like to see a comment above the change in

Re: Emacs: Crypto: How to get automatic encryption?

Hi Jameson, * Jameson Graef Rollins jroll...@finestructure.net [12. Jan. 2012]: On Tue, 03 Jan 2012 13:45:14 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Unfortunately, auto encrypting of replies to encrypted emails is not yet implemented. It is desperately needed, though,

Re: [PATCH v2] notmuch/emacs: Observe the charset of text/html parts, where known.

On Thu, 12 Jan 2012 13:49:59 -0500, Austin Clements amdra...@mit.edu wrote: Quoth David Edmondson on Jan 12 at 1:31 pm: Add the charset of text/html parts to the JSON output of 'notmuch -show' when it is known. Observe the encoding when rendering such parts in emacs. This seems like a

Re: Emacs: Crypto: How to get automatic encryption?

On Thu, 12 Jan 2012 20:05:14 +0100, Gregor Zattler telegr...@gmx.net wrote: But how about not only replying encrypted but encrypting every email if possible? Possible could mean different things, though: This is already easy to do in emacs, and doesn't require any special notmuch support:

Re: Emacs: Crypto: How to get automatic encryption?

On Thu, 12 Jan 2012 20:05:14 +0100, Gregor Zattler telegr...@gmx.net wrote: 2) encrypt if suitable public keys for all recipients are in GnuPGs key ring. [...] But I have no clue about how to do this with notmuch/Emacs. Isn't that what David provides an elisp-snippet for in

[PATCH v4 0/5] reply to sender

Hi all, changes since v3: Split the first patch into two, the first one refactoring the reply/from address scanning, and the second one adding the actual reply-to-sender feature. This addresses Austins comments in id:20120112033146.gu20...@mit.edu (and does improve the code). Patches 3-5 remain

[PATCH v4 1/5] cli: slightly refactor notmuch reply address scanning functions

Slightly refactor notmuch reply recipient and user from address scanning functions in preparation for reply-to-sender feature. Add support for not adding messages at all (just scan for user from address), and returning the number of messages added. No externally visible functional changes.

[PATCH v4 2/5] cli: add support for replying just to the sender in notmuch reply

Add new option --reply-to=(all|sender) to notmuch reply to select whether to reply to all (sender and all recipients), or just sender. Reply to all remains the default. Credits to Mark Walters markwalters1...@gmail.com for his similar earlier work where I picked up the basic idea of handling

  1   2   >