[PATCH 4/4] emacs: Use the new JSON reply format.

Hi Dmitry, On Thu, Jan 12, 2012 at 01:33, Dmitry Kurochkin wrote: > I did not follow the rest of the discussion, so sorry if I missed > something obvious. ?But why can't we render HTML parts in replies the > same way we do in notmuch-show (using `mm-display-part')? ?That should > not introduce a

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

Hi Dmitry, On Thu, Jan 12, 2012 at 01:33, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I did not follow the rest of the discussion, so sorry if I missed something obvious.  But why can't we render HTML parts in replies the same way we do in notmuch-show (using `mm-display-part')?  That

[PATCH 4/4] emacs: Use the new JSON reply format.

On Thu, 12 Jan 2012 12:07:40 +, David Edmondson wrote: > On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin gmail.com> wrote: > > I did not follow the rest of the discussion, so sorry if I missed > > something obvious. But why can't we render HTML parts in replies the > > same way we do

[PATCH 4/4] emacs: Use the new JSON reply format.

On Thu, 12 Jan 2012 15:36:07 +0200, Tomi Ollila wrote: > On Thu, 12 Jan 2012 12:07:40 +, David Edmondson wrote: > > On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > I did not follow the rest of the discussion, so sorry if I missed > > > something obvious. But

[PATCH 4/4] emacs: Use the new JSON reply format.

Hi Adam. On Mon, 9 Jan 2012 19:10:48 -0700, Adam Wolfe Gordon wrote: > Hi David, > > Thanks for the review. Most of the things you've suggested are easy > changes, and I think obvious improvements, so I'll change them for the > next version. A bit of discussion on the more involved things

[PATCH 4/4] emacs: Use the new JSON reply format.

On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin wrote: > I did not follow the rest of the discussion, so sorry if I missed > something obvious. But why can't we render HTML parts in replies the > same way we do in notmuch-show (using `mm-display-part')? That should > not introduce a w3m.el

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

Hi Adam. On Mon, 9 Jan 2012 19:10:48 -0700, Adam Wolfe Gordon a...@xvx.ca wrote: Hi David, Thanks for the review. Most of the things you've suggested are easy changes, and I think obvious improvements, so I'll change them for the next version. A bit of discussion on the more involved

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I did not follow the rest of the discussion, so sorry if I missed something obvious. But why can't we render HTML parts in replies the same way we do in notmuch-show (using `mm-display-part')? That should

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

On Thu, 12 Jan 2012 12:07:40 +, David Edmondson d...@dme.org wrote: On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I did not follow the rest of the discussion, so sorry if I missed something obvious. But why can't we render HTML parts in replies

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

On Thu, 12 Jan 2012 15:36:07 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Thu, 12 Jan 2012 12:07:40 +, David Edmondson d...@dme.org wrote: On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I did not follow the rest of the discussion, so sorry if

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

Hi David, Thanks for the review. Most of the things you've suggested are easy changes, and I think obvious improvements, so I'll change them for the next version. A bit of discussion on the more involved things below: On Mon, Jan 9, 2012 at 01:50, David Edmondson d...@dme.org wrote: On Sun,  

[PATCH 4/4] emacs: Use the new JSON reply format.

On Mon, 9 Jan 2012 19:10:48 -0700, Adam Wolfe Gordon wrote: > > Using w3m means that you should `require' it. What happens when a user > > doesn't have it? (Either the elisp or the command.) > > This was my initial thought, but when I looked at notmuch-show.el, > which uses w3m features, I

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

On Sun, Jan 8, 2012 at 18:27, Aaron Ecay aarone...@gmail.com wrote: +(defun w3m-region (start end)) ;; From `w3m.el'. What is the purpose of the above line?  If it is to make the compiler aware of the function, you should use ‘declare-function’ instead.  Defun will erase the original

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

On Mon, 9 Jan 2012 19:10:48 -0700, Adam Wolfe Gordon a...@xvx.ca wrote: Using w3m means that you should `require' it. What happens when a user doesn't have it? (Either the elisp or the command.) This was my initial thought, but when I looked at notmuch-show.el, which uses w3m features, I

[PATCH 4/4] emacs: Use the new JSON reply format.

Hi David, Thanks for the review. Most of the things you've suggested are easy changes, and I think obvious improvements, so I'll change them for the next version. A bit of discussion on the more involved things below: On Mon, Jan 9, 2012 at 01:50, David Edmondson wrote: > On Sun, ?8 Jan 2012

[PATCH 4/4] emacs: Use the new JSON reply format.

On Sun, Jan 8, 2012 at 18:27, Aaron Ecay wrote: >> +(defun w3m-region (start end)) ;; From `w3m.el'. > > What is the purpose of the above line? ?If it is to make the compiler > aware of the function, you should use ?declare-function? instead. ?Defun > will erase the original definition of the

[PATCH 4/4] emacs: Use the new JSON reply format.

On Sun, 8 Jan 2012 00:52:42 -0700, Adam Wolfe Gordon wrote: > +(defun w3m-region (start end)) ;; From `w3m.el'. > +(defun notmuch-mua-quote-part (part) > + (with-temp-buffer > +(insert part) > +(message-mode) > +(fill-region (point-min) (point-max)) > +

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

On Sun, 8 Jan 2012 00:52:42 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: +(defun w3m-region (start end)) ;; From `w3m.el'. +(defun notmuch-mua-quote-part (part) + (with-temp-buffer +(insert part) +(message-mode) +(fill-region (point-min) (point-max)) +(goto-char

[PATCH 4/4] emacs: Use the new JSON reply format.

Adam, One comment below. On Sun, 8 Jan 2012 00:52:42 -0700, Adam Wolfe Gordon wrote: > From: Adam Wolfe Gordon > > Using the new JSON reply format allows emacs to quote HTML parts > nicely by first parsing them with w3m, then quoting them. This is > very useful for

[PATCH 4/4] emacs: Use the new JSON reply format.

From: Adam Wolfe Gordon Using the new JSON reply format allows emacs to quote HTML parts nicely by first parsing them with w3m, then quoting them. This is very useful for users who regularly receive HTML-only email. The behavior for messages that contain plain text parts should be

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

Adam, One comment below. On Sun, 8 Jan 2012 00:52:42 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: From: Adam Wolfe Gordon a...@xvx.ca Using the new JSON reply format allows emacs to quote HTML parts nicely by first parsing them with w3m, then quoting them. This is very useful for

[PATCH 4/4] emacs: Use the new JSON reply format.

From: Adam Wolfe Gordon a...@xvx.ca Using the new JSON reply format allows emacs to quote HTML parts nicely by first parsing them with w3m, then quoting them. This is very useful for users who regularly receive HTML-only email. The behavior for messages that contain plain text parts should be