Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-13 Thread Roy Spliet
Op 13-04-2021 om 10:48 schreef Karol Herbst: On Tue, Apr 13, 2021 at 10:24 AM Roy Spliet wrote: Op 13-04-2021 om 01:10 schreef Karol Herbst: On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet wrote: Hello Aaron, Thanks for your insights. A follow-up query and some observations in-line. Op 12-04

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-13 Thread Roy Spliet
Op 13-04-2021 om 01:10 schreef Karol Herbst: On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet wrote: Hello Aaron, Thanks for your insights. A follow-up query and some observations in-line. Op 12-04-2021 om 20:06 schreef Aaron Plattner: On 4/10/21 1:48 PM, Roy Spliet wrote: Op 10-04-2021 om 20

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-12 Thread Roy Spliet
Hello Aaron, Thanks for your insights. A follow-up query and some observations in-line. Op 12-04-2021 om 20:06 schreef Aaron Plattner: On 4/10/21 1:48 PM, Roy Spliet wrote: Op 10-04-2021 om 20:23 schreef Lukas Wunner: On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote: Can I ask

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-10 Thread Roy Spliet
Op 10-04-2021 om 20:23 schreef Lukas Wunner: On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote: Can I ask someone with more technical knowledge of snd_hda_intel and vgaswitcheroo to brainstorm about the possible challenges of nouveau taking matters into its own hand rather than keeping

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-10 Thread Roy Spliet
Reviving this thread as we have another user (rightfully) complaining on IRC about this. The way I see it there's two issues: 1) snd_hda_intel not allowing runpm (or w/e vgaswitcheroo needs) when there's missing codecs, inhibiting the entire GPU from performing runpm. This needlessly wastes

Re: [Nouveau] [PATCH] drm/nouveau/kms/nve4-nv108: Limit cursors to 128x128

2021-03-21 Thread Roy Spliet
Tested-by: Roy Spliet Op 08-03-2021 om 16:50 schreef Daniel Thompson: On Thu, Mar 04, 2021 at 08:52:41PM -0500, Lyude Paul wrote: While Kepler does technically support 256x256 cursors, it turns out that Kepler actually has some additional requirements for scanout surfaces that we're

Re: [Nouveau] [PATCH v2] drm/nouveau/kms/nve4-nv108: Don't advertise 256x256 cursor support yet

2021-03-21 Thread Roy Spliet
Tested-by: Roy Spliet Op 05-03-2021 om 22:21 schreef Lyude Paul: While Kepler does technically support 256x256 cursors, it turns out that in order for us to use these correctly we need to make sure that the cursor plane uses a ctxdma that is set to use small (4K)/large (128K) pages - whichever

Re: [Nouveau] [PATCH] drivers: drm: nouveau: nvkm: Replace a word with a better phonetic word in the file macros.fuc

2021-02-05 Thread Roy Spliet
Op 05-02-2021 om 13:05 schreef Bhaskar Chowdhury: s/fuck/heck/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc

Re: [Nouveau] Request for help in adding a HDMI output

2021-01-23 Thread Roy Spliet
Op 23-01-2021 om 23:18 schreef o1bigtenor: OK, so this is your 4k monitor. It is plugged into the *secondary* GPU, and does not report any 4k@60 modes in the EDID (well, it does report 4k@60 YUV 4:2:0 modes, but we don't support those in nouveau at this time). Whether that's because the monitor

Re: [Nouveau] [RFC] Documentation: nouveau: Introduce some nouveau documentation

2020-09-24 Thread Roy Spliet
Op 24-09-2020 om 16:21 schreef Karol Herbst: On Thu, Sep 24, 2020 at 3:06 PM Roy Spliet wrote: Op 23-09-2020 om 22:36 schreef Karol Herbst: On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline wrote: On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst wrote: On Fri, Sep 11, 2020 at 6:21

Re: [Nouveau] [RFC] Documentation: nouveau: Introduce some nouveau documentation

2020-09-24 Thread Roy Spliet
Op 23-09-2020 om 22:36 schreef Karol Herbst: On Wed, Sep 23, 2020 at 10:39 PM Jeremy Cline wrote: On Wed, Sep 23, 2020 at 09:02:45PM +0200, Karol Herbst wrote: On Fri, Sep 11, 2020 at 6:21 PM Jeremy Cline wrote: yeah, I think overall this file is a good idea and being able to get a

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

2020-05-12 Thread Roy Spliet
Op 12-05-2020 om 14:36 schreef Alex Deucher: On Tue, May 12, 2020 at 4:16 AM Michel Dänzer wrote: On 2020-05-11 10:12 p.m., Alex Deucher wrote: On Mon, May 11, 2020 at 1:17 PM Christian König wrote: AGP is deprecated for 10+ years now and not used any more on modern hardware. Old

Re: [Nouveau] [PATCH 4/4] drm/nouveau: Remove struct nouveau_framebuffer

2020-02-06 Thread Roy Spliet
(Re-sending to list rather than just to James) Is this format modifier information not stored, or otherwise worth storing, directly in the nouveau_bo object associated with the framebuffer? I'm not particularly knowledgeable on the topic, but there already seem to exist some fields with very

Re: [Nouveau] [PATCH 1/2] drm/nouveau: move io_reserve_lru handling into the driver v2

2020-01-24 Thread Roy Spliet
Without diving in any of the details, your commit message has me curious and concerned... In a "manager" kind of way, despite being neither a manager nor an insider or active contributor. ;-) On 24/01/2020 14:30, Christian König wrote: From: Christian König While working on TTM cleanups

Re: [Nouveau] [PATCH] drm/nouveau/bios: fix incorrect kfree in platform_init

2020-01-03 Thread Roy Spliet
(re-sending as plain text) NACK. The before and after of this patch are functionally identical. The if-block returns unconditionally ("return priv;"), so the kfree will only ever be reached if the condition in the if-statement evaluates to false. Explicitly writing out an else-block is thus

Re: [Nouveau] [PATCH] drm/nouveau/bios: fix incorrect kfree in platform_init

2020-01-03 Thread Roy Spliet
NACK. The before and after of this patch are functionally identical. The if-block returns unconditionally ("return priv;"), so the kfree will only ever be reached if the condition in the if-statement evaluates to false. Explicitly writing out an else-block is thus superfluous. Op 03-01-2020

Re: [Nouveau] [PATCH v3] clk: Restore BYPASS_PLL_CHECK from PLLs

2019-09-06 Thread Roy Spliet
(Accidentally replied in person instead of to the list. Here a ~verbatim copy of my e-mail earlier) Briefly, the BYPASS_PLL_CHECK bit disables the PLL locking test when set to 1. PLLs should still lock (or not, if the params are wildly out-of-bounds), but the test is bypassed and disabled

Re: [Nouveau] [Piglit] X.Org GSoC 2019 - Student Application Period

2019-03-26 Thread Roy Spliet
Thanks for reaching out on the matter Ilia. I am not to be relied on. If you're lucky, I might be able to take some questions about past work, but cannot make a solid time commitment that warrants being a mentor. Of course, the mentor does not necessarily have to have the deepest understanding

Re: [Nouveau] Google's Chrome Team might Blacklist Nouveau on Chromium

2018-09-26 Thread Roy Spliet
I don't think any nouveau dev would disagree with the choice for a software rendered browser over an unreliable browser. Insofar I still count as a nouveau dev, I'll back this decision because it benefits user experience. What is disappointing though is that when I perform a search on our bug

Re: [Nouveau] [PATCH v3 5/6] kms/nv50: detect HDMI max MHz correctly

2018-08-03 Thread Roy Spliet
On 03/08/18 16:56, Karol Herbst wrote: On Fri, Aug 3, 2018 at 4:08 PM, Ilia Mirkin wrote: On Fri, Aug 3, 2018 at 8:19 AM, Karol Herbst wrote: v2: clean up left over comments don't overwrite hdmimhz parameter cap to 297MHz Signed-off-by: Karol Herbst ---

Re: [Nouveau] trouble connecting to Panduit VGA adapter

2017-09-01 Thread Roy Spliet
If this doesn't work I suspect the converter is really blocking/damaging the EDID information. The official NVIDIA driver is willing to fall back to default modes, but this fall-back was handled less gracefully on nouveau last time I checked. You might be able to use the xrandr tool to

Re: [Nouveau] [PATCH] drm/nouveau: Add support for clockgating on Fermi+

2017-04-25 Thread Roy Spliet
Thanks for the work so far. A quick scan through the first NVC4 trace at hand, using upstream demmio, reveals at least 20 writes to the BLCG registers of PGRAPH and a few in PXBAR prior to altering the value of register 0x20200 (see below). We know that these are related to the clock gating

Re: [Nouveau] [PATCH] volt: Improve min/max deteaction of range based volting

2017-04-22 Thread Roy Spliet
Response in-line: Op 22-04-17 om 13:22 schreef Karol Herbst: info.min and info.max doesn't always represent the actual voltage range we can use. Do the same as with the entry based volting. Fixes "ERROR: Can't get value of subfeature in0_min: Can't read" errors in sensors. Signed-off-by:

Re: [Nouveau] [PATCH 0/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

2017-04-13 Thread Roy Spliet
Just a non-technical (but important!) point: if you send four patches, make sure their title (the first line of your git commit messages) describes the content. Given you re-used the same title four times, I dare to say it's too generic. Also, I noticed that this is not the standard git patch

[Nouveau] [PATCH 13/13] nvkm/bios/perf: Retreive pointer to unk1c script

2017-04-10 Thread Roy Spliet
Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/perf.h | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/bios/perf.c | 14 ++ drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 1 + 3 files changed, 16 insertions(+)

[Nouveau] [PATCH 11/13] nvkm/ramgf100: Hook up ram training pattern init for NVC0+

2017-04-10 Thread Roy Spliet
Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c index a469719..e

[Nouveau] [PATCH 06/13] nvkm/ramgt215: Move ram training up the chain

2017-04-10 Thread Roy Spliet
Parts are re-used even on NVA3, others from GF100 on Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ram.h | 17 +++ drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 92 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c

[Nouveau] [PATCH 12/13] nvkm/pmu/memx: init script -> memx translation

2017-04-10 Thread Roy Spliet
Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/pmu.h | 2 + drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramfuc.h | 8 +++ drivers/gpu/drm/nouveau/nvkm/subdev/pmu/memx.c| 66 +++ 3 files changed, 76 insertions(+) diff

[Nouveau] [PATCH 07/13] nvkm/ramgf100: Don't mandate training pattern 4

2017-04-10 Thread Roy Spliet
It's not found on Fermi. Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c b/drivers/gpu/drm/nouveau/nvkm/

[Nouveau] [PATCH 03/13] nvkm/ramgf100: Get rid of (size, data) pairs for rammap, ramcfg, timing

2017-04-10 Thread Roy Spliet
In correspondence with the other ram_calc implementations. Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 37 --- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/sub

[Nouveau] [PATCH 08/13] nvkm/ramgf100: Unset bit before uploading train values

2017-04-10 Thread Roy Spliet
Just because the blob does it too... Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ra

[Nouveau] [PATCH 02/13] nvkm/ramnv50: Split up various ramcfg bytes in nibbles

2017-04-10 Thread Roy Spliet
In preparation for Fermi Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 9 ++--- drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c | 9 ++--- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c

[Nouveau] [PATCH 04/13] nvkm/ramgf100: Calculate timings

2017-04-10 Thread Roy Spliet
Todo: - Determine source of R[10f298] & 0x11 Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 115 ++ 1 file changed, 76 insertions(+), 39 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ram

[Nouveau] [PATCH 10/13] nvkm/ramgt215: Add train ptrn upload for GDDR5

2017-04-10 Thread Roy Spliet
Signed-off-by: Roy Spliet <nouv...@spliet.org> Tested-by: Ilia Mirkin <imir...@alum.mit.edu> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ram.h | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 128 +- 2 files changed, 99 insertions(+), 30 deleti

[Nouveau] [PATCH 05/13] nvkm/gddr5: MR calculation for timing table v1.0

2017-04-10 Thread Roy Spliet
Merges in skeggsb's: "fb/ram/gf10x: timing_10_0e_30" Todo: - find l3, rq - triple-check Signed-off-by: Roy Spliet <nouv...@spliet.org> --- .../drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 12 +++--- drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c | 22 -- drivers

[Nouveau] [PATCH 09/13] nvkm/ramgf100: Reinstate default ram train pattern

2017-04-10 Thread Roy Spliet
Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 59 +-- 1 file changed, 43 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramg

[Nouveau] RESEND Preparations for Fermi DRAM clock changes

2017-04-10 Thread Roy Spliet
Two patches went missing as a result of PEBCAK. No v2 marks as nothing changed really. Just resending for easier enforcement of patch order in other people's trees. Sorry for the noise. Original message: No, no, these will not implement Fermi reclocking. This set of patches contains some of the

[Nouveau] [PATCH 01/13] nvkm/bios: Give timings a name

2017-04-10 Thread Roy Spliet
tFAW, tCKE, tXPDLL, derived from datasheets. Merge skeggsb's: "bios/rammap: make unknown timing 1.0 fields match 2.0's naming" Signed-off-by: Roy Spliet <nouv...@spliet.org> --- .../drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 12 +++ drivers/gpu/drm/nouveau/nvkm/subd

[Nouveau] [PATCH 10/11] nvkm/pmu/memx: init script -> memx translation

2017-04-10 Thread Roy Spliet
Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/pmu.h | 2 + drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramfuc.h | 8 +++ drivers/gpu/drm/nouveau/nvkm/subdev/pmu/memx.c| 66 +++ 3 files changed, 76 insertions(+) diff

[Nouveau] [PATCH 09/11] nvkm/ramgf100: Hook up ram training pattern init for NVC0+

2017-04-10 Thread Roy Spliet
Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c index a469719..e

[Nouveau] [PATCH 04/11] nvkm/ramgt215: Move ram training up the chain

2017-04-10 Thread Roy Spliet
Parts are re-used even on NVA3, others from GF100 on Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ram.h | 17 +++ drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 92 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c

[Nouveau] [PATCH 02/11] nvkm/ramgf100: Calculate timings

2017-04-10 Thread Roy Spliet
Todo: - Determine source of R[10f298] & 0x11 Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 115 ++ 1 file changed, 76 insertions(+), 39 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ram

[Nouveau] [PATCH 06/11] nvkm/ramgf100: Unset bit before uploading train values

2017-04-10 Thread Roy Spliet
Just because the blob does it too... Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ra

[Nouveau] [PATCH 03/11] nvkm/gddr5: MR calculation for timing table v1.0

2017-04-10 Thread Roy Spliet
Merges in skeggsb's: "fb/ram/gf10x: timing_10_0e_30" Todo: - find l3, rq - triple-check Signed-off-by: Roy Spliet <nouv...@spliet.org> --- .../drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 12 +++--- drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c | 22 -- drivers

[Nouveau] Preparations for Fermi DRAM clock changes

2017-04-10 Thread Roy Spliet
No, no, these will not implement Fermi reclocking. This set of patches contains some of the preparatory work that I deem stable enough to move upstream. Notable changes - Training pattern upload routines from GK104+ now shared with GT215+ - Timing calculation for Fermi - GDDR5 MR calculation from

[Nouveau] [PATCH 11/11] nvkm/bios/perf: Retreive pointer to unk1c script

2017-04-10 Thread Roy Spliet
Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/perf.h | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/bios/perf.c | 14 ++ drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 1 + 3 files changed, 16 insertions(+)

[Nouveau] [PATCH 08/11] nvkm/ramgt215: Add train ptrn upload for GDDR5

2017-04-10 Thread Roy Spliet
Signed-off-by: Roy Spliet <nouv...@spliet.org> Tested-by: Ilia Mirkin <imir...@alum.mit.edu> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ram.h | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 128 +- 2 files changed, 99 insertions(+), 30 deleti

[Nouveau] [PATCH 05/11] nvkm/ramgf100: Don't mandate training pattern 4

2017-04-10 Thread Roy Spliet
It's not found on Fermi. Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c b/drivers/gpu/drm/nouveau/nvkm/

[Nouveau] [PATCH 07/11] nvkm/ramgf100: Reinstate default ram train pattern

2017-04-10 Thread Roy Spliet
Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 59 +-- 1 file changed, 43 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramg

[Nouveau] [PATCH 01/11] nvkm/ramgf100: Get rid of (size, data) pairs for rammap, ramcfg, timing

2017-04-10 Thread Roy Spliet
In correspondence with the other ram_calc implementations. Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 37 --- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/sub

Re: [Nouveau] OpenGL context switching with Noveau

2017-02-08 Thread Roy Spliet
For details see my presentation on day 3 of XDC2016. TL;DW: A context switch on average takes ~25 microseconds, but depending on the display resolution and the load on the card times up to 130 microseconds have been observed. The average does not appear to differ much between cards as the

Re: [Nouveau] NVAC "No Signal"

2017-01-09 Thread Roy Spliet
Op 09-01-17 om 00:24 schreef Ben Skeggs: On 12/24/2016 07:48 PM, Roy Spliet wrote: I've observed this regression on my NVAC board; a 1920x1080 TV on HDMI (single monitor set-up) gets no signal with Fedora kernels from 4.8. Trace sent to the mmio dumps mailbox. A brief scan already revealed

Re: [Nouveau] NVAC "No Signal"

2016-12-24 Thread Roy Spliet
I've observed this regression on my NVAC board; a 1920x1080 TV on HDMI (single monitor set-up) gets no signal with Fedora kernels from 4.8. Trace sent to the mmio dumps mailbox. A brief scan already revealed that register 0xe840 is never touched, so it appears that NVIDIA does something

Re: [Nouveau] [PATCH 0/5] GPU-DRM-nouveau: Fine-tuning for five function implementations

2016-09-21 Thread Roy Spliet
, but I'd like to see these changes tested before I can sleep soundly! Patches 4 and 5 are: Reviewed-by: Roy Spliet <nouv...@spliet.org> Op 21-09-16 om 08:23 schreef SF Markus Elfring: From: Markus Elfring<elfr...@users.sourceforge.net> Date: Wed, 21 Sep 2016 09:09:09 +0200

Re: [Nouveau] [PATCH 3/5] GPU-DRM-nouveau: Delete unnecessary braces

2016-09-21 Thread Roy Spliet
Comments in-line. Thanks. Roy Op 21-09-16 om 08:26 schreef SF Markus Elfring: From: Markus Elfring Date: Wed, 21 Sep 2016 08:28:08 +0200 Do not use curly brackets at four source code places where a single statement should be sufficient. Signed-off-by: Markus

[Nouveau] [PATCH v2 1/2] nvkm/clk/gf100+: Clean up PLL locking test

2016-06-17 Thread Roy Spliet
Corresponds with GT215. Don't rely on the lock test logic being unconditionally enabled, and disable test logic when done (presumably to save power). v2: Remove warning, nvkm_msec already warns on time-out Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/

[Nouveau] [PATCH v2 2/2] nvkm/clk/gf100: Read secondary bypass postdiv when required

2016-06-17 Thread Roy Spliet
v2: fix typo it's -> its Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/clk/gf100.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gf100.c b/drivers/gpu/drm/nou

Re: [Nouveau] [PATCH] drm/nouveau/iccsense: fix memory leak

2016-06-13 Thread Roy Spliet
Thanks. It seems though that you are not the only one who spotted this bug. This patch appears to be obsolete since 7505fdf [1]. Roy [1] https://github.com/skeggsb/nouveau/commit/7505fdfc2688e86f8e15069b611858f0dbe73a80 Op 06/12/16 om 15:56 schreef Sudip Mukherjee: In the for loop we are

[Nouveau] [PATCH 3/3] nvkm/init: Add support for opcode 0xaf

2016-06-04 Thread Roy Spliet
As seen in at least one NV134 VBIOS (... that I obviously don't own myself). Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 27 + 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/subde

[Nouveau] [PATCH 1/3] nvkm/clk/gf100+: Clean up PLL locking test

2016-06-04 Thread Roy Spliet
Corresponds with GT215. Don't rely on the lock test logic being unconditionally enabled, and disable test logic when done (presumably to save power). Warn when locking fails. Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/clk/gf100.

[Nouveau] PM + Init work

2016-06-04 Thread Roy Spliet
Following a series of three patches, two of which have been sitting in my tree for a while, the third is the result of some inspection of an NV134 BIOS that seems to use the 0xaf upcode to upload training patterns. Please test! Roy Ps. Sorry they come from yet another e-mail address. My previous

[Nouveau] [PATCH 2/3] nvkm/clk/gf100: Read secondary bypass postdiv when required

2016-06-04 Thread Roy Spliet
Signed-off-by: Roy Spliet <nouv...@spliet.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/clk/gf100.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gf100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gf100.c

[Nouveau] [PATCH] gr/fuc: Store $r0 in interrupt handler

2016-03-12 Thread Roy Spliet
It's supposed to always be 0, but at least nv_iowr() temporarily violates this. Since the ih touches $r0, it should be stored. Signed-off-by: Roy Spliet <rs...@cam.ac.uk> --- drm/nouveau/nvkm/engine/gr/fuc/gpc.fuc | 2 + drm/nouveau/nvkm/engine/gr/fuc/gpcgf100.fuc3.h

Re: [Nouveau] nouveau contributor dinner Friday evening before FOSDEM?

2016-01-21 Thread Roy Spliet
+1 or in layman terms, I'll be there ;-) Roy Op 21-01-16 om 15:29 schreef Karol Herbst: Hi everybody, yeah, sounds good greetings Karol Pierre Moreau hat am 21. Januar 2016 um 14:17 geschrieben: Hello everyone, I'm in for the dinner! As for the restaurant, since

Re: [Nouveau] [PATCH 2/2] clk: allow engine reclock on fermi

2016-01-13 Thread Roy Spliet
Hey Karol, Until you can convince me that this (pending) progress-in-insight[1] is accounted for in the way nouveau configures the clock registers, I must NACK this patch. Sorry. Roy [1] "nvkm/clk/gf100: Read secondary bypass postdiv when required" - currently on

Re: [Nouveau] [PATCH 3/4] subdev/pmu/fuc: implement perf

2015-10-26 Thread Roy Spliet
See my tiny nit-pick below. Op 26-10-15 om 18:13 schreef Karol Herbst: From: Karol Herbst --- drm/nouveau/nvkm/subdev/pmu/fuc/gf100.fuc3.h | 788 +++ drm/nouveau/nvkm/subdev/pmu/fuc/gf119.fuc4.h | 740 ++---

Re: [Nouveau] [PATCH 4/9] pci: implement pcie speed change for tesla

2015-10-12 Thread Roy Spliet
Hey Karol. Thanks, great work. A few questions and nit-picks in-line, but I reckon on the technical side all is fine. Cheers, Roy Op 12-10-15 om 21:27 schreef Karol Herbst: Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/subdev/pci/g84.c | 113

Re: [Nouveau] [PATCH 9/9] perf: change pcie speed on pstate change

2015-10-12 Thread Roy Spliet
Comment in-line. Cheers, Roy Op 12-10-15 om 21:27 schreef Karol Herbst: Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/subdev/clk/base.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drm/nouveau/nvkm/subdev/clk/base.c

Re: [Nouveau] [PATCH 7/9] fb/ramnv50: Script changes for G94 and up

2015-09-30 Thread Roy Spliet
Hey Ben, --- original message --- From: Ben Skeggs <skeg...@gmail.com> Date: 05:05:34 30-09-2015 To: Roy Spliet <rspl...@eclipso.eu>, Nouveau Mailinglist <nouveau@lists.freedesktop.org> Subject: Re: [PATCH 7/9] fb/ramnv50: Script changes for G94 and up > -BEG

[Nouveau] [PATCH 5/9] fb/ramnv50: Voltage GPIOs

2015-09-29 Thread Roy Spliet
Does not seem to be necessary for NVA0, hence untested by me. Signed-off-by: Roy Spliet <rspl...@eclipso.eu> Tested-by: Pierre Moreau <pierre.mor...@free.fr> --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/fb/ram

[Nouveau] [PATCH 2/9] fb/ramgt215: Transform GPIO ramfuc method from FBVREF-specific to generic

2015-09-29 Thread Roy Spliet
In preparation of changing FBVDDQ, as observed on at least one GDDR3 card. While at it, adhere to func.log[1] properly for consistency. Signed-off-by: Roy Spliet <rspl...@eclipso.eu> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 41 ++- drivers/gpu/drm/nouvea

[Nouveau] [PATCH 1/9] bios/rammap: Identify DLLoff for >= GF100

2015-09-29 Thread Roy Spliet
Signed-off-by: Roy Spliet <rspl...@eclipso.eu> --- .../drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 1 - drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/gddr5.c | 3 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c

[Nouveau] [PATCH 6/9] fb/ramnv50: Deal with cards without timing entries

2015-09-29 Thread Roy Spliet
Like Pierre's G94. We might want to structure Kepler similarly in a follow-up. Signed-off-by: Roy Spliet <rspl...@eclipso.eu> Tested-by: Pierre Moreau <pierre.mor...@free.fr> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/gddr3.c | 10 +++--- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ra

[Nouveau] [PATCH 8/9] bus/hwsq: Implement VBLANK waiting heuristic

2015-09-29 Thread Roy Spliet
Avoids waiting for VBLANKS that never arrive on headless or otherwise unconventional set-ups. Strategy taken from MEMX. Signed-off-by: Roy Spliet <rspl...@eclipso.eu> Tested-by: Pierre Moreau <pierre.mor...@free.fr> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/bus.h | 1 + dri

[Nouveau] All-round reclocking improvements

2015-09-29 Thread Roy Spliet
In bulletpoints: - Add some support for G94 and G96 reclocking. Has been tested on literally two cards, which is hardly adequate as "full coverage". On the other hand, the changes were small enough to make me confident this might work for others as well. - Fix NV50 wait for VBLANK when no

[Nouveau] [PATCH 3/9] fb/ramgt215: Change FBVDD/Q when BIOS asks for it

2015-09-29 Thread Roy Spliet
Signed-off-by: Roy Spliet <rspl...@eclipso.eu> --- .../gpu/drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 18 ++ 3 files changed, 20 insertions(+)

[Nouveau] [PATCH 7/9] fb/ramnv50: Script changes for G94 and up

2015-09-29 Thread Roy Spliet
10053c is not even read on some cards, and I have no idea exactly what the criteria are. Likely NVIDIA pre-scans the VBIOS and in their driver disables all features that are never used. The practical effect should be the same as this implementation though. Signed-off-by: Roy Spliet <r

[Nouveau] [PATCH 4/9] fb/ramgt215: Restructure r111100 calculation for DDR2

2015-09-29 Thread Roy Spliet
Seems to be mostly equal to DDR3 on < GT218, should improve stability for DDR2 reclocks. Signed-off-by: Roy Spliet <rspl...@eclipso.eu> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 70 --- 1 file changed, 37 insertions(+), 33 deletions(-) diff --git a/dr

[Nouveau] [PATCH 9/9] clk/g84: Enable reclocking for GDDR3 G94-G200

2015-09-29 Thread Roy Spliet
Your milage may vary, as it's only been tested on a single G94 and one G96. Signed-off-by: Roy Spliet <rspl...@eclipso.eu> Tested-by: Pierre Moreau <pierre.mor...@free.fr> --- drivers/gpu/drm/nouveau/nvkm/subdev/clk/g84.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Nouveau] Fix reclocking regression in drm-next

2015-09-02 Thread Roy Spliet
Attached patch fixes an issue reported by Pierre Moreau, that prevents reclocking of GT21x and MCP7x from working after "the big rewrite". Please review and push forward for kernel 4.3. Thanks! Roy ___ Nouveau mailing list

[Nouveau] [PATCH] clk/gt215: Unbreak engine pausing for GT21x/MCP7x

2015-09-02 Thread Roy Spliet
Typo that snuck in with commit 6979c6303a4abf263753cd9d577d79f05c6e8c47 Signed-off-by: Roy Spliet <rspl...@eclipso.eu> Reported-by: Pierre Moreau <pierre.mor...@free.fr> --- drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Nouveau] [PATCH] bios/rammap: Identify DLLoff for = GF100

2015-07-26 Thread Roy Spliet
Signed-off-by: Roy Spliet rspl...@eclipso.eu --- .../drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 1 - drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/gddr5.c | 3 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c | 41

[Nouveau] [Cover letter] Identify DLLoff for = GF100

2015-07-26 Thread Roy Spliet
Since the previously sent RFC resulted in no comments, I take it everything is ok. I gave it a test-spin on my NVE7, no regressions there. GDDR5 can always be worked on later; this patch does not regress anything in that area. As far as I'm concerned it's ready for inclusion. Happy testing, Roy

[Nouveau] [RFC] bios/rammap: Identify DLLoff for = GF100

2015-07-05 Thread Roy Spliet
--- .../drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 1 - drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/gddr5.c | 3 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgk104.c | 41 ++

[Nouveau] [RFC] Fermi/Kepler identify DLLoff

2015-07-05 Thread Roy Spliet
Hello, Attached a small patch that correctly identifies the DLLoff bit for =GF100. Marked RFC because I haven't seen any GDDR5 samples that *enable* the DLL. I'd like to verify whether the DLL should be reset when enabled. Could increase likelihood of succesfull reclock. Ben: could you do some

[Nouveau] [PATCH v2 10/10] clk/nv50: Enable user reclocking for NVA0

2015-05-24 Thread Roy Spliet
Tested on a few cards. Probably works quite well for most, given they should all be GDDR3. Signed-off-by: Roy Spliet rspl...@eclipso.eu --- drivers/gpu/drm/nouveau/nvkm/subdev/clk/nv50.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk

[Nouveau] [PATCH v2 07/10] bios/ramcfg: Separate out RON pull value

2015-05-24 Thread Roy Spliet
Signed-off-by: Roy Spliet rspl...@eclipso.eu --- drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c | 3 ++- drivers/gpu/drm/nouveau/nvkm/subdev/bios/timing.c | 2 ++ drivers/gpu/drm/nouveau/nvkm/subdev/fb/gddr3.c

[Nouveau] [PATCH v2 09/10] fb/gddr3: Add a few CL and WR entries observed on GTX260

2015-05-24 Thread Roy Spliet
Signed-off-by: Roy Spliet rspl...@eclipso.eu --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/gddr3.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gddr3.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gddr3.c index 8d759f8a..4465446

Re: [Nouveau] [PATCH 4/9] nvkm/fb/ramnv50: Ressurect timing code, use proper timing/rammap handlers

2015-05-23 Thread Roy Spliet
Hello Tobias, Reply inline. --- original message --- From: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de Date: 01:00:17 23-05-2015 To: Roy Spliet rspl...@eclipso.eu, nouveau@lists.freedesktop.org Subject: Re: [Nouveau] [PATCH 4/9] nvkm/fb/ramnv50: Ressurect timing code, use proper

[Nouveau] [PATCH v2 03/10] fb/ramnv50: Make 0x100da0 per-partition

2015-05-23 Thread Roy Spliet
Like on GT215 Signed-off-by: Roy Spliet rspl...@eclipso.eu --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv50.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv50.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb

[Nouveau] [PATCH v2 01/10] clk/gt215: u32-s32 for difference in req. and set clock

2015-05-23 Thread Roy Spliet
This difference can of course be negative too... Signed-off-by: Roy Spliet rspl...@eclipso.eu --- drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c b/drivers/gpu/drm/nouveau/nvkm

[Nouveau] [PATCH v2 04/10] fb/ramgt215: No need to cuss like that

2015-05-23 Thread Roy Spliet
Signed-off-by: Roy Spliet rspl...@eclipso.eu --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c index 47d53ed..bc36a4f

[Nouveau] [PATCH v2 06/10] bios/rammap: Parse perf mode as if it's a rammap entry

2015-05-23 Thread Roy Spliet
Some of the bits in there are similar to the bits in the gt215 rammap. Signed-off-by: Roy Spliet rspl...@eclipso.eu --- drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 5 + drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/rammap.h | 2 ++ drivers/gpu/drm/nouveau/nvkm/subdev

[Nouveau] [PATCH v2 02/10] bios/rammap: Pull DLLoff bit out of version 0x10 struct

2015-05-23 Thread Roy Spliet
In preparation of NV50 reclocking, where there is no version Signed-off-by: Roy Spliet rspl...@eclipso.eu --- drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/gddr3.c

[Nouveau] [PATCH v2] Add support for NVA0

2015-05-23 Thread Roy Spliet
V2: - Slightly clarify the conditional timings in nv50_ram_timing_calc() - now rated U, approved for general audiences ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [PATCH v2 05/10] fb/ramnv50: Ressurect timing code, use proper timing/rammap handlers

2015-05-23 Thread Roy Spliet
Might need some generalisation to GT200. For those: use at your own risk! Signed-off-by: Roy Spliet rspl...@eclipso.eu --- .../drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 16 ++ .../drm/nouveau/include/nvkm/subdev/bios/rammap.h | 2 + drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c

[Nouveau] [PATCH 4/9] nvkm/fb/ramnv50: Ressurect timing code, use proper timing/rammap handlers

2015-05-22 Thread Roy Spliet
Might need some generalisation to GT200. For those: use at your own risk! Signed-off-by: Roy Spliet rspl...@eclipso.eu --- .../drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 16 ++ .../drm/nouveau/include/nvkm/subdev/bios/rammap.h | 2 + drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c

[Nouveau] [PATCH 5/9] nvkm/bios/rammap: Parse perf mode as if it's a rammap entry

2015-05-22 Thread Roy Spliet
Some of the bits in there are similar to the bits in the gt215 rammap. Signed-off-by: Roy Spliet rspl...@eclipso.eu --- drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 5 + drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/rammap.h | 2 ++ drivers/gpu/drm/nouveau/nvkm/subdev

[Nouveau] Reclocking support for NVA0

2015-05-22 Thread Roy Spliet
Adds reclocking for NVA0, and a whole lot of work for other cards. Had these patches collecting dust for a little, but tested them with both my NVA0, and Martin's a while back. Success not guaranteed, but should be quite a leap forward. Happy reviewing and testing. Cheers, Roy

[Nouveau] [PATCH 2/9] nvkm/bios/rammap: Pull DLLoff bit out of version 0x10 struct

2015-05-22 Thread Roy Spliet
In preparation of NV50 reclocking, where there is no version Signed-off-by: Roy Spliet rspl...@eclipso.eu --- drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/bios/rammap.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/fb/gddr3.c

  1   2   3   >