Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli merged PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1689601808 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +110,288 @@ public void multiValuedBi

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1689538685 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +110,288 @@ public void multiValue

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1689259248 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +114,289 @@ public void multiValuedBi

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1689259599 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -18,26 +18,50 @@ import java.io.IOExcept

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1687938401 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -18,26 +18,50 @@ import java.io.IOExc

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1683026945 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -297,13 +297,11 @@ private void getBrok

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#issuecomment-2236745018 After @stefan-egli insights and looking on performance implication for whole properties compression/decompression process, my opinion is that it doesn't brink to much value to co

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#issuecomment-2236322219 Turns out that it might look slightly different altogether: In the latest test from @ionutzpi where it passes a broken surrogate through NodeBuilder (except it shouldn't

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#issuecomment-2225449508 @reschke I vote for your proposal(fixing segment store) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

reschke commented on PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#issuecomment-2225379200 bq. For RDB it could be different: it could mean that if you want to use compression for RDB you'd have to accept that broken surrogates are not supported (unless we find a fast wa

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#issuecomment-2225354781 @reschke @reschke I created methods to check the behavior with broken surrogate before and after introducing compression. After compression the test failed. -- This is an autom

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#issuecomment-991078 With the default set to disable compression, in theory this PR shouldn't do no harm and could be merged, as changing the default is a conscious decision that could be done base

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

reschke commented on PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#issuecomment-299402 > Why is this a MongoDB specific aspect? For MongoDB we know it is not supported (see [this skip here](https://github.com/apache/jackrabbit-oak/blob/0e327a27eb988a0f7656535275f3735

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644787553 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -60,6 +73,11 @@ public void before() thr

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#issuecomment-2176272288 [looks](https://github.com/apache/jackrabbit-oak/blob/14c357120e49d83281dc473d810ca485deb94501/oak-store-spi/src/main/java/org/apache/jackrabbit/oak/plugins/memory/AbstractPrope

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644558711 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -127,8 +188,25 @@ public boolean equals(Object

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

reschke commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644549857 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -127,8 +188,25 @@ public boolean equals(Object o

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644545109 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -127,8 +188,25 @@ public boolean equals(Object

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644545109 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -127,8 +188,25 @@ public boolean equals(Object

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

reschke commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644499232 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -127,8 +188,25 @@ public boolean equals(Object o

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644492664 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +100,225 @@ public void multiValuedBi

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644490150 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +100,225 @@ public void multiValuedBi

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644489555 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -116,7 +163,20 @@ public int count() { */

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644489190 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -18,26 +18,45 @@ import java.io.IOExcept

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644488604 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +45,64 @@ import org.apache.jackrabbit.

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644487143 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +100,179 @@ public void multiValuedBi

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644486368 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +100,179 @@ public void multiValuedBi

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644485936 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +45,64 @@ import org.apache.jackrabbit.

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644395621 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -128,7 +188,7 @@ public boolean equals(Objec

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

reschke commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644353388 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -128,7 +188,7 @@ public boolean equals(Object ob

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644348052 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -116,7 +163,20 @@ public int count() { */

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644336103 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -116,7 +163,20 @@ public int count() {

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

reschke commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644328794 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -116,7 +163,20 @@ public int count() { */

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644291222 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +45,64 @@ import org.apache.jackrabb

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642878592 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +100,179 @@ public void multiValuedBi

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

reschke commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642813805 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +100,179 @@ public void multiValuedBin

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642766461 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +100,179 @@ public void multiValuedBi

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642746647 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +100,179 @@ public void multiValuedBi

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642740716 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +45,64 @@ import org.apache.jackrabbit.

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642740716 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +45,64 @@ import org.apache.jackrabbit.

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642736298 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +100,179 @@ public void multiValuedBi

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642735284 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +45,64 @@ import org.apache.jackrabbit.

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642734832 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +45,64 @@ import org.apache.jackrabbit.

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642734255 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -128,7 +188,7 @@ public boolean equals(Object o

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642721700 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +100,179 @@ public void multiValue

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642713859 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +45,64 @@ import org.apache.jackrabb

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

stefan-egli commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642708995 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +45,64 @@ import org.apache.jackrabb

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

reschke commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1642564726 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +45,64 @@ import org.apache.jackrabbit.o

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1639713253 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +44,66 @@ import org.apache.jackrabbit.

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1639707803 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -18,26 +18,43 @@ import java.io.IOExcept

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

ionutzpi commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1639707557 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +44,66 @@ import org.apache.jackrabbit.

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

reschke commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1639705992 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +44,66 @@ import org.apache.jackrabbit.o

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

reschke commented on PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#issuecomment-2167814526 I believe the main concern is that we don't know yet exactly why we are doing this. IMHO it would be better to first collect data on the size of the properties. -- This is an au

Re: [PR] OAK-10803 -- compress/uncompress property [jackrabbit-oak]

reschke commented on code in PR #1526: URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1639674435 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +44,66 @@ import org.apache.jackrabbit.o