[PATCH] Add parser for file list objects

--- src/stkutil.c | 85 + src/stkutil.h |6 2 files changed, 91 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 940eee2..18f1cdb 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -416,6 +416,89 @@

[PATCH 04/10] Add server at command data structure

--- gatchat/gatserver.c | 27 +++ gatchat/gatserver.h | 22 ++ 2 files changed, 49 insertions(+), 0 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 0658553..6173765 100644 --- a/gatchat/gatserver.c +++

[PATCH 02/10] Add basic command parsing

According to V.250 5.3.1, the basic command is either a single character or the '' followed by a single character. --- gatchat/gatserver.c | 99 +- 1 files changed, 97 insertions(+), 2 deletions(-) diff --git a/gatchat/gatserver.c

[PATCH 03/10] Add extended command parsing

--- gatchat/gatserver.c | 65 +- 1 files changed, 63 insertions(+), 2 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 2c53d84..0658553 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c @@ -197,16 +197,77 @@

[PATCH 07/10] Add G_AT_SERVER_RESULT_EXT_ERROR

--- gatchat/gatserver.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gatchat/gatserver.h b/gatchat/gatserver.h index 5e9eb62..6fb78bd 100644 --- a/gatchat/gatserver.h +++ b/gatchat/gatserver.h @@ -43,6 +43,7 @@ enum _GAtServerResult {

Add parse framework for GAtServer

Update patches based on comments and rebase with latest git. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 09/10] Refactor g_at_server_send_final

Cache the result code as last_result from at command callback. And flush out the last result code when the whole command line is parsed, except the last result is an extended error code, like +CMS ERROR or +CME ERROR. --- gatchat/gatserver.c | 55

[PATCH 01/10] Add framework of server parser

a. The parser fetch and parse one command per loop. The prefix is the command prefix without parameter. For example, the prefix of AT+CLIP=1 is +CLIP. b. Search registered notification node in command_list. Invoke the callback if found. c. Termiate the execution if the result is an error.

[PATCH 06/10] Add g_at_server_register and unregister callback

--- gatchat/gatserver.c | 48 gatchat/gatserver.h |6 ++ 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 3f60f1c..1ffc2c3 100644 --- a/gatchat/gatserver.c +++

[PATCH 10/10] Add utilities to send server response

The server response could be either result code or information text. Result code types: final, intermediate and unsolicited. Information text: one or multiple lines of text. --- gatchat/gatserver.c | 42 ++ gatchat/gatserver.h | 17 + 2

[PATCH 05/10] Add notify at command callback

--- gatchat/gatserver.c | 48 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 6173765..3f60f1c 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c @@ -227,9 +227,57 @@ static

[PATCH 08/10] Fix do not emit error if extended error has emitted

--- gatchat/gatserver.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 1ffc2c3..9683fa3 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c @@ -165,6 +165,10 @@ static void g_at_server_send_final(GAtServer

Re: [PATCH 1/8][RFC] Add functions to notify core of SIM insertion/removal or request polling.

Hi Denis, On 18 March 2010 00:01, Denis Kenzior denk...@gmail.com wrote: Implement optional polling.  Polling is mandatory according to the specification but on most hardware it will me impractical because there will be vendor specific unsolicited notifications that can be used instead.  

[Usage] SMS handling

Hi all, I have a question: what is the best practice (or the suggested behaviour) to handle SMSes in an application using oFono? I am thinking about two common cases: 1) handling outgoing message status: I use the SendMessage DBus API but AFAIK I'm not aware of the status of the sending

Re: [Usage] SMS handling

Hi Dario, Hi all, I have a question: what is the best practice (or the suggested behaviour) to handle SMSes in an application using oFono? I am thinking about two common cases: 1) handling outgoing message status: I use the SendMessage DBus API but AFAIK I'm not aware of the status of the

[PATCH] Checking PIN length based on its type (PIN / PUK / NET).

From: Pekka Pessi pekka.pe...@nokia.com --- src/call-barring.c | 12 ++-- src/call-meter.c |4 ++-- src/common.c | 30 +++--- src/common.h | 11 ++- src/sim.c | 14 +++--- 5 files changed, 48 insertions(+), 23

[PATCH] Checking PIN length based on its type (PIN / PUK / NET).

From: Pekka Pessi pekka.pe...@nokia.com --- src/call-barring.c | 12 ++-- src/call-meter.c |4 ++-- src/common.c | 30 +++--- src/common.h | 11 ++- src/sim.c | 12 ++-- 5 files changed, 47 insertions(+), 22

Re: [PATCH] Checking PIN length based on its type (PIN / PUK / NET).

2010/3/19 ppe...@gmail.com: -       if (!strcmp(new, old)) +       if (!strcmp(new, old, PIN_TYPE_PIN))                return dbus_message_new_method_return(msg); I could have sworn I compiled and run the code, but then probably not. -- Pekka.Pessi mail at nokia.com

Re: [PATCH] Checking PIN length based on its type (PIN / PUK / NET).

Hi Pekka, 2010/3/19 ppe...@gmail.com: - if (!strcmp(new, old)) + if (!strcmp(new, old, PIN_TYPE_PIN)) return dbus_message_new_method_return(msg); I could have sworn I compiled and run the code, but then probably not. Just resend the patch ;) Regards,

Re: [Usage] SMS handling

Hi Denis, The current semantics are that the DBusMessage returns only when the SMS has been successfully sent to the network, or oFono determined that it cannot send it. So you can assume that SMS is pending as soon as dbus_message_send is performed by your client. And that SMS has been

Re: [Usage] SMS handling

Hi Dario, Hi Denis, The current semantics are that the DBusMessage returns only when the SMS has been successfully sent to the network, or oFono determined that it cannot send it. So you can assume that SMS is pending as soon as dbus_message_send is performed by your client. And that

Access to SIM card when Modem is not Powered

Hi all, I think the Modem Powered property is meant to control the radios (something like at+cfun=0 vs. at+cfun=1..). Now core automatically removes all the atoms in case modem has Powered false. However, the SIM card should be accessible while the radios are off (cfun=0) so that PIN code could

[PATCH] Checking PIN length based on its type (PIN / PUK / NET).

From: Pekka Pessi pekka.pe...@nokia.com --- src/call-barring.c | 12 ++-- src/call-meter.c |4 ++-- src/common.c | 33 ++--- src/common.h |9 - src/sim.c | 12 ++-- 5 files changed, 48 insertions(+), 22

Re: [PATCH] Checking PIN length based on its type (PIN / PUK / NET).

Uh-oh. I'll fix those and try to test it without checks in isidriver... --Pekka 2010/3/19 Denis Kenzior denk...@gmail.com: Hi Pekka, -gboolean is_valid_pin(const char *pin) +gboolean is_valid_pin(const char *pin, enum pin_type type)  {       unsigned int i; @@ -588,14 +588,30 @@ gboolean

Re: [patch 5/6] IP support for PPP

On Thu, 18 Mar 2010 12:26:15 +0100 Marcel Holtmann mar...@holtmann.org wrote: Hi Kristen, +static guint32 bytes_to_32(guint8 *bytes) +{ + union addr { + guint8 bytes[4]; + guint32 word; + } a; + + memcpy(a.bytes,

Re: Access to SIM card when Modem is not Powered

Hi Pekka, Hi all, I think the Modem Powered property is meant to control the radios (something like at+cfun=0 vs. at+cfun=1..). Now core automatically removes all the atoms in case modem has Powered false. However, the SIM card should be accessible while the radios are off (cfun=0) so

Re: [PATCH] Checking PIN length based on its type (PIN / PUK / NET).

Hi Pekka, From: Pekka Pessi pekka.pe...@nokia.com --- src/call-barring.c | 12 ++-- src/call-meter.c |4 ++-- src/common.c | 33 ++--- src/common.h |9 - src/sim.c | 12 ++-- 5 files changed, 48

[patch 1/6] Add PPP protocol support with HDLC framing

This patch implements the basic PPP protocol. LCP, NCP etc. are handled in a different patch. --- Makefile.am |4 gatchat/gatppp.c | 133 gatchat/gatppp.h | 59 +++ gatchat/ppp.c| 455 +++ gatchat/ppp.h

[patch 4/6] CHAP with MD5 authentication

Implement authentication support with CHAP and MD5 digest --- Makefile.am|3 gatchat/gatppp.c | 11 ++ gatchat/gatppp.h |2 gatchat/ppp.c |1 gatchat/ppp.h | 15 +++ gatchat/ppp_auth.c | 230 + 6 files

[patch 5/6] IP support for PPP

Implement IPCP support. Creates a tun interface to pass IP traffic. --- Makefile.am |2 gatchat/gatppp.c |1 gatchat/ppp.c |1 gatchat/ppp.h | 12 + gatchat/ppp_net.c | 356 ++ 5 files changed, 371

[patch 6/6] Allow gsmdial to use gatchat ppp support

Add option to use PPP to gsmdial. --- gatchat/gsmdial.c | 90 -- 1 file changed, 87 insertions(+), 3 deletions(-) Index: ofono/gatchat/gsmdial.c === ---

[patch 0/6] gatchat PPP support v3

Modified patches based on second round of feedback ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono