RE: [PATCH 1/4] radio settings: allow for more than one property

2010-10-22 Thread Mika.Liljeberg
Hi Denis, > > Oops, will fix. For some reason my checkpatch script did > not complain about this. > > > > You must be using a script as well. To avoid unnecessary > fuss like this, would it be possible to integrate it to the > oFono tree so everyone would check their patches using the same th

RE: [RFC] AGPS Support

2010-10-22 Thread Sjur BRENDELAND
Hi Bastian, > Bastian, Waldo wrote: > > Please find attached a proposal for both a DBUS and Modem API for AGPS > support. There are some minor changes compared to the proposal from > May 14, 2010. > ... >                void SendLCSFrame(string frametype, string framedata) > >                

Re: [PATCH] common : bring back some details about technology

2010-10-22 Thread Aki Niemi
Hi, 2010/10/21 "Benoît Monin" : > diff --git a/src/common.c b/src/common.c > index b5b9a6f..d571d81 100644 > --- a/src/common.c > +++ b/src/common.c > @@ -655,15 +655,15 @@ const char *registration_tech_to_string(int tech) >         case ACCESS_TECHNOLOGY_GSM: >                 return "gsm"; >   

Re: [PATCH 1/4] radio settings: allow for more than one property

2010-10-22 Thread Denis Kenzior
Hi Mika, On 10/22/2010 02:08 AM, mika.liljeb...@nokia.com wrote: > Hi Denis, > >>> Oops, will fix. For some reason my checkpatch script did >> not complain about this. >>> >>> You must be using a script as well. To avoid unnecessary >> fuss like this, would it be possible to integrate it to th

Re: Using ofono HFP

2010-10-22 Thread Moises Silva
On Thu, Oct 14, 2010 at 8:00 AM, Pekka Pessi wrote: > > dbus-glib is, err, challenging. Use gdlib if you can. > > On the other hand, telepathy-ring has a minimal implementation of > Modem and ModemManager APIs for dbus-glib: > > http://meego.gitorious.org/meego-cellular/telepathy-ring > > It uses

RE: [PATCH 1/4] radio settings: allow for more than one property

2010-10-22 Thread Mika.Liljeberg
Hi Denis, > > Thanks. Still, I'd vote for a common checkpatch script in > the oFono tree. ;) > > > > Are you volunteering to maintain such a beast and make sure > it is up to > date with the kernel upstream version? Only if I get to decide on the coding style. Otherwise, I'm proposing you guys

Re: [PATCH] common : bring back some details about technology

2010-10-22 Thread Benoît Monin
Hi Aki, > De : Aki Niemi > > Hi, > > 2010/10/21 "Benoît Monin" : > > diff --git a/src/common.c b/src/common.c > > index b5b9a6f..d571d81 100644 > > --- a/src/common.c > > +++ b/src/common.c > > @@ -655,15 +655,15 @@ const char *registration_tech_to_string(int tech) > >         case ACCESS_TECHNO

Re: [PATCH] common : bring back some details about technology

2010-10-22 Thread Denis Kenzior
Hi Benoît, On 10/22/2010 09:01 AM, "Benoît Monin" wrote: > Hi Aki, > >> De : Aki Niemi >> >> Hi, >> >> 2010/10/21 "Benoît Monin" : >>> diff --git a/src/common.c b/src/common.c >>> index b5b9a6f..d571d81 100644 >>> --- a/src/common.c >>> +++ b/src/common.c >>> @@ -655,15 +655,15 @@ const char *reg

Re: [PATCH 1/4] radio settings: allow for more than one property

2010-10-22 Thread Denis Kenzior
Hi Mika, On 10/22/2010 09:21 AM, mika.liljeb...@nokia.com wrote: > Hi Denis, > >>> Thanks. Still, I'd vote for a common checkpatch script in >> the oFono tree. ;) >>> >> >> Are you volunteering to maintain such a beast and make sure >> it is up to >> date with the kernel upstream version? > >

Re: [PATCH] hso: Set modem name based on udev network interface name

2010-10-22 Thread Denis Kenzior
Hi Benoît, On 10/21/2010 03:26 AM, "Benoît Monin" wrote: > Useful if you have multiple identical modems and you need a way > to know which modem you're talking to. > --- > plugins/udev.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/plugins/udev.c b/plugins/udev.c

Re: [RFC] AGPS Support

2010-10-22 Thread Denis Kenzior
Hi Sjur, > The 27.007 Spec specifies positioning request/responses for AT where > Positioning data are coded in XML data structures. > > I think the oFono interface should not use binary data, but rather be aligned > with 27.007 > and present decoded data as DBUS typed signals and methods with t

Emergency Calls

2010-10-22 Thread Andras Domokos
Hi, This is a proposal for handling emergency calls in ofono: Detect when an emergency call is requested/ended and notify the interested, subscribed parties, so that steps can be taken to ensure that the emergency call can be established and maintained. The "EmergencyMode" boolean property added

[RFC PATCH 1/3] modem: modem state watch added

2010-10-22 Thread Andras Domokos
Signed-off-by: Andras Domokos --- src/modem.c | 64 +++--- src/ofono.h | 15 + 2 files changed, 67 insertions(+), 12 deletions(-) diff --git a/src/modem.c b/src/modem.c index 7a29edf..9aeb49c 100644 --- a/src/modem.c +++ b/src/

[RFC PATCH 2/3] voicecall: emergency call handling added

2010-10-22 Thread Andras Domokos
Signed-off-by: Andras Domokos --- include/voicecall.h | 12 +++ src/voicecall.c | 221 ++ 2 files changed, 215 insertions(+), 18 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index 2356fcf..d530148 100644 --- a/include

[RFC PATCH 3/3] modem: emergency state handling added

2010-10-22 Thread Andras Domokos
Signed-off-by: Andras Domokos --- src/modem.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 9aeb49c..9e96cce 100644 --- a/src/modem.c +++ b/src/modem.c @@ -70,6 +70,8 @@ struct ofono_modem { s

Re: [RFC PATCH 1/5] simfs: retrieve only EF-info without EF-contents

2010-10-22 Thread Denis Kenzior
Hi Petteri, On 10/21/2010 09:58 AM, Petteri Tikander wrote: > --- > include/sim.h |5 > src/simfs.c | 64 ++-- > src/simfs.h |4 +++ > 3 files changed, 70 insertions(+), 3 deletions(-) I applied this patch but did some evil a

Re: [RFC PATCH 2/5] sim: add function for retrieving only EF-info

2010-10-22 Thread Denis Kenzior
Hi Petteri, On 10/21/2010 09:58 AM, Petteri Tikander wrote: > --- > src/sim.c | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > I squashed this patch completely, there's no need to introduce public API for this functionality at this time. Regards, -Denis

Re: [RFC PATCH 3/5] sim: check if Fixed Dial is enabled in SIM-card

2010-10-22 Thread Denis Kenzior
Hi Petteri, On 10/21/2010 09:58 AM, Petteri Tikander wrote: > If SIM-card is inserted, status is checked from EFsst > (is FDN activated) and EFadn (is ADN invalidated). > If USIM-card is inserted, status is checked from EFest > (is FDN activated). > > If FD is enabled, halt SIM initialization pro

Re: [RFC PATCH 4/5] modem: some debugs added for indicating modem state change

2010-10-22 Thread Denis Kenzior
Hi Petteri, On 10/21/2010 09:58 AM, Petteri Tikander wrote: > --- > src/modem.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofon

Re: [RFC PATCH 5/5] sim: check existence of imsi-code

2010-10-22 Thread Denis Kenzior
Hi Petteri, On 10/21/2010 09:58 AM, Petteri Tikander wrote: > For instance: when handling sim_get_properties > in PRE_SIM-state imsi is not received/stored. > --- > src/sim.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Good catch! Patch has been applied, thanks. Regards, -

Re: [RFC ssn PATCH 4/4] D-Bus API for Supplementary Service Notifications

2010-10-22 Thread Denis Kenzior
Hi Pekka, On 10/08/2010 10:36 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > doc/call-barring-api.txt | 10 --- > doc/call-forwarding-api.txt |9 +++ > doc/voicecall-api.txt| 55 > +- > doc/voicecallmanager-ap

Re: [RFC ssn PATCH 1/4] Supplementary Service Notifications

2010-10-22 Thread Denis Kenzior
Hi Pekka, Sorry for replying so late. On 10/08/2010 10:36 AM, pekka.pe...@nokia.com wrote: > Hello all, > > I've been working on supplementary service notifications (iow, trying to > decipher notifySS usage from 24.080 and related specifications). > > SSN atom is not used much, so I ended up mo

Re: [RFC sim-ready-v1 PATCH 0/3] ofono_sim_ready_notify

2010-10-22 Thread Denis Kenzior
Hi Pekka, On 10/18/2010 10:40 AM, pekka.pe...@nokia.com wrote: > Hi all, > > Here is my 2nd stab at the ofono_sim_ready_notify(). > > Main difference from Denis's and Kristen's patch is that the modem > driver now has a way to indicate that is ready or not: if SIM is not > ready, the ofono_sim_d

Re: [RFC sim-ready-v1 PATCH 3/3] atmodem/sim: use ofono_sim_ready_notify

2010-10-22 Thread Denis Kenzior
Hi Pekka, > By default the driver don't trust the modem to do the right thing and > adds a delay of 1000 milliseconds after entering the PIN/PUK. It is > possible to remove the delay by adding a suitable quirk in > at_wait_for_ready(). > > However, the delay seems to be SIM-card-specific and 100

Re: [PATCH 1/4] voicecall: __ofono_voicecall_tone_send internal api.

2010-10-22 Thread Denis Kenzior
Hi Andrew, On 10/21/2010 12:09 AM, Andrzej Zaborowski wrote: > This provides a way for other atoms to send DTMF tones during a call. > It is assumed that vc->driver->send_tone returns only after the tones > have finished being emitted. > > In this version Dbus DTMF requests are in the same queue

Re: [PATCH 2/4] stk: Handle the Send DTMF proactive command.

2010-10-22 Thread Denis Kenzior
Hi Andrew, On 10/21/2010 12:09 AM, Andrzej Zaborowski wrote: > The default_agent_notify and session_agent_notify changes below are > needed for respond_on_exit commands to be able to free up their > resources, reset alpha id, etc. Commands other than Send DTMF that > use respond_on_exit are all a

Re: [PATCH 3/4] atmodem: Delay return from send_dtmf

2010-10-22 Thread Denis Kenzior
Hi Andrew, On 10/21/2010 12:09 AM, Andrzej Zaborowski wrote: > AT+VTS responds with an OK immediately, so add a wait in the driver > before returning so that core knows when the tone has finished. Note > that some modems actually do wait against 27.007, and other modems > use a manufacturer speci

Re: [PATCH 4/4] stk: Apply STK text attributes as html.

2010-10-22 Thread Denis Kenzior
Hi Andrew, On 10/21/2010 12:09 AM, Andrzej Zaborowski wrote: > --- > src/stk.c | 148 ++-- > 1 files changed, 123 insertions(+), 25 deletions(-) > Patch has been applied, thanks. I also went ahead and marked the relevant task on the TODO