[PATCH 3/4] isimodem: revector GPRS context driver

2010-11-10 Thread Mika Liljeberg
--- drivers/isimodem/gprs-context.c | 280 +-- 1 files changed, 121 insertions(+), 159 deletions(-) diff --git a/drivers/isimodem/gprs-context.c b/drivers/isimodem/gprs-context.c index 47e858a..62f7ac2 100644 --- a/drivers/isimodem/gprs-context.c +++ b/drivers

Re: Can I modify CallingLineRestriction(the Property of CallSetting) value to "disabled" or "enabled"

2010-11-10 Thread Pekka Pessi
Hi all, 2010/11/10 Gu, Yang : >>According to your tip , I tried to set "HideCallerId" to "default", >>"disabled" and >>"enabled", and I can verify by run list-modem script that "HideCallerId" had >>been >>modified . but I still could find phone number on both called party and >>calling party ,

[PATCH 4/4] isigen: make number of PDP contexts configurable

2010-11-10 Thread Mika Liljeberg
--- plugins/isigen.c | 23 +-- plugins/udev.c |6 +- 2 files changed, 22 insertions(+), 7 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c index 838d060..cee4e44 100644 --- a/plugins/isigen.c +++ b/plugins/isigen.c @@ -58,6 +58,8 @@ #include "drivers/

[PATCH] TODO: Add owner to extend the voicecall interface with a property indicating emergency call

2010-11-10 Thread John Mathew
--- TODO |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/TODO b/TODO index 84d5aa7..ed37c58 100644 --- a/TODO +++ b/TODO @@ -416,7 +416,7 @@ Emergency Calls Priority: High Complexity: C1 - + Owner: John Mathew Miscellaneous = -- 1.7.0.4 __

[PATCH 1/4] gisi: fix crash bug in g_isi_remove_subscription

2010-11-10 Thread Mika Liljeberg
--- gisi/client.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/gisi/client.c b/gisi/client.c index 8ab3dc9..8e41331 100644 --- a/gisi/client.c +++ b/gisi/client.c @@ -744,16 +744,19 @@ int g_isi_subscribe(GIsiClient *client, uint8_t type, */ void g_isi_remove_s

RE: Can I modify CallingLineRestriction(the Property of CallSetting) value to "disabled" or "enabled"

2010-11-10 Thread Gu, Yang
Hi Haitao, >-Original Message- >From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of >Ding, HaitaoX >Sent: Wednesday, November 10, 2010 12:13 PM >To: ofono@ofono.org >Subject: RE: Can I modify CallingLineRestriction(the Property of CallSetting) >value to >"disabled

[PATCH] TODO: Check SIM pin status if sim_change_pin fails.

2010-11-10 Thread Marit Henriksen
From: Marit Henriksen --- I'm sorry if I gave the impression that I don't want to contribute to the development of oFono core, I guess I'm just not that familiar with how things work. TODO |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 84d5aa7.

[PATCH 2/4] gisi: return NULL instead of asserting

2010-11-10 Thread Mika Liljeberg
--- gisi/pep.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gisi/pep.c b/gisi/pep.c index f1ff589..bea1902 100644 --- a/gisi/pep.c +++ b/gisi/pep.c @@ -148,6 +148,8 @@ unsigned g_isi_pep_get_ifindex(const GIsiPEP *pep) char *g_isi_pep_get_ifname(const GIsiPEP *p

[PATCH 0/4] bugfixes + revectored isimodem GPRS context driver

2010-11-10 Thread Mika Liljeberg
Hi All, The first two patches are bugfixes. The rest adapts the isimodem GPRS context driver to the current multiple PDP context support in oFono core. Br, MikaL [PATCH 1/4] gisi: fix crash bug in g_isi_remove_subscription [PATCH 2/4] gisi: return NULL instead of asserting [PATCH 3/4]

Re: [RFC PATCH 2/3] modem: add EmergencyMode property

2010-11-10 Thread Andras Domokos
Hi Denis, On 11/09/2010 04:37 PM, ext Denis Kenzior wrote: Hi Andras, On 11/09/2010 02:59 AM, Andras Domokos wrote: Signed-off-by: Andras Domokos --- src/modem.c | 53 + src/ofono.h |4 2 files changed, 57 insertions(+), 0

Re: [RFC PATCH 2/3] modem: add EmergencyMode property

2010-11-10 Thread Denis Kenzior
Hi Andras, >> So we have to be a bit careful here. You can't simply call >> modem_change_state here. This results in calling the post_online >> method, which populates the atoms that function when the radio is on. >> Instead you need to call the set_online driver method directly. >> >> Also, you

[PATCH 1/3] sim: Add sim_service_available() for querying EFsst or EFust.

2010-11-10 Thread Andrzej Zaborowski
The function is not public api because the service constants are in src/simutil.h. --- src/ofono.h |5 + src/sim.c | 15 +++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index e5b4acb..4d76d20 100644 --- a/src/ofono.h +++ b/src/o

[PATCH 2/3] sms: SMS-PP download must be enabled in SIM service tables.

2010-11-10 Thread Andrzej Zaborowski
--- src/sms.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index eba4564..fe45ef3 100644 --- a/src/sms.c +++ b/src/sms.c @@ -37,6 +37,7 @@ #include "util.h" #include "smsutil.h" #include "storage.h" +#include "simutil.h" #define

[PATCH 3/3] cbs: CB download must be enabled in SIM service tables.

2010-11-10 Thread Andrzej Zaborowski
--- src/cbs.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/cbs.c b/src/cbs.c index 6bd2f69..821985b 100644 --- a/src/cbs.c +++ b/src/cbs.c @@ -173,6 +173,7 @@ static void cbs_dispatch_text(struct ofono_cbs *cbs, enum sms_class cls, void ofono_cbs_noti

Re: [PATCH] TODO: Add owner to extend the voicecall interface with a property indicating emergency call

2010-11-10 Thread Denis Kenzior
Hi John, On 11/10/2010 06:25 AM, John Mathew wrote: > --- > TODO |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/TODO b/TODO > index 84d5aa7..ed37c58 100644 > --- a/TODO > +++ b/TODO > @@ -416,7 +416,7 @@ Emergency Calls > >Priority: High >Complexity: C1

Re: [PATCH] TODO: Check SIM pin status if sim_change_pin fails.

2010-11-10 Thread Denis Kenzior
Hi Marit, On 11/10/2010 05:35 AM, Marit Henriksen wrote: > From: Marit Henriksen > > --- > I'm sorry if I gave the impression that I don't want to contribute to > the development of oFono core, I guess I'm just not that familiar with > how things work. > No worries, patch has been applied. T

Re: [PATCH 1/3] sim: Add sim_service_available() for querying EFsst or EFust.

2010-11-10 Thread Denis Kenzior
Hi Andrew, On 11/09/2010 09:27 PM, Andrzej Zaborowski wrote: > The function is not public api because the service constants are in > src/simutil.h. > --- Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://list

Re: [PATCH 2/3] sms: SMS-PP download must be enabled in SIM service tables.

2010-11-10 Thread Denis Kenzior
Hi Andrew, On 11/09/2010 09:27 PM, Andrzej Zaborowski wrote: > --- > src/sms.c | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://l

Re: [PATCH 3/3] cbs: CB download must be enabled in SIM service tables.

2010-11-10 Thread Denis Kenzior
Hi Andrew, On 11/09/2010 09:27 PM, Andrzej Zaborowski wrote: > --- > src/cbs.c | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://l

[PATCH] TODO: Assign Voicecall emergency property task

2010-11-10 Thread John Mathew
--- TODO |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/TODO b/TODO index eefa605..bf2305b 100644 --- a/TODO +++ b/TODO @@ -422,7 +422,7 @@ Emergency Calls Priority: High Complexity: C1 - + Owner: John Mathew Miscellaneous = -- 1.7.0.4 ___

Re: [PATCH] TODO: Assign Voicecall emergency property task

2010-11-10 Thread Denis Kenzior
Hi John, On 11/10/2010 10:09 AM, John Mathew wrote: > --- > TODO |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Applied, thanks for taking up this task. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/li

[no subject]

2010-11-10 Thread John Mathew
Resending patch with commit header under 50 characters. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 4/4] isigen: make number of PDP contexts configurable

2010-11-10 Thread Marcel Holtmann
Hi Mika, > plugins/isigen.c | 23 +-- > plugins/udev.c |6 +- > 2 files changed, 22 insertions(+), 7 deletions(-) > @@ -434,6 +434,10 @@ static void add_isi(struct ofono_modem *modem, > if (addr != NULL) > ofono_modem_set_integer(modem, "Add

Re: [RFC PATCH 2/3] modem: add EmergencyMode property

2010-11-10 Thread Marcel Holtmann
Hi Denis, > >> Here you should turn the radio off if it was off before starting the > >> emergency call. > >> > >> > > > > The rationale behind leaving the radio on after emergency calls > > was to have the theoretical possibility the emergency call center > > to call you back (when SIM card

RFCs updated: Infineon modem support for agps

2010-11-10 Thread Robertino Benis
Hi all, This is the second RFC set of patches, attempting to start shaping aGPS support for Infenion modem in oFono. I have included comments received both from Denis and Marcel on the first RFC version. This set of patches includes: - basic API documentation, - suggested core APIs and example i

[PATCH] todo: ifxmodem apgs support

2010-11-10 Thread Robertino Benis
--- TODO | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index bf2305b..fe617af 100644 --- a/TODO +++ b/TODO @@ -496,3 +496,19 @@ Miscellaneous Priority: Low Complexity: C4 + + +Modem support += + +- Infineon modem: + Adding

[RFC v2 1/3] doc: addidng documentation for basic assisted gps

2010-11-10 Thread Robertino Benis
--- doc/assistedgps-manager-api.txt | 107 +++ 1 files changed, 107 insertions(+), 0 deletions(-) create mode 100644 doc/assistedgps-manager-api.txt diff --git a/doc/assistedgps-manager-api.txt b/doc/assistedgps-manager-api.txt new file mode 100644 index

[RFC v2 2/3] agps: adding agps related functions

2010-11-10 Thread Robertino Benis
--- include/agps.h | 157 1 files changed, 157 insertions(+), 0 deletions(-) create mode 100644 include/agps.h diff --git a/include/agps.h b/include/agps.h new file mode 100644 index 000..783136b --- /dev/null +++ b/include/agps.h @@

[RFC v2 3/3] ifxmodem: adding modem API to support agps

2010-11-10 Thread Robertino Benis
--- drivers/ifxmodem/agps.c | 413 +++ 1 files changed, 413 insertions(+), 0 deletions(-) create mode 100644 drivers/ifxmodem/agps.c diff --git a/drivers/ifxmodem/agps.c b/drivers/ifxmodem/agps.c new file mode 100644 index 000..4e8d427 --- /dev/nu

RE: [RFC v2 3/3] ifxmodem: adding modem API to support agps

2010-11-10 Thread Bastian, Waldo
The error handling in ifx_agps_inject_time_cb needs to have a call to CALLBACK_WITH_FAILURE. Calling g_at_chat_register(agd->chat, "%%XFTI:", ...) from ifx_agps_inject_time_cb seems wrong: - It gets called multiple times - Are you sure that %XFTI can't come before the OK response? - agd->chat sh

RE: [RFC v2 3/3] ifxmodem: adding modem API to support agps

2010-11-10 Thread Marcel Holtmann
Hi Waldo, > The error handling in ifx_agps_inject_time_cb needs to have a call to > CALLBACK_WITH_FAILURE. < snip> > In ifx_agps_send_lcs_frame the raw_frame isn't hex encoded before it gets > inserted into the AT command. this mailing list does NOT allow top posting and you know this. Still

RE: [RFC v2 3/3] ifxmodem: adding modem API to support agps

2010-11-10 Thread Bastian, Waldo
> this mailing list does NOT allow top posting and you know this. I indeed realized this about a second after I pressed send. My initial response was to use Outlook's recall function to correct my mistake... luckily sanity prevailed. I am very sorry about this transgression. I will now sulk in

RE: Can I modify CallingLineRestriction(the Property of CallSetting) value to "disabled" or "enabled"

2010-11-10 Thread Gu, Yang
Hi, >-Original Message- >From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of >Pekka Pessi >Sent: Wednesday, November 10, 2010 8:33 PM >To: ofono@ofono.org >Subject: Re: Can I modify CallingLineRestriction(the Property of CallSetting) >value to >"disabled" or "ena

RE: Can I modify CallingLineRestriction(the Property ofCallSetting) value to "disabled" or "enabled"

2010-11-10 Thread Zhang, Caiwen
Hi Yang, > -Original Message- > From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On > Behalf Of Gu, Yang > Sent: Thursday, November 11, 2010 10:37 AM > To: ofono@ofono.org > Subject: RE: Can I modify CallingLineRestriction(the Property > ofCallSetting) value to "disabled" or

Re: [PATCH v4 1/2] stemodem: Add RTNL functionality managing CAIF Network Interfaces.

2010-11-10 Thread Marcel Holtmann
Hi Sjur, > I'm sorry about the formatting for the v3 version of this patch. > I used git send-email via my gmail account, and ended up with base64 > MIME content encoding. I dont' know what went wrong :-( > > I think I have closed most of your review comments so far. I kept using > sendto as I d

Re: [PATCH v4 2/2] stemodem: Update gprs-context to use rtnl to create/remove interfaces.

2010-11-10 Thread Marcel Holtmann
Hi Sjur, > drivers/stemodem/gprs-context.c | 207 > +-- > 1 files changed, 135 insertions(+), 72 deletions(-) > > diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c > index 9f59579..4260d31 100644 > --- a/drivers/stemodem/gprs-con

RE: [RFC] plugin/ste: Use D-Bus API from Modem Init Daemon for autoconfig.

2010-11-10 Thread Marcel Holtmann
Hi Sjur, > > > This patch introduces auto discovery of ST-Ericsson modems. > > > ST-Ericsson modems are managed by a Modem Init Daemon which > > > is responsible for start/stop/restart flashing etc. The > > > STE plugin monitors the modem state exposed from the > > > Modem Init Damon Dbus API. Whe

PPP disconnected via Huawei modem

2010-11-10 Thread Chen Yuwei
Hi, I use MeeGo NB 10/26 release to browse some website via Huawei modem, The PPP connection is disconnected when recieve a PPP event (RXJ-). Then the PPP can not be connected anymore. Why? What condition does ofono recieve this event? The ofono also recieved udev event "remove" and removed the hu