Re: [PATCH 3/3] gisi: use strerror_r() instead of strerror()

On Friday 26 November 2010 23:07:29 ext Denis Kenzior, you wrote: So my question is why we're using g_printerr in the first place inside a library. Perhaps an approach similar to g_at_chat_set_debug is in order? I don't know. I guess I will wait for Aki's infamous rewritten gisi anyway. --

[PATCH] configure: do not hard-code the C run-time library name

Since oFono does (obviously) not use -nostdlib, this only broke support for alternative C run-times. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 7f7a935..0c1986a 100644 --- a/configure.ac +++ b/configure.ac @@ -61,7

[PATCH] Mark ofono/*.h symbolink links as built sources

This forces automake/make to build them first if needed (as before). But it avoids marking every single header as a dependency of every single object. Thus we do not need a bogus full rebuild of the tree everytime a header is added. --- Makefile.am |5 ++--- 1 files changed, 2 insertions(+),

Re: [PATCH] Mark ofono/*.h symbolink links as built sources

Hi Remi, This forces automake/make to build them first if needed (as before). But it avoids marking every single header as a dependency of every single object. Thus we do not need a bogus full rebuild of the tree everytime a header is added. I had this before, but it caused problems with

Re: [PATCH] configure: do not hard-code the C run-time library name

Hi Remi, Since oFono does (obviously) not use -nostdlib, this only broke support for alternative C run-times. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) looks good enough to me. Patch has been applied. Regards Marcel

Re: [PATCH 2/3] Use %m instead of strerror() in syslog messages

Hi Remi, strerror() is not thread-safe, nor in the glibc implementation, nor in the POSIX specification. In my experience, it will infrequently crash when another thread uses locale data in any way, including string formatting and such... Since the Huawei driver uses thread, we

Re: [PATCH] Add voice call boolean property for MO/MT distinction

Hi Remi, This becomes a problem if we have more than one application managing voice calls. And I expect that will _be_ the most common case. You have the main call UI, but you also have the Bluetooth headset/carkit, the USB AT commands port, and possibly some third party call

Read/Write EFcfis/EFcphs-cff

Hi, This patch reads and writes the VoiceUnconditional call forwarding status from and to the SIM files EFcfis/EFcphs-cff. New property ForwardingFlagOnSim is added to inform the status of the VoiceUnconditional status read from SIM. If EFcfis is present, EFcfis file is read and the status is

[PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff

--- src/call-forwarding.c | 266 +++- 1 files changed, 260 insertions(+), 6 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index ce03c40..bb345a6 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -34,6 +34,7 @@

[PATCH 3/7] isigen: Move call forwarding to post sim

--- plugins/isigen.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c index 3384e9f..47f2553 100644 --- a/plugins/isigen.c +++ b/plugins/isigen.c @@ -402,6 +402,7 @@ static void isigen_post_sim(struct ofono_modem *modem)

[PATCH 2/7] ifx: Move call forwarding to post sim

--- plugins/ifx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index 037273a..cd6e667 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -703,6 +703,7 @@ static void ifx_post_sim(struct ofono_modem *modem) ofono_stk_create(modem,

[PATCH 7/7] TODO: Marking the Read/Write EFcfis task as done

--- TODO |9 - doc/features.txt |5 + 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/TODO b/TODO index c484871..b33063a 100644 --- a/TODO +++ b/TODO @@ -92,15 +92,6 @@ SMS SIM / SIM File system = -- Read / Write EFcfis. Call

[PATCH 5/7] phonesim: Move call forwarding to post sim

--- plugins/phonesim.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/plugins/phonesim.c b/plugins/phonesim.c index d2faf42..e29d04d 100644 --- a/plugins/phonesim.c +++ b/plugins/phonesim.c @@ -470,6 +470,8 @@ static void phonesim_post_sim(struct ofono_modem *modem)

[PATCH 6/7] doc: Add new property to call forwarding

--- doc/call-forwarding-api.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/doc/call-forwarding-api.txt b/doc/call-forwarding-api.txt index 067531a..e8b4b9f 100644 --- a/doc/call-forwarding-api.txt +++ b/doc/call-forwarding-api.txt @@ -57,3 +57,8 @@ Properties

[PATCH 4/7] plugins/n900: Move call forwarding to post sim

--- plugins/n900.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/n900.c b/plugins/n900.c index a9e6b59..3f6aa39 100644 --- a/plugins/n900.c +++ b/plugins/n900.c @@ -491,6 +491,7 @@ static void n900_post_sim(struct ofono_modem *modem) DBG();

Re: [PATCH 2/3] stk: Handle provide local info proactive command

Hi Yang, On 11/28/2010 08:47 PM, Gu, Yang wrote: Hi Denis, diff --git a/src/smsutil.c b/src/smsutil.c index e6dbf5f..5394817 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -324,10 +324,10 @@ gboolean sms_encode_scts(const struct sms_scts *in, unsigned char *pdu, if (in-year 99)

Re: [PATCH 1/5] text-telephony: add public header

Hi Waldo, On 11/27/2010 03:04 PM, Bastian, Waldo wrote: + void (*remove)(struct ofono_ctm *tt); + void (*query_tty)(struct ofono_ctm *tt, + ofono_ctm_query_cb_t cb, + void *data); + void (*set_tty)(struct ofono_ctm *tt, +

ConnectionContext creation for LTE PDN Connection.

Hi all, We have started to investigate LTE impact on oFono, specifically how to integrate LTE and initial PDN connection, and we have some questions regarding this. This raises some questions about the handling of ConnectionContexts. When a terminal attach to LTE network it would normally do

[PATCH] sim: fix issue in triggering EFest read

--- src/sim.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/sim.c b/src/sim.c index e5e304c..5a84833 100644 --- a/src/sim.c +++ b/src/sim.c @@ -1445,7 +1445,11 @@ static void sim_efust_read_cb(int ok, int length, int record, * must be present if EFfdn

Re: ConnectionContext creation for LTE PDN Connection.

Hello, On Monday 29 November 2010 16:46:43 ext Sjur BRENDELAND, you wrote: This raises some questions about the handling of ConnectionContexts. When a terminal attach to LTE network it would normally do an implicit context activation request associated to attach request (+CGATT=1).

Re: ConnectionContext creation for LTE PDN Connection.

Hi Remi, Or should oFono automatically create a Connection Context? Furthermore, should oFono automatically proceed and set Active=true, bind the connection to a network interface and set network interface in state UP, Definitely not. This would interfere with any other existing IP

Re: [PATCH 1/2] phonesim: implement ctm atom

Hi Lucas, On 11/27/2010 01:22 PM, Lucas De Marchi wrote: --- plugins/phonesim.c | 150 ++-- 1 files changed, 146 insertions(+), 4 deletions(-) Patch has been applied, thanks. Regards, -Denis ___

Re: [PATCH 2/2] TODO: Mark CTM task as done

Hi Lucas, On 11/27/2010 01:22 PM, Lucas De Marchi wrote: --- TODO | 11 --- doc/features.txt |7 +++ 2 files changed, 7 insertions(+), 11 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono

[PATCH] sim: fix issue in triggering EFest read

--- src/sim.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/sim.c b/src/sim.c index e5e304c..30a6ac2 100644 --- a/src/sim.c +++ b/src/sim.c @@ -1441,11 +1441,18 @@ static void sim_efust_read_cb(int ok, int length, int record, /* *

Re: [PATCH 1/9] coding-style: add rule about checking NULL pointer

Hi Lucas, On 11/27/2010 01:38 PM, Lucas De Marchi wrote: --- doc/coding-style.txt | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list

[PATCH] sim: fix typo

--- src/simapplication.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/simapplication.cpp b/src/simapplication.cpp index 05ae21f..71bb81d 100644 --- a/src/simapplication.cpp +++ b/src/simapplication.cpp @@ -,7 +,7 @@ void

[PATCH] simfs: make sim_fs_read_block work for 256 byte files

--- src/simfs.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/simfs.c b/src/simfs.c index 5f459ab..258a42f 100644 --- a/src/simfs.c +++ b/src/simfs.c @@ -59,6 +59,7 @@ static gboolean sim_fs_op_read_block(gpointer user_data); struct sim_fs_op {

Re: [PATCH 2/9] drivers: explicitly compare pointers to NULL

On 11/27/2010 01:38 PM, Lucas De Marchi wrote: This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- drivers/atmodem/atutil.c|2 +-

Re: [PATCH 3/9] unit: explicitly compare pointers to NULL

Hi Lucas, On 11/27/2010 01:38 PM, Lucas De Marchi wrote: This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- unit/test-caif.c|2 +- unit/test-mux.c

Re: [PATCH 4/9] gisi: explicitly compare pointers to NULL

Hi Lucas, On 11/27/2010 01:38 PM, Lucas De Marchi wrote: This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- gisi/client.c | 46

Re: [PATCH 5/9] examples: explicitly compare pointers to NULL

Hi Lucas, On 11/27/2010 01:38 PM, Lucas De Marchi wrote: This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- examples/nettime.c |2 +- 1 files changed, 1

Re: [PATCH 6/9] gatchat: explicitly compare pointers to NULL

Hi Lucas, On 11/27/2010 01:39 PM, Lucas De Marchi wrote: This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- gatchat/gatchat.c | 46

Re: [PATCH 8/9] plugins: explicitly compare pointers to NULL

Hi Lucas, On 11/27/2010 01:39 PM, Lucas De Marchi wrote: This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- plugins/bluetooth.c |6 +++---

Re: [PATCH 9/9] core: explicitly compare pointers to NULL

Hi Lucas, On 11/27/2010 01:39 PM, Lucas De Marchi wrote: This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- src/audio-settings.c | 12

Re: [PATCH] sim: fix typo

Hi Gustavo, On 11/29/2010 12:51 PM, Gustavo F. Padovan wrote: --- src/simapplication.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] sim: fix issue in triggering EFest read

Hi Jeevaka, On 11/29/2010 10:57 AM, Jeevaka Badrappan wrote: --- src/sim.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] stk: Add busy error for the display text command

Hi Guillaume, On 25 November 2010 09:44, Lucas, GuillaumeX guillaumex.lu...@intel.com wrote: From: Guillaume Lucas guillaumex.lu...@intel.com According to the sequence 1.2 of the ETSI TS 102 384 a busy screen error type must be returned for the display text proactive command when the message