Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-08 Thread Aki Niemi
Hi Rémi, On Tue, 2010-12-07 at 18:12 +0200, ext Rémi Denis-Courmont wrote: > More than one second delay over D-Bus is not unheard of, especially on mobile > devices. I don't see the point of sending _both_ the reception timestamp and > the original NITZ value, but I do see the point in sending a

[PATCH 1/4] gisi: Changes to prepare for isimodem2.5

2010-12-08 Thread Jessica Nilsson
This set of patches introduces the isimodem2.5. WG2.5 (isimodem2.5) Supported features list: General: Online / Offline mode (RF on/off) Voice call: MO/MT call Multiparty call (max 7 calls) Transfer call Swap calls Hold calls Hang up all Hang up specific call Disconnect reason (Network/local/remo

[PATCH 2/4]simutil: Changes to prepare for isimodem2.5

2010-12-08 Thread Jessica Nilsson
updates in src/simutil.h Adding some sim file id and sim dir id mostly related to phonebook usim/sim. Regards, Jessica Nilsson --- src/simutil.h | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 92b2e0f..bc53255 1006

[PATCH 4/4] scripts: Added init.rc script

2010-12-08 Thread Jessica Nilsson
Updates in Makefile.am and the adding of an init file. Regards, Jessica Nilsson --- Makefile.am| 10 +++ scripts/ofonod | 79 2 files changed, 89 insertions(+), 0 deletions(-) create mode 100755 scripts/ofonod diff --git a/Ma

RE: [PATCH] stkutil: fix crash issue cause by null length of text string

2010-12-08 Thread Lucas, GuillaumeX
Hi > > On 7 December 2010 22:55, wrote: > > Hi Guillaume, > > > >> > >> According to 3GPP TS 31.124 a null length for the text string > >> should be allowed. An empty string must be returned to the > >> user in this case. > >> --- > >>  src/stkutil.c |    6 -- > >>  1 files changed, 4 inser

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-08 Thread Marcel Holtmann
Hi Aki, > > > where is this timed running? I prefer the plugin just send a D-Bus > > > message to the timed directly instead of a Get/Changed API kind of > > > thing. > > > > AFAIK, timed is in system bus. However, I fail to see how you can make > > this any simpler. In the end, one of the two en

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Marcel Holtmann
Hi Aki, > > Here a proposal for call counters implementation for keeping track > > of the total incoming and outgoing call duration counters. Each > > established call instance is contributing to either of the call > > duration counters. The 2 counters are updated periodically when > > there is an

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-08 Thread Aki Niemi
Hi Marcel, 2010/12/8 Marcel Holtmann : >> is timed actually open source and I can have a look at it? > > so what about this? Where is the timed respository? I really wanna have > a look at it and see what it is doing. Knock yourself out: http://meego.gitorious.org/meego-middleware/timed Cheers,

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

2010-12-08 Thread Marcel Holtmann
Hi Jessica, > Updates in Makefile.am - adding of isimodem2.5 > Adding of drivers/isimodem2.5/ files to fully listed functionality. > > Regards, > Jessica Nilsson > > --- > Makefile.am| 36 +- > drivers/isimodem2.5/call-barring.c | 503 ++ > drivers/isi

Re: [PATCH 1/4] gisi: Changes to prepare for isimodem2.5

2010-12-08 Thread Marcel Holtmann
Hi Jessica, > This set of patches introduces the isimodem2.5. > > WG2.5 (isimodem2.5) Supported features list: > > General: > Online / Offline mode (RF on/off) > > Voice call: > MO/MT call > Multiparty call (max 7 calls) > Transfer call > Swap calls > Hold calls > Hang up all > Hang up specific

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Aki Niemi
Hi Marcel, 2010/12/8 Marcel Holtmann : > so Denis and I talked about this a little bit and I am not fine with > this at all. Next time, can you invite me to join your little talk? > Lets take this one step and please explain to me what your requirements > and objectives are. I also wanna see a t

Re: [RFC PATCH 2/4] modem: add EmergencyMode property

2010-12-08 Thread Denis Kenzior
Hi Pekka, >> So my only major concern left is here actually. If we activate an >> emergency call and a set_property(Online, blah) is active, we get into >> some funny race conditions. I mentioned these to Pekka on IRC. But >> basically the worst one is if we have an Online=False operation pendi

Re: [PATCH 1/3] sms: store pending tx pdus on disk

2010-12-08 Thread Denis Kenzior
On 12/07/2010 04:57 PM, Kristen Carlson Accardi wrote: > On Mon, 06 Dec 2010 20:38:58 -0600 > Denis Kenzior wrote: > > > >>> + /* >>> +* file name is: imsi/order in tx_queue-uuid/order of pdus >>> +*/ >>> + if (write_file(buf, len, SMS_BACKUP_MODE, >>> + SM

RE: ofono Digest, Vol 20, Issue 28

2010-12-08 Thread krishna k
Hello, This is regarding driving ST-Ericsson Modem (which user CAIF protocol) using OFono framework. Host: LinuxTarget : ST-Ericsson GSM ModemCommunication: RS232 cableDrivers: VCP (virtual comport drivers from FTDI ftdi-elan.ko, ftdi_sio.ko) We implemented CAIF protocol and able to drive ST-Er

CAIF Protocol : oFono

2010-12-08 Thread krishna k
Hello, This is regarding driving ST-Ericsson Modem (which user CAIF protocol) using OFono framework.-Host: LinuxTarget : ST-Ericsson GSM ModemCommunication: RS232 cableDrivers: VCP (virtual comport drivers from FTDI ft

[PATCH] stk: fix issue to avoid null pointer for alpha_id

2010-12-08 Thread Lucas, GuillaumeX
From: Guillaume Lucas If a SET UP CALL proactive command with no alpha identifier occurs, the alpha_id pointer will be set to NULL. This will generate a crash in the stkagent with dbus function. To avoid this we use an empty string if the alpha identifier is not present in the command. --- src/s

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Marcel Holtmann
Hi Aki, > > so Denis and I talked about this a little bit and I am not fine with > > this at all. > > Next time, can you invite me to join your little talk? because you are not sitting next to me right now ;) > > Lets take this one step and please explain to me what your requirements > > and ob

Re: [PATCH 1/4] gisi: Changes to prepare for isimodem2.5

2010-12-08 Thread Jessica Nilsson
Hi Marcel, this needs to be split into separate patches and the commit message needs to be a bit cleaner. Also is this in sync with the GISI re-write Aki is doing? thank you for your comments. We are studying what Aki is doing and are in contact with him and will get back to this. Best Regar

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

2010-12-08 Thread Jessica Nilsson
Hi Marcel, thanks for your input. this is not gonna work this way. No one can review such a massive patch. Actually Evolution even refused to format this for me. :-) Right you are, it's huge So please split this into one patch per atom driver. We are starting to look at this split

RE: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Mika.Liljeberg
Hi, > > Because if your battery runs out in the middle of a 4 hour > conference > > call, your timers are not updated and become worthless. Obviously, > > this is a compromise between how reliable the counters are and how > > many wakeups and IO we can bear. > > I think this is not a good idea t

Re: [PATCH] Simulate provide local info command in sim app

2010-12-08 Thread Denis Kenzior
Hi Yang, On 12/08/2010 01:18 AM, Yang Gu wrote: > --- > src/simapplication.cpp | 68 > > src/simapplication.h |2 + > 2 files changed, 70 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis __

Re: [PATCH 2/3] Make timezone an optional field

2010-12-08 Thread Denis Kenzior
Hi Yang, On 11/30/2010 04:44 AM, Yang Gu wrote: > --- > src/smsutil.c | 11 ++- > src/smsutil.h |1 + > src/stkutil.c | 13 ++--- > 3 files changed, 13 insertions(+), 12 deletions(-) > Patch has been applied, thanks. Regards, -Denis _

Re: [PATCH 3/3] stk: Handle provide local info proactive command

2010-12-08 Thread Denis Kenzior
Hi Yang, On 11/30/2010 04:44 AM, Yang Gu wrote: > --- > src/stk.c | 77 > + > 1 files changed, 77 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono

RE: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

2010-12-08 Thread Mika.Liljeberg
Hi, > > In addition, I don't a point in a filename. So isimodem25 > or isimodem2 > > or something like that please. I am open for proposals. > > > Let's go for isimodem25 Quite a bit of the code is practically a copy-paste from the isimodem driver. Have you looked into the possibility of s

Re: [PATCH 1/4] gisi: Changes to prepare for isimodem2.5

2010-12-08 Thread Aki Niemi
Hi, On Wed, 2010-12-08 at 14:17 +0100, ext Jessica Nilsson wrote: > > Also is this in sync with the GISI re-write Aki is doing? > thank you for your comments. > We are studying what Aki is doing and are in contact with him and will > get back to this. One item I can see is missing is the ability

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

2010-12-08 Thread Marcel Holtmann
Hi Jessica, > > So please split this into one patch per atom driver. > > > We are starting to look at this split up. > Do you have any other suggestions? I really want one patch per atom driver. > > In addition, I don't a point in a filename. So isimodem25 or isimodem2 > > or something like

Re: [PATCH 4/4] scripts: Added init.rc script

2010-12-08 Thread Marcel Holtmann
Hi Jessica, > Updates in Makefile.am and the adding of an init file. > > Regards, > Jessica Nilsson > > --- > Makefile.am| 10 +++ > scripts/ofonod | 79 > > 2 files changed, 89 insertions(+), 0 deletions(-) > create mode 10

Re: [PATCH 2/4]simutil: Changes to prepare for isimodem2.5

2010-12-08 Thread Marcel Holtmann
Hi Jessica, > updates in src/simutil.h > Adding some sim file id and sim dir id mostly related to phonebook usim/sim. please write a proper commit message here. The subject is not acceptable since it misleads what this patch is doing. Also "updates in src/..." comments are not really useful. We

Re: [PATCH 7/9] gdbus: explicitly compare pointers to NULL

2010-12-08 Thread Marcel Holtmann
Hi Lucas, > This patch was generated by the following semantic patch > (http://coccinelle.lip6.fr/) > > // > @fix disable is_null,isnt_null1@ > expression *E; > @@ > > - !E > + E == NULL > // > --- > gdbus/object.c | 24 > gdbus/polkit.c |2 +- > gdbus/watch.c

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Andras Domokos
Hi, On 12/08/2010 02:41 PM, ext Marcel Holtmann wrote: Hi Aki, so Denis and I talked about this a little bit and I am not fine with this at all. Next time, can you invite me to join your little talk? because you are not sitting next to me right now ;) Lets take this o

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Marcel Holtmann
Hi Andras, > >>> Lets take this one step and please explain to me what your requirements > >>> and objectives are. I also wanna see a top to bottom from UI down to the > >>> modem usage of this API. > >>> > >> We need a UI showing total MO and MT call times. They also need to be > >> able

Re: [PATCH 1/2] huaweimodem: Add support for radio settings

2010-12-08 Thread Denis Kenzior
Hi Lucas, On 11/30/2010 12:41 PM, Lucas De Marchi wrote: > --- > Makefile.am |3 +- > drivers/huaweimodem/huaweimodem.c|2 + > drivers/huaweimodem/huaweimodem.h|3 + > drivers/huaweimodem/radio-settings.c | 212 > ++ >

Re: [PATCH] SMS character set unit tests.

2010-12-08 Thread Denis Kenzior
Hi Oleg, On 12/01/2010 06:27 AM, Oleg Zhurakivskyy wrote: > --- > unit/test-sms.c | 244 > +++ > 1 files changed, 244 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis __

Re: [PATCH] TODO: Mark Language Notification task as done

2010-12-08 Thread Denis Kenzior
Hi Jeevaka, On 12/01/2010 01:47 PM, Jeevaka Badrappan wrote: > --- > TODO |6 -- > doc/features.txt |4 > 2 files changed, 4 insertions(+), 6 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailin

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-08 Thread Rémi Denis-Courmont
On Wednesday 08 December 2010 10:13:45 ext Aki Niemi, you wrote: > Hi Rémi, > > On Tue, 2010-12-07 at 18:12 +0200, ext Rémi Denis-Courmont wrote: > > More than one second delay over D-Bus is not unheard of, especially on > > mobile devices. I don't see the point of sending _both_ the reception > >

Re: [PATCH 1/2] huaweimodem: Add support for radio settings

2010-12-08 Thread Lucas De Marchi
On Wed, Dec 8, 2010 at 2:17 PM, Denis Kenzior wrote: > Hi Lucas, > > On 11/30/2010 12:41 PM, Lucas De Marchi wrote: >> --- >>  Makefile.am                          |    3 +- >>  drivers/huaweimodem/huaweimodem.c    |    2 + >>  drivers/huaweimodem/huaweimodem.h    |    3 + >>  drivers/huaweimodem/

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Andras Domokos
Hi Marcel, On 12/08/2010 06:12 PM, ext Marcel Holtmann wrote: Hi Andras, Lets take this one step and please explain to me what your requirements and objectives are. I also wanna see a top to bottom from UI down to the modem usage of this API. We need a UI showing total MO and

Re: [PATCH v2 1/3] radio-settings: add frequency band selection methods

2010-12-08 Thread Denis Kenzior
Hi Lucas, On 12/01/2010 07:55 PM, Lucas De Marchi wrote: > --- > include/radio-settings.h | 33 + > 1 files changed, 33 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailin

Re: [PATCH v2 2/3] radio-settings: add frequency band selection properties

2010-12-08 Thread Denis Kenzior
Hi Lucas, On 12/01/2010 07:55 PM, Lucas De Marchi wrote: > --- > src/radio-settings.c | 250 > +- > 1 files changed, 248 insertions(+), 2 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___

Re: [PATCH v2 3/3] doc: document frequency band selection

2010-12-08 Thread Denis Kenzior
Hi Lucas, On 12/01/2010 07:55 PM, Lucas De Marchi wrote: > --- > doc/radio-settings-api.txt | 43 +++ > 1 files changed, 43 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___

Re: [PATCH] TODO: Add onwer to 'GPS power control atom' task

2010-12-08 Thread Denis Kenzior
Hi Rafael, On 12/02/2010 01:22 PM, Rafael Ignacio Zurita wrote: > > --- > TODO |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/TODO b/TODO > index a421a99..a365d38 100644 > --- a/TODO > +++ b/TODO > @@ -488,6 +488,7 @@ Miscellaneous > >Priority: Low >Comp

RE: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Kai.Vehmanen
Hi, On 08 Dec 2010, Marcel Holtmann wrote: > So I am actually thinking that doing that inside PulseAudio is a lot > more efficient solution. > > The idea is that PA already runs in the user session and has to monitor > the uplink/downlink state (and additionally could monitor call states > as wel

[PATCH] smsutil: do not hardcode TP-ValidityPeriod

2010-12-08 Thread Pekka . Pessi
From: Pekka Pessi --- src/smsutil.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index f4eee24..59faaf7 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -3162,11 +3162,10 @@ GSList *sms_datagram_prepare(const char *to, memse

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Marcel Holtmann
Hi Andras, > >> The call counters are shown to the user when he or she opens up > >> an application/applet whatever UI component that is meant for > >> showing this information. > >> > > do we have a clear use case requirement from an UI point of view on how > > this is expected to be

RE: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Marcel Holtmann
Hi Kai, > > So I am actually thinking that doing that inside PulseAudio is a lot > > more efficient solution. > > > > The idea is that PA already runs in the user session and has to monitor > > the uplink/downlink state (and additionally could monitor call states > > as well if needed). So it kno

[PATCH] TODO: CDMA SMS and CDMA CMAS

2010-12-08 Thread Lei Yu
--- TODO | 122 ++--- 1 files changed, 94 insertions(+), 28 deletions(-) diff --git a/TODO b/TODO index 6cf7202..0760216 100644 --- a/TODO +++ b/TODO @@ -49,33 +49,6 @@ SMS Complexity: C1 Owner: Kristen Carlson Accardi -- Add C

[PATCH 0/5] Add CDMA SMS Support

2010-12-08 Thread Lei Yu
This set of patches introduces the foundation for CDMA SMS support in oFono. The pathes cover support of receiving simple CDMA SMS WMT DELIVER message. Currently, only few CDMA SMS parameters and subparameters have been supported. Support of additional features will come in future patches. Include

[PATCH 2/5] cdma-sms: Add CDMA SMS Support

2010-12-08 Thread Lei Yu
--- Makefile.am|3 +- src/cdma-sms.c | 342 ++ src/cdma-smsutil.c | 467 src/cdma-smsutil.h | 264 + 4 files changed, 1075 insertions(+), 1 deletions(-) create m

[PATCH 1/5] cdma-sms: Add CDMA SMS Support

2010-12-08 Thread Lei Yu
--- Makefile.am|2 +- include/cdma-sms.h | 69 include/dbus.h |4 +++ src/ofono.h|2 + 4 files changed, 76 insertions(+), 1 deletions(-) create mode 100644 include/cdma-sms.h diff --git a/Makefile.am b/Makefil

[PATCH 3/5] cdma-atmodem: Add CDMA SMS Support

2010-12-08 Thread Lei Yu
--- Makefile.am|7 ++ configure.ac |5 ++ drivers/cdma-atmodem/atmodem.c | 47 drivers/cdma-atmodem/atmodem.h | 23 ++ drivers/cdma-atmodem/atutil.c | 45 drivers/cdma-atmodem/atutil.h | 64 + dri

[PATCH 4/5] cdmaphonesim: Add CDMA SMS Support

2010-12-08 Thread Lei Yu
--- Makefile.am |9 ++ configure.ac |6 + plugins/cdmaphonesim.c| 344 + plugins/cdmaphonesim.conf | 14 ++ 4 files changed, 373 insertions(+), 0 deletions(-) create mode 100644 plugins/cdmaphonesim.c create mo

[PATCH 5/5] test: Add CDMA SMS unit test code

2010-12-08 Thread Lei Yu
--- Makefile.am |6 ++- unit/test-cdmasms.c | 134 +++ 2 files changed, 139 insertions(+), 1 deletions(-) create mode 100644 unit/test-cdmasms.c diff --git a/Makefile.am b/Makefile.am index 44a6395..4a91993 100644 --- a/Makefile.am +++

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

2010-12-08 Thread Aki Niemi
Hi Jessica, 2010/12/8 Jessica Nilsson : > +static void reset_buf(char *buf, char *buf_2, int buf_len) > +{ > +       memset(buf, '\0', buf_len); > +       memset(buf_2, '\0', buf_len); > +} > + > +static int get_topics_len(const char *topics) > +{ > +       int i = 0; > +       int k = 0; > +    

Re: [PATCH] TODO: Add task for NITZ name support in netreg

2010-12-08 Thread Aki Niemi
Hi Denis, 2010/12/3 Denis Kenzior : > Out of curiosity, how do you plan to support this on AT modems?  I have > yet to see any AT modem report the NITZ network name via a proprietary > command. Are you sure? In my experience, the NITZ name may be received moments after registration, so it would m

[PATCH] Fix test-sms build failure

2010-12-08 Thread leena.gunda
Fix for http://bugs.meego.com/show_bug.cgi?id=11081 --- unit/test-sms.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/unit/test-sms.c b/unit/test-sms.c index 94b9dbf..239cd4a 100644 --- a/unit/test-sms.c +++ b/unit/test-sms.c @@ -636,7 +636,7 @@ static void test_sms_ch

Re: [PATCH] TODO: Add task for NITZ name support in netreg

2010-12-08 Thread Denis Kenzior
Hi Aki, On 12/09/2010 12:52 AM, Aki Niemi wrote: > Hi Denis, > > 2010/12/3 Denis Kenzior : >> Out of curiosity, how do you plan to support this on AT modems? I have >> yet to see any AT modem report the NITZ network name via a proprietary >> command. > > Are you sure? In my experience, the NITZ