Re: [PATCH] Enable hs 2330 MBM modem

2011-01-28 Thread Marcel Holtmann
Hi Zhigang, > diff --git a/plugins/udev.c b/plugins/udev.c > index 202b225..810049a 100644 > --- a/plugins/udev.c > +++ b/plugins/udev.c > @@ -123,6 +123,7 @@ static void add_mbm(struct ofono_modem *modem, > g_str_has_suffix(desc, "Minicard Modem 2") || >

Re: [PATCH] Enable Dell 5540 AGPS interface

2011-01-28 Thread Marcel Holtmann
Hi Zhigang, > plugins/udev.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/plugins/udev.c b/plugins/udev.c > index 202b225..ce1efe6 100644 > --- a/plugins/udev.c > +++ b/plugins/udev.c > @@ -135,7 +135,7 @@ static void add_mbm(struct ofono_modem *modem, >

[PATCH v4 0/2] bluetooth: Add bluetooth server support

2011-01-28 Thread Frédéric Danis
It watches Bluetooth adapter property changes and adds SDP record to listen client connection request. It supports multiple adapters, servers and client connections. Frédéric Danis (2): bluetooth: Add bluetooth server support bluetooth: Add Bluetooth service authorization support Makefile.am

[PATCH 1/2] bluetooth: Add bluetooth server support

2011-01-28 Thread Frédéric Danis
--- Makefile.am |1 + plugins/bluetooth.c | 280 ++- plugins/bluetooth.h |9 ++ 3 files changed, 287 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9b77e63..c0efe28 100644 --- a/Makefile.am +++ b/Makefile

[PATCH 2/2] bluetooth: Add Bluetooth service authorization support

2011-01-28 Thread Frédéric Danis
--- plugins/bluetooth.c | 133 +++ 1 files changed, 124 insertions(+), 9 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 0aaa406..a9e49a6 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -44,6 +44,8 @@ static

RE: [RFC] doc: Proposal for LTE/IMS API.

2011-01-28 Thread Jeevaka.Badrappan
Hi Sjur, ofono-boun...@ofono.org wrote: > > - SIM identities used for IMS registration such as: > PrivateImsIdentity, PublicImsIdentity, HomeDomainName. Correct me if I'm wrong. Private Identity is the one used for registration, authorisation, administration and billing purposes whereas the P

Re: [RFC] doc: Proposal for LTE/IMS API.

2011-01-28 Thread Arun Ravindran
Hi Sjur, doc/ims-api.txt | 119 +++ 1 files changed, 119 insertions(+), 0 deletions(-) create mode 100644 doc/ims-api.txt +Propertiesboolean ImsVoiceRegistered [readwrite, optional] + +Inform modem's radio stack that

[PATCH] doc: Assisted Satellite Navigation API and Agent API

2011-01-28 Thread Sjur Brændeland
From: Simon Lethbridge This patch introduces support for Global Satellite Navigation System (GNSS), using the AT commands AT+CPOS and +CPOSR as specified 3GPP 27.007. --- Hi Denis, 2010/11/30 Denis Kenzior : >> +AssistedSatelliteNavigation hierarchy >What do you think of naming this AssistedNavi

[PATCH 1/1] gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions

2011-01-28 Thread Jessica Nilsson
--- This is needed in order for isimodem2.5 to work. Best Regards, Jessica Nilsson ST-Ericsson gisi/common.h |3 + gisi/message.c |8 + gisi/message.h |1 + gisi/modem.c | 105 -- gisi/modem.h |4 + gisi/pipe.c| 433

Re: [PATCH 1/1] gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions

2011-01-28 Thread Marcel Holtmann
Hi Jessica, > --- > This is needed in order for isimodem2.5 to work. you might wanna keep the subject line under 50 characters and have a more detailed explanation in the commit body. See M5. Also you might need a From line at the top. Regards Marcel _

[PATCH 0/5] Add missing NULL check

2011-01-28 Thread Jeevaka Badrappan
Hi, Following set of patches adds the missing NULL check in radio-setting atom driver for all the modems. Regards, Jeevaka Jeevaka Badrappan (5): ifxmodem: add NULL check hsomodem: add NULL check huaweimodem: add NULL check stemodem: add NULL check nwmodem: add NULL check drivers/hs

[PATCH 1/5] ifxmodem: add NULL check

2011-01-28 Thread Jeevaka Badrappan
--- drivers/ifxmodem/radio-settings.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/ifxmodem/radio-settings.c b/drivers/ifxmodem/radio-settings.c index fd590ae..6771e00 100644 --- a/drivers/ifxmodem/radio-settings.c +++ b/drivers/ifxmodem/radio-se

[PATCH 2/5] hsomodem: add NULL check

2011-01-28 Thread Jeevaka Badrappan
--- drivers/hsomodem/radio-settings.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/hsomodem/radio-settings.c b/drivers/hsomodem/radio-settings.c index cefd415..a761d44 100644 --- a/drivers/hsomodem/radio-settings.c +++ b/drivers/hsomodem/radio-se

[PATCH 3/5] huaweimodem: add NULL check

2011-01-28 Thread Jeevaka Badrappan
--- drivers/huaweimodem/radio-settings.c | 30 -- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/huaweimodem/radio-settings.c b/drivers/huaweimodem/radio-settings.c index 68112fe..c850e33 100644 --- a/drivers/huaweimodem/radio-settings.c +++

[PATCH 4/5] stemodem: add NULL check

2011-01-28 Thread Jeevaka Badrappan
--- drivers/stemodem/radio-settings.c | 33 +++-- 1 files changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/stemodem/radio-settings.c b/drivers/stemodem/radio-settings.c index 5b50126..337a19c 100644 --- a/drivers/stemodem/radio-settings.c +++ b/driver

[PATCH 5/5] nwmodem: add NULL check

2011-01-28 Thread Jeevaka Badrappan
--- drivers/nwmodem/radio-settings.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/nwmodem/radio-settings.c b/drivers/nwmodem/radio-settings.c index b8b5719..0cf75f5 100644 --- a/drivers/nwmodem/radio-settings.c +++ b/drivers/nwmodem/radio-settings

Re: [PATCH 1/5] ifxmodem: add NULL check

2011-01-28 Thread Marcel Holtmann
Hi Jeevaka, > drivers/ifxmodem/radio-settings.c | 15 ++- > 1 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/ifxmodem/radio-settings.c > b/drivers/ifxmodem/radio-settings.c > index fd590ae..6771e00 100644 > --- a/drivers/ifxmodem/radio-settings.c > +++ b/

Re: [PATCH] doc: Assisted Satellite Navigation API and Agent API

2011-01-28 Thread Rémi Denis-Courmont
On Friday 28 January 2011 13:32:50 ext Sjur Brændeland, you wrote: > + void RegisterPositioningRequestAgent(object path) > + > + Registers an agent which will be called whenever a > + CPOSR AT response is received. The Agent must respond > +

Re: [RFC 1/5] gprs: Update documentation for IPv6

2011-01-28 Thread Sjur Brændeland
Hi, > +               dict IPv6Settings [readonly, optional] > + > +                       Holds all the IPv6 network settings. > + > +                       string Interface [readonly, optional] > + > +                               Holds the name of the IPv6 network interface > +                

[PATCH] TODO: add CF state change task

2011-01-28 Thread Jarko Poutiainen
--- TODO | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 41f1f7f..b62eb99 100644 --- a/TODO +++ b/TODO @@ -255,6 +255,22 @@ Supplementary Services Priority: Low Complexity: C8 +- Call forwarding state handling change + + At the mo

Re: [PATCH 1/1] gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions

2011-01-28 Thread Jessica Nilsson
Hi Marcel, On Fri, Jan 28, 2011 at 12:42 PM, Marcel Holtmann wrote: > you might wanna keep the subject line under 50 characters and have a > more detailed explanation in the commit body. See M5. How did I miss that one? I will fix it! > Also you might need a From line at the top. I think the m

RE: [RFC 1/5] gprs: Update documentation for IPv6

2011-01-28 Thread Mika.Liljeberg
Hi Sjur, > > +   For combined IPv4v6 context (3GPP rel 8) the > > +   same network interface may be used for both > > +   IPv4 and IPv6. IPv4 and IPv6 may also be > > +   offered via separate network interfaces. > > + > > I think it would be nice if we could keep only one interface here. > It's a

Re: [PATCH] TODO: add CF state change task

2011-01-28 Thread Marcel Holtmann
Hi Jarko, > TODO | 16 > 1 files changed, 16 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

RE: [RFC 1/5] gprs: Update documentation for IPv6

2011-01-28 Thread Marcel Holtmann
Hi Mika, > > > + For combined IPv4v6 context (3GPP rel 8) the > > > + same network interface may be used for both > > > + IPv4 and IPv6. IPv4 and IPv6 may also be > > > + offered via separate network interfaces. > > > + > > > > I think it would be nice if we could keep only one interface

Re: [PATCH 1/1] gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions

2011-01-28 Thread Rémi Denis-Courmont
On Friday 28 January 2011 13:37:10 ext Jessica Nilsson, you wrote: > diff --git a/gisi/common.h b/gisi/common.h > index 83a8cf5..c78f893 100644 > --- a/gisi/common.h > +++ b/gisi/common.h > @@ -26,6 +26,8 @@ > extern "C" { > #endif > > +#define PN_HOST0x00

Re: [RFC 1/5] gprs: Update documentation for IPv6

2011-01-28 Thread Rémi Denis-Courmont
On Friday 28 January 2011 14:49:16 ext Sjur Brændeland, you wrote: > I think it would be nice if we could keep only one interface here. > It's a bit messy that the difference between R7 and R8 > networks will be visible to the users like this. > > So when in a R7 network the uplink traffic should

Re: [RFC 1/5] gprs: Update documentation for IPv6

2011-01-28 Thread Rémi Denis-Courmont
On Friday 28 January 2011 16:17:04 ext Marcel Holtmann, you wrote: > I am not sure it is a good idea to make ConnMan do that. For IFX, I was > actually considering just piping the two RawIP streams into one network > interface. That seems easy enough. > > And to be honest for PPP, just doing IPv4

[PATCH] plugins:ste:preparation for hotswap

2011-01-28 Thread Jussi Kangas
--- Hi, This patch enables ste modem to handle hotswap situation. Br, Jussi plugins/ste.c | 109 +--- 1 files changed, 80 insertions(+), 29 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 85d2d51..e183073 100644 --- a/plugin

Re: [PATCH] plugins:ste:preparation for hotswap

2011-01-28 Thread Marcel Holtmann
Hi Jussi, > --- > Hi, > > This patch enables ste modem to handle hotswap situation. for the subject just ste: is enough. > Br, > Jussi > > plugins/ste.c | 109 +--- > 1 files changed, 80 insertions(+), 29 deletions(-) > > diff --git a/p

RE: [RFC 1/5] gprs: Update documentation for IPv6

2011-01-28 Thread Marcel Holtmann
Hi Mika, > > I am not sure it is a good idea to make ConnMan do that. > > Why is that? we need to chat with Samuel about this. I foresee a bunch of issues trying to handle two context properly. This needs a bit more deeper thinking on how things are done. > > And to be honest for PPP, just doin

Re: [RFC] doc: Proposal for LTE/IMS API.

2011-01-28 Thread Pekka Pessi
Hi Arun, 2011/1/28 Arun Ravindran : >>  +        boolean ImsVoiceOverPs [readonly, optional] >>  + >>  +            IMS voice is enabled by network >>  +            Related AT command: AT+CIREP. >>  + > > Which specification details this AT command, searched in 27.007 rel 10, but > it is not avail

Re: Ofono has too tight limits for SIM lock code lengths

2011-01-28 Thread Pekka Pessi
Moro Jussi, 2011/1/27 Jussi Kangas : >> so every single enum has kept some sort of proper namespacing. And I >> would really prefer to not break this for ofono_sim_password_type. > > I suppose u are talking about parameter name here? and > OFONO_PASSWORD_PIN_TYPE_NET is somehow inproper? Well, how

RE: [RFC 1/5] gprs: Update documentation for IPv6

2011-01-28 Thread Mika.Liljeberg
Hi Marcel, > Hi Mika, > > > > I am not sure it is a good idea to make ConnMan do that. > > > > Why is that? > > we need to chat with Samuel about this. I foresee a bunch of issues > trying to handle two context properly. This needs a bit more deeper > thinking on how things are done. Ok. But

RE: [RFC 1/5] gprs: Update documentation for IPv6

2011-01-28 Thread Mika.Liljeberg
Hi Marcel, > I am not sure it is a good idea to make ConnMan do that. Why is that? > And to be honest for PPP, just doing IPv4 seems acceptable > since PPP is > bad idea in the first place. It is a limitation I am willing > to accept. Yeah, PPP is not really a requirement for us, although it

Re: [RFC] voicecallmanager-api: call related SS signals (proposal)

2011-01-28 Thread Andras Domokos
Hi Denis, On 01/27/2011 06:01 PM, ext Denis Kenzior wrote: Hi Andras, This becomes a problem when there are multiple calls since it is not possible to determine to which call instance the indication is referring to. This raises the question where/how to show this type of properties? Have you

[ss-notify FYI 2/6] ssn: add ssn code argument to ssn notify callbacks

2011-01-28 Thread Pekka . Pessi
From: Pekka Pessi Including the ssn code as an argument in notify callbacks allows handling of multiple notifications in single function. --- src/ofono.h |4 ++-- src/ssn.c |8 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index df201

[ss-notify FYI 0/6]

2011-01-28 Thread Pekka . Pessi
Hi Andras, Here are my ss-notify patches. Perhaps 1, 3 and 4 are useful as they are. The patch 2 should be augmented in order to include the call id in the API, too. The voicecall implementation has to be revised accordingly. The patch 6 is strictly FYI. --Pekka ___

[ss-notify FYI 1/6] ssn: include ssn codes in public API

2011-01-28 Thread Pekka . Pessi
From: Pekka Pessi Include +CSSI and +CSSU codes in and prefix them with OFONO_. --- include/ssn.h | 28 +++- 1 files changed, 27 insertions(+), 1 deletions(-) diff --git a/include/ssn.h b/include/ssn.h index d640cad..9466a80 100644 --- a/include/ssn.h +++ b/include/ss

[ss-notify FYI 4/6] call-barring: remove CSSU notifications

2011-01-28 Thread Pekka . Pessi
From: Pekka Pessi The CSSU notifications are better handled within voicecall. They indicate the reason why a call is rejected and augment the DisconnectReason. According to the 24.088 section 2.1, the SS notification for barring of incoming calls is sent when callee has barred incoming calls. T

[ss-notify FYI 3/6] isimodem/ssn: add common notifications

2011-01-28 Thread Pekka . Pessi
From: Pekka Pessi Add notifications on hold, retrieve, multiparty, call waiting, barrings, and call forwarding. --- drivers/isimodem/call.h | 12 drivers/isimodem/ssn.c | 168 ++- 2 files changed, 179 insertions(+), 1 deletions(-) diff --git

[ss-notify FYI 6/6] Document notifications in voicecall-api.txt.

2011-01-28 Thread Pekka . Pessi
From: Pekka Pessi --- doc/voicecall-api.txt | 34 +- 1 files changed, 33 insertions(+), 1 deletions(-) diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt index 047b8cb..aae0867 100644 --- a/doc/voicecall-api.txt +++ b/doc/voicecall-api.txt @@ -56,6 +56,

[ss-notify FYI 5/6] voicecall: watch mt ssn events

2011-01-28 Thread Pekka . Pessi
From: Pekka Pessi Watch supplementary service notifications from barring services, remote party putting call on hold, retrieving or join call into a multiparty conference. The barring indications augment the DisconnectReason and they contain additional information about the reason why a call is

Re: [RFC] voicecallmanager-api: call related SS signals (proposal)

2011-01-28 Thread Denis Kenzior
Hi Andras, On 01/28/2011 11:13 AM, Andras Domokos wrote: > Hi Denis, > > On 01/27/2011 06:01 PM, ext Denis Kenzior wrote: >> Hi Andras, >> >>> This becomes a problem when there are multiple calls since it is not >>> possible to determine to which call instance the indication is referring >>> to.

Re: [PATCH v3 0/3] Persist TX SMS messages

2011-01-28 Thread Denis Kenzior
Hi Lucas, On 01/27/2011 08:39 PM, Lucas De Marchi wrote: > Third version. It includes some changes suggested by Denis: > > - Get rid of the oldpath field in struct txq_backup_entry > - Store the encoded uuid in struct txq_backup_entry > - Use SMS_MSGID_FMT to get the file name > - Some more clean

Re: [PATCH] smsutil: do not allow larger file names

2011-01-28 Thread Denis Kenzior
Hi Lucas, On 01/27/2011 08:48 PM, Lucas De Marchi wrote: > If file name had anything in the name after addr-msgid, it would be > parsed as well. This is not what we want, since there could be temporary > files lying around. > --- > src/smsutil.c |5 +++-- > 1 files changed, 3 insertions(+), 2