[PATCH_v6 0/5] *** SUBJECT HERE ***

2011-05-19 Thread Guillaume Zajac
*** BLURB HERE *** Guillaume Zajac (5): gatppp: Add new contructor to use external fd private-network: add header into include and Makefile.am private-network: add request/release functions and new feature to Makefile.am emulator: add request/release private network calls connman:

[PATCH_v6 2/5] private-network: add header into include and Makefile.am

2011-05-19 Thread Guillaume Zajac
--- Makefile.am |4 +- include/private-network.h | 56 + 2 files changed, 58 insertions(+), 2 deletions(-) create mode 100644 include/private-network.h diff --git a/Makefile.am b/Makefile.am index a413a47..d7e5626 100644 ---

[PATCH_v6 1/5] gatppp: Add new contructor to use external fd

2011-05-19 Thread Guillaume Zajac
--- gatchat/gatppp.c | 33 - gatchat/gatppp.h |1 + gatchat/ppp.h |2 +- gatchat/ppp_net.c | 47 --- 4 files changed, 66 insertions(+), 17 deletions(-) diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c

[PATCH_v6 3/5] private-network: add request/release functions and new feature to Makefile.am

2011-05-19 Thread Guillaume Zajac
--- Makefile.am |3 +- src/ofono.h |6 +++ src/private-network.c | 91 + 3 files changed, 99 insertions(+), 1 deletions(-) create mode 100644 src/private-network.c diff --git a/Makefile.am b/Makefile.am index

[PATCH_v6 4/5] emulator: add request/release private network calls

2011-05-19 Thread Guillaume Zajac
--- src/emulator.c | 75 --- 1 files changed, 65 insertions(+), 10 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index c17b901..0a83403 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -25,6 +25,7 @@ #include stdio.h

[PATCH_v6 5/5] connman: add plugin in oFono to request/release private network

2011-05-19 Thread Guillaume Zajac
--- Makefile.am |3 + plugins/connman.c | 299 + 2 files changed, 302 insertions(+), 0 deletions(-) create mode 100644 plugins/connman.c diff --git a/Makefile.am b/Makefile.am index e1eaf15..ffb85ae 100644 --- a/Makefile.am +++

[PATCH_v6 0/5] Private network request to ConnMan

2011-05-19 Thread Guillaume Zajac
Hi, With subject and blurb :) I forgot to close fd when ppp_net_new() returns NULL. This version include this change. Guillaume Zajac (5): gatppp: Add new contructor to use external fd private-network: add header into include and Makefile.am private-network: add request/release functions

[PATCH_v6 1/5] gatppp: Add new contructor to use external fd

2011-05-19 Thread Guillaume Zajac
--- gatchat/gatppp.c | 33 - gatchat/gatppp.h |1 + gatchat/ppp.h |2 +- gatchat/ppp_net.c | 47 --- 4 files changed, 66 insertions(+), 17 deletions(-) diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c

[PATCH_v6 2/5] private-network: add header into include and Makefile.am

2011-05-19 Thread Guillaume Zajac
--- Makefile.am |4 +- include/private-network.h | 56 + 2 files changed, 58 insertions(+), 2 deletions(-) create mode 100644 include/private-network.h diff --git a/Makefile.am b/Makefile.am index a413a47..d7e5626 100644 ---

[PATCH_v6 3/5] private-network: add request/release functions and new feature to Makefile.am

2011-05-19 Thread Guillaume Zajac
--- Makefile.am |3 +- src/ofono.h |6 +++ src/private-network.c | 91 + 3 files changed, 99 insertions(+), 1 deletions(-) create mode 100644 src/private-network.c diff --git a/Makefile.am b/Makefile.am index

[PATCH_v6 4/5] emulator: add request/release private network calls

2011-05-19 Thread Guillaume Zajac
--- src/emulator.c | 75 --- 1 files changed, 65 insertions(+), 10 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index c17b901..0a83403 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -25,6 +25,7 @@ #include stdio.h

[PATCH_v6 5/5] connman: add plugin in oFono to request/release private network

2011-05-19 Thread Guillaume Zajac
--- Makefile.am |3 + plugins/connman.c | 299 + 2 files changed, 302 insertions(+), 0 deletions(-) create mode 100644 plugins/connman.c diff --git a/Makefile.am b/Makefile.am index e1eaf15..ffb85ae 100644 --- a/Makefile.am +++

Emulator not unregistered while sending ATH0

2011-05-19 Thread Guillaume Zajac
Hi Denis, I noticed that when I send +++ - ATH0 during a PPP session the ppp server is well unregistered. However when the physical layer is removed (bluetooht or TCP), the associated emulator is not unregistered. As we used in gatutil.c set_close_on_unref(TRUE), it means there is still on

[RFC PATCH 2/2] network-registration.c: implement CIND for Telit UC864-G

2011-05-19 Thread Bernhard . Guillon
From: Bernhard Guillon bernhard.guil...@hale.at *UC864 has a incompatible CIND *use specific constants for a KISS callback function *add a Telit specific check for not measurable strength Co-authored-by: Christopher Vogl christopher.v...@hale.at Signed-off-by: Bernhard Guillon

[RFC PATCH 1/2] Add basic Telit UC864-G support:

2011-05-19 Thread Bernhard . Guillon
From: Bernhard Guillon bernhard.guil...@hale.at *add a basic plugin based on different ofono plugins *use Telit specific QSS for SIM-state *add verry basic GPS support (usable with gypsy) *add udev support and rules *update Makefile Co-authored-by: Christopher Vogl christopher.v...@hale.at

Re: Emulator not unregistered while sending ATH0

2011-05-19 Thread Guillaume Zajac
Hi Denis, I have mixed some stuff concerning GIOChannels... On 19/05/2011 12:13, Guillaume Zajac wrote: Hi Denis, I noticed that when I send +++ - ATH0 during a PPP session the ppp server is well unregistered. However when the physical layer is removed (bluetooht or TCP), the associated

Re: [PATCH] isimodem: Improper handling of missed call

2011-05-19 Thread Aki Niemi
Hi Arun, 2011/5/18 Arun Ravindran arun...@gmail.com: +       case CALL_STATUS_MT_RELEASE: +               if ((call-prev_status == CALL_STATUS_MT_ALERTING) || +                               (call-prev_status == CALL_STATUS_COMING) || +                               (call-prev_status ==

Re: Emulator not unregistered while sending ATH0

2011-05-19 Thread Guillaume Zajac
Hi again Denis, I have found the issue I will submit a fix. See explanations below. On 19/05/2011 14:12, Guillaume Zajac wrote: Hi Denis, I have mixed some stuff concerning GIOChannels... On 19/05/2011 12:13, Guillaume Zajac wrote: Hi Denis, I noticed that when I send +++ - ATH0 during a

[PATCH] emulator: fix dun_ath_cb() not to remove GAtServer io_disconnect() CB

2011-05-19 Thread Guillaume Zajac
--- src/emulator.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index c17b901..251bed8 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -219,15 +219,19 @@ static void dun_ath_cb(GAtServer *server, GAtServerRequestType type,

Re: [PATCH] emulator: fix dun_ath_cb() not to remove GAtServer io_disconnect() CB

2011-05-19 Thread Denis Kenzior
Hi Guillaume, On 05/19/2011 08:03 AM, Guillaume Zajac wrote: --- src/emulator.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index c17b901..251bed8 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -219,15 +219,19 @@

Re: [PATCH 2/4] voicecall: add ATD support for HFP emulator

2011-05-19 Thread Denis Kenzior
Hi Frederic, So, I think that voicecall should return an OFONO_ERROR_TYPE_CME 30, and ofono_emulator_send_final should take care of replying the right string. Nope, you have to take your pick, either CME ERROR: 30, or NO CARRIER. I'd expect most implementations to reply with a NO CARRIER in

Re: [PATCH] voicecall: add +VTS support for HFP emulator

2011-05-19 Thread Denis Kenzior
Hi Frédéric, +static void emulator_vts_cb(struct ofono_emulator *em, + struct ofono_emulator_request *req, void *userdata) +{ + struct ofono_voicecall *vc = userdata; + struct ofono_error result; + const char *str; + + switch

Re: [RFC PATCH 1/2] Add basic Telit UC864-G support:

2011-05-19 Thread Marcel Holtmann
Hi Bernhard, *add a basic plugin based on different ofono plugins *use Telit specific QSS for SIM-state *add verry basic GPS support (usable with gypsy) *add udev support and rules *update Makefile Co-authored-by: Christopher Vogl christopher.v...@hale.at Signed-off-by: Bernhard Guillon

Re: [RFC PATCH 2/2] network-registration.c: implement CIND for Telit UC864-G

2011-05-19 Thread Marcel Holtmann
Hi Bernhard, *UC864 has a incompatible CIND *use specific constants for a KISS callback function *add a Telit specific check for not measurable strength Co-authored-by: Christopher Vogl christopher.v...@hale.at Signed-off-by: Bernhard Guillon bernhard.guil...@hale.at no signed-off-by