Re: [RFC PATCH 3/5] voicecall: implement SSN handling functions

2011-03-14 Thread Andras Domokos
Hi Denis, On 03/11/2011 09:54 PM, ext Denis Kenzior wrote: Hi Andras, +static struct voicecall *voicecall_select(struct ofono_voicecall *vc, + unsigned int id, int code) +{ + struct voicecall *v = NULL; + GSList *l; + + if (id !=

Re: [RFC PATCH 1/3] ssn: remove SSN atom completely

2011-03-04 Thread Andras Domokos
Hi Denis, On 03/03/2011 09:51 PM, ext Denis Kenzior wrote: Hi Andras, On 03/03/2011 10:48 AM, Andras Domokos wrote: --- Makefile.am |6 +- drivers/atmodem/atmodem.c |2 - drivers/atmodem/atmodem.h |3 - drivers/atmodem/ssn.c | 147

Re: [RFC PATCH 2/3] voicecall: add SSN handling functions

2011-03-04 Thread Andras Domokos
Hi Denis, On 03/03/2011 10:03 PM, ext Denis Kenzior wrote: Hi Andras, On 03/03/2011 10:48 AM, Andras Domokos wrote: --- include/types.h |2 + include/voicecall.h |6 ++ src/voicecall.c | 156 +++ 3 files changed, 164

[PATCH 0/5] Voice call SS notifications (4th version)

2011-03-04 Thread Andras Domokos
to AT modem driver (+CSSU and +CSSI notifications) - added voice call SS notification handling to ISI modem driver Andras Domokos (5): ssn: remove SSN atom completely voicecall: add SSN function declarations voicecall: implement SSN handling functions atmodem: implement SSN handling isimodem

[RFC PATCH 2/5] voicecall: add SSN function declarations

2011-03-04 Thread Andras Domokos
--- include/voicecall.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index f00eb08..5e6da02 100644 --- a/include/voicecall.h +++ b/include/voicecall.h @@ -160,6 +160,12 @@ void ofono_voicecall_set_data(struct

[RFC PATCH 4/5] atmodem: implement SSN handling

2011-03-04 Thread Andras Domokos
--- drivers/atmodem/voicecall.c | 61 +++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c index ee055da..7d70c85 100644 --- a/drivers/atmodem/voicecall.c +++

[RFC PATCH 5/5] isimodem: implement SSN handling

2011-03-04 Thread Andras Domokos
--- drivers/isimodem/voicecall.c | 359 ++ 1 files changed, 359 insertions(+), 0 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 9507255..165f3b4 100644 --- a/drivers/isimodem/voicecall.c +++

[PATCH 0/3] Voice call SS notifications (3rd version)

2011-03-03 Thread Andras Domokos
and +CSSI notifications) Andras Domokos (3): ssn: remove SSN atom completely voicecall: add SSN handling functions atmodem: add SSN handling Makefile.am |6 +- drivers/atmodem/atmodem.c |2 - drivers/atmodem/atmodem.h |3 - drivers/atmodem/ssn.c | 147

[RFC PATCH 1/3] ssn: remove SSN atom completely

2011-03-03 Thread Andras Domokos
--- Makefile.am |6 +- drivers/atmodem/atmodem.c |2 - drivers/atmodem/atmodem.h |3 - drivers/atmodem/ssn.c | 147 - drivers/isimodem/isimodem.c |2 - drivers/isimodem/isimodem.h |3 - drivers/isimodem/ssn.c | 95

[RFC PATCH 2/3] voicecall: add SSN handling functions

2011-03-03 Thread Andras Domokos
--- include/types.h |2 + include/voicecall.h |6 ++ src/voicecall.c | 156 +++ 3 files changed, 164 insertions(+), 0 deletions(-) diff --git a/include/types.h b/include/types.h index d25f409..b639c8a 100644 --- a/include/types.h

[RFC PATCH 3/3] atmodem: add SSN handling

2011-03-03 Thread Andras Domokos
--- drivers/atmodem/voicecall.c | 61 +++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c index ee055da..7d70c85 100644 --- a/drivers/atmodem/voicecall.c +++

[PATCH 0/3] Voice call SS notifications (2nd version)

2011-02-28 Thread Andras Domokos
the SS callback functions with call number info and service code, useful in demultiplexing when a common callback function is defined for multiple service codes - added +CSSU and +CSSI type SS notifications handling to the voicecall code Andras Domokos (3): ssn: remove SSN atom ssn: add code

[RFC PATCH 1/3] ssn: remove SSN atom

2011-02-28 Thread Andras Domokos
--- drivers/atmodem/ssn.c |6 +--- include/ssn.h |9 +++ plugins/calypso.c |1 - plugins/g1.c |1 - plugins/huawei.c |1 - plugins/ifx.c |1 - plugins/isiusb.c |1 - plugins/linktop.c |1 - plugins/n900.c|1

[RFC PATCH 2/3] ssn: add code and call id to notifications

2011-02-28 Thread Andras Domokos
--- drivers/atmodem/ssn.c |4 ++-- include/ssn.h |7 --- src/ofono.h |5 +++-- src/ssn.c | 11 ++- 4 files changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/atmodem/ssn.c b/drivers/atmodem/ssn.c index c927bf1..ba8f89a 100644

Re: [RFC PATCH 2/3] ssn: add code and call id to notifications

2011-02-24 Thread Andras Domokos
10, 2011 at 2:42 PM, Andras Domokos andras.domo...@nokia.com mailto:andras.domo...@nokia.com wrote: Hi Denis, On 02/10/2011 05:08 AM, ext Denis Kenzior wrote: Hi Andras, diff --git a/include/ssn.h b/include/ssn.h index d640cad..ba3701b 100644

Re: [RFC PATCH 2/3] ssn: add code and call id to notifications

2011-02-24 Thread Andras Domokos
Hi, On 02/24/2011 05:43 PM, ext Denis Kenzior wrote: Hi Andras, Please no top posting on this mailing list. You should know this by now. I am terribly sorry, I know I should have not done that. On 02/24/2011 05:43 AM, Andras Domokos wrote: Hi Denis and Sankar, The call SS notification

Re: [RFC PATCH 2/3] ssn: add code and call id to notifications

2011-02-24 Thread Andras Domokos
Hi Denis, On 02/24/2011 06:14 PM, ext Denis Kenzior wrote: Hi Andras, The call SS notification handling patches hasn't been (fully) applied, I think we need to do something about it. I'd still like a version with the SSN atom removed. OK, I am going to remove the SSN atom, not a big deal,

Re: [RFC PATCH 1/3] call-barring: removed +CSSI type SS notifications

2011-02-10 Thread Andras Domokos
Hi Denis, On 02/10/2011 05:04 AM, ext Denis Kenzior wrote: Hi Andras On 02/09/2011 04:33 AM, Andras Domokos wrote: --- src/call-barring.c | 74 1 files changed, 0 insertions(+), 74 deletions(-) diff --git a/src/call-barring.c b/src

[PATCH 0/3] Voice call SS notifications

2011-02-09 Thread Andras Domokos
to the voicecall code The API level detailed changes are explained in the doc files. Andras Domokos (3): call-barring: removed +CSSI type SS notifications ssn: add code and call id to notifications voicecall: handle voice call SS notifications drivers/atmodem/ssn.c |4 +- include/ssn.h

[RFC PATCH 1/3] call-barring: removed +CSSI type SS notifications

2011-02-09 Thread Andras Domokos
--- src/call-barring.c | 74 1 files changed, 0 insertions(+), 74 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index 649826e..84ed277 100644 --- a/src/call-barring.c +++ b/src/call-barring.c @@ -58,9 +58,6 @@ struct

[RFC PATCH 2/3] ssn: add code and call id to notifications

2011-02-09 Thread Andras Domokos
--- drivers/atmodem/ssn.c |4 ++-- include/ssn.h |7 --- src/ofono.h |6 -- src/ssn.c | 11 ++- 4 files changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/atmodem/ssn.c b/drivers/atmodem/ssn.c index b7a9df4..b00871d 100644

[RFC PATCH 3/3] voicecall: handle voice call SS notifications

2011-02-09 Thread Andras Domokos
--- include/types.h |2 + src/voicecall.c | 242 ++- 2 files changed, 241 insertions(+), 3 deletions(-) diff --git a/include/types.h b/include/types.h index d25f409..b639c8a 100644 --- a/include/types.h +++ b/include/types.h @@ -96,6 +96,8

Re: [RFC] voicecall API changes (proposal v3)

2011-02-08 Thread Andras Domokos
Hi Denis, On 02/07/2011 09:39 PM, ext Denis Kenzior wrote: Hi Andras, On 02/07/2011 11:09 AM, Andras Domokos wrote: --- doc/call-barring-api.txt | 10 -- doc/voicecall-api.txt| 11 +++ doc/voicecallmanager-api.txt | 25 + 3 files

[RFC] voicecall API changes (proposal v3)

2011-02-07 Thread Andras Domokos
--- doc/call-barring-api.txt | 10 -- doc/voicecall-api.txt| 11 +++ doc/voicecallmanager-api.txt | 26 ++ 3 files changed, 37 insertions(+), 10 deletions(-) diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt index

Re: [RFC] voicecall API changes (proposal v3)

2011-02-07 Thread Andras Domokos
Hi Denis, On 02/07/2011 06:38 PM, ext Denis Kenzior wrote: Hi Andras, + CallForwarded(string type) + + Signal emitted when an outgoing voice call is made and + the call has been redirected to another number due to +

[RFC] voicecall API changes (proposal v3)

2011-02-07 Thread Andras Domokos
--- doc/call-barring-api.txt | 10 -- doc/voicecall-api.txt| 11 +++ doc/voicecallmanager-api.txt | 25 + 3 files changed, 36 insertions(+), 10 deletions(-) diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt index

Re: [RFC] voicecall API changes (proposal 2)

2011-02-03 Thread Andras Domokos
Hi Denis, On 02/02/2011 10:01 PM, ext Denis Kenzior wrote: Hi Andras, + + boolean ForwardedCall + + Contains the indication whether the incoming voice call + is a redirected call due to a call forwarding operation +

[RFC] voicecall API changes (proposal 2)

2011-02-02 Thread Andras Domokos
--- doc/call-barring-api.txt | 10 -- doc/voicecall-api.txt| 17 + doc/voicecallmanager-api.txt | 28 3 files changed, 45 insertions(+), 10 deletions(-) diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt index

Re: [RFC] voice call API changes (proposal)

2011-02-01 Thread Andras Domokos
Hi Denis, On 01/31/2011 09:58 PM, ext Denis Kenzior wrote: Hi Andras, On 01/31/2011 05:56 AM, Andras Domokos wrote: Here is a proposal for expanding the VoiceCallManager interface with call related Supplementary Services signals, and the VoiceCall interface with new properties. --- doc

[RFC] voice call API changes (proposal)

2011-01-31 Thread Andras Domokos
Here is a proposal for expanding the VoiceCallManager interface with call related Supplementary Services signals, and the VoiceCall interface with new properties. --- doc/call-barring-api.txt | 10 -- doc/voicecall-api.txt| 15 +++

Re: [RFC] voicecallmanager-api: call related SS signals (proposal)

2011-01-28 Thread Andras Domokos
Hi Denis, On 01/27/2011 06:01 PM, ext Denis Kenzior wrote: Hi Andras, This becomes a problem when there are multiple calls since it is not possible to determine to which call instance the indication is referring to. This raises the question where/how to show this type of properties? Have

[PATCH 0/4] Emergency Calls

2010-12-20 Thread Andras Domokos
modem to pre emergency call state (last call) - advertise Online property change on D-Bus (if any) - advertise Emergency property change on D-Bus (last call) Andras Domokos (3): modem: add Emergency property modem: move dial request_cb function voicecall: add emergency call handling

[RFC PATCH 1/3] modem: add Emergency property

2010-12-20 Thread Andras Domokos
--- src/dbus.c |7 ++ src/modem.c | 207 ++- src/ofono.h |5 ++ 3 files changed, 216 insertions(+), 3 deletions(-) diff --git a/src/dbus.c b/src/dbus.c index c24615f..3be8d22 100644 --- a/src/dbus.c +++ b/src/dbus.c @@ -345,6

[RFC PATCH 3/3] voicecall: add emergency call handling

2010-12-20 Thread Andras Domokos
--- src/voicecall.c | 122 ++- 1 files changed, 121 insertions(+), 1 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 0120cd0..370f760 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -52,6 +52,7 @@ struct ofono_voicecall

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-10 Thread Andras Domokos
Hi, On 12/10/2010 12:53 AM, ext Marcel Holtmann wrote: Hi Kai, I share the concern for the IO/CPU cost, but I don't think it matters much in which daemon this is done. Especially if some slack is allowed for the timers (which should be the case), ofonod will be scheduled when the CPU is

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Andras Domokos
Hi Marcel, On 12/08/2010 06:12 PM, ext Marcel Holtmann wrote: Hi Andras, Lets take this one step and please explain to me what your requirements and objectives are. I also wanna see a top to bottom from UI down to the modem usage of this API. We need a UI showing total MO

Re: [PATCH 0/3] Long dial string support (2nd)

2010-11-24 Thread Andras Domokos
Hi Denis, On 11/24/2010 12:04 AM, ext Denis Kenzior wrote: Hi Andras, Even if we don't support FDN at this point, there is still a remaining related issue, who we are going to dial numbers like: 12345456p1234# I think the the dial string could still be passed to the voicecall driver

Re: [PATCH 0/3] Long dial string support (2nd)

2010-11-24 Thread Andras Domokos
Hi Rajesh, On 11/22/2010 10:58 PM, ext rajesh.naga...@elektrobit.com wrote: Hi Andras, Dial strings can now be as long as 120 digits (not counting '+'). This feature is going to be needed by the FDN feature. An FDN may consist of a phone number plus a DTMF string. In order to have the

Re: [RFC PATCH 2/4] modem: add EmergencyMode property

2010-11-24 Thread Andras Domokos
Hi Denis, On 11/23/2010 10:46 AM, ext Denis Kenzior wrote: Hi Andras, On 11/15/2010 10:57 AM, Andras Domokos wrote: From: Andras Domokosandras.domo...@nokia.com --- src/modem.c | 134 +++ src/ofono.h |4 ++ 2 files changed

Re: [RFC PATCH 4/4] voicecall: add emergency call handling

2010-11-24 Thread Andras Domokos
Hi Denis, On 11/23/2010 11:00 AM, ext Denis Kenzior wrote: Hi Andras, On 11/15/2010 10:58 AM, Andras Domokos wrote: --- src/voicecall.c | 111 ++- 1 files changed, 110 insertions(+), 1 deletions(-) diff --git a/src/voicecall.c b/src

[RFC PATCH 2/4] modem: add EmergencyMode property

2010-11-24 Thread Andras Domokos
--- src/dbus.c |7 +++ src/modem.c | 137 +++ src/ofono.h |5 ++ 3 files changed, 149 insertions(+), 0 deletions(-) diff --git a/src/dbus.c b/src/dbus.c index ad29241..0b4fc06 100644 --- a/src/dbus.c +++ b/src/dbus.c @@ -348,6

Re: [PATCH 0/3] Long dial string support (2nd)

2010-11-23 Thread Andras Domokos
On 11/23/2010 07:41 PM, ext Denis Kenzior wrote: On 11/22/2010 10:36 AM, Andras Domokos wrote: Dial strings can now be as long as 120 digits (not counting '+'). This feature is going to be needed by the FDN feature. An FDN may consist of a phone number plus a DTMF string. In order to have

[PATCH 0/5] Call Counters (2nd)

2010-11-22 Thread Andras Domokos
and clearing the counters. Andras Domokos (5): history: expand history API include file history: expand history API voicecall: take into use the new history function plugins: add call counters doc: call counters API doc Makefile.am |3 + doc/callcounters-api.txt | 18

[RFC PATCH 2/5] history: expand history API

2010-11-22 Thread Andras Domokos
--- src/history.c | 24 src/ofono.h |4 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/src/history.c b/src/history.c index 0229cf5..31efadb 100644 --- a/src/history.c +++ b/src/history.c @@ -114,6 +114,30 @@ void

[RFC PATCH 3/5] voicecall: take into use the new history function

2010-11-22 Thread Andras Domokos
--- src/voicecall.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index bd64432..b40d284 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -630,6 +630,7 @@ static void voicecall_emit_multiparty(struct voicecall *call, gboolean

[RFC PATCH 1/3] common: add long dial string support

2010-11-22 Thread Andras Domokos
--- include/types.h |2 +- src/common.c| 38 +- src/common.h|1 + 3 files changed, 35 insertions(+), 6 deletions(-) diff --git a/include/types.h b/include/types.h index ba2481f..b3d2247 100644 --- a/include/types.h +++ b/include/types.h @@

[RFC PATCH 3/3] isimodem/voicecall: add long dial string support

2010-11-22 Thread Andras Domokos
--- drivers/isimodem/voicecall.c | 83 +- 1 files changed, 65 insertions(+), 18 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index c3365f6..b0dad72 100644 --- a/drivers/isimodem/voicecall.c +++

[RFC PATCH 2/3] voicecall: add long dial string support

2010-11-22 Thread Andras Domokos
--- src/voicecall.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index bd64432..4022f36 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -408,7 +408,7 @@ static DBusMessage *voicecall_deflect(DBusConnection *conn,

[RFC PATCH 2/2] isimodem/voicecall: add long dial string support

2010-11-16 Thread Andras Domokos
--- drivers/isimodem/voicecall.c | 83 +- 1 files changed, 65 insertions(+), 18 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index c3365f6..b0dad72 100644 --- a/drivers/isimodem/voicecall.c +++

[RFC PATCH 1/2] common: add long dial string support

2010-11-16 Thread Andras Domokos
--- include/types.h |2 +- src/common.c| 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/types.h b/include/types.h index ba2481f..b3d2247 100644 --- a/include/types.h +++ b/include/types.h @@ -76,7 +76,7 @@ struct ofono_error { int error;

[PATCH 0/5] Call Counters

2010-11-15 Thread Andras Domokos
and clearing the counters. Andras Domokos (5): history: expand history API include file history: expand history API voicecall: take into use the new history function voicecall: add call counters Makefile: add call counters to the build Makefile.am|3 + include/history.h |3

[RFC PATCH 2/5] history: expand history API

2010-11-15 Thread Andras Domokos
--- src/history.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/src/history.c b/src/history.c index 0229cf5..31efadb 100644 --- a/src/history.c +++ b/src/history.c @@ -114,6 +114,30 @@ void __ofono_history_probe_drivers(struct ofono_modem

[RFC PATCH 1/5] history: expand history API include file

2010-11-15 Thread Andras Domokos
--- include/history.h |3 +++ src/ofono.h |4 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/history.h b/include/history.h index c1c4aa1..a2490f6 100644 --- a/include/history.h +++ b/include/history.h @@ -49,6 +49,9 @@ struct ofono_history_driver {

Re: [PATCH 0/4] Emergency Calls (3rd round)

2010-11-15 Thread Andras Domokos
Hi Frederic, I found a small issue in these patches, resulting into improper handling of the emergency calls for the non-SIM cases, but now that has been fixed and I am going to create a new set of patches. The answer to your question is yes, emergency calls will be also possible without a

[RFC PATCH 4/4] voicecall: add emergency call handling

2010-11-15 Thread Andras Domokos
--- src/voicecall.c | 111 ++- 1 files changed, 110 insertions(+), 1 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 3af614b..066cdb9 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -52,6 +52,7 @@ struct ofono_voicecall

[RFC PATCH 1/4] modem: add modem online-offline watch

2010-11-15 Thread Andras Domokos
From: Andras Domokos andras.domo...@nokia.com --- src/modem.c | 46 ++ src/ofono.h |8 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 3776461..f73cc1d 100644 --- a/src/modem.c +++ b/src

[RFC PATCH 2/4] modem: add EmergencyMode property

2010-11-13 Thread Andras Domokos
From: Andras Domokos andras.domo...@nokia.com --- src/modem.c | 132 +++ src/ofono.h |4 ++ 2 files changed, 136 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index f73cc1d..5315e72 100644 --- a/src/modem.c

[RFC PATCH 1/4] modem: add modem online-offline watch

2010-11-13 Thread Andras Domokos
From: Andras Domokos andras.domo...@nokia.com --- src/modem.c | 46 ++ src/ofono.h |8 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 3776461..f73cc1d 100644 --- a/src/modem.c +++ b/src

Re: [RFC PATCH 2/3] modem: add EmergencyMode property

2010-11-10 Thread Andras Domokos
Hi Denis, On 11/09/2010 04:37 PM, ext Denis Kenzior wrote: Hi Andras, On 11/09/2010 02:59 AM, Andras Domokos wrote: Signed-off-by: Andras Domokosandras.domo...@nokia.com --- src/modem.c | 53 + src/ofono.h |4 2 files

[PATCH 0/3] Emergency Calls (2nd round)

2010-11-09 Thread Andras Domokos
From: Andras Domokos andras.domo...@nokia.com Here is a new proposal for emergency calls handling. Steps in handling emergency calls: - subscribe to modem online notifications (add modem online watcher) - an emergency call detected (phone number is emergency number) - increment emergency mode

[RFC PATCH 1/3] modem: add modem online-offline watch

2010-11-09 Thread Andras Domokos
Signed-off-by: Andras Domokos andras.domo...@nokia.com --- src/modem.c | 46 ++ src/ofono.h |8 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 3776461..f73cc1d 100644 --- a/src/modem.c

[RFC PATCH 2/3] modem: add EmergencyMode property

2010-11-09 Thread Andras Domokos
Signed-off-by: Andras Domokos andras.domo...@nokia.com --- src/modem.c | 53 + src/ofono.h |4 2 files changed, 57 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index f73cc1d..d7ad90e 100644 --- a/src/modem.c

[RFC PATCH 3/3] voicecall: add emergency call handling

2010-11-09 Thread Andras Domokos
Signed-off-by: Andras Domokos andras.domo...@nokia.com --- src/voicecall.c | 101 ++- 1 files changed, 100 insertions(+), 1 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index bd64432..0268ce1 100644 --- a/src/voicecall.c +++ b

Re: [RFC PATCH 2/3] voicecall: emergency call handling added

2010-11-01 Thread Andras Domokos
Hi Denis, On 10/29/2010 08:32 PM, ext Denis Kenzior wrote: Hi Andras, Just some general comments, but this patch seems to be backwards from the earlier proposal. Namely EmergencyMode is a property on the Modem interface, not on the VoiceCallManager. See doc/modem-api.txt, Emergency

Re: [RFC PATCH 2/3] voicecall: emergency call handling added

2010-10-29 Thread Andras Domokos
Hi Denis, Thank you for your comments, here is my response. On 10/28/2010 06:48 AM, ext Denis Kenzior wrote: Hi Andras, On 10/25/2010 03:03 AM, Andras Domokos wrote: From: Andras Domokosandras.domo...@nokia.com Signed-off-by: Andras Domokosandras.domo...@nokia.com --- include

Call counters proposal (TODO patch)

2010-10-25 Thread Andras Domokos
and incoming call duration information. + Separate call counters will be maintained for each SIM card. Call counters + can be read and reset to 0, and must be backed up periodically to a + non-volatile storage place. + + Priority: Medium + Complexity: C2 + Owner: Andras Domokos andras.domo

Emergency Calls

2010-10-22 Thread Andras Domokos
to know when the modem reached the online state, if a modem state change to online was necessary. The important details are in the patches. Cheers, Andras Andras Domokos (3): modem: modem state watch added voicecall: emergency call handling added modem: emergency state handling added include

[RFC PATCH 1/3] modem: modem state watch added

2010-10-22 Thread Andras Domokos
Signed-off-by: Andras Domokos andras.domo...@nokia.com --- src/modem.c | 64 +++--- src/ofono.h | 15 + 2 files changed, 67 insertions(+), 12 deletions(-) diff --git a/src/modem.c b/src/modem.c index 7a29edf..9aeb49c 100644

[RFC PATCH 2/3] voicecall: emergency call handling added

2010-10-22 Thread Andras Domokos
Signed-off-by: Andras Domokos andras.domo...@nokia.com --- include/voicecall.h | 12 +++ src/voicecall.c | 221 ++ 2 files changed, 215 insertions(+), 18 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index 2356fcf

[RFC PATCH 3/3] modem: emergency state handling added

2010-10-22 Thread Andras Domokos
Signed-off-by: Andras Domokos andras.domo...@nokia.com --- src/modem.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 9aeb49c..9e96cce 100644 --- a/src/modem.c +++ b/src/modem.c @@ -70,6 +70,8