[PATCH] cdma-voicecall: Fix for crash when unregistering atom

2011-06-13 Thread Dara Spieker-Doyle
--- src/cdma-voicecall.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/cdma-voicecall.c b/src/cdma-voicecall.c index a590063..2bdf850 100644 --- a/src/cdma-voicecall.c +++ b/src/cdma-voicecall.c @@ -335,6 +335,18 @@ void

Re: [PATCH] cdma-voicecall: Fix for crash when unregistering atom

2011-06-13 Thread Dara Spieker-Doyle
On 06/13/2011 03:37 PM, Dara Spieker-Doyle wrote: --- src/cdma-voicecall.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/cdma-voicecall.c b/src/cdma-voicecall.c index a590063..2bdf850 100644 --- a/src/cdma-voicecall.c +++ b/src/cdma-voicecall.c

[PATCH v2] cdma-voicecall: Fix for crash when unregistering atom

2011-06-13 Thread Dara Spieker-Doyle
--- src/cdma-voicecall.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/cdma-voicecall.c b/src/cdma-voicecall.c index a590063..183433d 100644 --- a/src/cdma-voicecall.c +++ b/src/cdma-voicecall.c @@ -335,6 +335,18 @@ void

Re: [PATCH 5/7] cdmamodem: Add Signal Strength Support

2011-02-09 Thread Dara Spieker-Doyle
Hi Rajesh On 02/09/2011 02:58 PM, ext rajesh.naga...@elektrobit.com wrote: Hi Dara, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Dara Spieker-Doyle Sent: 08 February 2011 13:05 To: ofono@ofono.org Subject: [PATCH 5/7] cdmamodem: Add

[PATCH 1/7] gatchat: Share utility with CDMA network driver

2011-02-08 Thread Dara Spieker-Doyle
--- gatchat/gatresult.c | 11 --- gatchat/gatresult.h | 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gatchat/gatresult.c b/gatchat/gatresult.c index 8a6dfae..6bd3ff1 100644 --- a/gatchat/gatresult.c +++ b/gatchat/gatresult.c @@ -94,17 +94,6 @@ const

[PATCH 0/7] Add CDMA Signal Strength Support

2011-02-08 Thread Dara Spieker-Doyle
(such as the signal strength) is not available while the port is busy with e.g. data traffic. Support for handling these scenarios is future work. Dara Spieker-Doyle (7): gatchat: Share utility with CDMA network driver dbus: Add CDMA netreg atom support cdma-netreg: Add Signal Strength Support cdma

[PATCH 2/7] dbus: Add CDMA netreg atom support

2011-02-08 Thread Dara Spieker-Doyle
--- include/dbus.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 19a138a..3e80c36 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -60,6 +60,8 @@ extern C { /* CDMA Interfaces */ #define OFONO_CDMA_VOICECALL_MANAGER_INTERFACE

[PATCH 3/7] cdma-netreg: Add Signal Strength Support

2011-02-08 Thread Dara Spieker-Doyle
--- Makefile.am |2 +- include/cdma-netreg.h | 77 + 2 files changed, 78 insertions(+), 1 deletions(-) create mode 100644 include/cdma-netreg.h diff --git a/Makefile.am b/Makefile.am index 758fb10..93550d0 100644 --- a/Makefile.am

[PATCH 4/7] cdma-netreg: Add Signal Strength Support

2011-02-08 Thread Dara Spieker-Doyle
--- Makefile.am|3 +- src/cdma-network.c | 263 src/ofono.h|2 + 3 files changed, 267 insertions(+), 1 deletions(-) create mode 100644 src/cdma-network.c diff --git a/Makefile.am b/Makefile.am index 93550d0..c245b4c

[PATCH 6/7] nokiacdma: Add cdma-netreg Support

2011-02-08 Thread Dara Spieker-Doyle
--- plugins/nokiacdma.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/nokiacdma.c b/plugins/nokiacdma.c index 7bd224d..946c1f2 100644 --- a/plugins/nokiacdma.c +++ b/plugins/nokiacdma.c @@ -44,6 +44,7 @@ #include drivers/atmodem/atutil.h #include

[PATCH 5/7] cdmamodem: Add Signal Strength Support

2011-02-08 Thread Dara Spieker-Doyle
--- Makefile.am |3 +- drivers/cdmamodem/cdmamodem.c|2 + drivers/cdmamodem/cdmamodem.h|2 + drivers/cdmamodem/network-registration.c | 211 ++ 4 files changed, 217 insertions(+), 1 deletions(-) create

[PATCH 7/7] test: Add CDMA Signal Strength Support

2011-02-08 Thread Dara Spieker-Doyle
--- Makefile.am |3 ++- test/cdma-get-current-network-signal-strength | 21 + 2 files changed, 23 insertions(+), 1 deletions(-) create mode 100755 test/cdma-get-current-network-signal-strength diff --git a/Makefile.am b/Makefile.am

[PATCH] TODO: minor style fix

2011-02-08 Thread Dara Spieker-Doyle
Bad caps --- TODO |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/TODO b/TODO index 13a6baa..9bd21d6 100644 --- a/TODO +++ b/TODO @@ -590,7 +590,7 @@ CDMA CMAS Priority: Medium Complexity: C4 -CDMA NETWORK ACQUISITION +CDMA Network Acquisition

Re: [PATCH] doc: Add modem Type property

2011-02-03 Thread Dara Spieker-Doyle
Hi Gustavo On 02/03/2011 11:25 AM, ext Gustavo F. Padovan wrote: Hi Dara, * Dara Spieker-Doyledara.spieker-do...@nokia.com [2011-01-20 14:48:57 -0800]: Add support for providing the type of the attached modem device including GSM (3GPP), CDMA (3GPP2) and Bluetooth HFP. ---

Re: [PATCH] doc: Add modem Type property

2011-01-21 Thread Dara Spieker-Doyle
Hi Gustavo and Denis On 01/21/2011 12:25 PM, ext Gustavo F. Padovan wrote: Hi Denis, * Denis Kenziordenk...@gmail.com [2011-01-21 14:15:46 -0600]: Hi Dara, On 01/20/2011 04:48 PM, Dara Spieker-Doyle wrote: Add support for providing the type of the attached modem device including GSM (3GPP

[RFC 1/1] doc: Add modem technology type property

2011-01-20 Thread Dara Spieker-Doyle
--- doc/modem-api.txt | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/doc/modem-api.txt b/doc/modem-api.txt index 45043b0..fe03833 100644 --- a/doc/modem-api.txt +++ b/doc/modem-api.txt @@ -82,6 +82,17 @@ Properties boolean Powered [readwrite]

[RFC 0/1] Add modem technology type property

2011-01-20 Thread Dara Spieker-Doyle
the potential for more such use cases in the future and look forward to comments/discussion regarding our options. Thank you Dara Spieker-Doyle (1): doc: Add modem technology type property doc/modem-api.txt | 11 +++ 1 files changed, 11 insertions(+), 0 deletions

Re: [RFC 1/1] doc: Add modem technology type property

2011-01-20 Thread Dara Spieker-Doyle
Hi Marcel On 01/20/2011 01:34 PM, ext Marcel Holtmann wrote: Hi Dara, doc/modem-api.txt | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/doc/modem-api.txt b/doc/modem-api.txt index 45043b0..fe03833 100644 --- a/doc/modem-api.txt +++ b/doc/modem-api.txt @@

Re: [RFC 1/1] doc: Add modem technology type property

2011-01-20 Thread Dara Spieker-Doyle
Hi Marcel On 01/20/2011 02:05 PM, ext Marcel Holtmann wrote: Thanks - sounds good to me. I'll prepare a patch to reflect this for gsm/cdma types and assume the hfp type extension is future work. not really. Actually HFP support is part of oFono already. Sorry - I meant hfp as an

[PATCH] doc: Add modem Type property

2011-01-20 Thread Dara Spieker-Doyle
Add support for providing the type of the attached modem device including GSM (3GPP), CDMA (3GPP2) and Bluetooth HFP. --- doc/modem-api.txt | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/doc/modem-api.txt b/doc/modem-api.txt index 45043b0..fe806c8 100644 ---

[PATCH] cdmamodem: fix to follow oFono probe rules

2011-01-14 Thread Dara Spieker-Doyle
Not allowed to call register directly from probe, use g_idle_add instead for now --- drivers/cdmamodem/voicecall.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/cdmamodem/voicecall.c b/drivers/cdmamodem/voicecall.c index a0fa79f..94ec74b 100644 ---

Re: [PATCH v5, 2/5] test: Add CDMA MO Call Support

2011-01-13 Thread Dara Spieker-Doyle
Hi Denis On 01/12/2011 09:25 PM, ext Denis Kenzior wrote: Hi Dara, On 01/10/2011 07:45 PM, Dara Spieker-Doyle wrote: --- Makefile.am |5 - test/cdma-dial-number | 25 + test/cdma-hangup | 20 test/cdma-list-call

Re: [PATCH 2/3] cdmamodem: Add CDMA devinfo support

2011-01-13 Thread Dara Spieker-Doyle
Hi Denis On 01/12/2011 10:03 PM, ext Denis Kenzior wrote: Hi Dara, On 01/11/2011 03:45 PM, Dara Spieker-Doyle wrote: --- Makefile.am |3 +- drivers/cdmamodem/cdmamodem.c |2 + drivers/cdmamodem/cdmamodem.h |2 + drivers/cdmamodem/devinfo.c | 169

[PATCH v6] test: Add CDMA MO Call Support

2011-01-13 Thread Dara Spieker-Doyle
Rebasing and adding CDMA MO Call test scripts --- Makefile.am |5 - test/cdma-dial-number | 24 test/cdma-hangup | 20 test/cdma-list-call | 25 + 4 files changed, 73 insertions(+), 1 deletions(-)

[PATCH v2, 2/2] nokiacdma: Add CDMA devinfo support

2011-01-13 Thread Dara Spieker-Doyle
--- plugins/nokiacdma.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/plugins/nokiacdma.c b/plugins/nokiacdma.c index e05c012..7bd224d 100644 --- a/plugins/nokiacdma.c +++ b/plugins/nokiacdma.c @@ -43,6 +43,7 @@ #include drivers/atmodem/atutil.h #include

[PATCH v2, 0/2] Add CDMA devinfo support

2011-01-13 Thread Dara Spieker-Doyle
. These patches have been tested against the Nokia 7205 CDMA device in a tethered mode. Dara Spieker-Doyle (2): cdmamodem: Add CDMA devinfo support nokiacdma: Add CDMA devinfo support Makefile.am |3 +- drivers/cdmamodem/cdmamodem.c |2 + drivers/cdmamodem/cdmamodem.h |2

[PATCH] cdmamodem: M15 Coding style fix

2011-01-13 Thread Dara Spieker-Doyle
--- drivers/cdmamodem/cdmamodem.h |4 ++-- drivers/cdmamodem/voicecall.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/cdmamodem/cdmamodem.h b/drivers/cdmamodem/cdmamodem.h index b085541..5011ade 100644 --- a/drivers/cdmamodem/cdmamodem.h +++

[PATCH 0/3] Add CDMA devinfo support

2011-01-11 Thread Dara Spieker-Doyle
tested against the Nokia 7205 CDMA device in a tethered mode. Limitations --- Patches 2/3 and 3/3 are dependent on acceptance of the CDMA MO Voicecall v5 patch series. Dara Spieker-Doyle (3): atmodem: Share common devinfo utilities cdmamodem: Add CDMA devinfo support nokiacdma: Add

[PATCH 1/3] atmodem: Share common devinfo utilities

2011-01-11 Thread Dara Spieker-Doyle
--- drivers/atmodem/atutil.c | 56 ++ drivers/atmodem/atutil.h |2 + drivers/atmodem/devinfo.c | 59 +++- 3 files changed, 62 insertions(+), 55 deletions(-) diff --git a/drivers/atmodem/atutil.c

[PATCH 2/3] cdmamodem: Add CDMA devinfo support

2011-01-11 Thread Dara Spieker-Doyle
--- Makefile.am |3 +- drivers/cdmamodem/cdmamodem.c |2 + drivers/cdmamodem/cdmamodem.h |2 + drivers/cdmamodem/devinfo.c | 169 + 4 files changed, 175 insertions(+), 1 deletions(-) create mode 100644

Re: [PATCH v4, 3/5] nokiacdma: Add plugin and CDMA MO Call Support

2011-01-10 Thread Dara Spieker-Doyle
Hi Denis On 01/10/2011 02:39 PM, ext Denis Kenzior wrote: Hi Dara, +static void nokiacdma_remove(struct ofono_modem *modem) +{ + struct nokiacdma_data *data = ofono_modem_get_data(modem); + + DBG(%p, modem); + + ofono_modem_set_data(modem, NULL); + + if (data-chat) +

Re: [PATCH v3, Part2, 3/3] udev: Add nokiacdma device

2011-01-03 Thread Dara Spieker-Doyle
Hi Denis On 12/22/2010 06:23 PM, ext Denis Kenzior wrote: Hi Dara, On 12/21/2010 01:23 PM, Dara Spieker-Doyle wrote: --- plugins/udev.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 255755e..9447e5c

[PATCH v4, 0/5] Add nokiacdma plugin and CDMA MO Call support

2011-01-03 Thread Dara Spieker-Doyle
have been tested against the Nokia 7205 CDMA device in a tethered mode. Limitations --- The Nokia 7205 device does not support an AT interface for reporting request responses, such as the call status and remote/network disconnect reasons, so these are currently untested. Dara Spieker

[PATCH v4, 1/5] cdmamodem: Add CDMA MO Call support

2011-01-03 Thread Dara Spieker-Doyle
--- Makefile.am |3 +- drivers/cdmamodem/cdmamodem.c |3 + drivers/cdmamodem/cdmamodem.h |3 + drivers/cdmamodem/voicecall.c | 160 + 4 files changed, 168 insertions(+), 1 deletions(-) create mode 100644

[PATCH v4, 2/5] test: Add CDMA MO Call Support

2011-01-03 Thread Dara Spieker-Doyle
--- Makefile.am |5 - test/cdma-dial-number | 25 + test/cdma-hangup | 20 test/cdma-list-call | 31 +++ 4 files changed, 80 insertions(+), 1 deletions(-) create mode 100755

[PATCH v4, 4/5] ofono-rules: Add nokiacdma device

2011-01-03 Thread Dara Spieker-Doyle
--- plugins/ofono.rules |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index 770834f..65ab7e2 100644 --- a/plugins/ofono.rules +++ b/plugins/ofono.rules @@ -432,4 +432,8 @@ ATTRS{idVendor}==0421, ATTRS{idProduct}==060e,

[PATCH v4, 3/5] nokiacdma: Add plugin and CDMA MO Call Support

2011-01-03 Thread Dara Spieker-Doyle
--- Makefile.am |3 + plugins/nokiacdma.c | 198 +++ 2 files changed, 201 insertions(+), 0 deletions(-) create mode 100644 plugins/nokiacdma.c diff --git a/Makefile.am b/Makefile.am index 4139863..8572efc 100644 --- a/Makefile.am +++

[PATCH v4, 5/5] udev: Add nokiacdma device

2011-01-03 Thread Dara Spieker-Doyle
--- plugins/udev.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 6a59b06..12402eb 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -462,6 +462,20 @@ static void add_calypso(struct ofono_modem *modem,

Re: [PATCH v3, Part1, 2/5] cdma-voicecall: Add CDMA MO Call Support

2010-12-23 Thread Dara Spieker-Doyle
Hi Denis On 12/22/2010 05:36 PM, ext Denis Kenzior wrote: Hi Dara, On 12/20/2010 07:36 PM, Dara Spieker-Doyle wrote: --- Makefile.am |3 +- src/cdma-voicecall.c | 430 ++ src/common.c | 41 + src/common.h

Re: [PATCH v3, Part1, 4/5] cdmamodem: Add CDMA voicecall driver support for MO Call

2010-12-23 Thread Dara Spieker-Doyle
Hi Denis Thank you for reviewing these. On 12/22/2010 05:26 PM, ext Denis Kenzior wrote: Hi Dara, snip + +struct voicecall_driver { + struct ofono_cdma_voicecall *vc; + unsigned int local_release; What is the use of these two variables? + GAtChat *chat; +

Re: [PATCH v3, Part1, 5/5] test: Add CDMA MO Call Support

2010-12-23 Thread Dara Spieker-Doyle
Hi Denis On 12/22/2010 05:31 PM, ext Denis Kenzior wrote: Hi Dara, On 12/20/2010 07:36 PM, Dara Spieker-Doyle wrote: --- Makefile.am |5 - test/cdma-dial-number | 24 test/cdma-hangup | 20 test/cdma-list-call

Re: [PATCH v3, Part2, 1/3] nokiacdma: Add plugin and CDMA MO Call Support

2010-12-23 Thread Dara Spieker-Doyle
Hi Denis On 12/22/2010 06:31 PM, ext Denis Kenzior wrote: Hi Dara, snip +struct nokiacdma_data { + GAtChat *chat; + ofono_bool_t online; + ofono_bool_t registration_status; What is the purpose of the above two variables? snip +static void nokiacdma_disconnect(gpointer

[PATCH] TODO: Add CDMA network and voicecall tasks

2010-12-22 Thread Dara Spieker-Doyle
--- a/TODO +++ b/TODO @@ -475,7 +475,6 @@ CDMA Voicecall Priority: High Complexity: C2 - Owner: Dara Spieker-Doyle dara.spieker-do...@nokia.com - Add support for Call Waiting over a CDMA network. Call Waiting (CW) provides notification of an incoming call to an originating subscriber

Re: [PATCH v2 7/9] ofono-rules: Add cdmagen device

2010-12-21 Thread Dara Spieker-Doyle
Hi Marcel On 12/21/2010 06:23 AM, ext Marcel Holtmann wrote: so calling this driver nokiacdma sounds a bit better to me. It makes it clear that the device is from Nokia. If you wanna shotcut it into nokcdma then that is also fine with me, but it should reflect what it is. Ok, I see. I'll

[PATCH v3, Part2, 1/3] nokiacdma: Add plugin and CDMA MO Call Support

2010-12-21 Thread Dara Spieker-Doyle
--- Makefile.am |3 + plugins/nokiacdma.c | 275 +++ 2 files changed, 278 insertions(+), 0 deletions(-) create mode 100644 plugins/nokiacdma.c diff --git a/Makefile.am b/Makefile.am index 32ded3d..74b6759 100644 --- a/Makefile.am +++

[PATCH v3, Part2, 2/3] ofono-rules: Add nokiacdma device

2010-12-21 Thread Dara Spieker-Doyle
--- plugins/ofono.rules |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index 9369566..a5ceb69 100644 --- a/plugins/ofono.rules +++ b/plugins/ofono.rules @@ -432,4 +432,8 @@ ATTRS{idVendor}==0421, ATTRS{idProduct}==060e,

[PATCH v3, Part2, 3/3] udev: Add nokiacdma device

2010-12-21 Thread Dara Spieker-Doyle
--- plugins/udev.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 255755e..9447e5c 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -449,6 +449,25 @@ static void add_isi(struct ofono_modem *modem,

[PATCH v3, Part2, 0/3] Add nokiacdma plugin and CDMA MO Call support

2010-12-21 Thread Dara Spieker-Doyle
status and remote/network disconnect reasons, so these are currently untested. Dara Spieker-Doyle (3): nokiacdma: Add plugin and CDMA MO Call Support ofono-rules: Add nokiacdma device udev: Add nokiacdma device Makefile.am | 20 ++- plugins/nokiacdma.c | 275

Re: [PATCH v2 8/9] udev: Add cdmagen

2010-12-20 Thread Dara Spieker-Doyle
Hi Marcel Thank you for reviewing these patches On 12/18/2010 10:29 AM, ext Marcel Holtmann wrote: Hi Dara, struct ofono_modem *modem; @@ -533,6 +552,8 @@ done: add_isi(modem, udev_device); else if (g_strcmp0(driver, n900) == 0) add_isi(modem,

Re: [PATCH v2 7/9] ofono-rules: Add cdmagen device

2010-12-20 Thread Dara Spieker-Doyle
Hi Marcel On 12/18/2010 10:31 AM, ext Marcel Holtmann wrote: Hi Dara, plugins/ofono.rules |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index da8a8ef..34698f0 100644 --- a/plugins/ofono.rules +++ b/plugins/ofono.rules

Re: [PATCH v2 3/9] cdma-voicecall: Add CDMA MO Call Support

2010-12-20 Thread Dara Spieker-Doyle
Hi Denis Thank you for reviewing these patches. I will submit new versions for your comments, please see any open points inline. On 12/20/2010 12:50 PM, ext Denis Kenzior wrote: + */ + +#ifndef __OFONO_CDMA_VOICECALL_H +#define __OFONO_CDMA_VOICECALL_H + +#ifdef __cplusplus +extern C {

Re: [PATCH v2 4/9] cdma-voicecall: Add CDMA MO Call Support

2010-12-20 Thread Dara Spieker-Doyle
Hi Denis On 12/20/2010 01:01 PM, ext Denis Kenzior wrote: + +static const char *voicecall_build_path(struct ofono_cdma_voicecall_manager *vc) +{ + static char path[256]; + + snprintf(path, sizeof(path), %s/voicecall, + __ofono_atom_get_path(vc-atom)); I'm still

[PATCH v3, Part1, 0/5] Add CDMA MO Call Support

2010-12-20 Thread Dara Spieker-Doyle
--- The Nokia 7205 device does not support an AT interface for reporting request responses, such as the call status and remote/network disconnect reasons, so these are currently untested. Dara Spieker-Doyle (5): cdma-voicecall: Add CDMA MO Call Support cdma-voicecall: Add CDMA MO Call

[PATCH v3, Part1, 1/5] cdma-voicecall: Add CDMA MO Call Support

2010-12-20 Thread Dara Spieker-Doyle
--- Makefile.am |2 +- include/cdma-voicecall.h | 89 ++ 2 files changed, 90 insertions(+), 1 deletions(-) create mode 100644 include/cdma-voicecall.h diff --git a/Makefile.am b/Makefile.am index 12b3c33..1270be5 100644 ---

[PATCH v3, Part1, 2/5] cdma-voicecall: Add CDMA MO Call Support

2010-12-20 Thread Dara Spieker-Doyle
--- Makefile.am |3 +- src/cdma-voicecall.c | 430 ++ src/common.c | 41 + src/common.h |6 + src/ofono.h |3 + 5 files changed, 482 insertions(+), 1 deletions(-) create mode 100644

[PATCH v3, Part1, 3/5] cdmamodem: Add cdmamodem stubs

2010-12-20 Thread Dara Spieker-Doyle
--- Makefile.am |6 + configure.ac |5 drivers/cdmamodem/cdmamodem.c | 45 + drivers/cdmamodem/cdmamodem.h | 22 4 files changed, 78 insertions(+), 0 deletions(-) create mode

[PATCH v3, Part1, 5/5] test: Add CDMA MO Call Support

2010-12-20 Thread Dara Spieker-Doyle
--- Makefile.am |5 - test/cdma-dial-number | 24 test/cdma-hangup | 20 test/cdma-list-call | 30 ++ 4 files changed, 78 insertions(+), 1 deletions(-) create mode 100755

[PATCH v2 3/9] cdma-voicecall: Add CDMA MO Call Support

2010-12-17 Thread Dara Spieker-Doyle
--- Makefile.am |2 +- include/cdma-voicecall.h | 89 ++ 2 files changed, 90 insertions(+), 1 deletions(-) create mode 100644 include/cdma-voicecall.h diff --git a/Makefile.am b/Makefile.am index 12b3c33..1270be5 100644 ---

[PATCH v2 0/9] Add CDMA MO Call Support

2010-12-17 Thread Dara Spieker-Doyle
been tested against the Nokia 7205 CDMA device in a tethered mode. Limitations --- The Nokia 7205 device does not support an AT interface for reporting request responses, such as the call status and remote/network disconnect reasons, so these are currently untested. Dara Spieker-Doyle (9

[PATCH v2 1/9] dbus: Add CDMA Voicecall Interface

2010-12-17 Thread Dara Spieker-Doyle
--- include/dbus.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 9e29afb..c527515 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -55,6 +55,9 @@ extern C { #define OFONO_STK_INTERFACE OFONO_SERVICE .SimToolkit #define

[PATCH v2 6/9] cdmagen: Add CDMA MO Call Support

2010-12-17 Thread Dara Spieker-Doyle
--- Makefile.am |3 + plugins/cdmagen.c | 274 + 2 files changed, 277 insertions(+), 0 deletions(-) create mode 100644 plugins/cdmagen.c diff --git a/Makefile.am b/Makefile.am index 50e893f..9949bcc 100644 --- a/Makefile.am +++

[PATCH v2 5/9] cdmamodem: Add CDMA MO Call Support

2010-12-17 Thread Dara Spieker-Doyle
--- Makefile.am |7 ++ configure.ac |5 + drivers/cdmamodem/cdmamodem.c | 48 ++ drivers/cdmamodem/cdmamodem.h | 25 ++ drivers/cdmamodem/voicecall.c | 190 + 5 files changed, 275 insertions(+), 0

[PATCH v2 4/9] cdma-voicecall: Add CDMA MO Call Support

2010-12-17 Thread Dara Spieker-Doyle
--- Makefile.am |3 +- src/cdma-voicecall.c | 444 ++ src/common.c | 41 + src/common.h |6 + src/ofono.h |3 + 5 files changed, 496 insertions(+), 1 deletions(-) create mode 100644

[PATCH v2 7/9] ofono-rules: Add cdmagen device

2010-12-17 Thread Dara Spieker-Doyle
--- plugins/ofono.rules |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index da8a8ef..34698f0 100644 --- a/plugins/ofono.rules +++ b/plugins/ofono.rules @@ -429,6 +429,10 @@ ATTRS{idVendor}==0930, ATTRS{idProduct}==1311,

[PATCH v2 8/9] udev: Add cdmagen

2010-12-17 Thread Dara Spieker-Doyle
--- plugins/udev.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 255755e..e9541ac 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -449,6 +449,25 @@ static void add_isi(struct ofono_modem *modem,

[PATCH v2 2/9] types: Add CDMA Phone Number

2010-12-17 Thread Dara Spieker-Doyle
--- include/types.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/types.h b/include/types.h index de15437..a394775 100644 --- a/include/types.h +++ b/include/types.h @@ -84,6 +84,14 @@ struct ofono_phone_number { int type; }; +/* Length of

[PATCH v2 9/9] test: Add CDMA MO Call Support

2010-12-17 Thread Dara Spieker-Doyle
--- Makefile.am |5 - test/cdma-dial-number | 24 test/cdma-hangup | 20 test/cdma-list-call | 30 ++ 4 files changed, 78 insertions(+), 1 deletions(-) create mode 100755

Re: [PATCH 3/5] cdma-atmodem: Add CDMA MO Call Support

2010-12-13 Thread Dara Spieker-Doyle
Hi Denis On Fri, 2010-12-10 at 22:41 +0100, Spieker-Doyle Dara (Nokia-MS/SanDiego) wrote: Hi Denis On Thu, 2010-12-09 at 09:43 +0100, ext Denis Kenzior wrote: drivers/cdma-atmodem/atutil.c| 45 + drivers/cdma-atmodem/atutil.h| 65 + Are these

Re: [PATCH] TODO: Add CDMA Voicecall Support Tasks

2010-12-10 Thread Dara Spieker-Doyle
Hi Denis On Thu, 2010-12-09 at 09:04 +0100, ext Denis Kenzior wrote: Patch looks good to me, however it does not apply: fatal: cannot convert from unknown-8bit to UTF-8 Thank you. We are currently investigating this format issue and will submit a new version once resolved. Cheers Dara

Re: [PATCH 2/5] cdma-voicecall: Add CDMA MO Call Support

2010-12-10 Thread Dara Spieker-Doyle
Hi Denis Thank you for reviewing this series of patches. We shall submit new versions according to your comments. Please find any other clarifying points inline. On Thu, 2010-12-09 at 09:36 +0100, ext Denis Kenzior wrote: + +static void voicecall_set_call_status(struct

[PATCH v2] TODO: Add CDMA Voicecall Support Tasks

2010-12-10 Thread Dara Spieker-Doyle
: High + Complexity: C2 + Owner: Dara Spieker-Doyle dara.spieker-do...@nokia.com + +- Add support for Three-Way Calling over a CDMA network. Three-Way Calling + provides the subscriber with the capability to add a third party to an + established two-party call, so that all three parties may

Re: [PATCH 2/5] cdma-voicecall: Add CDMA MO Call Support

2010-12-07 Thread Dara Spieker-Doyle
Hi Denis On Tue, 2010-12-07 at 04:16 +0100, ext Denis Kenzior wrote: Hi Rajesh, On 12/03/2010 03:34 PM, rajesh.naga...@elektrobit.com wrote: Hi Dara, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Dara Spieker-Doyle Sent

RE: [PATCH 2/5] cdma-voicecall: Add CDMA MO Call Support

2010-12-03 Thread Dara Spieker-Doyle
Hi Rajesh On Fri, 2010-12-03 at 01:30 +0100, ext rajesh.naga...@elektrobit.com wrote: +enum cdma_call_status { + CDMA_CALL_STATUS_ACTIVE = 0, + CDMA_CALL_STATUS_DIALING = 1, + CDMA_CALL_STATUS_ALERTING = 2, + CDMA_CALL_STATUS_INCOMING = 4, Should be 3 ? Yes indeed. I will

[PATCH] TODO: Add CDMA Voicecall Support Tasks

2010-12-02 Thread Dara Spieker-Doyle
: High + Complexity: C2 + Owner: Dara Spieker-Doyle dara.spieker-do...@nokia.com + +- Add support for Three-Way Calling over a CDMA network. Three-Way Calling + provides the subscriber with the capability to add a third party to an + established two-party call, so that all three parties may

[PATCH 0/5] Add CDMA MO Call Support

2010-12-02 Thread Dara Spieker-Doyle
in a tethered mode. Limitations --- The Nokia 7205 device does not support an AT interface for reporting request responses, such as the call status and remote/network disconnect reasons, so these are currently untested. Dara Spieker-Doyle (5): cdma-voicecall: Add CDMA MO Call Support

[PATCH 2/5] cdma-voicecall: Add CDMA MO Call Support

2010-12-02 Thread Dara Spieker-Doyle
--- Makefile.am |3 +- src/cdma-voicecall.c | 449 ++ src/common.c | 42 + src/common.h | 14 ++ src/ofono.h |3 + 5 files changed, 510 insertions(+), 1 deletions(-) create mode 100644

[PATCH 3/5] cdma-atmodem: Add CDMA MO Call Support

2010-12-02 Thread Dara Spieker-Doyle
--- Makefile.am |7 ++ configure.ac |5 + drivers/cdma-atmodem/atmodem.c | 47 + drivers/cdma-atmodem/atmodem.h | 26 + drivers/cdma-atmodem/atutil.c| 45 + drivers/cdma-atmodem/atutil.h| 65 +

[PATCH 4/5] cdmagen: Add CDMA MO Call Support

2010-12-02 Thread Dara Spieker-Doyle
--- Makefile.am |3 + plugins/cdmagen.c | 276 +++ plugins/ofono.rules |4 + plugins/udev.c | 21 4 files changed, 304 insertions(+), 0 deletions(-) create mode 100644 plugins/cdmagen.c diff --git a/Makefile.am

[PATCH 5/5] test: Add CDMA MO Call Support

2010-12-02 Thread Dara Spieker-Doyle
--- Makefile.am |5 - test/cdma-dial-number | 25 + test/cdma-hangup | 20 test/cdma-list-call | 30 ++ 4 files changed, 79 insertions(+), 1 deletions(-) create mode 100755