Re: [PATCH] atmodem: gnss aggregate xml

Hi Marcel, On Tue, 2011-03-29 at 16:14 +0300, Marcel Holtmann wrote: Hi Jarko, this is never ever going to work. Global and public variables are a big no no. First of all it would need to be static, but that is not going to help you since the GNSS atom can be instantiated multiple times.

[PATCH] atmodem: gnss aggregate xml

--- Hi, ok this is the very final patch from me for this. The parsing could be done better I know but seems to work. Hopefully this will any way give some idea for somebody else to finalise this. br, Jarko drivers/atmodem/gnss.c | 135 ++-- 1 files

Re: [PATCH 00/12] Basic E911 support

Hi Denis, On Tue, 2011-03-29 at 01:56 +0300, Denis Kenzior wrote: Hi Jarko, On 03/24/2011 08:46 AM, Jarko Poutiainen wrote: Hi, This is third attempt to provide implementation for basic E911 support. Br, Jarko I applied (most) of this patch series, however see my comments

[PATCH] atmodem: gnss aggregate xml

--- Hi, this patch provides logic to re-construct XML-formatted string prefixed with +CPOSR as defined in 27.007. Br, Jarko drivers/atmodem/gnss.c | 134 ++-- 1 files changed, 118 insertions(+), 16 deletions(-) diff --git a/drivers/atmodem/gnss.c

[PATCH] TODO:remove me from E911 support

Complexity: C2 - Owner: Jarko Poutiainen jarko.poutiai...@tieto.com - Add support for main.conf. This task will add support for general as well as per-atom configuration options that are read and parsed -- 1.7.0.4 ___ ofono mailing list ofono

[PATCH 00/12] Basic E911 support

Hi, This is third attempt to provide implementation for basic E911 support. Br, Jarko Jarko Poutiainen (12): dbus: add gnss interface definition include: add gnss.h file src: add atom type for gnss src: add gnss atom and agent implementation gatchat: introduce send for +CPOS gatchat

[PATCH 01/12] dbus: add gnss interface definition

--- include/dbus.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 38864fb..4dd9db5 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -56,6 +56,8 @@ extern C { #define OFONO_STK_INTERFACE OFONO_SERVICE .SimToolkit #define

[PATCH 02/12] include: add gnss.h file

--- Makefile.am|3 +- include/gnss.h | 69 2 files changed, 71 insertions(+), 1 deletions(-) create mode 100644 include/gnss.h diff --git a/Makefile.am b/Makefile.am index b0cbcd7..bff2374 100644 --- a/Makefile.am +++

[PATCH 04/12] src: add gnss atom and agent implementation

--- Makefile.am |3 +- src/gnss.c | 386 +++ src/gnssagent.c | 158 +++ src/gnssagent.h | 43 ++ 4 files changed, 589 insertions(+), 1 deletions(-) create mode 100644 src/gnss.c create mode 100644

[PATCH 03/12] src: add atom type for gnss

--- src/ofono.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index b9ca314..81570fe 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -132,6 +132,7 @@ enum ofono_atom_type { OFONO_ATOM_TYPE_EMULATOR_DUN,

[PATCH 06/12] gatchat: new hint to handle +CPOS

--- gatchat/gatsyntax.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gatchat/gatsyntax.h b/gatchat/gatsyntax.h index afc0bd3..2580ec6 100644 --- a/gatchat/gatsyntax.h +++ b/gatchat/gatsyntax.h @@ -29,7 +29,8 @@ extern C { enum _GAtSyntaxExpectHint {

[PATCH 07/12] gatchat: implementation for +CPOS send

--- gatchat/gatchat.c | 37 + 1 files changed, 33 insertions(+), 4 deletions(-) diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c index 3fd564d..eeb8d24 100644 --- a/gatchat/gatchat.c +++ b/gatchat/gatchat.c @@ -53,6 +53,7 @@ struct at_command {

[PATCH 05/12] gatchat: introduce send for +CPOS

--- gatchat/gatchat.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/gatchat/gatchat.h b/gatchat/gatchat.h index 8cbb559..eb82daa 100644 --- a/gatchat/gatchat.h +++ b/gatchat/gatchat.h @@ -124,6 +124,14 @@ guint g_at_chat_send_pdu_listing(GAtChat *chat, const char

[PATCH 08/12] gatchat: fix gatsyntax to support +CPOS

--- gatchat/gatsyntax.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/gatchat/gatsyntax.c b/gatchat/gatsyntax.c index 2fc70b8..469ffc3 100644 --- a/gatchat/gatsyntax.c +++ b/gatchat/gatsyntax.c @@ -44,6 +44,7 @@ enum GSMV1_STATE {

[PATCH 10/12] ste: add support for gnss

--- plugins/ste.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 36b3148..f7fe2b4 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -57,6 +57,7 @@ #include ofono/gprs-context.h #include ofono/radio-settings.h #include

[PATCH 11/12] ofono.conf: add positioning agent interface

--- src/ofono.conf |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/ofono.conf b/src/ofono.conf index 0dfa038..8a83cd0 100644 --- a/src/ofono.conf +++ b/src/ofono.conf @@ -13,6 +13,7 @@ allow send_interface=org.ofono.SimToolkitAgent/ allow

[PATCH 09/12] atmodem: add gnss driver

--- Makefile.am |3 +- drivers/atmodem/atmodem.c |2 + drivers/atmodem/atmodem.h |3 + drivers/atmodem/gnss.c| 282 + 4 files changed, 289 insertions(+), 1 deletions(-) create mode 100644 drivers/atmodem/gnss.c diff

[PATCH 12/12] test: add test-gnss

--- Makefile.am|3 +- test/test-gnss | 91 2 files changed, 93 insertions(+), 1 deletions(-) create mode 100755 test/test-gnss diff --git a/Makefile.am b/Makefile.am index b5a3d6e..626a310 100644 --- a/Makefile.am +++

Re: [PATCH 01/12] dbus: add gnss interface definition

Hi Denis, On Fri, 2011-03-18 at 06:26 +0200, Denis Kenzior wrote: Hi Jarko, On 03/11/2011 06:22 AM, Jarko Poutiainen wrote: --- include/dbus.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 19a138a..bf3e8a4 100644

Re: [PATCH 02/12] include: add gnss.h file

Hi Denis, On Fri, 2011-03-18 at 06:29 +0200, Denis Kenzior wrote: Hi Jarko, On 03/11/2011 06:22 AM, Jarko Poutiainen wrote: --- Makefile.am|2 +- include/gnss.h | 76 2 files changed, 77 insertions(+), 1 deletions

Re: [PATCH 04/12] src: add gnss atom and agent implementation

Hi Denis, On Fri, 2011-03-18 at 06:39 +0200, Denis Kenzior wrote: Hi Jarko, On 03/11/2011 06:23 AM, Jarko Poutiainen wrote: --- Makefile.am |3 +- src/gnss.c | 357 +++ src/gnssagent.c | 152

Re: [PATCH 09/12] atmodem: add gnss driver

Hi Denis, On Fri, 2011-03-18 at 07:03 +0200, Denis Kenzior wrote: On 03/11/2011 06:23 AM, Jarko Poutiainen wrote: --- Makefile.am |3 +- drivers/atmodem/atmodem.c |2 + drivers/atmodem/atmodem.h |3 + drivers/atmodem/gnss.c| 279

Re: [PATCH 07/12] gatchat: implementation for +CPOS send

Hi Denis, On Fri, 2011-03-18 at 06:42 +0200, Denis Kenzior wrote: Hi Jarko, On 03/11/2011 06:23 AM, Jarko Poutiainen wrote: --- gatchat/gatchat.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c index

Re: [PATCH 08/12] gatchat: fix gatsyntax to support +CPOS

Hi Denis, On Fri, 2011-03-18 at 06:53 +0200, Denis Kenzior wrote: Hi Jarko, On 03/11/2011 06:23 AM, Jarko Poutiainen wrote: --- gatchat/gatsyntax.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/gatchat/gatsyntax.c b/gatchat/gatsyntax.c

Re: [PATCH 6/9] gatchat: fix gatsyntax to support +CPOS

Hi Denis, On Fri, 2011-03-11 at 01:11 +0200, Denis Kenzior wrote: Hi Jarko, Fair enough, sorry for 'shooting the messenger' so to speak ;) Non taken. :) Essentially. You might have to define a new syntax hint for this prompt, namely EXPECT_BROKEN_PROMPT or something like that. Ok I'll

[PATCH 00/12] basic E911 support

Hi, This is second attempt to provide implementation for basic E911 support. Br, Jarko Jarko Poutiainen (12): dbus: add gnss interface definition include: add gnss.h file src: add atom type for gnss src: add gnss atom and agent implementation gatchat:introduce send for +CPOS

[PATCH 01/12] dbus: add gnss interface definition

--- include/dbus.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 19a138a..bf3e8a4 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -56,6 +56,8 @@ extern C { #define OFONO_STK_INTERFACE OFONO_SERVICE .SimToolkit #define

[PATCH 03/12] src: add atom type for gnss

--- src/ofono.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 995a1a5..2c6899e 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -131,6 +131,7 @@ enum ofono_atom_type { OFONO_ATOM_TYPE_EMULATOR_DUN,

[PATCH 02/12] include: add gnss.h file

--- Makefile.am|2 +- include/gnss.h | 76 2 files changed, 77 insertions(+), 1 deletions(-) create mode 100644 include/gnss.h diff --git a/Makefile.am b/Makefile.am index 3f20717..7d6acce 100644 --- a/Makefile.am +++

[PATCH 04/12] src: add gnss atom and agent implementation

--- Makefile.am |3 +- src/gnss.c | 357 +++ src/gnssagent.c | 152 +++ src/gnssagent.h | 40 ++ 4 files changed, 551 insertions(+), 1 deletions(-) create mode 100644 src/gnss.c create mode 100644

[PATCH 10/12] ste: add support for gnss

--- plugins/ste.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index efae573..749f673 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -58,6 +58,7 @@ #include ofono/gprs-context.h #include ofono/radio-settings.h #include

[PATCH 09/12] atmodem: add gnss driver

--- Makefile.am |3 +- drivers/atmodem/atmodem.c |2 + drivers/atmodem/atmodem.h |3 + drivers/atmodem/gnss.c| 279 + 4 files changed, 286 insertions(+), 1 deletions(-) create mode 100644 drivers/atmodem/gnss.c diff

[PATCH 05/12] gatchat:introduce send for +CPOS

--- gatchat/gatchat.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/gatchat/gatchat.h b/gatchat/gatchat.h index 8cbb559..eb82daa 100644 --- a/gatchat/gatchat.h +++ b/gatchat/gatchat.h @@ -124,6 +124,14 @@ guint g_at_chat_send_pdu_listing(GAtChat *chat, const char

[PATCH 11/12] ofono.conf: add positioning agent interface

--- src/ofono.conf |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/ofono.conf b/src/ofono.conf index 0dfa038..8a83cd0 100644 --- a/src/ofono.conf +++ b/src/ofono.conf @@ -13,6 +13,7 @@ allow send_interface=org.ofono.SimToolkitAgent/ allow

[PATCH 06/12] gatchat:new hint to handle +CPOS

--- gatchat/gatsyntax.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gatchat/gatsyntax.h b/gatchat/gatsyntax.h index afc0bd3..2580ec6 100644 --- a/gatchat/gatsyntax.h +++ b/gatchat/gatsyntax.h @@ -29,7 +29,8 @@ extern C { enum _GAtSyntaxExpectHint {

[PATCH 07/12] gatchat: implementation for +CPOS send

--- gatchat/gatchat.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c index 3fd564d..64f131d 100644 --- a/gatchat/gatchat.c +++ b/gatchat/gatchat.c @@ -1468,6 +1468,19 @@ guint g_at_chat_send_pdu_listing(GAtChat *chat,

[PATCH 12/12] test: add test-gnss

--- Makefile.am|3 +- test/test-gnss | 91 2 files changed, 93 insertions(+), 1 deletions(-) create mode 100755 test/test-gnss diff --git a/Makefile.am b/Makefile.am index 3dae7f4..daa5dd0 100644 --- a/Makefile.am +++

[PATCH 08/12] gatchat: fix gatsyntax to support +CPOS

--- gatchat/gatsyntax.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/gatchat/gatsyntax.c b/gatchat/gatsyntax.c index 2fc70b8..f1d896b 100644 --- a/gatchat/gatsyntax.c +++ b/gatchat/gatsyntax.c @@ -64,6 +64,9 @@ static void gsmv1_hint(GAtSyntax

Re: [PATCH 6/9] gatchat: fix gatsyntax to support +CPOS

Hello Denis, On Thu, 2011-03-10 at 00:19 +0200, Denis Kenzior wrote: Hi Jarko, On 03/08/2011 05:00 AM, Jarko Poutiainen wrote: --- gatchat/gatsyntax.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gatchat/gatsyntax.c b/gatchat/gatsyntax.c index

[PATCH 1/9] dbus: add gnss interface definition

--- include/dbus.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 19a138a..bf3e8a4 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -56,6 +56,8 @@ extern C { #define OFONO_STK_INTERFACE OFONO_SERVICE .SimToolkit #define

[PATCH 0/9] Basic E911 support

Hi, This set of patches provides implementation proposal for basic E911 support. Br, Jarko Jarko Poutiainen (9): dbus: add gnss interface definition include: add gnss.h file src: add atom type for gnss src: add gnss atom and agent implementation atmodem: add gnss driver gatchat: fix

[PATCH 4/9] src: add gnss atom and agent implementation

--- Makefile.am |3 +- src/gnss.c | 357 +++ src/gnssagent.c | 152 +++ src/gnssagent.h | 40 ++ 4 files changed, 551 insertions(+), 1 deletions(-) create mode 100644 src/gnss.c create mode 100644

[PATCH 3/9] src: add atom type for gnss

--- src/ofono.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 995a1a5..2c6899e 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -131,6 +131,7 @@ enum ofono_atom_type { OFONO_ATOM_TYPE_EMULATOR_DUN,

[PATCH 2/9] include: add gnss.h file

--- Makefile.am|2 +- include/gnss.h | 76 2 files changed, 77 insertions(+), 1 deletions(-) create mode 100644 include/gnss.h diff --git a/Makefile.am b/Makefile.am index 3f20717..7d6acce 100644 --- a/Makefile.am +++

[PATCH 5/9] atmodem: add gnss driver

--- Makefile.am |3 +- drivers/atmodem/atmodem.c |2 + drivers/atmodem/atmodem.h |3 + drivers/atmodem/gnss.c| 278 + 4 files changed, 285 insertions(+), 1 deletions(-) create mode 100644 drivers/atmodem/gnss.c diff

[PATCH 6/9] gatchat: fix gatsyntax to support +CPOS

--- gatchat/gatsyntax.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gatchat/gatsyntax.c b/gatchat/gatsyntax.c index 2fc70b8..a85bc66 100644 --- a/gatchat/gatsyntax.c +++ b/gatchat/gatsyntax.c @@ -90,7 +90,11 @@ static GAtSyntaxResult gsmv1_feed(GAtSyntax

[PATCH 8/9] ofono.conf: add positioning agent interface

--- src/ofono.conf |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/ofono.conf b/src/ofono.conf index 0dfa038..8a83cd0 100644 --- a/src/ofono.conf +++ b/src/ofono.conf @@ -13,6 +13,7 @@ allow send_interface=org.ofono.SimToolkitAgent/ allow

[PATCH 7/9] ste: add support for gnss

--- plugins/ste.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index efae573..749f673 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -58,6 +58,7 @@ #include ofono/gprs-context.h #include ofono/radio-settings.h #include

[PATCH 9/9] test: add test-gnss

--- Makefile.am|3 +- test/test-gnss | 91 2 files changed, 93 insertions(+), 1 deletions(-) create mode 100755 test/test-gnss diff --git a/Makefile.am b/Makefile.am index 3dae7f4..daa5dd0 100644 --- a/Makefile.am +++

[PATCH] TODO: add CF state change task

--- TODO | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 41f1f7f..b62eb99 100644 --- a/TODO +++ b/TODO @@ -255,6 +255,22 @@ Supplementary Services Priority: Low Complexity: C8 +- Call forwarding state handling change + + At the

Re: Ofono CF states not always correct

Hi Denis, On Fri, 2011-01-14 at 17:59 +0200, Denis Kenzior wrote: Hi Jarko, Both are active and the modem should be reporting both. At least that is how I understood the specifications. Well that is a bit debatable. As 27.007 states: command:

[PATCH] test: add set-call-forwarding

--- Makefile.am |3 +- test/set-call-forwarding | 64 ++ 2 files changed, 66 insertions(+), 1 deletions(-) create mode 100755 test/set-call-forwarding diff --git a/Makefile.am b/Makefile.am index 4dec90a..ead154d 100644 ---

Ofono CF states not always correct

Hello, I have been trying out and going through the code concerning Call Forwarding and I found out that if you enable for example CF VoiceBusy and then CF VoiceUnconditional, the VoiceBusy is still according to ofono enabled. This of course as such isn't so bad but by using

[PATCH] test: add set-call-forwarding

--- Makefile.am |3 +- test/set-call-forwarding | 65 ++ 2 files changed, 67 insertions(+), 1 deletions(-) create mode 100755 test/set-call-forwarding diff --git a/Makefile.am b/Makefile.am index 8ad01cd..563da9f 100644 ---

[PATCH] test: add disable-call-forwarding

--- Makefile.am |3 +- test/disable-call-forwarding | 55 ++ 2 files changed, 57 insertions(+), 1 deletions(-) create mode 100755 test/disable-call-forwarding diff --git a/Makefile.am b/Makefile.am index 8ad01cd..7908467 100644 ---