Re: [PATCH v1 1/2] service: remove files when unable to decode received msg

2012-04-11 Thread Marcel Holtmann
Hi Ronald, > src/service.c |7 ++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/src/service.c b/src/service.c > index f148252..851db34 100644 > --- a/src/service.c > +++ b/src/service.c > @@ -984,7 +984,12 @@ static gboolean load_message_from_store(const char > *s

Re: [PATCH 2/2] ussd: Fix speedup ussd encoding

2012-04-10 Thread Marcel Holtmann
Hi Denis, > > Speedup dongles encode USSD strings in GSM7 > > packed, so we don't have to pack it ourselves. > > --- > > drivers/atmodem/ussd.c | 13 ++--- > > plugins/speedup.c |2 +- > > 2 files changed, 11 insertions(+), 4 deletions(-) > > > > Patch looks good, but please

Re: [PATCH v3 0/3] bug fixing in send message recovery

2012-03-30 Thread Marcel Holtmann
Hi Sebastien, > Patch 1 to 3 fix some leaks when a problem arises when a send request is > created. > > > Sébastien Bianti (3): > service: factorize error code > service: NULL uuid here is an error > service: remove orphan file all three patches have been applied. Regards Marcel _

Re: [PATCH 0/2] complete storage task

2012-03-30 Thread Marcel Holtmann
Hi Sebastien, > These patches concern mmsd for ofono mailing list. > > > Sébastien Bianti (2): > service: transaction id should'nt be NULL > TODO: storage task complete both patches have been applied. Regards Marcel ___ ofono mailing list ofon

Re: Configuring a TCP-connected Modem

2012-03-27 Thread Marcel Holtmann
Hi Aaron, > I have a sort of strange question. I'd like to be able to configure an > Inmarsat BGAN modem with ofono using a TCP connection to a port on the > modem. The modem is connected via Ethernet. > > Has this sort of thing been done? Any ideas on what it would take to get > this working? w

Re: [PATCH v3] huawei: fix AT^DDSETEX=2 timing

2012-03-24 Thread Marcel Holtmann
Hi Jarkko, > Voice output serial port is enabled on some Huawei models (e.g. E169) > without problems, but for example on E173u-2 it is never enabled > during an incoming call. There might also be other Huawei models > having the same issue. > > I traced the issue down to "^DDSETEX" AT command, w

Re: [PATCH v2] huawei: fix AT^DDSETEX=2 timing

2012-03-23 Thread Marcel Holtmann
Hi Jarkko, > Voice output serial port is enabled on some Huawei models (e.g. E169) > without problems, but for example on E173u-2 it is never enabled > during an incoming call. There might also be other Huawei models > having the same issue. > > I traced the issue down to "^DDSETEX" AT command, w

Re: [PATCH] huawei: fix AT^DDSETEX=2 timing

2012-03-23 Thread Marcel Holtmann
Hi Jarkko, > --- > drivers/huaweimodem/voicecall.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) can I get a patch where the long explanation summary is actually the commit message. I want this recorded in the git log. Regards Marcel _

Re: [PATCH 3/3] let configure find required libs

2012-03-23 Thread Marcel Holtmann
Hi Jens, > Makefile.am |2 +- > configure.ac | 24 +--- > 2 files changed, 18 insertions(+), 8 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index bebcb90..178def4 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -28,7 +28,7 @@ src_mmsd_SOURCES = $(gdbus

Re: [PATCH 2/3] changing depreciated libtool initialization to modern one

2012-03-23 Thread Marcel Holtmann
Hi Jens, > > Makefile.am |4 > > configure.ac | 10 -- > > 2 files changed, 12 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile.am b/Makefile.am > > index c3a4486..bebcb90 100644 > > --- a/Makefile.am > > +++ b/Makefile.am > > @@ -1,6 +1,10 @@ > > > > AM_MAKEFLA

Re: [PATCH 1/3] add some length verification to avoid reading not owned memory

2012-03-23 Thread Marcel Holtmann
Hi Jens, please prefix the subject line with the files that get changed. So something like push: would be good. > src/push.c |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/src/push.c b/src/push.c > index 6a54907..6107352 100644 > --- a/src/push.c > +++ b/sr

Re: [mmsd] Error handling while receiving message

2012-03-23 Thread Marcel Holtmann
Hi Ronald, > I'm working on handling errors while receiving an MMS (listed in TODO as > : "Error cases should handled and reported to the application layer." in > MMS Reception section). > > What kind of error do you want to report to the application : generic > MMS reception error such as "Un

Re: [PATCH v2 6/6] service: request needs to keep msg

2012-03-23 Thread Marcel Holtmann
Hi Sebastien, > src/service.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH v2 5/6] service: fix some leaks

2012-03-23 Thread Marcel Holtmann
Hi Sebastien, > src/service.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH v2 4/6] service: request_post_file opens the pdu itself

2012-03-23 Thread Marcel Holtmann
Hi Sebastien, > src/service.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH v2 3/6] service: remove pdu without meta

2012-03-23 Thread Marcel Holtmann
Hi Sebastien, > src/service.c | 11 ++- > 1 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/src/service.c b/src/service.c > index 0161ec0..8dbee12 100644 > --- a/src/service.c > +++ b/src/service.c > @@ -777,11 +777,17 @@ static DBusMessage *send_message(DBusConnection

Re: [PATCH v2 2/6] service: fixed possible meta with NULL uuid

2012-03-23 Thread Marcel Holtmann
Hi Sebastien, > If mms_store_file fails. > --- > src/service.c |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/src/service.c b/src/service.c > index 3fdf4e0..0161ec0 100644 > --- a/src/service.c > +++ b/src/service.c > @@ -767,6 +767,15 @@ static DBusMessage

Re: [PATCH v2 1/6] service: remove dead file

2012-03-23 Thread Marcel Holtmann
Hi Sebastien, > --- > src/service.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/src/service.c b/src/service.c > index ef6b544..3fdf4e0 100644 > --- a/src/service.c > +++ b/src/service.c > @@ -755,6 +755,7 @@ static DBusMessage *send_message(DBusConnection *conn,

Re: [PATCH 0/2] mmsd: fix problems when unregistering msg

2012-03-22 Thread Marcel Holtmann
Hi Ronald, > Please find changes in mmsd in order to fix problems that occurred when > unregistering messages. > > 1) the messages table contains mms_message object and not uuid, now > every message is unregister with its correct path when the messages > table is destroyed. Furthermore, don't nee

Re: [PATCH 1/1] service: remove unused mms_request's members

2012-03-22 Thread Marcel Holtmann
Hi Ronald, > src/service.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] sim: Use quoted string with AT+CRSM data parameter

2012-03-21 Thread Marcel Holtmann
Hi Nicolas, > Fix issue with some modems preventing to update elementary files > (speedup, ZTE, huawei, MBM) > --- > drivers/atmodem/sim.c | 52 ++-- > 1 files changed, 45 insertions(+), 7 deletions(-) > > diff --git a/drivers/atmodem/sim.c b/drivers

Re: [PATCH 1/1] TODO: remove completed tasks

2012-03-13 Thread Marcel Holtmann
Hi Sebastien, > --- > TODO | 59 --- > 1 files changed, 0 insertions(+), 59 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/

Re: [PATCH 1/1] service: mms_request_destroy shouldn't free msg

2012-03-13 Thread Marcel Holtmann
Hi Sebastien, > mms_message is referenced in the hash table mms_service->messages > --- > src/service.c |7 --- > 1 files changed, 4 insertions(+), 3 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: Huawei voice output port issue + patch

2012-03-09 Thread Marcel Holtmann
Hi Jarkko, > Voice output serial port is enabled on some Huawei models (e.g. E169) > without problems, but for example on E173u-2 it is never enabled during > an incoming call. There might also be other Huawei models having the > same issue. > > I traced the issue down to "^DDSETEX" AT command

Re: [Gta04-owner] Polling CLCC error handling on Option modem (GTA04)

2012-03-07 Thread Marcel Holtmann
Hi Matthias, > > > You can always try ignoring CME ERROR 100 and re-try the CLCC poll. > > > Maybe the modem is in a transitional period (e.g. call being released) > > > and it can't answer the CLCC properly. In other words, there's a bug > > > related to timing of call state changes & CLCC imple

Re: [RFC v0] ofono: Only register network when APN is set

2012-02-28 Thread Marcel Holtmann
Hi guys, > > We should now show a network without an APN. > > --- > > I have not tested this one. But something like this should do > > the trick. Maybe someone with deeper knowledge on the APN > > behavior could explain under which circumstances the APN is set, e.g. > > see the netreg vs apn sett

Re: [Gta04-owner] HSO modem, apparent confusion between App and Control ports

2012-02-27 Thread Marcel Holtmann
Hi Neil, > I'm using an HSO modem in a GTA04 device, and have a UI that, on session > startup, powers the modem on, and sets it online. > > Sometimes - after roughly 50% of reboots - the setting online times out, > and I've established that this is because there's still a preceding > command in c

Re: [PATCH] hso: Don't access freed data, in hso_set_online

2012-02-27 Thread Marcel Holtmann
Hi Neil, > --- > plugins/hso.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: trying to understand context creation

2012-02-27 Thread Marcel Holtmann
Hi Jussi, > >> From a UI point of view, connman crashing and connman being stopped > >> are 100% same -- the only thing the UI can do is inform the user that > >> there is a critical problem, so they won't just wait there expecting > >> that Wifi AP to show up any moment now... I hope the users w

Re: [PATCH] configure/make basics

2012-02-27 Thread Marcel Holtmann
Hi Jens, > while hacking on a plugin for mmsd to deal with supl push > messages, I ran into a few "not so nice" solved things > in configure.ac / Makefile.am > > 1) libtool handling >libtool configuration is meanwhile done using LT_INIT(options) >instead of AC_PROC_LIBTOOL and alike >

Re: [PATCH] add some length verification to avoid reading not owned memory

2012-02-27 Thread Marcel Holtmann
Hi Jens, > while reading mmsd sources I stumbled over missing length > checks in src/push.c:mms_push_notify(). I didn't re-read > the entire source to prove overall ;) please use git format-patch and git send-email to send us inline patches. In case your email client doesn't support inline patche

Re: trying to understand context creation

2012-02-27 Thread Marcel Holtmann
Hi Jussi, > >> HW problems any more than I'm "fixing" connman crashes in my UI -- > >> both are still events I'd rather handle (witihin limits) if that makes > >> the UX better. > > > > Sure, the UI should handle the basics, e.g. connman service being > > stopped by the administrator. However, go

Re: Introducing Jens Rehsack

2012-02-26 Thread Marcel Holtmann
Hi Jens, > before start to asking questions, I'd like to introduce myself and > why I joined into the community. > > I'm hired by Vodafone Global (Vodafone Group Services GmbH) to > assist there on some networking services, currently location > services. One part of the job will be to work with o

Re: Enhancing mmsd

2012-02-26 Thread Marcel Holtmann
Hi Jens, > >> as announced in my last mail, I'm here to work with + improve ofono > >> and related software. > >> > >> My next task will be to implement an ofono plugin which handles some > >> UPL push messages. Because there is only one "listener" at > >> org.ofono.PushNotificationAgent possible,

Re: [PATCH] hso: Don't access freed data, in hso_set_online

2012-02-26 Thread Marcel Holtmann
Hi Neil, > plugins/hso.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/plugins/hso.c b/plugins/hso.c > index 4834c56..697beaa 100644 > --- a/plugins/hso.c > +++ b/plugins/hso.c > @@ -422,7 +422,7 @@ static void hso_set_online(struct ofono_modem *modem, > ofono_b

Re: Build issue

2012-01-31 Thread Marcel Holtmann
Hi Guillaume, > Patch 38c6525 - btio: Add support for getting the Encryption Key Size > via btio (Vinicius Costa Gomes 6 days ago) > > breaks oFono build. > > make --no-print-directory all-am > CC plugins/bluetooth.o > CC btio/btio.o > btio/btio.c: In function ‘get_key_size’: > btio/btio.c:522:

Re: [PATCH v4 0/6] Provider name and SID

2012-01-18 Thread Marcel Holtmann
Hi Philippe, > This version introduces a QCDM helper library. > Also, to simplify the QCDM handling, a dedicated callback is set for each > command sent. > Currently, we are not considering that a new command can be issued before the > answer from the previous command is handled. If this case occu

Re: Some experiments with the SIMCOM SIM5216E modem on a ARM926 board

2012-01-12 Thread Marcel Holtmann
Hi Jean-Christian, > > T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 > > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > > P: Vendor=05c6 ProdID=9000 Rev= 0.00 > > S: Manufacturer=SimTech, Incorporated > > S: Product=SimTech SIM5216 > > C:* #Ifs= 5 Cfg#= 1 Atr=e0 MxPw

Re: Some experiments with the SIMCOM SIM5216E modem on a ARM926 board

2012-01-12 Thread Marcel Holtmann
Hi Jean-Christian, > >> It's a mystery for me if Simcom do there own software or only use the > >> Qualcamm one. The chipset of this modem is the QSC6270 and I expected > >> that ofono already have something appropriate. I suspect the "g1" driver > >> to be a close match and if fact it work alread

Re: [PATCH v4 1/3] SIMCOM SIM900 module support

2012-01-12 Thread Marcel Holtmann
Hi Renat, > > + /* For obtain correct sms service number */ > > + g_at_chat_send(data->modem, "AT+CSCS=\"GSM\"", NULL, > > + NULL, NULL, NULL); > > you might better introduce a OFONO_VENDOR_SIM900 quirk and use that in > the SMS atom driver. The phoneb

Re: Some experiments with the SIMCOM SIM5216E modem on a ARM926 board

2012-01-11 Thread Marcel Holtmann
Hi Jean-Christian, > Thanks for your valuable response. Here is an update of the situation. > > >> The modem is connected by the USB and report: vendor=0x05c6 > >> product=0x9000. This seem to indicate that it use a Qualcomm chip. It > >> expose 5 serial interfaces, where the 2 and 3 (starting fr

Re: [PATCH v4 1/3] SIMCOM SIM900 module support

2012-01-11 Thread Marcel Holtmann
Hi Denis, > >> + /* For obtain correct sms service number */ > >> + g_at_chat_send(data->modem, "AT+CSCS=\"GSM\"", NULL, > >> + NULL, NULL, NULL); > > > > you might better introduce a OFONO_VENDOR_SIM900 quirk and use that in > > the SMS atom driver. The phonebook support will

Re: [PATCH v4 2/3] Add SIM900 detection support.

2012-01-11 Thread Marcel Holtmann
Hi Renat, > This allows for detection of SIM900 modem module in case of > appropriate driver specified in udev rules. > > Example rule: > KERNEL=="gsmtty3", ENV{OFONO_DRIVER}="sim900" you could also use the 27.010 support that is included in oFono itself and set it up from within the plugin. I a

Re: [PATCH v4 1/3] SIMCOM SIM900 module support

2012-01-11 Thread Marcel Holtmann
Hi Renat, > This patch add support for SIM900 GSM module > http://wm.sim.com/Sim/FrontShow_en/wireless/detail.aspx?cid=6&nid=770 > --- > Makefile.am |3 + > plugins/sim900.c | 261 > ++ > 2 files changed, 264 insertions(+), 0 deletion

RE: [PATCH_v0 2/3] huawei: Add modem type detection

2012-01-11 Thread Marcel Holtmann
Hi Ying An, > >Right, I see this is easier do to how I you submitted it :) > >However, I have a dongle EC1261 that is bugged because: > > - when I send ATI, the capabilities line is returned with > >"+GCAP +GCAP:" prefix > > - when I send AT+GCAP, the prefix is "+GCAP:" > > > >Unle

Re: plugins/mbpi.c compiler warnings

2012-01-10 Thread Marcel Holtmann
Hi Denis, > > CC plugins/mbpi.o > > plugins/mbpi.c: In function ‘apn_start’: > > plugins/mbpi.c:170: warning: passing argument 2 of > > ‘g_markup_parse_context_push’ discards qualifiers from pointer target type > > /usr/include/glib-2.0/glib/gmarkup.h:115: note: expected ‘struct > > GMarku

plugins/mbpi.c compiler warnings

2012-01-10 Thread Marcel Holtmann
CC plugins/mbpi.o plugins/mbpi.c: In function ‘apn_start’: plugins/mbpi.c:170: warning: passing argument 2 of ‘g_markup_parse_context_push’ discards qualifiers from pointer target type /usr/include/glib-2.0/glib/gmarkup.h:115: note: expected ‘struct GMarkupParser *’ but argument is of type

Re: Some experiments with the SIMCOM SIM5216E modem on a ARM926 board

2012-01-09 Thread Marcel Holtmann
Hi Jean-Christian, > I have got a custom board with a SIMCOM INCORPORATED SIM5216E modem, a > device not so common. I was able to successfully use it with Ofono, but > I want to get some advise to polish the work, as I have observed a > couple of strange things. > > The modem is connected by t

Re: [PATCH 2/5] speedup: Check for supported modem capabilities first

2012-01-09 Thread Marcel Holtmann
Hi Denis, > > plugins/speedup.c | 40 ++-- > > 1 files changed, 38 insertions(+), 2 deletions(-) > > > > diff --git a/plugins/speedup.c b/plugins/speedup.c > > index a90dfe3..f03f8f3 100644 > > --- a/plugins/speedup.c > > +++ b/plugins/speedup.c > > @@ -25,6

Re: [PATCH_v0 2/3] huawei: Add modem type detection

2012-01-09 Thread Marcel Holtmann
Hi Philippe, > >>> > > DBG("%p", modem); > > -ofono_devinfo_create(modem, 0, "atmodem", data->pcui); > -sim = ofono_sim_create(modem, OFONO_VENDOR_HUAWEI, > +if (data->gsm == TRUE) { > +ofono_devinfo_create(modem,

Re: [PATCH_v0 2/3] huawei: Add modem type detection

2012-01-09 Thread Marcel Holtmann
Hi Guillaume, > >> +static gboolean parse_ati_result(GAtResult *result) > >> +{ > >> + GAtResultIter iter; > >> + const char *line; > >> + int num = g_at_result_num_response_lines(result); > >> + int i; > >> + > >> + g_at_result_iter_init(&iter, result); > >> + > >> + for (i = 0; i< num; i+

Re: [PATCH_v0 3/3] huaweicdma: Delete unused plugin

2012-01-06 Thread Marcel Holtmann
Hi Guillaume, > Makefile.am |3 - > plugins/huaweicdma.c | 247 > -- > 2 files changed, 0 insertions(+), 250 deletions(-) > delete mode 100644 plugins/huaweicdma.c so I applied this patch as well. Just to get it out of way. Since w

Re: [PATCH_v0 2/3] huawei: Add modem type detection

2012-01-06 Thread Marcel Holtmann
Hi Guillaume, > This plugin is now merged with huaweicdma one. > Atoms will now be created with GSM or CDMA drivers > depending on the result of ATI command. > No SIM atom is created for embedded sim from CDMA > modems. > --- > plugins/huawei.c | 77 +

Re: [PATCH_v0 1/3] udevng: Simplify vendor_list for Huawei constructor

2012-01-06 Thread Marcel Holtmann
Hi Guillaume, > According to Huawei constructor, the port mapping is identical > for all the modems. We can decide to use GSM or CDMA drivers into > the plugin. > --- > plugins/udevng.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) we might should do this last, but I applied th

Re: [PATCH] udevng: use huaweicdma driver for olive V-ME101

2012-01-05 Thread Marcel Holtmann
Hi Nicolas, > >> plugins/udevng.c |3 +-- > >> 1 files changed, 1 insertions(+), 2 deletions(-) > >> > >> diff --git a/plugins/udevng.c b/plugins/udevng.c > >> index be87320..8d478cf 100644 > >> --- a/plugins/udevng.c > >> +++ b/plugins/udevng.c > >> @@ -800,11 +800,10 @@ static struct { >

Re: The way to install proper driver for 3G dongle in oFono

2012-01-05 Thread Marcel Holtmann
Hi Guillaume, > and what about the case when the SIM card is present, but PIN > locked? > > > According to the result, it might be interesting to send ATI > > when the > > constructor plugin is probe by oFono. > >

Re: [PATCH] udevng: use huaweicdma driver for olive V-ME101

2012-01-05 Thread Marcel Holtmann
Hi Nicolas, > plugins/udevng.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/plugins/udevng.c b/plugins/udevng.c > index be87320..8d478cf 100644 > --- a/plugins/udevng.c > +++ b/plugins/udevng.c > @@ -800,11 +800,10 @@ static struct { > { "hso","hs

Re: The way to install proper driver for 3G dongle in oFono

2012-01-04 Thread Marcel Holtmann
Hi Guillaume, > >> and what about the case when the SIM card is present, but PIN > >> locked? > >> > >>> According to the result, it might be interesting to send ATI when > >>> the > >>> constructor plugin is probe by oFono. > >>> Thus with

Re: The way to install proper driver for 3G dongle in oFono

2012-01-04 Thread Marcel Holtmann
Hi Guillaume, > and what about the case when the SIM card is present, but PIN locked? > > > According to the result, it might be interesting to send ATI when > > the > > constructor plugin is probe by oFono. > > Thus with +GCAP info we can decide

Re: The way to install proper driver for 3G dongle in oFono

2012-01-04 Thread Marcel Holtmann
Hi Guillaume, > >> and what about the case when the SIM card is present, but PIN locked? > >> > >>> According to the result, it might be interesting to send ATI when the > >>> constructor plugin is probe by oFono. > >>> Thus with +GCAP info we can decide which driver to use. >

RE: The way to install proper driver for 3G dongle in oFono

2011-12-22 Thread Marcel Holtmann
Hi Ying An, > >> >and what about the case when the SIM card is present, but PIN locked? > >> > > >> >> According to the result, it might be interesting to send ATI when the > >> >> constructor plugin is probe by oFono. > >> >> Thus with +GCAP info we can decide which driver to use. > >> > > >> >Is

RE: The way to install proper driver for 3G dongle in oFono

2011-12-22 Thread Marcel Holtmann
Hi Ying An, > >and what about the case when the SIM card is present, but PIN locked? > > > >> According to the result, it might be interesting to send ATI when the > >> constructor plugin is probe by oFono. > >> Thus with +GCAP info we can decide which driver to use. > > > >Is sending +GCAP after

Re: The way to install proper driver for 3G dongle in oFono

2011-12-22 Thread Marcel Holtmann
Hi Guillaume, > >> We are facing a problem in oFono when using 3G modems: > >> > >> A CDMA2000 modem can have same PID with WCDMA modem, or > >>> TDS-CDMA > >> modem -- 3G modem vendors already confirm they do that. > >> > >> That's to say, if following current strategy, it

Re: [PATCH v2 2/2] Makefile: Add Speedup udev rules to EXTRA_DIST

2011-12-21 Thread Marcel Holtmann
Hi Philippe, > Makefile.am |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH v2 1/2] Add-udev-rules-for-Speedup-dongles

2011-12-21 Thread Marcel Holtmann
Hi Philippe, > plugins/ofono-speedup.rules | 23 +++ > 1 files changed, 23 insertions(+), 0 deletions(-) > create mode 100644 plugins/ofono-speedup.rules patch has been applied. Thanks. Regards Marcel ___ ofono mailing list o

RE: The way to install proper driver for 3G dongle in oFono

2011-12-21 Thread Marcel Holtmann
Hi Ying An, > >> >> We are facing a problem in oFono when using 3G modems: > >> >> > >> >> A CDMA2000 modem can have same PID with WCDMA modem, or > >TDS-CDMA > >> >> modem -- 3G modem vendors already confirm they do that. > >> >> > >> >> That's to say, if following current strategy, it will be a

Re: [PATCH 2/2] Add udev rules for Speedup dongles

2011-12-20 Thread Marcel Holtmann
Hi Philippe, > plugins/ofono-speedup.rules | 23 +++ > 1 files changed, 23 insertions(+), 0 deletions(-) > create mode 100644 plugins/ofono-speedup.rules you might wanna add this file also to EXTRA_DIST. Otherwise it will never be included in any release. Regards Marcel

Re: [PATCH 1/2] udevng: Do only label assignment for Speedup dongles

2011-12-20 Thread Marcel Holtmann
Hi Philippe, > plugins/udevng.c |7 --- > 1 files changed, 0 insertions(+), 7 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: The way to install proper driver for 3G dongle in oFono

2011-12-20 Thread Marcel Holtmann
Hi Guillaume, > >> We are facing a problem in oFono when using 3G modems: > >> > >> A CDMA2000 modem can have same PID with WCDMA modem, or TDS-CDMA > >> modem -- 3G modem vendors already confirm they do that. > >> > >> That's to say, if following current strategy, it will be a problem to > >> i

Re: [PATCH 5/5] udev: Add rules to support SpeedUp 9800 dongle

2011-12-18 Thread Marcel Holtmann
Hi Philippe, > plugins/ofono.rules |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/plugins/ofono.rules b/plugins/ofono.rules > index 7f284d4..9e7a651 100644 > --- a/plugins/ofono.rules > +++ b/plugins/ofono.rules > @@ -29,6 +29,10 @@ ATTRS{idVendor}=="19d2", ATTR

Re: [PATCH 4/5] udev: Add rules to support Speedup 7300 dongle

2011-12-18 Thread Marcel Holtmann
Hi Philippe, > plugins/ofono.rules |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/plugins/ofono.rules b/plugins/ofono.rules > index 079db07..7f284d4 100644 > --- a/plugins/ofono.rules > +++ b/plugins/ofono.rules > @@ -25,6 +25,10 @@ ATTRS{idVendor}=="19d2", ATTR

Re: [PATCH 2/5] udev: Add rules to support ZTE MF190 dongle

2011-12-18 Thread Marcel Holtmann
Hi Philippe, > plugins/ofono.rules |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/plugins/ofono.rules b/plugins/ofono.rules > index c7fac57..079db07 100644 > --- a/plugins/ofono.rules > +++ b/plugins/ofono.rules > @@ -22,6 +22,9 @@ KERNEL!="ttyUSB[0-9]*", GOTO="o

Re: [PATCH 1/5] udev: Add rules to support ZTE MF668 dongle

2011-12-18 Thread Marcel Holtmann
Hi Philippe, > plugins/ofono.rules |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/plugins/ofono.rules b/plugins/ofono.rules > index 30a1b7e..c7fac57 100644 > --- a/plugins/ofono.rules > +++ b/plugins/ofono.rules > @@ -15,6 +15,15 @@ KERNEL=="shrm0", ENV{OFO

Re: [PATCH 3/5] udevng.c: tty assignment according OFONO_LABEL should take precedence

2011-12-18 Thread Marcel Holtmann
Hi Philippe, > plugins/udevng.c | 61 + > 1 files changed, 38 insertions(+), 23 deletions(-) > > diff --git a/plugins/udevng.c b/plugins/udevng.c > index be87320..6a3c970 100644 > --- a/plugins/udevng.c > +++ b/plugins/udevng.c > @@ -235,6 +2

Re: [RFC v3 16/16] elect: Add documentation

2011-12-16 Thread Marcel Holtmann
Hi Daniel, > On 15.12.2011 02:10, Denis Kenzior wrote: > >> +Service org.ofono.elect > >> +Interface org.ofono.elect.Manager > > > > Any particular reason why the project is named 'elect'? > > No particular reason. I needed a name. dund was already taken. Since DUN > stands for dialup

Re: [PATCH v2 06/12] gatchat: Add possibility to associate a diagnostic monitor to the AT-capable port

2011-12-08 Thread Marcel Holtmann
Hi Philippe, > >> gatchat/gatchat.c | 26 ++ > >> gatchat/gatchat.h |4 > >> 2 files changed, 30 insertions(+), 0 deletions(-) > >> > >> diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c > >> index 7a0ef35..00e5fa8 100644 > >> --- a/gatchat/gatchat.c > >> ++

Re: [PATCH v2 06/12] gatchat: Add possibility to associate a diagnostic monitor to the AT-capable port

2011-12-08 Thread Marcel Holtmann
Hi Philippe, > gatchat/gatchat.c | 26 ++ > gatchat/gatchat.h |4 > 2 files changed, 30 insertions(+), 0 deletions(-) > > diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c > index 7a0ef35..00e5fa8 100644 > --- a/gatchat/gatchat.c > +++ b/gatchat/gatchat.c > @@

Re: [RFC_v1 2/2] sierra: Add SIM state polling

2011-12-05 Thread Marcel Holtmann
Hi Denis, > >> - The sierra driver does not instantiate any gprs_context drivers, so it > >> isn't even capable of GPRS in its current state. Sending the&C0 > >> command is only needed if you are planning to use PPP and probably > >> belongs in a separate patch. > >> > > > > I didn't see the gpr

Re: [PATCH 0/5] udev rules update

2011-11-29 Thread Marcel Holtmann
Hi Philippe, > This set of patches have been sent this summer but not upstreamed. > As few bugs have been opened which could be fixed by those patches, I resend > them > for review. > > - For Speedup dongles, the logic in udevng is to assign the modem port on the > latest interface. This is not

oFono 1.0 has been released

2011-10-16 Thread Marcel Holtmann
Hello everybody, I am pleased to announce that we have released oFono 1.0 this week. This marks a major step for oFono and we consider it fully feature complete for 2G and 3G telephony. oFono is released under GPL version 2 and is 100% open source. It includes support for the majority of data mod

Re: [PATCH] udevng: add a driver name for telit

2011-10-15 Thread Marcel Holtmann
Hi Gustavo, > telit hardware needs usbserial. > --- > plugins/udevng.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listin

Re: [VPATH PATCH 2/2] Fix $(INCLUDE) in Makefile.am

2011-08-30 Thread Marcel Holtmann
Hi Pekka, > Allow using directory names as namespaces. > --- > Makefile.am |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index 832c8ac..92ef72e 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -447,7 +447,8 @@ AM_CFLAGS = @DBUS_CFL

Re: [VPATH PATCH 1/2] Fix generating links in Makefile.am

2011-08-30 Thread Marcel Holtmann
Hi Pekka, > In case relative dependency is in $(srcdir), $< already includes path to > $(srcdir). > --- > Makefile.am |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing l

Re: [PATCH 0/3] oFono rules update

2011-08-24 Thread Marcel Holtmann
Hi Philippe, > Actually, with this dongle, we have 6 TTY (usb0 -> usb5) and usb-devices > gives: > > T: Bus=02 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 32 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=19d2 ProdID=0124 Rev=00.00 > S: Manufacturer=ZTE,Inc

Re: [PATCH 0/3] oFono rules update

2011-08-23 Thread Marcel Holtmann
Hi Phillipe, > >> Based on the latest usb_modeswitch rules, some 3G dongles require > >> to modify the ofono rules to be supported correctly (tests done in India) > >> > >> > >> Philippe Nunes (3): > >>udev: use ttyUSB3 for ZTE K3570 modem port. > >>udev: add support for Olive HSDPA modem

Re: [PATCH] udev: Fix typo for Huawei diagnostic interfaces

2011-08-17 Thread Marcel Holtmann
Hi Daniel, > plugins/udevng.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: Underlying Bluetooth device of a modem

2011-08-12 Thread Marcel Holtmann
Hi Gustavo, > > > > > I am trying to set up a simple HFP demonstrator using > > > > > BlueZ+oFono+PulseAudio, with a dbus client that coordinates the three > > > > > of > > > > > them. Being a simple prototype, the goal is to see how they behave > > > > > and > > > > > analyze how well it wou

Re: Underlying Bluetooth device of a modem

2011-08-12 Thread Marcel Holtmann
Hi Mikel, > I am trying to set up a simple HFP demonstrator using > BlueZ+oFono+PulseAudio, with a dbus client that coordinates the three of > them. Being a simple prototype, the goal is to see how they behave and > analyze how well it would all scale. > > The first q

Re: Underlying Bluetooth device of a modem

2011-08-11 Thread Marcel Holtmann
Hi Gustavo, > > > I am trying to set up a simple HFP demonstrator using > > > BlueZ+oFono+PulseAudio, with a dbus client that coordinates the three of > > > them. Being a simple prototype, the goal is to see how they behave and > > > analyze how well it would all scale. > > > > > > The first q

Re: [PATCH 0/3] oFono rules update

2011-08-11 Thread Marcel Holtmann
Hi Philippe, > Based on the latest usb_modeswitch rules, some 3G dongles require > to modify the ofono rules to be supported correctly (tests done in India) > > > Philippe Nunes (3): > udev: use ttyUSB3 for ZTE K3570 modem port. > udev: add support for Olive HSDPA modem > udev: Use ttyU

Re: Underlying Bluetooth device of a modem

2011-08-10 Thread Marcel Holtmann
Hi Mikel, > I am trying to set up a simple HFP demonstrator using > BlueZ+oFono+PulseAudio, with a dbus client that coordinates the three of > them. Being a simple prototype, the goal is to see how they behave and > analyze how well it would all scale. > > The first question that arises is qui

Re: [PATCH_v5 7/8] huaweicdmamodem: create a huawei cdma driver.

2011-08-05 Thread Marcel Holtmann
Hi Bertrand, > Makefile.am|6 + > drivers/huaweicdmamodem/huaweicdmamodem.c | 45 +++ > drivers/huaweicdmamodem/huaweicdmamodem.h | 23 > drivers/huaweicdmamodem/network-registration.c | 159 > > 4 files cha

RE: [PATCH] speedup: blacklist the NO CARRIER terminator for control channel

2011-08-04 Thread Marcel Holtmann
Hi Bertrand, > > > Some Speedup cards will send the NO CARRIER in the control channel. > > > > please include a trace. I am not sure how this effect anything since we > > are not supporting online/offline mode with these cards. > > Ok, no problem. What kind of test do you want me to do? > > I m

Re: [PATCH] speedup: blacklist the NO CARRIER terminator for control channel

2011-08-04 Thread Marcel Holtmann
Hi Bertrand, > Some Speedup cards will send the NO CARRIER in the control channel. please include a trace. I am not sure how this effect anything since we are not supporting online/offline mode with these cards. Regards Marcel ___ ofono mailing list

Re: [PATCH] udev: add support for Olive HSDPA modem, which seems to be a SpeedUP.

2011-08-04 Thread Marcel Holtmann
Hi Bertrand, > plugins/ofono.rules |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

RE: [PATCH 4/4] atmodem: Add support for the PIN counter command AT+CPNNUM

2011-08-04 Thread Marcel Holtmann
Hi Bertrand, > > > drivers/atmodem/sim.c | 95 > > + > > > 1 files changed, 95 insertions(+), 0 deletions(-) > > > > please include an OFONO_AT_DEBUG trace of this AT command. > > I have attached a full log from a SpeedUp dongle, but here is the

Re: [PATCH] Add missing PreferredLanguages property to SimManager documentation

2011-08-04 Thread Marcel Holtmann
Hi Alex, > > patch has been applied, but I had to fix up the commit message for to > > have a proper prefix. Keep that in mind next time. > > Perhaps this rule should be documented too :) you do know the answer to this one, patches are welcome ;) Regards Marcel __

Re: [PATCH] Add missing PreferredLanguages property to SimManager documentation

2011-08-04 Thread Marcel Holtmann
Hi Alex, > doc/sim-api.txt |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) patch has been applied, but I had to fix up the commit message for to have a proper prefix. Keep that in mind next time. Regards Marcel ___ ofono mailing li

Re: [PATCH] dunmodem: Add stub for gprs.

2011-08-03 Thread Marcel Holtmann
Hi Mario, > Makefile.am |3 +- > drivers/dunmodem/dunmodem.c |2 + > drivers/dunmodem/dunmodem.h |3 + > drivers/dunmodem/gprs.c | 99 > +++ > 4 files changed, 106 insertions(+), 1 deletions(-) > create mode 100644 driver

Re: [PATCH] cdmamodem: remove an unneeded buffer and sprintf.

2011-08-03 Thread Marcel Holtmann
Hi Bertrand, > drivers/cdmamodem/connman.c |5 + > 1 files changed, 1 insertions(+), 4 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

<    1   2   3   4   5   6   7   8   9   10   >