RE: [PATCH 02/12] gprs: driver interface changes for IPv6

2011-02-08 Thread Mika.Liljeberg
Hi Denis, > >>> +enum ofono_gprs_addrconf { > >>> + OFONO_GPRS_ADDRCONF_NONE, > >>> + OFONO_GPRS_ADDRCONF_STATIC, > >>> + OFONO_GPRS_ADDRCONF_DHCP, > >>> +}; > >>> + > >> > >> What exactly is the _NONE addrconf for? And why don't we use > >> a gboolean > >> here like before? > > > > Neither "s

RE: [PATCH 02/12] gprs: driver interface changes for IPv6

2011-02-08 Thread Mika.Liljeberg
Hi Marcel, Thanks for the comments. > > Normally, IPv6 addresses and routes are autoconfigured > using IPv6 stateless address autoconfiguration followed > optionally by DHCPv6 to get additional settings. The kernel > actually starts stateless address autoconfiguration > immediately when the

RE: [PATCH 02/12] gprs: driver interface changes for IPv6

2011-02-07 Thread Marcel Holtmann
Hi Mika, > > > +enum ofono_gprs_addrconf { > > > + OFONO_GPRS_ADDRCONF_NONE, > > > + OFONO_GPRS_ADDRCONF_STATIC, > > > + OFONO_GPRS_ADDRCONF_DHCP, > > > +}; > > > + > > > > What exactly is the _NONE addrconf for? And why don't we use > > a gboolean > > here like before? > > Neither "static" no

Re: [PATCH 02/12] gprs: driver interface changes for IPv6

2011-02-07 Thread Denis Kenzior
Hi Mika, On 02/07/2011 03:55 AM, mika.liljeb...@nokia.com wrote: > Hi Denis, > > Thanks for the comments. > >>> +enum ofono_gprs_addrconf { >>> + OFONO_GPRS_ADDRCONF_NONE, >>> + OFONO_GPRS_ADDRCONF_STATIC, >>> + OFONO_GPRS_ADDRCONF_DHCP, >>> +}; >>> + >> >> What exactly is the _NONE addrc

RE: [PATCH 02/12] gprs: driver interface changes for IPv6

2011-02-07 Thread Mika.Liljeberg
Hi Denis, Thanks for the comments. > > +enum ofono_gprs_addrconf { > > + OFONO_GPRS_ADDRCONF_NONE, > > + OFONO_GPRS_ADDRCONF_STATIC, > > + OFONO_GPRS_ADDRCONF_DHCP, > > +}; > > + > > What exactly is the _NONE addrconf for? And why don't we use > a gboolean > here like before? Neither "

Re: [PATCH 02/12] gprs: driver interface changes for IPv6

2011-02-04 Thread Denis Kenzior
Hi Mika, > +enum ofono_gprs_addrconf { > + OFONO_GPRS_ADDRCONF_NONE, > + OFONO_GPRS_ADDRCONF_STATIC, > + OFONO_GPRS_ADDRCONF_DHCP, > +}; > + What exactly is the _NONE addrconf for? And why don't we use a gboolean here like before? > struct ofono_gprs_primary_context { > unsig

[PATCH 02/12] gprs: driver interface changes for IPv6

2011-02-03 Thread Mika Liljeberg
--- include/gprs-context.h | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/include/gprs-context.h b/include/gprs-context.h index c29c0dc..88530f6 100644 --- a/include/gprs-context.h +++ b/include/gprs-context.h @@ -37,6 +37,7 @@ struct ofono_gprs_conte