Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-23 Thread Neil Jerram
Marcel Holtmann mar...@holtmann.org writes: Hi Neil, (I don't yet understand why it makes sense for calypso to be handled differently from other cases in plugins/ofono.rules, but I'm happy to trust that there is a good reason for this.) the other cases come from an unique vendor and

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-22 Thread Marcel Holtmann
Hi Neil, Then I didn't look far back enough (or I'm simply blind). But I still prefer this to be inside the driver or HACKING.calypso for easier access. I am with you that this needs to be documented better than GIT commit logs. However I do prefer doc/calypso-modem.txt and

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Neil Jerram
Denis Kenzior denk...@gmail.com writes: We prefer if you use git send-email to format the patch for submission. Sure, I will do that in future. Thanks for looking at the patch anyway. I think the better way would be to drop a udev rule directly into /etc/udev.d or similar. The rule should

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Denis Kenzior
Hi Neil, I think the better way would be to drop a udev rule directly into /etc/udev.d or similar. The rule should be as simple as: KERNEL==ttySAC0, ENV{OFONO_DRIVER}=calypso Do you mean in another file than 97-ofono.rules? Yep. Regards, -Denis

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Marcel Holtmann
Hi Denis, I think the better way would be to drop a udev rule directly into /etc/udev.d or similar. The rule should be as simple as: KERNEL==ttySAC0, ENV{OFONO_DRIVER}=calypso Do you mean in another file than 97-ofono.rules? Yep. I prefer not to have this inside ofono.git at all.

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Denis Kenzior
Hi Marcel, On 12/21/2010 12:13 PM, Marcel Holtmann wrote: Hi Denis, I think the better way would be to drop a udev rule directly into /etc/udev.d or similar. The rule should be as simple as: KERNEL==ttySAC0, ENV{OFONO_DRIVER}=calypso Do you mean in another file than 97-ofono.rules?

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Marcel Holtmann
Hi Denis, We could document this as Freerunner specific notes to point people into the right direction. And we should maybe to the same for IFX since that is currently only documented in the GIT commit logs. Documentation inside the individual modem driver is the way to go. And IFX

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Denis Kenzior
Hi Marcel, On 12/21/2010 01:05 PM, Marcel Holtmann wrote: Hi Denis, We could document this as Freerunner specific notes to point people into the right direction. And we should maybe to the same for IFX since that is currently only documented in the GIT commit logs. Documentation inside

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Marcel Holtmann
Hi Denis, We could document this as Freerunner specific notes to point people into the right direction. And we should maybe to the same for IFX since that is currently only documented in the GIT commit logs. Documentation inside the individual modem driver is the way to go. And IFX

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Denis Kenzior
Hi Marcel, Then I didn't look far back enough (or I'm simply blind). But I still prefer this to be inside the driver or HACKING.calypso for easier access. I am with you that this needs to be documented better than GIT commit logs. However I do prefer doc/calypso-modem.txt and

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Neil Jerram
Denis Kenzior denk...@gmail.com writes: Hi Marcel, Then I didn't look far back enough (or I'm simply blind). But I still prefer this to be inside the driver or HACKING.calypso for easier access. I am with you that this needs to be documented better than GIT commit logs. However I do

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-20 Thread Denis Kenzior
Hi Neil, On 12/15/2010 04:12 PM, Neil Jerram wrote: Hi all, With the patch below, ofono-0.36 (the current Debian unstable version) detects the calypso modem on my freerunner. (Whereas without it, it doesn't.) We prefer if you use git send-email to format the patch for submission. For now

PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-15 Thread Neil Jerram
2001 From: Neil Jerram n...@ossau.uklinux.net Date: Wed, 15 Dec 2010 21:56:50 + Subject: [PATCH] Enable udev-based autodetection of calypso modem on Freerunner As https://ofono.org/wiki/ofono-supported-modems says for calypso: It works with modem.conf. However it may need udev rule now