Re: [PATCH v2] ppp: using RX ACCM = 0 by default

2021-01-07 Thread Denis Kenzior
for Ofono by default as pppd does for instance. This will reduce PPP data overhead as well. --- gatchat/gatppp.c | 5 + gatchat/gatppp.h | 1 + gatchat/ppp.h | 1 + gatchat/ppp_lcp.c | 15 ++- 4 files changed, 21 insertions(+), 1 deletion(-) Applied, thanks. Regards

[PATCH v2] ppp: using RX ACCM = 0 by default

2021-01-07 Thread s . e . golubtsov
PPP data overhead as well. --- gatchat/gatppp.c | 5 + gatchat/gatppp.h | 1 + gatchat/ppp.h | 1 + gatchat/ppp_lcp.c | 15 ++- 4 files changed, 21 insertions(+), 1 deletion(-) diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c index 141e2746..259e6d5c 100644 --- a/gatchat

Re: [PATCH ppp] ppp: Apply configuration options from a DCE request if ACK it

2021-01-04 Thread Denis Kenzior
Hi Sergei, On 1/1/21 3:04 PM, s.e.golubt...@gmail.com wrote: From: Sergei Golubtsov Apply configuration options if the DCE sends a PPP LCP configure request and the DTE is going to ACK the request. Otherwise some options such as the ACCM may not correspond to the configuration negotiated

[PATCH ppp] ppp: Apply configuration options from a DCE request if ACK it

2021-01-01 Thread s . e . golubtsov
From: Sergei Golubtsov Apply configuration options if the DCE sends a PPP LCP configure request and the DTE is going to ACK the request. Otherwise some options such as the ACCM may not correspond to the configuration negotiated with the DCE. --- gatchat/ppp_cp.c | 7 +-- 1 file changed, 5

Re: Unable to establish ppp connection with Huawei dongle

2020-09-02 Thread Rakes Pani
/* Using the default ACCM */ @@ -392,7 +446,8 @@ struct pppcp_data *lcp_new(GAtPPP *ppp, gboolean is_server) pppcp_set_data(pppcp, lcp); - lcp_reset_config_options(lcp); + //lcp_reset_config_options(pppcp,lcp); + lcp_generate_config_options_modified(pppcp,lcp);

Re: Unable to establish ppp connection with Huawei dongle

2020-09-02 Thread Lars Poeschel
gt; 2. enable-modem (ofono-testclient) > 3. create-internet-context airtelgprs.com(ofono-testclient) > 4. online-modem (ofono-testclient) > 5. echo -e -n 'AT+CGDCONT=1,"IP","airtelgprs.com"\r' > /dev/ttyUSB0 > 6. echo -e -n 'AT+CGDATA="PPP",1\r' &g

Re: Unable to establish ppp connection with Huawei dongle

2020-09-02 Thread rakespani
. 1. list-modems (ofono-testclient) 2. enable-modem (ofono-testclient) 3. create-internet-context airtelgprs.com(ofono-testclient) 4. online-modem (ofono-testclient) 5. echo -e -n 'AT+CGDCONT=1,"IP","airtelgprs.com"\r' > /dev/ttyUSB0 6. echo -e -n 'AT+CGDATA="PPP&qu

Re: Unable to establish ppp connection with Huawei dongle

2020-08-31 Thread Lars Poeschel
cgdcont_cb() ok 1 1. You use ofono-1.24 which is fairly old. Latest release is 1.31 so far. > Aug 26 11:36:28 raspberrypi3 daemon.info ofonod[147]: Modem: > > AT+CGDATA="PPP",1\r > Aug 26 11:36:28 raspberrypi3 daemon.info ofonod[147]: Modem: < \r\nCONNECT > 1\r

Unable to establish ppp connection with Huawei dongle

2020-08-26 Thread rakespani
7]: Modem: < \r\nOK\r\n Aug 26 11:36:28 raspberrypi3 daemon.debug ofonod[147]: ../ofono-1.24/drivers/atmodem/gprs-context.c:at_cgdcont_cb() ok 1 Aug 26 11:36:28 raspberrypi3 daemon.info ofonod[147]: Modem: > AT+CGDATA="PPP",1\r Aug 26 11:36:28 raspberrypi3 daemon.info ofonod[147]: Mod

Re: [PATCH] - oFono v1.31 stuck in loop when unplugging a USB dongle connected via PPP

2019-11-21 Thread Denis Kenzior
Hi Jimmy, On 11/19/19 4:53 AM, Jimmy Gysens wrote: Hi, After unplugging a Huawei USB dongle, the 'atoms' in oFono are removed via 'flush_atoms'. Every atom has a destruct function pointer, used as a - yes - destructor. When unplugging a dongle, connected via PPP, oFono will remove

[PATCH] - oFono v1.31 stuck in loop when unplugging a USB dongle connected via PPP

2019-11-19 Thread Jimmy Gysens
Hi, After unplugging a Huawei USB dongle, the 'atoms' in oFono are removed via 'flush_atoms'. Every atom has a destruct function pointer, used as a - yes - destructor. When unplugging a dongle, connected via PPP, oFono will remove the current GPRS context (= data connection). The function

[PATCH 4/4] atmodem: Use atd99 as ppp command for ublox

2019-05-31 Thread Philippe De Swert
Seems a number of ublox modems (unlike specified) do not support the AT+CGDATA command. So let's use atd99 instead which does seem to work. --- drivers/atmodem/gprs-context.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/atmodem/gprs-context.c

Re: [PATCH] ppp: Allow to set-up ppp connection without authentification

2019-05-31 Thread Philippe De Swert
ad of > trying to set G_AT_PPP_AUTH_METHOD_NONE. > > Maybe we should just revert that patch completely instead and force PPP > based drivers to always use CHAP even if no authentication is > configured, the way it used to be. > Might be an option too, anyway t

Re: [PATCH] ppp: Allow to set-up ppp connection without authentification

2019-05-30 Thread Denis Kenzior
Hi Philippe, On 05/30/2019 11:26 AM, Philippe De Swert wrote: When using RCR_REJECT no ppp connection will be established. It used to work before, and this was a side-effect of commit 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645 See also this thread: https://lists.ofono.org/pipermail/ofono/2019

[PATCH] ppp: Allow to set-up ppp connection without authentification

2019-05-30 Thread Philippe De Swert
When using RCR_REJECT no ppp connection will be established. It used to work before, and this was a side-effect of commit 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645 See also this thread: https://lists.ofono.org/pipermail/ofono/2019-January/019067.html --- gatchat/ppp_lcp.c | 2 +- 1 file changed

Re: [PATCH 8/8] Fix gprs_netreg_update behaviour if PPP connection active

2019-02-17 Thread Denis Kenzior
Hi Tommi, On 02/15/2019 06:11 AM, philippedesw...@gmail.com wrote: From: Tommi Rekosuo If a PPP connection is active, the modem can't detach before the PPP connection has been disabled. This can happen if I don't believe this is true for every modem. What exactly is your modem doing here

[PATCH 8/8] Fix gprs_netreg_update behaviour if PPP connection active

2019-02-15 Thread philippedeswert
From: Tommi Rekosuo If a PPP connection is active, the modem can't detach before the PPP connection has been disabled. This can happen if RoamingAllowed is changed when connection is active. This leaves connman in undefined state as the context 'Active' state is not propagated properly

Re: PPP broken by 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645

2019-01-04 Thread Giacinto Cifelli
; > diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c > index 3fe38217..4aa63207 100644 > --- a/gatchat/ppp_lcp.c > +++ b/gatchat/ppp_lcp.c > @@ -281,7 +281,8 @@ static enum rcr_result lcp_rcr(struct pppcp_data *pppcp, > return RCR_NAK; > > case G_AT_P

Re: PPP broken by 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645

2019-01-04 Thread Denis Kenzior
Hi Martin, It doesn't work, because the early return skips the call to ppp_set_auth() in the last switch block. Calling the function before returning works though: This is still wrong. lcp_rcr processes many options, AUTH_PROTO being only a small subset. So you can't simply return

Re: PPP broken by 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645

2019-01-04 Thread Martin Hundebøll
G_AT_PPP_AUTH_METHOD_NONE: - return RCR_REJECT; + ppp_set_auth(ppp, ppp_option_iter_get_data()); + return RCR_ACCEPT; } break; } // Martin

Re: PPP broken by 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645

2019-01-04 Thread Martin Hundebøll
Hi Giacinto, On 04/01/2019 15.30, Giacinto Cifelli wrote: Seems commit 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645 broke PPP for me in 1.27 (updating from 1.24) After reverting the commit (without removing the header file include to not break compilation) PPP was back to working for me

Re: PPP broken by 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645

2019-01-04 Thread Giacinto Cifelli
; Is your PDP context configured for AUTH_NONE, PAP or CHAP? > > AUTH_NONE. > > > And what happens if you change it? > > It took me a while to understand this was the issue as I had another > sim who would request CHAP and that one worked (even if it was empty > user

Re: PPP broken by 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645

2019-01-04 Thread Philippe De Swert
ured for AUTH_NONE, PAP or CHAP? AUTH_NONE. > And what happens if you change it? It took me a while to understand this was the issue as I had another sim who would request CHAP and that one worked (even if it was empty username and pass, operators are weird..) So from what I have seen I would say the

Re: PPP broken by 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645

2019-01-04 Thread Giacinto Cifelli
hi Philippe, On Fri, Jan 4, 2019 at 3:13 PM Philippe De Swert wrote: > > Hi, > > Seems commit 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645 broke PPP for > me in 1.27 (updating from 1.24) After reverting the commit (without > removing the header file include to not break compilati

PPP broken by 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645

2019-01-04 Thread Philippe De Swert
Hi, Seems commit 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645 broke PPP for me in 1.27 (updating from 1.24) After reverting the commit (without removing the header file include to not break compilation) PPP was back to working for me. The comments for a88662d23c45f49d9af5a508d4d0a778950b2420 made

Re: huawei: modem channel gets closed after PPP disconnection

2017-02-17 Thread Denis Kenzior
Hi Christophe, So only network interface appears (connection) and vanishes (disconnection). Okay, good. So nothing more than a POLLERR|POLLHUP event on modem channel. okay, but the socket still has to be reopened I guess due to the POLLHUP. If you are OK, I'll send patch next week.

Re: huawei: modem channel gets closed after PPP disconnection

2017-02-17 Thread Christophe Ronco
this. Also, a udev event monitor might help to tell if the tty is being physically removed / reinserted. I've done the connect/disconnect operation with strace and a udev event monitor. The PPP modem channel is /dev/ttyUSB1. Here is the result of the udev event monitor: root@klk-lpbs-040070

Re: huawei: modem channel gets closed after PPP disconnection

2017-02-16 Thread Denis Kenzior
Hi Christophe, On 02/16/2017 03:26 AM, Christophe Ronco wrote: Hi, I use a huawei E3372 modem. It connects to GPRS using PPP. I am able to activate context and then deactivate it. After that, I am not able to reactivate the context. During deactivation, the AT channel used by PPP gets closed

huawei: modem channel gets closed after PPP disconnection

2017-02-16 Thread Christophe Ronco
Hi, I use a huawei E3372 modem. It connects to GPRS using PPP. I am able to activate context and then deactivate it. After that, I am not able to reactivate the context. During deactivation, the AT channel used by PPP gets closed and nobody reopens it. During reactivation, the first

Re: [help] connect 2 APN at the same time (PPP and QMI)

2014-12-05 Thread Mylene Josserand
I am going to read/add debug in connman's code (plugin/ofono.c), I will post again if I find something. I found something _very_ useful : https://github.com/aldebaran/connman/blob/master/plugins/ofono.c#L1074 Connman supports only one Internet context per modem that is why my 2nd context

Re: [help] connect 2 APN at the same time (PPP and QMI)

2014-12-04 Thread Mylene Josserand
and udevng to allocate 2 gprs-contexts. One using the QMI driver and the other using PPP. e.g. something like: gc = ofono_gprs_context_create(modem, 0, qmimodem, device); ofono_gprs_add_context(gprs, gc); gc = ofono_gprs_context_create(modem, 0, atmodem, ppp_chat

Re: [help] connect 2 APN at the same time (PPP and QMI)

2014-12-04 Thread Mylene Josserand
missed ? I continued to look around and I succeed to make it work ! I looked to other modem plugins. I think I understand what the slave is thanks to that. It is the other interfaces to send AT commands, only, whereas the main GAtChat serves to create the PPP connection, is not it ? If I am wrong

Re: [help] connect 2 APN at the same time (PPP and QMI)

2014-12-04 Thread Denis Kenzior
Hi Mylene, I looked to other modem plugins. I think I understand what the slave is thanks to that. It is the other interfaces to send AT commands, only, whereas the main GAtChat serves to create the PPP connection, is not it ? If I am wrong, do not hesitate to make me understand how

[help] connect 2 APN at the same time (PPP and QMI)

2014-12-03 Thread Mylene Josserand
Hi everyone, I am new to Ofono and I need some advices. My modem has two interfaces : one interface on which I can do a PPP connection and another interface QMI to make wwan connection. My SIM card has 2 APNs and I must connect to them simultaneously. So, I need to be connected in PPP

Re: [help] connect 2 APN at the same time (PPP and QMI)

2014-12-03 Thread Denis Kenzior
Hi Mylene, My modem has two interfaces : one interface on which I can do a PPP connection and another interface QMI to make wwan connection. My SIM card has 2 APNs and I must connect to them simultaneously. So, I need to be connected in PPP with APN1 and in qmi/wwan with APN2. This sort

[PATCH 0/3] Provision the PPP authentication method from mbpi

2014-06-24 Thread Philip Paeps
My patch to the mobile-broadband-provider-info database DTD to add an attribute indicating the authentication method to use was accepted by the maintainers[1] and merged in their tree[2]. This set of patches adds support for the new attribute in the mbpi plugin so new GPRS contexts can be

Re: [PATCH 0/3] Provision the PPP authentication method from mbpi

2014-06-24 Thread Denis Kenzior
Hi Philip, On 06/24/2014 04:57 AM, Philip Paeps wrote: My patch to the mobile-broadband-provider-info database DTD to add an attribute indicating the authentication method to use was accepted by the maintainers[1] and merged in their tree[2]. This set of patches adds support for the new

[PATCH 4/5] gprs: make PPP authentication method configurable

2014-06-19 Thread Philip Paeps
Add a new AuthenticationMethod property to select between pap and chap PPP authentication, defaulting to chap (i.e.: previous behaviour). --- src/gprs.c | 84 1 file changed, 84 insertions(+) diff --git a/src/gprs.c b/src/gprs.c

[PATCH 3/5] atmodem: set the PPP authentication method to use

2014-06-19 Thread Philip Paeps
state { struct gprs_context_data { GAtChat *chat; unsigned int active_context; + GAtPPPAuthMethod auth_method; char username[OFONO_GPRS_MAX_USERNAME_LENGTH + 1]; char password[OFONO_GPRS_MAX_PASSWORD_LENGTH + 1]; GAtPPP *ppp; @@ -154,6 +155,7 @@ static

Re: [PATCH 2/3] gprs: make PPP authentication method configurable

2014-06-18 Thread Denis Kenzior
Hi Philip, On 06/17/2014 04:57 PM, Philip Paeps wrote: Add a new AuthMethod property to select between pap and chap PPP authentication, defaulting to chap (i.e.: previous behaviour). Signed-off-by: Philip Paeps phi...@paeps.cx No signed-off-by please... --- doc/connman-api.txt

[PATCH 2/3] gprs: make PPP authentication method configurable

2014-06-17 Thread Philip Paeps
Add a new AuthMethod property to select between pap and chap PPP authentication, defaulting to chap (i.e.: previous behaviour). Signed-off-by: Philip Paeps phi...@paeps.cx --- doc/connman-api.txt|4 ++ drivers/atmodem/gprs-context.c | 14 +++ include/gprs-context.h

PPP ofono and Connman

2014-02-17 Thread Freedreamer
Hi all, on my embedded system I got 3 interfaces : wifi , ethernet and gprs and I decided to handle 'em with connman. When I start a ppp connection with ofono everything seems to work properly , I got the DNS and with the test script I can process ppp parameter. ifconfig command shows the ppp0

ppp negotiation failing- Huawei E392

2013-09-19 Thread Prashant Kumar
hi all, i'm unable to get the ppp interface after doing *activate_context* script in the test directory of ofono-1.6. please find log in the attachment. please help me to solve this issue. thanks and regards prashant kumar ofonod[28384]: drivers/atmodem/gprs

Re: PPP negotiation failing

2013-09-18 Thread Fabio S. Higa
Hello all, oFono's PPP stack only supports CHAP. Patches are of course always welcome. I resolved this issue with the modem Telit GE910 sending the command AT#GAUTH=2 in order to set the authentication to CHAP. I have added this command on function telit_post_sim(), before

Re: PPP connection to a private APN

2013-08-12 Thread Jesper Larsen
On Mon, Aug 12, 2013 at 11:19 AM, Etienne Mabille mabille.etie...@gmail.com wrote: 2013/8/9 Denis Kenzior denk...@gmail.com Another topic is the authentication protocol. By default the Telit HE910 uses PAP which is not handled by ofono. I started to implement it in gatchat/ppp_auth.c it

PPP connection to a private APN

2013-08-02 Thread Etienne Mabille
Hi everyone, I am forced to work with version 1.3 of oFono and I want to setup a ppp connection on a private APN. It works well on a public APN but not on the private one. I looked at the debug trace and it seems like oFono doesn't give the username and password anywhere in the AT commands

Re: tun interface name conflicts with ppp driver

2012-12-06 Thread Marcel Holtmann
Hi Cedric, when a context is active, the interface name is typically ppp0. If you try to run pppd for some other device/interface, the kernel ppp driver prints an error because it can't register ppp0. It looks like it's assumed that ppp* interface names are reserved for the ppp_driver. Can

Re: tun interface name conflicts with ppp driver

2012-12-06 Thread Cedric Jehasse
Hi Marcel, actually we are using ppp%d syntax to assign the network interfaces. So the kernel does the numbering. This is a bug in pppd and not ours. Looking at the pppd code, it seems to hardcodes ppp0. So please complain to them for assuming that a certain device name is owned by them

Re: tun interface name conflicts with ppp driver

2012-12-06 Thread Marcel Holtmann
Hi Cedric, actually we are using ppp%d syntax to assign the network interfaces. So the kernel does the numbering. This is a bug in pppd and not ours. Looking at the pppd code, it seems to hardcodes ppp0. So please complain to them for assuming that a certain device name is owned by them

Re: PPP disconnected via Huawei modem

2012-08-21 Thread Фьодор
2010/11/11 Chen Yuwei yuwac...@gmail.com Hi, I use MeeGo NB 10/26 release to browse some website via Huawei modem, The PPP connection is disconnected when recieve a PPP event (RXJ-). Then the PPP can not be connected anymore. Why? What condition does ofono recieve this event? The ofono

PPP disconnet with Huawei modem

2012-08-21 Thread Chen Yuwei
Hi, I use MeeGo NB 10/26 release to browse some website via Huawei modem, The PPP connection is disconnected when recieve a PPP event (RXJ-). Then the PPP can not be connected anymore. Why? What condition does ofono recieve this event? The ofono also recieved udev event remove and removed

Unable to establish a complete PPP link on Sagem Hilo GPRS modem

2012-08-20 Thread Schroeter Nicolas
Hi, I am developing a plugin for the Sagem Hilo GPRS modem. I use the ofono version 1.10. When I activate the GPRS context, I never get a complete established PPP link. The PPP debug is: Jan 2 16:24:36 109656587698 daemon.info ofonod[600]: Aux: AT+CGATT=1\r Jan 2 16:24:39 109656587698

Re: Unable to establish a complete PPP link on Sagem Hilo GPRS modem

2012-08-20 Thread Denis Kenzior
109656587698 daemon.debug ofonod[600]: drivers/atmodem/gprs-context.c:setup_ppp() Jan 2 16:25:14 109656587698 daemon.info ofonod[600]: PPP: lcp: pppcp_generate_event: current state 0:INITIAL Jan 2 16:25:14 109656587698 daemon.info ofonod[600]: PPP: event: 0 (Up), action: 2, new_state: 2 (CLOSED

Re: Unable to establish a complete PPP link on Sagem Hilo GPRS modem

2012-08-20 Thread Schroeter Nicolas
109656587698 daemon.debug ofonod[600]: drivers/atmodem/gprs-context.c:setup_ppp() Jan 2 16:25:14 109656587698 daemon.info ofonod[600]: PPP: lcp: pppcp_generate_event: current state 0:INITIAL Jan 2 16:25:14 109656587698 daemon.info ofonod[600]: PPP: event: 0 (Up), action: 2, new_state: 2 (CLOSED

Re: [PATCH 1/2] dundee: add timeout to close stalled ppp handshake

2012-08-17 Thread Daniel Wagner
Hi Gustavo, On Tue, Aug 14, 2012 at 04:14:31AM -0300, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk If something goes wrong the PPP handshake can stall, then we just add a timer to return an error after a certain timeout (15 seconds). Both patches applied. I

[PATCH 1/2] dundee: add timeout to close stalled ppp handshake

2012-08-14 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk If something goes wrong the PPP handshake can stall, then we just add a timer to return an error after a certain timeout (15 seconds). --- dundee/dbus.c | 6 ++ dundee/device.c | 28 dundee/dundee.h | 1

[PATCH 5/8] gprs-context: print reason for ppp disconnect

2012-08-13 Thread Christopher Vogl
@@ static void ppp_disconnect(GAtPPPDisconnectReason reason, gpointer user_data) struct ofono_gprs_context *gc = user_data; struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc); - DBG(); + DBG(Reason: %d, reason); g_at_ppp_unref(gcd-ppp); gcd

Re: [PATCH 5/8] gprs-context: print reason for ppp disconnect

2012-08-13 Thread Denis Kenzior
Hi Christopher, On 08/13/2012 08:22 AM, Christopher Vogl wrote: --- drivers/atmodem/gprs-context.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list

Re: PPP connection is not established between DUN server(linux + ofono) and DUN client(Win7)

2012-07-03 Thread Guillaume Zajac
Hi Wu, On 03/07/2012 09:29, Zheng, Wu wrote: Hi, I am trying the DUN feature of ofono. DUN server: Linux kernel 3.0 and ofono-1.7 DUN client:win7 However, PPP connection is not established between DUN server(linux + ofono) and DUN client(Win7). DUN client(win7) keep at the status

RE: PPP connection is not established between DUN server(linux + ofono) and DUN client(Win7)

2012-07-03 Thread Zheng, Wu
Hi Zajac, Thanks for your help. PPP connection can be established after removing some PPP compression activated. Best regards Zheng wu -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Guillaume Zajac Sent: Tuesday, July 03, 2012 4:06 PM

[PATCH v6 15/16] dundee: Add PPP handling code to device

2012-04-02 Thread Daniel Wagner
registered; + GAtPPP *ppp; + GAtChat *chat; + char *name; gboolean active; struct ipv4_settings settings; + DBusMessage *pending; void *data; }; @@ -146,6 +154,27 @@ void __dundee_device_foreach(dundee_device_foreach_func func, void *userdata

[PATCH v5 15/16] dundee: Add PPP handling code to device

2012-01-04 Thread Daniel Wagner
; + GAtPPP *ppp; + GAtChat *chat; + char *name; gboolean active; struct ipv4_settings settings; + DBusMessage *pending; void *data; }; @@ -146,6 +154,27 @@ void __dundee_device_foreach(dundee_device_foreach_func func, void *userdata

[RFC v4 15/16] dundee: Add PPP handling code to device

2011-12-20 Thread Daniel Wagner
; + GAtPPP *ppp; + GAtChat *chat; + char *name; gboolean active; struct ipv4_settings settings; + DBusMessage *pending; void *data; }; @@ -146,6 +154,27 @@ void __dundee_device_foreach(dundee_device_foreach_func func, void *userdata

Re: [RFC v3 14/16] elect: Add GatChat and PPP handler

2011-12-14 Thread Denis Kenzior
Hi Daniel, On 12/13/2011 09:00 AM, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de --- Makefile.am |2 +- elect/dial.c | 125 +- 2 files changed, 125 insertions(+), 2 deletions(-) snip +static int

[RFC v3 13/16] elect: Add ppp callbacks to device

2011-12-13 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- elect/device.c | 103 1 files changed, 103 insertions(+), 0 deletions(-) diff --git a/elect/device.c b/elect/device.c index b404546..b4cbbfc 100644 --- a/elect/device.c +++

[RFC v3 14/16] elect: Add GatChat and PPP handler

2011-12-13 Thread Daniel Wagner
+#include gatchat.h +#include gattty.h +#include gatppp.h + #include elect.h +static const char *none_prefix[] = { NULL }; + struct elect_dial { char *path; void *data; + GAtPPP *ppp; + GAtChat *chat; + elect_dial_connect_cb_t connect_cb

[RFC v2 08/11] elect: Add ppp callbacks to device

2011-12-09 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- Makefile.am|2 +- elect/device.c | 96 elect/elect.h | 15 + 3 files changed, 112 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index

[RFC v2 09/11] elect: Add GatChat and PPP handler

2011-12-09 Thread Daniel Wagner
{ + char *path; + void *data; + + GAtPPP *ppp; + GAtChat *chat; + + elect_dun_connect_cb_t connect_cb; + elect_dun_disconnect_cb_t disconnect_cb; +}; + +static void dun_debug(const char *str, void *data) +{ + DBG(%s: %s\n, (const char *) data, str

[PATCH 0/2] PPP: recording ppp dump to file

2011-08-05 Thread Bertrand Aygon
Create a new env var to activate PPP dump recording into a file. Store this file in the PPP context, so the recording can occurs from the beginning of the session, and so we are sure to not loose any frame. Bertrand Aygon (2): gatppp: save dumpfile into ppp info to start recording during open

[PATCH 1/2] gatppp: save dumpfile into ppp info to start recording during open phase.

2011-08-05 Thread Bertrand Aygon
xmit_acfc; gboolean xmit_pfc; + gchar *dumpfile; }; void ppp_debug(GAtPPP *ppp, const char *str) @@ -541,6 +542,8 @@ gboolean g_at_ppp_open(GAtPPP *ppp, GAtIO *io) if (ppp-hdlc == NULL) return FALSE; + g_at_hdlc_set_recording(ppp-hdlc, ppp-dumpfile

[PATCH 2/2] gprs: use a new var env to active PPP dump.

2011-08-05 Thread Bertrand Aygon
(OFONO_PPP_DEBUG)) g_at_ppp_set_debug(gcd-ppp, ppp_debug, PPP); + dumpfile = getenv(OFONO_PPP_DUMP); + if (dumpfile) + g_at_ppp_set_recording(gcd-ppp, dumpfile); + g_at_ppp_set_credentials(gcd-ppp, gcd-username, gcd-password); /* set connect

Re: [PATCH 1/2] gatppp: save dumpfile into ppp info to start recording during open phase.

2011-08-05 Thread Denis Kenzior
+85,7 @@ struct _GAtPPP { gboolean suspended; gboolean xmit_acfc; gboolean xmit_pfc; + gchar *dumpfile; }; void ppp_debug(GAtPPP *ppp, const char *str) @@ -541,6 +542,8 @@ gboolean g_at_ppp_open(GAtPPP *ppp, GAtIO *io) if (ppp-hdlc == NULL

RE: [PATCH 1/2] gatppp: save dumpfile into ppp info to start recording during open phase.

2011-08-05 Thread Aygon, Bertrand
Hi Denis, @@ -541,6 +542,8 @@ gboolean g_at_ppp_open(GAtPPP *ppp, GAtIO *io) if (ppp-hdlc == NULL) return FALSE; + g_at_hdlc_set_recording(ppp-hdlc, ppp-dumpfile); + I force the start of the recording in the ppp_open. Without this change, if we call

Re: [PATCH 1/2] gatppp: save dumpfile into ppp info to start recording during open phase.

2011-08-05 Thread Denis Kenzior
Hi Bertrand, On 08/05/2011 10:06 AM, Aygon, Bertrand wrote: Hi Denis, @@ -541,6 +542,8 @@ gboolean g_at_ppp_open(GAtPPP *ppp, GAtIO *io) if (ppp-hdlc == NULL) return FALSE; + g_at_hdlc_set_recording(ppp-hdlc, ppp-dumpfile); + I force the start of the recording

RE: [PATCH 1/2] gatppp: save dumpfile into ppp info to start recording during open phase.

2011-08-05 Thread Aygon, Bertrand
Hi Denis, @@ -541,6 +542,8 @@ gboolean g_at_ppp_open(GAtPPP *ppp, GAtIO *io) if (ppp-hdlc == NULL) return FALSE; + g_at_hdlc_set_recording(ppp-hdlc, ppp-dumpfile); + I force the start of the recording in the ppp_open. Without this change, if we call

RE: [PATCH 1/2] gatppp: save dumpfile into ppp info to start recording during open phase.

2011-08-05 Thread Aygon, Bertrand
Hi, @@ -541,6 +542,8 @@ gboolean g_at_ppp_open(GAtPPP *ppp, GAtIO *io) if (ppp-hdlc == NULL) return FALSE; + g_at_hdlc_set_recording(ppp-hdlc, ppp-dumpfile); + I force the start of the recording in the ppp_open. Without this change, if we call

[PATCH_v3] speedupcdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-27 Thread Bertrand Aygon
--- plugins/speedupcdma.c | 91 +++- 1 files changed, 59 insertions(+), 32 deletions(-) diff --git a/plugins/speedupcdma.c b/plugins/speedupcdma.c index d11afb7..67bb617 100644 --- a/plugins/speedupcdma.c +++ b/plugins/speedupcdma.c @@ -37,10 +37,9

[PATCH_v2] huaweicdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-27 Thread Bertrand Aygon
--- plugins/huaweicdma.c | 106 +- 1 files changed, 87 insertions(+), 19 deletions(-) diff --git a/plugins/huaweicdma.c b/plugins/huaweicdma.c index 7288850..dccf17e 100644 --- a/plugins/huaweicdma.c +++ b/plugins/huaweicdma.c @@ -38,7 +38,8 @@

Re: [PATCH_v3] speedupcdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-27 Thread Marcel Holtmann
Hi Bertrand, plugins/speedupcdma.c | 91 +++- 1 files changed, 59 insertions(+), 32 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCH_v2] huaweicdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-27 Thread Marcel Holtmann
Hi Bertrand, plugins/huaweicdma.c | 106 +- 1 files changed, 87 insertions(+), 19 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org

[PATCH_v2] speedupcdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-26 Thread Bertrand Aygon
--- plugins/speedupcdma.c | 99 - 1 files changed, 73 insertions(+), 26 deletions(-) diff --git a/plugins/speedupcdma.c b/plugins/speedupcdma.c index d11afb7..8cb4dae 100644 --- a/plugins/speedupcdma.c +++ b/plugins/speedupcdma.c @@ -40,7 +40,8

[PATCH_v2] huaweicdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-26 Thread Bertrand Aygon
--- plugins/huaweicdma.c | 132 ++ 1 files changed, 111 insertions(+), 21 deletions(-) diff --git a/plugins/huaweicdma.c b/plugins/huaweicdma.c index 7288850..f819a24 100644 --- a/plugins/huaweicdma.c +++ b/plugins/huaweicdma.c @@ -37,8 +37,11 @@

Re: [PATCH_v2] speedupcdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-26 Thread Marcel Holtmann
Hi Bertrand, plugins/speedupcdma.c | 99 - 1 files changed, 73 insertions(+), 26 deletions(-) diff --git a/plugins/speedupcdma.c b/plugins/speedupcdma.c index d11afb7..8cb4dae 100644 --- a/plugins/speedupcdma.c +++

Re: [PATCH_v2] huaweicdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-26 Thread Marcel Holtmann
Hi Bertrand, plugins/huaweicdma.c | 132 ++ 1 files changed, 111 insertions(+), 21 deletions(-) since the code is still the same as speedupcdma, same comments apply here (minus the s/aux/pcui/ changes) ;) Regards Marcel

[PATCH] huaweicdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-24 Thread Bertrand Aygon
--- plugins/huaweicdma.c | 160 ++--- 1 files changed, 137 insertions(+), 23 deletions(-) diff --git a/plugins/huaweicdma.c b/plugins/huaweicdma.c index 4f45fec..be43bd7 100644 --- a/plugins/huaweicdma.c +++ b/plugins/huaweicdma.c @@ -23,7 +23,6 @@

[PATCH] speedupcdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-24 Thread Bertrand Aygon
--- plugins/speedupcdma.c | 135 ++--- 1 files changed, 105 insertions(+), 30 deletions(-) diff --git a/plugins/speedupcdma.c b/plugins/speedupcdma.c index b7e54a1..88f68f5 100644 --- a/plugins/speedupcdma.c +++ b/plugins/speedupcdma.c @@ -23,7 +23,6

Re: [PATCH] huaweicdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-24 Thread Marcel Holtmann
Huwei dongles that I had around and it just worked nicely. No more stupid TTY hangup. You can nicely switch between AT command and PPP mode. +static int huaweicdma_enable(struct ofono_modem *modem) +{ + struct huaweicdma_data *data = ofono_modem_get_data(modem); + + DBG(); + + data

Re: [PATCH] speedupcdma: open 2 ttys, to use a dedicated one for PPP.

2011-07-24 Thread Marcel Holtmann
Hi Bertrand, plugins/speedupcdma.c | 135 ++--- 1 files changed, 105 insertions(+), 30 deletions(-) diff --git a/plugins/speedupcdma.c b/plugins/speedupcdma.c index b7e54a1..88f68f5 100644 --- a/plugins/speedupcdma.c +++

[PATCH] CDMA ConnMan API: add username and password for PPP authentication.

2011-07-20 Thread Bertrand Aygon
--- doc/cdma-connman-api.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/cdma-connman-api.txt b/doc/cdma-connman-api.txt index e486c09..48699a3 100644 --- a/doc/cdma-connman-api.txt +++ b/doc/cdma-connman-api.txt @@ -35,6 +35,16 @@ Properties boolean

[PATCH 3/4] driver cdma-connman: add credential while setting up PPP if required

2011-07-20 Thread Guillaume Zajac
= ofono_cdma_connman_get_password(cm); + io = g_at_chat_get_io(cd-chat); g_at_chat_suspend(cd-chat); @@ -145,6 +150,9 @@ static gboolean setup_ppp(struct ofono_cdma_connman *cm) g_at_ppp_set_connect_function(cd-ppp, ppp_connect, cm); g_at_ppp_set_disconnect_function(cd-ppp

Re: [PATCH] CDMA ConnMan API: add username and password for PPP authentication.

2011-07-20 Thread Marcel Holtmann
Hi Bertrand, doc/cdma-connman-api.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/cdma-connman-api.txt b/doc/cdma-connman-api.txt index e486c09..48699a3 100644 --- a/doc/cdma-connman-api.txt +++ b/doc/cdma-connman-api.txt @@ -35,6 +35,16 @@

RE: [PATCH] CDMA ConnMan API: add username and password for PPP authentication.

2011-07-20 Thread Aygon, Bertrand
, gave up on it by now. We are in Indonesia, and for AHA operator, we have to give a username and a password. If we do not specify them, the PPP negotiation fails. So please try with an empty username + password and show us logs of what is happening on a real network. Which log? Pppd log? Regards

RE: [PATCH] CDMA ConnMan API: add username and password for PPP authentication.

2011-07-20 Thread Marcel Holtmann
that required them, gave up on it by now. We are in Indonesia, and for AHA operator, we have to give a username and a password. If we do not specify them, the PPP negotiation fails. Have you tried empty strings like . Have you tried random values? Do they have to be really specific ones

RE: [PATCH] CDMA ConnMan API: add username and password for PPP authentication.

2011-07-20 Thread Aygon, Bertrand
) CID: 0 : ATE0Q0V1\r : \r\nOK\r\n : AT+CFUN?\r : \r\n+CFUN: 1\r\n\r\nOK\r\n Current modem mode is 1 : ATD#777\r : \r\nCONNECT 310\r\n Username: a...@aha.co.id Password: (null) PPP: lcp: pppcp_generate_event: current state 0:INITIAL PPP: event: 0 (Up), action: 2, new_state: 2 (CLOSED) PPP: lcp

RE: [PATCH] CDMA ConnMan API: add username and password for PPP authentication.

2011-07-20 Thread Marcel Holtmann
two TTY cases. That is normal. Huawei treats the first TTY as modem to issue PPP on it. And the second one (PCUI) is used for notifications. So yes, oFono needs to open both. You will need the second one for network registration updates. Regards Marcel

RE: [PATCH] CDMA ConnMan API: add username and password for PPP authentication.

2011-07-20 Thread Aygon, Bertrand
it look cleaner. Thanks. For you two TTY cases. That is normal. Huawei treats the first TTY as modem to issue PPP on it. And the second one (PCUI) is used for notifications. So yes, oFono needs to open both. You will need the second one for network registration updates. But I think that if you

RE: [PATCH] CDMA ConnMan API: add username and password for PPP authentication.

2011-07-20 Thread Marcel Holtmann
Hi Bertrand, For you two TTY cases. That is normal. Huawei treats the first TTY as modem to issue PPP on it. And the second one (PCUI) is used for notifications. So yes, oFono needs to open both. You will need the second one for network registration updates. But I think that if you send

[PATCH] TODO: Set owner on ACFC and PFC PPP options

2011-06-06 Thread Guillaume Zajac
--- TODO |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 6dafba5..75e64d0 100644 --- a/TODO +++ b/TODO @@ -147,12 +147,14 @@ PPP Priority: Medium Complexity: C1 + Owner: Guillaume Zajac guillaume.za...@linux.intel.com - PFC support. Extend

Re: [PATCH] TODO: Set owner on ACFC and PFC PPP options

2011-06-06 Thread Denis Kenzior
Hi Guillaume, On 06/06/2011 09:45 AM, Guillaume Zajac wrote: --- TODO |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Thanks for taking up this task. Patch has been applied. Regards, -Denis ___ ofono mailing list ofono@ofono.org

[PATCH] fix ppp protocol-reject constructing error

2011-05-11 Thread Caiwen Zhang
In PPP Protocol-Reject package the 'rejected data field' should be a copy of the rejected package, the copy starts from the data field. besides, Protocol-Reject package include a 'rejected protocol field', it is the same as the protocol field of the rejected package. Protocol-Reject package

  1   2   3   4   >