Re: [Okular-devel] Review Request 126183: Add a FindPoppler module to ECM

> On Nov. 27, 2015, 9:47 p.m., Alex Merry wrote: > > find-modules/FindPoppler.cmake, lines 117-118 > > > > > > You used SKIP_PKG_CONFIG, so I doubt this comment is accurate. SKIP_PKG_CONFIG shouldn't be there, I

Re: [Okular-devel] Review Request 126183: Add a FindPoppler module to ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126183/#review88908 --- Looks good, but a few minor improvements can be made to docs a

Re: [Okular-devel] Review Request 126183: Add a FindPoppler module to ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126183/#review88904 --- Do you have the patch you'd use for okular so we can have a lo

[Okular-devel] Review Request 126183: Add a FindPoppler module to ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126183/ --- Review request for Extra Cmake Modules, Okular, Albert Astals Cid, and Tobi