Re: [Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

2016-02-18 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126842/ --- (Updated Feb. 18, 2016, 11:51 a.m.) Status -- This change has been d

Re: [Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

2016-02-15 Thread Albert Astals Cid
> On Feb. 11, 2016, 9:41 p.m., Armin K. wrote: > > I didn't notice this review request and did porting on my own. My patch > > takes into account some things your doesn't at the moment. Can you port the > > version checks and possibly other changes from my RR to your patch, so I > > can close

Re: [Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

2016-02-11 Thread Michael Palimaka
> On Feb. 11, 2016, 9:41 p.m., Armin K. wrote: > > I didn't notice this review request and did porting on my own. My patch > > takes into account some things your doesn't at the moment. Can you port the > > version checks and possibly other changes from my RR to your patch, so I > > can close

Re: [Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

2016-02-11 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126842/#review92275 --- I didn't notice this review request and did porting on my own

Re: [Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

2016-02-11 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126842/#review92274 --- generators/CMakeLists.txt (lines 12 - 13)

Re: [Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

2016-01-30 Thread Albert Astals Cid
> On Jan. 22, 2016, 2:45 p.m., Alex Richardson wrote: > > This is missing the checks for various poppler versions that the old module > > did. I have a similar patch locally but not yet pushed the change to use > > the e-c-m module as that is not in a released version yet. > > > > Not sure wha

Re: [Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

2016-01-22 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126842/#review91441 --- This is missing the checks for various poppler versions that

[Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.

2016-01-22 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126842/ --- Review request for Okular. Repository: okular Description --- Some