D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. sander requested review of this revision. REVISION SUMMARY Previously, left-clicking with the mouse would advance the presentation to the next page no matter the cursor position. With this pa

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. Lovely! Probably `CCBUG: 346979` REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander Cc: ngraham, okular-devel, darcyshen, aacid

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular Cc: ngraham, okular-devel, darcyshen, aacid

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid added a comment. I'd be terribly unhappy about this, i never look at where my mouse is when clicking in presentation view. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular Cc: aacid, ngraham, okular-devel, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid added a comment. I understand this can be helpful for some configurations, so having a configuration option (that defaults to the old behaviour) would be more than acceptable for me. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular Cc:

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. But now, if you do, if will go back. :) This is pretty much mandatory for touch friendliness, which is important with more and more laptops being convertibles. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular Cc: aac

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular Cc: aacid, ngraham, okular-devel, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. How about we let the new behavior apply only to touch events, and leave the mouse handling as it is? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular Cc: aacid, ngraham, okular-devel, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid added a comment. In D18118#389500 , @sander wrote: > How about we let the new behavior apply only to touch events, and leave the mouse handling as it is? I don't know, it is still a behaviour change, and given how nervous people us

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. I totally agree that presentations are stressful enough. But we can't use this observation to preclude any possible user interface changes to presentation mode. That can't be right. Idea: swiping back and forwards might be better, especially if you can touch or

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid added a comment. In D18118#389511 , @ngraham wrote: > I totally agree that presentations are stressful enough. But we can't use this observation to preclude any possible user interface changes to presentation mode. That can't be right. >

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. Changing pages by swiping on a touchscreen works already (Qt requires you to swipe with three(!) fingers, though). But if I were a piano player using Okular to show me the music sheets I'd rather not swipe for fear of smashing the entire screen off the piano. REPOSIT

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. In D18118#389517 , @sander wrote: > Qt requires you to swipe with three(!) fingers, though Oh, no wonder I never discovered it. Anything other than single-finger swipe is pretty useless and non-discoverable IMO.

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. That's the standard Qt swipe gesture. Anything else would require writing your own gesture recognizer. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular Cc: aacid, ngraham, okular-devel, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. Well, a single-finger swipe is the same thing as a click-and-drag when the input device is a touchscreen rather than a mouse or touchpad. If we have the ability to see that information, then single-finger swipe wouldn't be so hard, right? The problem is that thr

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. Actually, the necessary gesture recognizer exists, as part of a GwenView patch: https://phabricator.kde.org/D13901 . If that code was accessible from Okular, moving to one-finger swipes would be trivial. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

michaelweghorn added a comment. I'd also prefer to leave the current behaviour of a left-click as it is, regardless of the exact position. That is also in line with what e.g. LibreOffice Impress does. Allowing to go back by doing a single-finger swipe sounds great. REPOSITORY R223 Okular

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. > I'd also prefer to leave the current behaviour of a left-click as it is Do you speak for both mouse clicks and touch screen 'clicks'? Because the original wish is really only about touch screens, and the effects of this patch on mouse clicks was at least partia

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

michaelweghorn added a comment. In D18118#391100 , @sander wrote: > Do you speak for both mouse clicks and touch screen 'clicks'? Because the original wish is really only about touch screens, and the effects of this patch on mouse clicks was at

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. I think that swiping is a separate issue. One-finger swipes should actually be easy to implement as the difficult part already exists in the Gwenview patch mentioned above. And we probably all agree that one-finger swipes are better than three-finger ones. Howe

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

michaelweghorn added a comment. OK, I understand. I don't have any strong opinion on this then. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular Cc: michaelweghorn, aacid, ngraham, okular-devel, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#389490 , @aacid wrote: > I'd be terribly unhappy about this, i never look at where my mouse is when clicking in presentation view. Perhaps a "pedal mode" for mouse and a pedal needs to be added. I think

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. > Swiping is already implemented. On my machine I can only swipe forward, not backwards in presentation mode. The wheel is too small and inaccurate for quick, rapid, touch control. Swiping left and right would be a acceptable to me, but you need to be able to s

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#389517 , @sander wrote: > Changing pages by swiping on a touchscreen works already (Qt requires you to swipe with three(!) fingers, though). But if I were a piano player using Okular to show me the music sheets

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#389518 , @ngraham wrote: > In D18118#389517 , @sander wrote: > > > Qt requires you to swipe with three(!) fingers, though > > > Oh, no wonder I never discovere

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#391065 , @michaelweghorn wrote: > I'd also prefer to leave the current behaviour of a left-click as it is, regardless of the exact position. That is also in line with what e.g. LibreOffice Impress does. Allowi

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#391119 , @sander wrote: > I think that swiping is a separate issue. One-finger swipes should actually be easy to implement as the difficult part already exists in the Gwenview patch mentioned above. And we pr

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. If we can implement this for touch only, +1 on touching the left side to go back. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular Cc: gbodley, michaelweghorn, aacid, ngraham, okular-devel, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#391388 , @ngraham wrote: > If we can implement this for touch only, +1 on touching the left side to go back. I experimented a bit more with 3 finger swiping. While it works, it's not really great. To

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. > It's interesting that swiping down from the top with a single finger brings out the menu' so there does seem to be the potential of single finger swiping. No, that is simply triggered by moving the mouse/your finger on the top two rows of pixels. REPOSITORY

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander updated this revision to Diff 49288. sander edited the summary of this revision. sander edited the test plan for this revision. sander added a comment. New patch version: - You can go back by touching on the left half of a touchscreen, touching the right half will go forward - Mo

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. Tested with my convertible laptop and it works correctly for both the click and touch use cases. Code looks sensible to me as well. REPOSITORY R223 Okular REVISION DETAIL htt

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid added a comment. I still object to this, you're changing the default behaviour of the software for the 0.03% of users that use okular to play in a touch screen while playing the piano. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular,

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. The change is an improvement: Right now when using a touchscreen for presentation mode there is no way to go back. Since this doesn't affect the mouse use case at all, I don't understand the problem here. REPOSITORY R223 Okular REVISION DETAIL https://phabricato

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid added a comment. In D18118#391654 , @ngraham wrote: > The change is an improvement: Right now when using a touchscreen for presentation mode there is no way to go back. Since this doesn't affect the mouse use case at all, I don't understan

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. In D18118#391655 , @aacid wrote: > In D18118#391654 , @ngraham wrote: > > > The change is an improvement: Right now when using a touchscreen for presentation mode there is n

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#391651 , @aacid wrote: > I still object to this, you're changing the default behaviour of the software for the 0.03% of users that use okular to play in a touch screen while playing the piano. As a star

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#391667 , @ngraham wrote: > In D18118#391655 , @aacid wrote: > > > In D18118#391654 , @ngraham wrote: > > > > > The ch

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid added a comment. In D18118#391950 , @gbodley wrote: > In D18118#391651 , @aacid wrote: > > > I still object to this, you're changing the default behaviour of the software for the 0.03% of users

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#392035 , @aacid wrote: > In D18118#391950 , @gbodley wrote: > > > In D18118#391651 , @aacid wrote: > > > > > I still

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. Guys, stop fighting. I'll make it optional in the next patch upload, all I need is a bit of time. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: gbodley, michaelweghorn, aacid, ngraham, okular-devel, da

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#392071 , @sander wrote: > Guys, stop fighting. I'll make it optional in the next patch upload, all I need is a bit of time. Please make it so that once you click the box, it stays locked in through rel

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander updated this revision to Diff 53196. sander edited the summary of this revision. sander edited the test plan for this revision. sander added a comment. Make the new touch screen behavior optional. There are three choices now in 'preferences->presentation': - Forward/Backward: Tapp

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. UI-wise, here's what I might recommend: Touchscreen: [ ] Tap left side to go to previous page [ ] Tap right side to go to next page That way we have all the same functionality, but the labels explain how to use the feature, too. REPOSITORY

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. Not sure I fully understand your proposal. What happens if I uncheck the first option, check the second one, and then tap on the left half of the screen? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: g

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. Nothing happens. I'm kind of wondering why we need to enable them separately in the first place though. Couldn't we just have a single checkbox that enables and disables both? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sa

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. If I understand Albert correctly he wants to have the current behavior as an option. Your proposal does not offer that, does it? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: gbodley, michaelweghorn, a

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. Oh, I think I see what you mean now. How about this, then? Touch navigation: ( ) Tap left/right sides to go back/forward (0) Tap anywhere to go forward ( ) Disabled REPOSITORY R223 Okular REVISION DETAIL https://p

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. That's the current behavior, only with different UI text, right? That's fine with me. I will provide an updated patch within the next few days. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: gbodley, m

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. > That's the current behavior, ... Meaning: That is the current behavior *of the patch*, ... REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: gbodley, michaelweghorn, aacid, ngraham, okular-devel, tfel

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added a comment. In D18118#425420 , @sander wrote: > That's the current behavior, only with different UI text, right? That's fine with me. I will provide an updated patch within the next few days. Exactly! REPOSITORY R223 Oku

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a subscriber: sander. gbodley added a comment. What is the behavior of the mouse buttons? In other words can the left mouse button make it go forward without being anywhere on the screen, and the right button make if go backwards. I'm asking this because there are programm

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. > What is the behavior of the mouse buttons? In other words can the left mouse button make it go forward without being anywhere on the screen, and the right button make if go backwards. Yes, doesn't that work for you? The complete logic is in the method `mous

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander updated this revision to Diff 53295. sander added a comment. UI reworded following Nate's suggestions REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18118?vs=53196&id=53295 REVISION DETAIL https://phabricator.kde.org/D18118 AFFECTED FILES conf/d

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham accepted this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: sander, gbodley, michaelweghorn, aacid, ngraham, okular-devel, tfella, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. Albert, is this okay for you now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: sander, gbodley, michaelweghorn, aacid, ngraham, okular-devel, tfella, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid accepted this revision. aacid added a comment. Looks good to me. Comment needs updating but that's all. Given everyone but me accepted code before this i feel it's safe to assume now everyone is happy INLINE COMMENTS > presentationwidget.cpp:716 > +} > +// Tou

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid added inline comments. INLINE COMMENTS > dlgpresentationbase.ui:106 > + > +Tap left/right sides to go back/forward > + Maybe should be side instead of sides? @ngraham ? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sa

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

ngraham added inline comments. INLINE COMMENTS > aacid wrote in dlgpresentationbase.ui:106 > Maybe should be side instead of sides? @ngraham ? Sort of a judgment call. The plural version sounds slightly better to my ears, but it's likely that the singular version is more technical correct. Go w

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. What is the exact language? I find the parenthesis to be an awkward sentence structure. If that is the actual language in the tool-tip. I would think something like "Tapping: Left half = previous page, Right Half = following page would suffice. or *Tapping: Le

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander edited the summary of this revision. sander edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham, aacid Cc: sander, gbodley, michaelweghorn, aacid, ngraham, okular-devel, tfella, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander updated this revision to Diff 53691. sander added a comment. - 'sides' --> 'side' - updated old comment REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18118?vs=53295&id=53691 REVISION DETAIL https://phabricator.kde.org/D18118 AFFECTED FILES co

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham, aacid Cc: sander, gbodley, michaelweghorn, aacid, ngraham, okular-devel, tfella, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

This revision was automatically updated to reflect the committed changes. Closed by commit R223:50bfd9fe8645: Presentation: optionally go to prev. page when touching left half of the page (authored by sander). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1811

Re: D18118: Presentation mode: go to previous page when left-clicking on left half of the page

What is the behavior of the mouse buttons? In other words can the left mouse button make it go forward without being anywhere on the screen, and the right button make if go backwards. I'm asking this because there are programmable pedals for turning pages as well. I believe they are related to l

Re: D18118: Presentation mode: go to previous page when left-clicking on left half of the page

What is the exact language? I find the parenthesis to be an awkward sentence structure. If that is the actual language in the tool-tip. I would think something like "Tapping: Left half = previous page, Right Half = following page would suffice. or *Tapping: Left side = Previous, Right side = Subs