Re: [Openais] [PATCH] ipc: Fix error handling of mmap util functions.

2010-06-28 Thread Steven Dake
On 06/28/2010 04:43 PM, Angus Salkeld wrote: Steve, Not exactly the same as your latest patch ... - use snprintf() - use write to test that we can actually use all of the file. Signed-off-by: Angus Salkeldasalk...@redhat.com --- exec/coroipcs.c | 74

[Openais] corosync trunk - fix ipc flow control take 1

2010-06-28 Thread Steven Dake
This is take 1 of this patch. Needs bsd port. Will work on that soon. Wanted to get some feedback on the code. This fixes a problem where flow control and dispatch are intermixed into the same stream of data, resulting in a lockup of the ipc system under really heavy load. Can't really

Re: [Openais] corosync - handle reload configuration and statics update

2010-06-27 Thread Steven Dake
On 06/25/2010 03:02 AM, Jan Friesse wrote: Patch fixes following situation: 1. objdb receives reload notification and ends in function object_reload_config. This will call objdb_wrlock. I will call this thread #1 2. Another thread will decide to update corosync statistics and calls

[Openais] update to fixing /dev/shm leak

2010-06-27 Thread Steven Dake
this patch is a replacement for the last fdata leak fix regards -steve Index: exec/logsys.c === --- exec/logsys.c (revision 2962) +++ exec/logsys.c (working copy) @@ -224,23 +224,45 @@ int fd; int res;

Re: [Openais] coroipcc.c sem_init/sem_destroy?

2010-06-25 Thread Steven Dake
On 06/25/2010 05:20 PM, dan clark wrote: Should the coroipcc client library have matching sem_destroy in the hdb_destructor for the corresponding sem_init calls in coroipcc_service_ connect? thanks, dan Dan exec/coroipcs.c executes a sem_destroy on the posix semaphores when the client

Re: [Openais] recover from corosync daemon restart and cpg_finalize timing

2010-06-24 Thread Steven Dake
On 06/23/2010 11:35 PM, Andrew Beekhof wrote: On Thu, Jun 24, 2010 at 1:50 AM, dan clark2cla...@gmail.com wrote: Dear Gentle Reader Attached is a small test program to stress initializing and finalizing communication between a corosync cpg client and the corosync daemon. The test was

[Openais] corosync trunk - fix /dev/shm file leak

2010-06-24 Thread Steven Dake
this fixes leaking of files in /dev/shm which happens if corosync is started and stopped repeatedly. Regards -steve Index: exec/logsys.c === --- exec/logsys.c (revision 2962) +++ exec/logsys.c (working copy) @@ -225,6

Re: [Openais] corosync trunk - fix /dev/shm file leak

2010-06-24 Thread Steven Dake
On 06/24/2010 02:42 AM, Angus Salkeld wrote: On Thu, Jun 24, 2010 at 01:23:44AM -0700, Steven Dake wrote: this fixes leaking of files in /dev/shm which happens if corosync is started and stopped repeatedly. Couple of suggestions inline. Regards -steve Index: exec/logsys.c

Re: [Openais] recover from corosync daemon restart and cpg_finalize timing

2010-06-24 Thread Steven Dake
Dan, Thanks for the test case responses inline On 06/23/2010 04:50 PM, dan clark wrote: Dear Gentle Reader Attached is a small test program to stress initializing and finalizing communication between a corosync cpg client and the corosync daemon. The test was run under version 1.2.4.

Re: [Openais] Are variants of multicast supported in corosync?

2010-06-23 Thread Steven Dake
On 05/25/2010 12:53 AM, Sampathkumar, Kishore wrote: Hi, Does corosync support, or are there plans to support, the following: (a) Source-Specific Multicast for IP, as specified in rfc4607 (b) Administratively Scoped IP Multicast, as specified in rfc2365 The group multicast addresses used

Re: [Openais] corosync 1.2.5 still doesn't shutdown properly

2010-06-23 Thread Steven Dake
On 06/22/2010 11:22 PM, Alain.Moulle wrote: Hi, With whatever release (i.e. currently with corosync-1.2.1-2.el6.x86_64), I always have trouble with the stop of corosync. And each time it failed when there were some failed actions reported by crm_mon. Regards Alain Please give 1.2.5 a try.

Re: [Openais] corosync 1.2.5 still doesn't shutdown properly

2010-06-22 Thread Steven Dake
On 06/22/2010 03:56 AM, Vadym Chepkov wrote: Hi, I decided to check if I can start using corosync again on several of my clusters (have to use heartbeat there at the moment). I don't even have any services defined in corosync.conf, commented pacemaker out, just plain corosync and it never

Re: [Openais] corosync - glibc detected *** corosync: malloc(): memory corruption

2010-06-22 Thread Steven Dake
On 06/22/2010 02:15 AM, Jan Friesse wrote: Corosync has problem with readdir_r and if pathconf function fails. Main problem is hidden in calling pathconf (internally calls statfs) which may fail. After this fail, newly allocated memory for readdir_r was smaller than expected and memory was

Re: [Openais] corosync 1.2.5 still doesn't shutdown properly

2010-06-22 Thread Steven Dake
On 06/22/2010 11:07 AM, Vadym Chepkov wrote: On Tue, Jun 22, 2010 at 1:49 PM, Steven Dakesd...@redhat.com wrote: On 06/22/2010 03:56 AM, Vadym Chepkov wrote: Hi, I decided to check if I can start using corosync again on several of my clusters (have to use heartbeat there at the moment). I

Re: [Openais] corosync 1.2.5 still doesn't shutdown properly

2010-06-22 Thread Steven Dake
On 06/22/2010 11:31 AM, Vadym Chepkov wrote: On Tue, Jun 22, 2010 at 2:21 PM, Steven Dakesd...@redhat.com wrote: On 06/22/2010 11:07 AM, Vadym Chepkov wrote: On Tue, Jun 22, 2010 at 1:49 PM, Steven Dakesd...@redhat.comwrote: On 06/22/2010 03:56 AM, Vadym Chepkov wrote: Hi, I decided

Re: [Openais] trunk patch - unlock global serializer mutex

2010-06-21 Thread Steven Dake
On 06/20/2010 10:19 PM, renayama19661...@ybb.ne.jp wrote: Hi Steven, I tested your patch on Esxi. The problem that the guest whom I reported cannot stop was broken off by your patch. * It is not used 100% for the CPU of the guest. * And corosync stops quickly. We look forward to

[Openais] [announce] corosync 1.2.5 released!

2010-06-21 Thread Steven Dake
I am pleased to announce the release of corosync 1.2.5. This version fixes the following problems: * Certain cman commands used to reload configurations would trigger a recursion explosion ooming the system. * Send proper notification code of CPG_REASON_LEAVE in cpg service. * Move configure

[Openais] trunk patch - unlock global serializer mutex

2010-06-18 Thread Steven Dake
The global serializer mutex is left in a locked state during the shutdown process. At about the same time, the timer system expires a timer (which takes the global serializer lock) leading to either high CPU use on multiprocessor during shutdown or deadlock on uniprocessor. Regards -steve

Re: [Openais] corosync + whitetank - Send CPG_REASON_PROCDOWN on process left

2010-06-15 Thread Steven Dake
On 06/15/2010 04:15 AM, Jan Friesse wrote: Send CPG_REASON_PROCDOWN on process left Our manual pages are clear: CPG_REASON_PROCDOWN - the process left a group without calling cpg_leave(). Currently, we are sending CPG_REASON_LEAVE in such situation. Regards, Honza

Re: [Openais] [PATCH][corosync] fix bad pointer dereference in objdb

2010-06-15 Thread Steven Dake
On 06/15/2010 08:05 AM, Christine Caulfield wrote: object_key_iter() calls object_key_iter_typed() and then always tries to dereference the string it returns, even if the call fails. The attached patch fixes this. This bug also affects trunk and flatiron, and maybe other branches too.

Re: [Openais] it seems there is a pb to use Eth brigdes with corosync ?

2010-06-15 Thread Steven Dake
On 06/14/2010 07:25 AM, Alain.Moulle wrote: Hi Steven, have you read my last email about this pb, with my tests results ? can I open a defect on openais for this issue ? and if so, how/where can I open this defect ? Thanks Regards Alain Alain, Yes but I have not had time to reproduce

Re: [Openais] [announce] corosync 1.2.4 released

2010-06-15 Thread Steven Dake
On 06/11/2010 12:14 AM, renayama19661...@ybb.ne.jp wrote: Hi Steven, I report a result. When I started in corosync -p, I succeed in a stop. When I do not start with a p option, VM succeed in a stop when corosync operate it with a mutex lock. GThe problem is localized to using

Re: [Openais] [PATCH] V3 Fix debug function in logsys.c (Was Re: Remove unused functions from logsys.c)

2010-06-12 Thread Steven Dake
Andreas, Thanks for all the work on this, but your intuition of removing the code completely (your first patch) is correct. This is why the patch was applied without argument. I don't want ifdef's in the code around debug output. Libraries in general, such as logsys, should never print any

Re: [Openais] {patch] Corosync hangs on startup

2010-06-11 Thread Steven Dake
On 06/11/2010 09:00 AM, Andrew Beekhof wrote: This is a bit convoluted, but hang in there. So there is this bug: http://developerbugs.linux-foundation.org/show_bug.cgi?id=2379 Essentially, to reproduce, you stop syslog but leave it enabled in corosync.conf. Here is the logging section

Re: [Openais] [announce] corosync 1.2.4 released

2010-06-11 Thread Steven Dake
On 06/11/2010 07:16 AM, Andrew Beekhof wrote: On Fri, Jun 11, 2010 at 4:03 PM, Colincolin@gmail.com wrote: On Thu, Jun 10, 2010 at 12:22 AM, Steven Dakesd...@redhat.com wrote: This version has the following changes: * Fixes defects in logsys which are crashing pacemaker installations.

Re: [Openais] [announce] corosync 1.2.4 released

2010-06-10 Thread Steven Dake
On 06/10/2010 01:58 AM, renayama19661...@ybb.ne.jp wrote: Hi All, I tried 1.2.4. I do not use Pacemaker. * 4 node VM.(RHEL5.4 x86) * VM on Esxi. * debug : on * rrp_mode : none However, at the time of debug:on, corosync fails in a stop. Some VM fails in a stop and are hung up.

[Openais] [announce] corosync 1.2.4 released

2010-06-09 Thread Steven Dake
I am pleased to announce the release of corosync 1.2.4 for immediate download from our website. This version has the following changes: * Fixes defects in logsys which are crashing pacemaker installations. * Adds man pages for all binaries installed with the make install command. * Fixes several

[Openais] [announce] freezing flatiron(1.y.z) branch - opening weaver's needle branch (2.y.z)

2010-06-09 Thread Steven Dake
The rate of change for Corosync has been high for some time since 1.0.0 was published in July 2009. Nearly every Linux distribution is shipping projects or products based upon the Corosync 1.y.z series. To provide some sanity for downstream distributions and projects using Corosync APIs, we

Re: [Openais] corosync.spec

2010-06-09 Thread Steven Dake
Vadym, Thanks for the patch. Keep in mind the default spec file is only a guide. We expect each distro will tailor it to their own policies. Please note: https://bugzilla.redhat.com/show_bug.cgi?id=455279 It appears from the above bugzilla the initddir is the proper macro to use. configure

[Openais] corosync trunk - remove harmless compiler warning

2010-06-09 Thread Steven Dake
Remove harmless compiler warning by initializing pointer to NULL. Index: lib/coroipcc.c === --- lib/coroipcc.c (revision 2942) +++ lib/coroipcc.c (working copy) @@ -479,7 +479,7 @@ #else struct timespec timeout;

Re: [Openais] corosync.spec

2010-06-09 Thread Steven Dake
and it's still _initrddir there How about a simple conditional? %{!?_initdir}: %{_sysconfdir}/rc.d/init.d} Vadym On Jun 9, 2010, at 9:07 PM, Steven Dake wrote: Vadym, Thanks for the patch. Keep in mind the default spec file is only a guide. We expect each distro will tailor

[Openais] corosync trunk - fix ring buffer implementation in logsys

2010-06-06 Thread Steven Dake
The current logsys does not use a file backed mapping for its circular buffer. It requires a circular buffer managed by the memory manager. This patch fixes that problem. This patch also fixes the error handling of the writing of the logsys fplay buffer to be more correct. Regards -steve

Re: [Openais] it seems there is a pb to use Eth brigdes with corosync ?

2010-06-04 Thread Steven Dake
On 06/04/2010 07:34 AM, Alain.Moulle wrote: Hi is it supported to have one of the ringnumber with a bindnetaddr linked to an Eth bridge if (br0) ? because on one config, I have : rrp_mode : active and for 1st ringnumber : bindnetaddr: 12.1.0.0 for 2nd ringnumber : bindnetaddr: 12.0.0.0

[Openais] corosync trunk - resolve problems with failed to receive logic

2010-06-03 Thread Steven Dake
The failed to receive logic in totem is not correct. This condition occurs when a node can't receive multicast packets for a long period of time. Generally it impacts low numbers of users which have hardware that exhibit out-of-norm behaviours. The solution is to more closely match the spec

[Openais] openais whitetank - failed to recv patch

2010-06-03 Thread Steven Dake
same patch for whitetank Index: exec/totemsrp.c === --- exec/totemsrp.c (revision 2144) +++ exec/totemsrp.c (working copy) @@ -297,6 +297,8 @@ struct totemsrp_instance { int iface_changes; + int

Re: [Openais] How to tune corosync heartbeat timer ?

2010-06-02 Thread Steven Dake
On 06/02/2010 01:19 AM, Alain.Moulle wrote: Hi Steven, have you got a formula to calculate the timeout with regard to token,token_retransmits_before_loss_const , and consensus values ? I recommend: token = length to detect failed node consensus = 2.2 * token join = 150msec

[Openais] handle EINTR in sem_wait (pacemaker corosync 1.2.2+ crash)

2010-06-01 Thread Steven Dake
Hello, I have found the cause of the crash that was occurring only on some deployments. The cause is that sem_wait is interrupted by signal, and the wait operation is not retried (as is customary in posix). Patch attached to fix A big thank you to Vladislav Bogdanov for running the test

[Openais] corosync-trunk do proper handling of last_aru

2010-06-01 Thread Steven Dake
Totem spec is clear: reject retransmitted tokens if token.aru = aru in token on last rotation ... do some logic Here is how the current code works: last_aru = instance-my_last_aru; instance-my_last_aru = token-aru; reject retransmitted tokens if token.aru = aru in token on last rotation ... do

Re: [Openais] [PATCH] temporarily remove a cts test case

2010-06-01 Thread Steven Dake
On 06/01/2010 07:59 PM, Angus Salkeld wrote: === --- cts/corotests.py(revision 2917) +++ cts/corotests.py(working copy) @@ -339,11 +339,16 @@ self.CM.start_cpg = False def config_valid(self, config): +

Re: [Openais] [PATCH] logsys: seperate out the ringbuffer for readability.

2010-05-31 Thread Steven Dake
On 05/31/2010 12:31 AM, Jan Friesse wrote: Steven Dake wrote: On 05/28/2010 02:14 AM, Jan Friesse wrote: Angus, attached is fixed version of rb, which should do what you think current implementation is doing. Please take a time to read comments beginning with ^ But basically

Re: [Openais] packet dissectors for totempg, cman, clvmd, rgmanager, cpg,

2010-05-28 Thread Steven Dake
On 05/28/2010 06:59 AM, Masatake YAMATO wrote: On 5/27/2010 at 04:26 AM, Caplan, Michaelmcap...@nds.com wrote: Is there a corosync dissector available for Windows based Wireshark? I suspect the short answer to your question is no. Work has been done in this area, but this doesn't appear to

Re: [Openais] [PATCH] logsys: seperate out the ringbuffer for readability.

2010-05-28 Thread Steven Dake
On 05/28/2010 02:14 AM, Jan Friesse wrote: Angus, attached is fixed version of rb, which should do what you think current implementation is doing. Please take a time to read comments beginning with ^ But basically: - Implementation didn't support storing of data with non multiply

Re: [Openais] [PATCH] logsys: seperate out the ringbuffer for readability.

2010-05-28 Thread Steven Dake
@@ +/* + * Copyright (c) 2010 Red Hat, Inc. + * + * All rights reserved. + * + * Author: Steven Dake (sd...@redhat.com) + * + * This software licensed under BSD license, the text of which follows: + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted

Re: [Openais] [PATCH] makefile specfile changes for new man pages

2010-05-28 Thread Steven Dake
On 05/26/2010 11:20 PM, Angus Salkeld wrote: + corosync-fplay.8 \ + corosync-keygen.8 \ good for merge ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais

Re: [Openais] [Pacemaker] corosync/openais fails to start

2010-05-27 Thread Steven Dake
This is a known issue on some platforms, although the exact cause is unknown. I have tried RHEL 5.5 as well as CentOS 5.5 with clusterrepo rpms and been unable to reproduce. I'll keep looking. Regards -steve On 05/27/2010 06:07 AM, Diego Remolina wrote: Hi, I was running the old rpms from

Re: [Openais] [PATCH 1/6] Add a man page for corosync-keygen and update corosync_overview

2010-05-27 Thread Steven Dake
The man page change set looks good for commit I didn't notice Makefile.am changes though, maybe something is needed there. regards -steve On 05/26/2010 10:12 PM, Angus Salkeld wrote: Signed-off-by: Angus Salkeldasalk...@redhat.com --- man/corosync-keygen.8 | 83

Re: [Openais] [Pacemaker] corosync/openais fails to start

2010-05-27 Thread Steven Dake
cluster. Diego Steven Dake wrote: This is a known issue on some platforms, although the exact cause is unknown. I have tried RHEL 5.5 as well as CentOS 5.5 with clusterrepo rpms and been unable to reproduce. I'll keep looking. Regards -steve On 05/27/2010 06:07 AM, Diego Remolina wrote

Re: [Openais] Multicast and Xen Bridge Networking issues

2010-05-26 Thread Steven Dake
On 05/26/2010 02:24 AM, S, Prashanth wrote: We have two (physical) machines. Each of them is hosting one Linux Virtual Machine (HVM) on top of Xen Hypervisor 3.4.1, The VMs are able to communicate with each other (using Xen Bridge Networking) thru the ethernet on the physical hosts. However,

Re: [Openais] Corosync enters endless loop after hiccup in system

2010-05-26 Thread Steven Dake
On 05/26/2010 03:37 AM, Colin wrote: Hi Again, looking at the differences between 1.2.0 and 1.2.3 it appears that some problem was detected in logsys.c -- the log messages have a dedicated queue independent of the flight recorder, the inter-thread signalling was changed from condition

Re: [Openais] Corosync enters endless loop after hiccup in system

2010-05-26 Thread Steven Dake
On 05/26/2010 02:42 AM, Colin wrote: On Tue, Mar 30, 2010 at 1:00 PM, Dejan Muhamedagicde...@suse.de wrote: On Tue, Mar 30, 2010 at 11:43:22AM +0200, Colin wrote: we are running Corosync 1.2.0-0ubuntu1 on Ubuntu 10.4 beta w/current updates; the cluster consists of two systems running in KVM,

[Openais] corosync trunk - set schedule parameters properly

2010-05-26 Thread Steven Dake
A memcpy() operation is not copying the proper sched info for later setting. This results in pthread_setschedparam returning the error code 22 (EINVAL) because it is operating on junk data. Regards -steve Index: exec/logsys.c ===

Re: [Openais] [openais whitetank] - Fix for RHBZ#579081

2010-05-26 Thread Steven Dake
On 05/26/2010 07:03 AM, Jan Friesse wrote: First attached is patch solving $SUBJ bug intended for Z-stream. Real solution based on Posix semaphores for 5.6 is in progress. Second patch should solve second problem with dispatch. Regards, Honza sem_wait patch good for merge. The

Re: [Openais] corosync - coroipcc - don't loop forever on EINTR

2010-05-26 Thread Steven Dake
clever design - good for merge steve On 05/26/2010 08:54 AM, Jan Friesse wrote: See patch description. Regards, Honza ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais

Re: [Openais] packet dissectors for totempg, cman, clvmd, rgmanager, cpg,

2010-05-26 Thread Steven Dake
On 05/26/2010 09:20 PM, Masatake YAMATO wrote: On 5/27/2010 at 04:26 AM, Caplan, Michaelmcap...@nds.com wrote: Is there a corosync dissector available for Windows based Wireshark? I suspect the short answer to your question is no. Work has been done in this area, but this doesn't appear to

Re: [Openais] Are variants of multicast supported in corosync?

2010-05-25 Thread Steven Dake
On 05/25/2010 12:53 AM, Sampathkumar, Kishore wrote: Hi, Does corosync support, or are there plans to support, the following: (a) Source-Specific Multicast for IP, as specified in rfc4607 (b) Administratively Scoped IP Multicast, as specified in rfc2365 The group multicast addresses used

Re: [Openais] FW: [Linux-HA] Problem with last Pacemaker and corosync releases available for RHEL5 ?

2010-05-25 Thread Steven Dake
On 05/25/2010 06:30 AM, Simpson, John R wrote: Greetings all, I'm new to the OpenAIS/Corosync list and am moving this discussion here at the request of Andrew Beekhof. A few people on the Linux-HA / Pacemaker mailing list, myself included, have been getting segmentation faults from

Re: [Openais] Pb with last corosync releases available for RHEL5 ...

2010-05-24 Thread Steven Dake
On 05/24/2010 02:51 PM, Vladislav Bogdanov wrote: Hi all, Sorry for being out of References, just subscribed. On Fri, 2010-05-21 at 16:19 +0200, Alain.Moulle wrote: Hi These new releases of corosync do not start successfully on RHEL5 : corosync-1.2.2-1.1.el5

Re: [Openais] corosync is having problems on a single node

2010-05-22 Thread Steven Dake
On Sat, 2010-05-22 at 21:57 +0530, Sampathkumar, Kishore wrote: I’m trying to setup corosync on a single node. I downloaded corosync-1.2.3.tar.gz, and after extracting it, issued the following as root on a single node: # configure # make install The above succeeded.

Re: [Openais] [Corosync] Using TCP as a transport?

2010-05-21 Thread Steven Dake
mind sending a patch? If you currently implement the code in totemudp.c, make sure to make a new transport called totemudpu.c :) Regards -steve On Thu, May 13, 2010 at 5:15 PM, Steven Dake sd...@redhat.com wrote: ya looks good On Thu, 2010-05-13 at 16:15

[Openais] mainconfig: use proper type for comparison

2010-05-18 Thread Steven Dake
mode is compared for checking -1, however, it is unsigned. Make it signed so the comparison works properly. Regards -steve ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais

[Openais] ring status get free code - fix

2010-05-18 Thread Steven Dake
This patch fixes the free operations in ring status get when there is a failure during memory allocation in the cfg client. Regards -steve Index: lib/cfg.c === --- lib/cfg.c (revision 2850) +++ lib/cfg.c (working copy) @@ -272,7

[Openais] make cpg_membership_get functoinal

2010-05-18 Thread Steven Dake
better ways to get this information now, but the api should return proper results. Regards -stve Index: test/testcpg.c === --- test/testcpg.c (revision 2850) +++ test/testcpg.c (working copy) @@ -174,6 +174,9 @@ int opt; unsigned

Re: [Openais] [PATCH] Clarify bindnetaddr description in corosync manpage

2010-05-18 Thread Steven Dake
merged thanks On Tue, 2010-05-18 at 22:45 -0600, Tim Serong wrote: This patch updates the wording for the bindnetaddr option in corosync.conf to explicitly state that you need to use the network address, as opposed to should always end in zero, which is only correct for class C networks.

Re: [Openais] [PATCH 1/3] cov 10405: remove unused pointer from totemsrp.

2010-05-17 Thread Steven Dake
good for merge On Mon, 2010-05-17 at 12:01 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/totemsrp.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/exec/totemsrp.c b/exec/totemsrp.c index 8786859..93e8769 100644 ---

Re: [Openais] [PATCH 3/3] cov 10387 (and others): make _logsys_subsys_create() return int

2010-05-17 Thread Steven Dake
good for merge On Mon, 2010-05-17 at 12:02 +1000, Angus Salkeld wrote: in the body it can return -1, and callers check for -1. but the return type is unsigned int? Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/logsys.c|2 +-

[Openais] corosync trunk: flush log messages if worker thread for logsys hasn't been started

2010-05-17 Thread Steven Dake
This patch flushes log messages in the case of an error condition that occurs before the worker thread responsible for log flushing is activated. Regards -steve Index: exec/logsys.c === --- exec/logsys.c (revision 2843) +++

Re: [Openais] [PATCH 1/3] cov 10391: allow assert to check for a negitive number

2010-05-17 Thread Steven Dake
good for merge On Tue, 2010-05-18 at 10:07 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/totemsrp.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/exec/totemsrp.c b/exec/totemsrp.c index 93e8769..6dfd42d 100644 ---

Re: [Openais] [PATCH 12/13] cov (10387, 10397): cleanup memory mapping functions

2010-05-16 Thread Steven Dake
good for merge On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/coroipcs.c | 29 + lib/coroipcc.c | 16 2 files changed, 41 insertions(+), 4 deletions(-) diff --git

Re: [Openais] [PATCH 11/13] cov 10374: check sam_hc_send() before counter++

2010-05-16 Thread Steven Dake
surprised coverity caught this.. :) good for merge On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- lib/sam.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/sam.c b/lib/sam.c index

Re: [Openais] [PATCH 08/13] cov 10390: remove pointless assert.

2010-05-16 Thread Steven Dake
good for merge On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: sq_position is unsigned. Signed-off-by: Angus Salkeld asalk...@redhat.com --- include/corosync/sq.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/corosync/sq.h

Re: [Openais] [PATCH 07/13] cov 10389: remove unneccessary check.

2010-05-16 Thread Steven Dake
good for merge On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/service.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/exec/service.c b/exec/service.c index 40275ef..be55459 100644 ---

Re: [Openais] [PATCH 09/13] cov 10392: remove pointless assert

2010-05-16 Thread Steven Dake
On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: backlog is unsigned Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/totemsrp.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/exec/totemsrp.c b/exec/totemsrp.c index 3d8bd05..a7818b4 100644

Re: [Openais] [PATCH 06/13] cov 10373: check poll return value

2010-05-16 Thread Steven Dake
This patch isn't correct. poll can return -1 (errno=EINTR) which means interrupted by signal and should retry. Test for that errno and retry in that case. Regards -steve On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com ---

Re: [Openais] [PATCH 05/13] cov 10371: check return of lcr_ifact_reference

2010-05-16 Thread Steven Dake
good for merge -steve On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/service.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/exec/service.c b/exec/service.c index f06ca22..40275ef 100644

Re: [Openais] [PATCH 04/13] cov 10401: error_string never set

2010-05-16 Thread Steven Dake
good for merge On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/totemconfig.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec/totemconfig.c b/exec/totemconfig.c index e55722d..49fed20 100644

Re: [Openais] [PATCH 03/13] cov 10402: (cpg) remove early return

2010-05-16 Thread Steven Dake
Agree the stray return is troubling - but need to test this patch and make sure it doesn't break anything. Regards -steve On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- services/cpg.c |1 - 1 files changed, 0 insertions(+), 1

Re: [Openais] [PATCH 02/13] cov 10411: fix leak in totemudp.c

2010-05-16 Thread Steven Dake
ugh good catch good for merge regards -steve On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/totemudp.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/exec/totemudp.c b/exec/totemudp.c index

Re: [Openais] [PATCH 01/13] cov 10400: unit'ed variable.

2010-05-16 Thread Steven Dake
good for merge regards -steve On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: not important, easy to fix. Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/coropoll.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec/coropoll.c

Re: [Openais] [PATCH] cfg: fix compile error

2010-05-16 Thread Steven Dake
good for merge On Sun, 2010-05-16 at 18:11 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- services/cfg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/services/cfg.c b/services/cfg.c index 689bc96..109bea8 100644 ---

Re: [Openais] cfg ringreenable is no response.

2010-05-14 Thread Steven Dake
thanks for the patch - good work merged -steve On Fri, 2010-05-14 at 16:29 +0900, sato yuki wrote: Hello Steven, Hello all This patch is thing to cfg service. corosync-cfgtool -r no response at corosync-1.2.2. Thanks in advance. yuki sato plain text document attachment (cfg.patch)

[Openais] corosync trunk - set uninitialized variable

2010-05-13 Thread Steven Dake
Although this is probably harmless, can't hurt to initialize this variable. Regards -steve ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais

Re: [Openais] [PATCH 2/7] cov 10381: check result of open()

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/crypto.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/exec/crypto.c b/exec/crypto.c index 0ae415e..f85f4b9 100644 ---

Re: [Openais] [PATCH 3/7] cov 10382: imporove error handling around open()

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/totemsrp.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/exec/totemsrp.c b/exec/totemsrp.c index c8d165e..3d8bd05

Re: [Openais] [PATCH 4/7] cov 10383: impove the error handling after socket()

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- lcr/uis.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lcr/uis.c b/lcr/uis.c index 004c464..93745a5 100755 --- a/lcr/uis.c +++

Re: [Openais] [PATCH 5/7] cov 10384: better error handling from accept()

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- lcr/uis.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lcr/uis.c b/lcr/uis.c index 93745a5..a124134 100755 --- a/lcr/uis.c +++

Re: [Openais] [PATCH 7/7] cov 10378: fix syntax error.

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/coroipcs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index 9d81b7e..a2bc867 100644 ---

Re: [Openais] [PATCH 6/7] cov 10385: assigning signed int to unsigned variable

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- tools/corosync-fplay.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/corosync-fplay.c b/tools/corosync-fplay.c index

Re: [Openais] [PATCH 3/4] CTS: fix test_agent start/stop errors

2010-05-12 Thread Steven Dake
good for merge On Wed, 2010-05-12 at 14:38 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- cts/corosync.py | 16 +++- cts/corotests.py |7 --- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/cts/corosync.py

Re: [Openais] [PATCH 2/4] CTS: fix test service configuration

2010-05-12 Thread Steven Dake
good for merge On Wed, 2010-05-12 at 14:40 +1000, Angus Salkeld wrote: Signed-off-by: Angus Salkeld asalk...@redhat.com --- cts/corosync.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cts/corosync.py b/cts/corosync.py index 64b096d..79f4470 100644 ---

Re: [Openais] [PATCH 4/4] cpg: fix unitialized variable

2010-05-12 Thread Steven Dake
good for merge On Wed, 2010-05-12 at 14:42 +1000, Angus Salkeld wrote: This fixes a bug found by CTS. Signed-off-by: Angus Salkeld asalk...@redhat.com --- services/cpg.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/services/cpg.c b/services/cpg.c

Re: [Openais] SAM - integration with quorum

2010-05-12 Thread Steven Dake
Great work on the patch - good for merge Planning to do the watchdog portion (ie confdb) as separate patch? Regards -steve On Fri, 2010-04-30 at 11:47 +0200, Jan Friesse wrote: Integration of SAM and quorum Regards, Honza ___ Openais mailing

[Openais] announcing corosync 1.2.2 released!

2010-05-12 Thread Steven Dake
I am pleased to announce the latest release of corosync 1.2.2 is available for immediate download via our web site at http://www.corosync.org. Changes: * Fix debug: on defect preventing shutdown of Pacemaker. * Fix segfault which occurred when syncv2 didn't synchronize properly. * Fix lockup of

[Openais] logsys rework take 1

2010-05-11 Thread Steven Dake
=== --- exec/logsys.c (revision 2809) +++ exec/logsys.c (working copy) @@ -1,6 +1,6 @@ /* * Copyright (c) 2002-2004 MontaVista Software, Inc. - * Copyright (c) 2006-2009 Red Hat, Inc. + * Copyright (c) 2006-2010 Red Hat, Inc. * * Author: Steven Dake (sd

[Openais] plan for resolving corosync services unloading problem blocking shutdown on opensuse

2010-05-10 Thread Steven Dake
It seems pretty clear from the mailing list traffic recently there is a critical flaw with the shutdown related in some way to Pacemaker and Corosync that happens on a few people's opensuse systems. It seems to only reproduce on opensuse however we don't know if it is limited to this platform.

Re: [Openais] plan for resolving corosync services unloading problem blocking shutdown on opensuse

2010-05-10 Thread Steven Dake
Bug analysis that we are undertaking can be found here: https://bugzilla.redhat.com/show_bug.cgi?id=590898 Please feel free to add any extra data you may have beyond the backtrace. Thanks -steve On Mon, 2010-05-10 at 14:38 -0700, Steven Dake wrote: It seems pretty clear from the mailing list

Re: [Openais] plan for resolving corosync services unloading problem blocking shutdown on opensuse

2010-05-10 Thread Steven Dake
will post his SRPM somewhere or maybe instructions how to compile it, I would be happy to contribute. Vadym On May 10, 2010, at 5:38 PM, Steven Dake wrote: It seems pretty clear from the mailing list traffic recently there is a critical flaw with the shutdown related in some way to Pacemaker

Re: [Openais] plan for resolving corosync services unloading problem blocking shutdown on opensuse

2010-05-10 Thread Steven Dake
On Mon, 2010-05-10 at 19:02 -0400, Vadym Chepkov wrote: Yes, I am try without On May 10, 2010, at 6:59 PM, Steven Dake wrote: Do you have debug: on in your config file? Regards -steve On Mon, 2010-05-10 at 18:24 -0400, Vadym Chepkov wrote: Hi, I experienced the same

Re: [Openais] plan for resolving corosync services unloading problem blocking shutdown on opensuse

2010-05-10 Thread Steven Dake
On Mon, 2010-05-10 at 23:58 +0200, Andreas Mock wrote: -Ursprüngliche Nachricht- Von: Steven Dake sd...@redhat.com Gesendet: 10.05.2010 23:38:01 An: Alain.Moulle alain.mou...@bull.net Betreff: [Openais] plan for resolving corosync services unloading problem blocking shutdown

Re: [Openais] What can I do when facing Waiting for corosync services to unload:.........

2010-05-04 Thread Steven Dake
Alain, We are aware of a newly discovered shutdown issue but don't yet have a root cause of the problem. We haven't been able to reproduce it on our equipment so as of yet we can't fix it. If you could gather a backtrace of the corosync process during shutdown that might help. To do that,

Re: [Openais] [PATCH] spec: fix some errors from rpmbuild rpmlint

2010-05-04 Thread Steven Dake
good for merge On Wed, 2010-05-05 at 11:32 +1000, Angus Salkeld wrote: oops, missed an _initddir. Here is an updated patch. -Angus Signed-off-by: Angus Salkeld asalk...@redhat.com --- corosync.spec.in |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git

<    1   2   3   4   5   6   7   8   9   10   >