Hey Geoff,
I'm going to turn off tests for the Appveyor build due to the problems
with PR#1572. I don't think they are real - do you remember a similiar
issue with a PR of David Koes, where I had exactly the same problem
(except here it's multiple tests)? Something's funny with the VMs that
Appvey
We need to verify that it doesn't mess up the conda packages for windows.
I'll have some time by the end of the week.
PS.
https://ci.appveyor.com/project/baoilleach/openbabel/build/1.0.481 this
build says 100% tests passed. Am I looking at the wrong one?
Pozdrawiam, | Best regards,
Maciek
The link is on the PR:
https://ci.appveyor.com/project/baoilleach/openbabel/build/1.0.501
Ok - I'll wait until you confirm.
- Noel
On 5 June 2017 at 19:18, Maciek Wójcikowski wrote:
> We need to verify that it doesn't mess up the conda packages for windows.
> I'll have some time by the end of t
I'm keen to get my code merged, so I'm going to press you on this.
I've spent several months getting these tests to 100% passing. I'm
happy to send a screenshot showing this on my Windows machine.
- Noel
On 6 June 2017 at 20:52, Noel O'Boyle wrote:
> The link is on the PR:
> https://ci.appveyor.
I'm getting different errors on current master, see
https://ci.appveyor.com/project/mwojcikowski/conda-openbabel/build/1.0.19
I need to fix conda recipe for git master first, but I think we should
merge it as is and figure out what is the issue with tests later on.
Pozdrawiam, | Best regard
Thanks for the super quick response. I do appreciate it.
There is a std::isnan via _isnan build problem which will require a
#define for particular MSVC versions, but that's nothing to do with my
pull request.
Ok - I'm going to do ahead and silence the tests
- Noel
On 9 June 2017 at 13:56,
I'm on it as we speak.
Pozdrawiam, | Best regards,
Maciek Wójcikowski
mac...@wojcikowski.pl
2017-06-09 15:09 GMT+02:00 Noel O'Boyle :
> Thanks for the super quick response. I do appreciate it.
>
> There is a std::isnan via _isnan build problem which will require a
> #define for particular
Apparently my last name killed conda build...
https://ci.appveyor.com/project/mwojcikowski/conda-openbabel/build/1.0.23/job/hvv95j1fagio4ike
Pozdrawiam, | Best regards,
Maciek Wójcikowski
mac...@wojcikowski.pl
2017-06-09 15:19 GMT+02:00 Maciek Wójcikowski :
> I'm on it as we speak.
>
> --
Hi,
I wanted to follow up on the windows builds. My builds still have some
issues, but the ones you had trouble with pass (at least with my PR with
isnan fix). So I could say that they are artefact of your build setup on
Appveyor an the code itself is fine. Note that Conda uses older MSVC
specific
I deliberately supply the InChI .lib and set the appropriate build
flags in order to speed up the build. Also to avoid build warnings
that are outside our control.
- Noel
On 12 June 2017 at 13:57, Maciek Wójcikowski wrote:
> Hi,
>
> I wanted to follow up on the windows builds. My builds still ha
May you try to build the included InChI? All combination of parameters I've
tried failed or were ignored.
Pozdrawiam, | Best regards,
Maciek Wójcikowski
mac...@wojcikowski.pl
2017-06-12 16:23 GMT+02:00 Noel O'Boyle :
> I deliberately supply the InChI .lib and set the appropriate build
> f
11 matches
Mail list logo
