Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-08-08 Thread Richard Purdie
On Mon, 2023-08-07 at 16:15 +0200, Peter Suti wrote: > On Mon, Aug 7, 2023 at 2:55 PM Richard Purdie > wrote: > > > > On Mon, 2023-08-07 at 13:19 +0200, Peter Suti wrote: > > > On Fri, Aug 4, 2023 at 4:47 PM Richard Purdie > > > wrote: > > > > > > > > Do you have a way to reproduce this using r

Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-08-07 Thread Peter Suti
On Mon, Aug 7, 2023 at 2:55 PM Richard Purdie wrote: > > On Mon, 2023-08-07 at 13:19 +0200, Peter Suti wrote: > > On Fri, Aug 4, 2023 at 4:47 PM Richard Purdie > > wrote: > > > > > > Do you have a way to reproduce this using recipes in OE-Core? > > > > > > For example, I tried adding this to the

Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-08-07 Thread Richard Purdie
On Mon, 2023-08-07 at 13:19 +0200, Peter Suti wrote: > On Fri, Aug 4, 2023 at 4:47 PM Richard Purdie > wrote: > > > > Do you have a way to reproduce this using recipes in OE-Core? > > > > For example, I tried adding this to the cairo recipe: > > > > EXTERNALSRC = "/xxx/cairo-1.16.0" > > inherit

Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-08-07 Thread Peter Suti
On Fri, Aug 4, 2023 at 4:47 PM Richard Purdie wrote: > > Do you have a way to reproduce this using recipes in OE-Core? > > For example, I tried adding this to the cairo recipe: > > EXTERNALSRC = "/xxx/cairo-1.16.0" > inherit externalsrc > > and then building cairo, cleaning cairo, building pango (

Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-08-04 Thread Richard Purdie
On Wed, 2023-08-02 at 11:26 +0200, Peter Suti wrote: > On Mon, Jul 31, 2023 at 2:33 PM Richard Purdie > wrote: > > > > I did look at the bug and it sounds like if you clean a recipe, builds > > of other recipes which depend upon it then fail? > > Well not just in this case specifically, it is re

Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-08-02 Thread Peter Suti
On Mon, Jul 31, 2023 at 2:33 PM Richard Purdie wrote: > > I did look at the bug and it sounds like if you clean a recipe, builds > of other recipes which depend upon it then fail? Well not just in this case specifically, it is reproducible when doing a clean build. But this is the easiest most co

Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-07-31 Thread Richard Purdie
On Mon, 2023-07-31 at 14:08 +0200, Peter Suti wrote: > On Mon, Jul 31, 2023 at 1:06 PM Richard Purdie > wrote: > > > > On Mon, 2023-07-31 at 12:43 +0200, Peter Suti wrote: > > > On Mon, Jul 31, 2023 at 12:15 PM Richard Purdie > > > wrote: > > > > > > > > On Mon, 2023-07-31 at 11:34 +0200, Peter

Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-07-31 Thread Peter Suti
On Mon, Jul 31, 2023 at 1:06 PM Richard Purdie wrote: > > On Mon, 2023-07-31 at 12:43 +0200, Peter Suti wrote: > > On Mon, Jul 31, 2023 at 12:15 PM Richard Purdie > > wrote: > > > > > > On Mon, 2023-07-31 at 11:34 +0200, Peter Suti wrote: > > > > Fixes [YOCTO #15164] > > > > > > > > Instead of de

Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-07-31 Thread Richard Purdie
On Mon, 2023-07-31 at 12:43 +0200, Peter Suti wrote: > On Mon, Jul 31, 2023 at 12:15 PM Richard Purdie > wrote: > > > > On Mon, 2023-07-31 at 11:34 +0200, Peter Suti wrote: > > > Fixes [YOCTO #15164] > > > > > > Instead of deleting setscene tasks, now SSTATE_SKIP_CREATION is set > > > instead.

Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-07-31 Thread Peter Suti
On Mon, Jul 31, 2023 at 12:15 PM Richard Purdie wrote: > > On Mon, 2023-07-31 at 11:34 +0200, Peter Suti wrote: > > Fixes [YOCTO #15164] > > > > Instead of deleting setscene tasks, now SSTATE_SKIP_CREATION is set instead. > > > > This seems to fix the compile issues where the populate_sysroot task

Re: [OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-07-31 Thread Richard Purdie
On Mon, 2023-07-31 at 11:34 +0200, Peter Suti wrote: > Fixes [YOCTO #15164] > > Instead of deleting setscene tasks, now SSTATE_SKIP_CREATION is set instead. > > This seems to fix the compile issues where the populate_sysroot task was > not run when an externalsrc recipe was built as a dependency.

[OE-core] [PATCH] externalsrc: fix dependency chain issues

2023-07-31 Thread Peter Suti
Fixes [YOCTO #15164] Instead of deleting setscene tasks, now SSTATE_SKIP_CREATION is set instead. This seems to fix the compile issues where the populate_sysroot task was not run when an externalsrc recipe was built as a dependency. Signed-off-by: Peter Suti --- meta/classes/externalsrc.bbclas