Re: [OE-core] [PATCH 1/6] runqemu: Use OE_TMPDIR

2012-05-14 Thread Mark Hatle
On 5/14/12 5:51 PM, Marko Lindqvist wrote: On 8 May 2012 02:56, Scott Garman wrote: I can understand why we're trying to ensure our build system doesn't require /bin/sh to be bash, but I think support scripts like runqemu might be a special case. What do other people in the community think of

Re: [OE-core] [PATCH 1/6] runqemu: Use OE_TMPDIR

2012-05-14 Thread Marko Lindqvist
On 8 May 2012 02:56, Scott Garman wrote: > > I can understand why we're trying to ensure our build system doesn't require > /bin/sh to be bash, but I think support scripts like runqemu might be a > special case. > > What do other people in the community think of this? The runqemu script > isn't tr

Re: [OE-core] [PATCH 1/6] runqemu: Use OE_TMPDIR

2012-05-14 Thread Khem Raj
On Mon, May 14, 2012 at 3:34 PM, Mark Hatle wrote: > --- a/scripts/runqemu > +++ b/scripts/runqemu > @@ -300,14 +300,16 @@ findimage() { >     # recently created one is the one we most likely want to boot. >     filenames=`ls -t $where/*-image*$machine.$extension 2>/dev/null | xargs` >     for nam

Re: [OE-core] [PATCH 1/6] runqemu: Use OE_TMPDIR

2012-05-14 Thread Mark Hatle
On 5/8/12 2:07 AM, Peter Seebach wrote: On Mon, 7 May 2012 16:56:11 -0700 Scott Garman wrote: From what I can tell, the =~ regex operator is a bashism. It's also one that helps a lot with the code readability. So now that we're faced with re-writing the script to avoid using that operator,

Re: [OE-core] [PATCH 1/6] runqemu: Use OE_TMPDIR

2012-05-08 Thread Peter Seebach
On Mon, 7 May 2012 16:56:11 -0700 Scott Garman wrote: > From what I can tell, the =~ regex operator is a bashism. It's also > one that helps a lot with the code readability. So now that we're > faced with re-writing the script to avoid using that operator, I'm > having second thoughts about whet

Re: [OE-core] [PATCH 1/6] runqemu: Use OE_TMPDIR

2012-05-07 Thread Scott Garman
On 05/03/2012 10:12 AM, Bernhard Reutner-Fischer wrote: The error message erroneously talked about TMPDIR. Just use OE_TMPDIR everywhere to make the name of the variable obvious. Signed-off-by: Bernhard Reutner-Fischer Bernhard, This change wasn't well-tested and has broken the runqemu script

Re: [OE-core] [PATCH 1/6] runqemu: Use OE_TMPDIR

2012-05-04 Thread Scott Garman
On 05/03/2012 10:12 AM, Bernhard Reutner-Fischer wrote: The error message erroneously talked about TMPDIR. Just use OE_TMPDIR everywhere to make the name of the variable obvious. Signed-off-by: Bernhard Reutner-Fischer Bernhard, these are great improvements - thanks for refactoring this! Full

[OE-core] [PATCH 1/6] runqemu: Use OE_TMPDIR

2012-05-03 Thread Bernhard Reutner-Fischer
The error message erroneously talked about TMPDIR. Just use OE_TMPDIR everywhere to make the name of the variable obvious. Signed-off-by: Bernhard Reutner-Fischer --- scripts/runqemu | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/scripts/runqe