Re: [API Review]: Node validation

2013-07-09 Thread Martin Sladecek
On 07/09/2013 10:59 PM, David Grieve wrote: Since there is already a "requestLayout()" which defers to the next pulse, what about "demandLayout()"? Or why can't getBoundsInParent() or getBoundsInLocal() do this? Even with this function, there is still the problem where the dimensions of a nod

Re: [API Review]: Node validation

2013-07-09 Thread Martin Sladecek
+1 -Martin On 07/09/2013 05:06 PM, Pavel Safrata wrote: To me this sounds best so far. Perhaps updateVisuals() would be even better? Pavel On 8.7.2013 18:45, Scott Palmer wrote: validateVisuals() ? Or something with the word "visual" as it combines layout and other CSS information. Scott

hg: openjfx/8/controls/rt: 5 new changesets

2013-07-09 Thread hang . vo
Changeset: 53ab58d87489 Author:jgiles Date: 2013-07-10 10:14 +1200 URL: http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/53ab58d87489 RT-30593: TableView.TableViewSelectionModel changes in Lombard are not back compatible with previous versions ! modules/controls/src/main/java

Re: CFV: New OpenJFX Committer: Alexander Kouznetsov

2013-07-09 Thread Paru Somashekar
vote: yes -Paru. On 7/9/13 3:09 PM, Richard Bair wrote: I hereby nominate Alexander Kouznetsov to OpenJFX Committer. Alex is a member of the samples team, but also contributes to the core platform itself and to J1 demos. His recent work can be seen here: http://hg.openjdk.java.net/openjfx/8/

Re: CFV: New OpenJFX Committer: Debra Masada

2013-07-09 Thread Paru Somashekar
vote: yes -Paru. On 7/9/13 3:07 PM, Richard Bair wrote: I hereby nominate Debbie Masada to OpenJFX Committer. Debbie is a member of the samples team and works on Ensemble and other sample applications, adding functionality etc. as necessary. Some of her recent changes can be seen here. http

hg: openjfx/8/controls/rt: [TEST ONLY] Added test for RT-30549 and removed an inactive redundant test.

2013-07-09 Thread hang . vo
Changeset: 35f439b88db8 Author:leifs Date: 2013-07-09 16:39 -0700 URL: http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/35f439b88db8 [TEST ONLY] Added test for RT-30549 and removed an inactive redundant test. ! modules/controls/src/test/java/javafx/scene/control/DatePickerTest.

Re: CFV: New OpenJFX Committer: Alexander Kouznetsov

2013-07-09 Thread David Hill
On 7/9/13 Jul 9, 6:09 PM, Richard Bair wrote: I hereby nominate Alexander Kouznetsov to OpenJFX Committer. vote: yes Alex is a member of the samples team, but also contributes to the core platform itself and to J1 demos. His recent work can be seen here: http://hg.openjdk.java.net/openjfx/8/

Re: CFV: New OpenJFX Committer: Oleg Mazurov

2013-07-09 Thread David Hill
On 7/9/13 Jul 9, 6:17 PM, Richard Bair wrote: I hereby nominate Oleg Mazurov to OpenJFX Committer. vote: yest Oleg has been a key behind-the-scenes contributor to JavaFX performance. Some of his contributions can be counted in code http://hg.openjdk.java.net/openjfx/8/master/rt/log?rev=mazu

Re: CFV: New OpenJFX Committer: Danno Ferrin

2013-07-09 Thread David Hill
On 7/9/13 Jul 9, 6:03 PM, Richard Bair wrote: I hereby nominate Danno Ferrin to OpenJFX Committer. vote: yes Danno has been actively submitting patches and following up to make sure they get integrated for the past 8 months or so (the first patch I found was on this issue: https://javafx-jir

Re: CFV: New OpenJFX Committer: Debra Masada

2013-07-09 Thread David Hill
On 7/9/13 Jul 9, 6:07 PM, Richard Bair wrote: I hereby nominate Debbie Masada to OpenJFX Committer. vote: yes Debbie is a member of the samples team and works on Ensemble and other sample applications, adding functionality etc. as necessary. Some of her recent changes can be seen here. http

CFV: New OpenJFX Committer: Oleg Mazurov

2013-07-09 Thread Richard Bair
I hereby nominate Oleg Mazurov to OpenJFX Committer. Oleg has been a key behind-the-scenes contributor to JavaFX performance. Some of his contributions can be counted in code http://hg.openjdk.java.net/openjfx/8/master/rt/log?rev=mazurov But much more in terms of performance profiling and analy

CFV: New OpenJFX Committer: Alexander Kouznetsov

2013-07-09 Thread Richard Bair
I hereby nominate Alexander Kouznetsov to OpenJFX Committer. Alex is a member of the samples team, but also contributes to the core platform itself and to J1 demos. His recent work can be seen here: http://hg.openjdk.java.net/openjfx/8/master/rt/log?rev=kouznetsov Votes are due by Jul 23, 2013.

CFV: New OpenJFX Committer: Debra Masada

2013-07-09 Thread Richard Bair
I hereby nominate Debbie Masada to OpenJFX Committer. Debbie is a member of the samples team and works on Ensemble and other sample applications, adding functionality etc. as necessary. Some of her recent changes can be seen here. http://hg.openjdk.java.net/openjfx/8/master/rt/log?rev=masada V

Re: CFV: New OpenJFX Committer: Danno Ferrin

2013-07-09 Thread Jonathan Giles
vote: yes -- Jonathan On 10/07/2013 10:03 a.m., Richard Bair wrote: I hereby nominate Danno Ferrin to OpenJFX Committer. Danno has been actively submitting patches and following up to make sure they get integrated for the past 8 months or so (the first patch I found was on this issue: https:

CFV: New OpenJFX Committer: Danno Ferrin

2013-07-09 Thread Richard Bair
I hereby nominate Danno Ferrin to OpenJFX Committer. Danno has been actively submitting patches and following up to make sure they get integrated for the past 8 months or so (the first patch I found was on this issue: https://javafx-jira.kenai.com/browse/RT-26719). He has maintained a BitBucket

Re: [API Review]: Node validation

2013-07-09 Thread Tom Schindl
On 09.07.13 22:59, David Grieve wrote: > Since there is already a "requestLayout()" which defers to the next pulse, > what about "demandLayout()"? then I would go for forceLayout() Tom

Re: [API Review]: Node validation

2013-07-09 Thread David Grieve
Since there is already a "requestLayout()" which defers to the next pulse, what about "demandLayout()"? Or why can't getBoundsInParent() or getBoundsInLocal() do this? Even with this function, there is still the problem where the dimensions of a node won't be right if called before the node is

Re: Gradle build, one step forward, two backward :)

2013-07-09 Thread Mario Torre
On Mon, 2013-07-08 at 09:09 -0700, Richard Bair wrote: Hi Richard, > You are on Linux I'm guessing (educated guess). The open source linux > implementation was I believe just barely pushed. Which repo are you > building from (master or graphics)? Ouch, sorry I didn't say that... Yes, working on

Re: Validate cell, or request a cell update

2013-07-09 Thread Werner Lehmann
Ok - this means that in Cell.updateItem I would have to add a (weak?) listener to the item's state property. If the cell is reused for another item I would have to remove the old listener first. My only concern is that this will be done a lot when scrolling through the list. Thanks... If the

Re: Validate cell, or request a cell update

2013-07-09 Thread Richard Bair
I think this is different. The idea was that you would bind state on the cell to the item it is representing, so that it is automatically updated when needed and then there is no need to manually poke it. If the data item isn't observable, then you need a way to manually poke it. Richard On Ju

Re: [API Review]: Add 'fxml.version' to System Properties (Was: FXML version number)

2013-07-09 Thread Eric Le Ponner
Hi Danno, Scene Builder relies on FXMLLoader: - it won't open an FXML file whose fxml.version does not match FXMLLoader own version - it will attempt to open an FXML file no matter javafx.version but this may fail if SB FX SDK is no longer compatible with the FX version specified in the FXML f

hg: openjfx/8/graphics/rt: RT-31410 Ensemble8/Modena/3DViewer source missing from samples bundle

2013-07-09 Thread hang . vo
Changeset: 56e31708e758 Author:dmasada Date: 2013-07-09 08:20 -0700 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/56e31708e758 RT-31410 Ensemble8/Modena/3DViewer source missing from samples bundle + apps/experiments/3DViewer/build.xml + apps/experiments/Modena/build.xml

Re: [API Review]: Node validation

2013-07-09 Thread Pavel Safrata
To me this sounds best so far. Perhaps updateVisuals() would be even better? Pavel On 8.7.2013 18:45, Scott Palmer wrote: validateVisuals() ? Or something with the word "visual" as it combines layout and other CSS information. Scott On Mon, Jul 8, 2013 at 12:31 PM, Richard Bair wrote: OK, j

Re: [API Review]: Add 'fxml.version' to System Properties (Was: FXML version number)

2013-07-09 Thread Danno Ferrin
I think mixing FXML versions in one FXML document is a bad idea, so my proposal of a version attribute would only show at the root of the document applying to all elements of that document, seeing the fx:version attribute anywhere else should be considered a strict validation error, so the concerns

Re: [Review request] Make Cell.updateItem(item, empty) public, rather than protected

2013-07-09 Thread Tom Schindl
> Whether this justifies breaking code is up to the openjfx team, simply > saying it does not break compatibility to get some API approved is not > the way to go. > I don't want to imply that Jonathan did this! I know it was an oversight. Tom

hg: openjfx/8/graphics/rt: 3 new changesets

2013-07-09 Thread hang . vo
Changeset: 1220a4b96aaa Author:Vasiliy Baranov Date: 2013-07-09 16:40 +0400 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/1220a4b96aaa [TEST ONLY] Ignore failing test ! modules/web/src/test/java/javafx/scene/web/MiscellaneousTest.java Changeset: b3e19138d374 Author:

Re: [Review request] Make Cell.updateItem(item, empty) public, rather than protected

2013-07-09 Thread Tom Schindl
Hi, I must not (although most of the code out there which specialized Cell kept it protected and hence is broken) and all I did was to point out that this is and will be a breaking changeing. Whether this justifies breaking code is up to the openjfx team, simply saying it does not break compatibi

Re: CFV: New OpenJFX Committer: Petr Pchelko

2013-07-09 Thread sergey malenkov
Vote: Yes On 09.07.2013 14:22, Artem Ananiev wrote: I hereby nominate Petr Pchelko to OpenJFX Committer. Petr is a member of AWT group and an active contributor to JDK8 and OpenJFX projects. His primary areas of responsibility are AWT, Glass, and Mac OS X. Here is a list of his recent commit

Re: CFV: New OpenJFX Committer: Petr Pchelko

2013-07-09 Thread David Hill
vote: yes On 7/9/13 Jul 9, 6:22 AM, Artem Ananiev wrote: I hereby nominate Petr Pchelko to OpenJFX Committer. Petr is a member of AWT group and an active contributor to JDK8 and OpenJFX projects. His primary areas of responsibility are AWT, Glass, and Mac OS X. Here is a list of his recent

Re: [Review request] Make Cell.updateItem(item, empty) public, rather than protected

2013-07-09 Thread David Ray
I don't see what the problem is? Why must you reduce the visibility? You wouldn't do that for any other public method you've overridden? That would be clinging to a memory of what the API used to be. I would understand if I had to set my protected method public after updating my jdk - it's neces

Re: CFV: New OpenJFX Committer: Petr Pchelko

2013-07-09 Thread Anthony Petrov
Vote: YES -- best regards, Anthony On 07/09/2013 02:22 PM, Artem Ananiev wrote: I hereby nominate Petr Pchelko to OpenJFX Committer. Petr is a member of AWT group and an active contributor to JDK8 and OpenJFX projects. His primary areas of responsibility are AWT, Glass, and Mac OS X. Here is

Re: [API Review]: Add 'fxml.version' to System Properties (Was: FXML version number)

2013-07-09 Thread Svata Dedic
Hi, sorry to step in in the middle of the discussion. I was pointed to this thread only lately, as a part of review process of https://javafx-jira.kenai.com/browse/RT-28599 The note about XML diff / processing tools is valid; indeed even NetBeans which processes FXML must be adapted to creat

CFV: New OpenJFX Committer: Petr Pchelko

2013-07-09 Thread Artem Ananiev
I hereby nominate Petr Pchelko to OpenJFX Committer. Petr is a member of AWT group and an active contributor to JDK8 and OpenJFX projects. His primary areas of responsibility are AWT, Glass, and Mac OS X. Here is a list of his recent commits to OpenJFX: http://hg.openjdk.java.net/openjfx/8/m

Validate cell, or request a cell update

2013-07-09 Thread Werner Lehmann
Hi, Jonathan's question about Cell.updateItem rang a bell. Earlier this year I used a listview with a cell factory and had to resort to a dirty trick to get individual items to update in the SG if the underlying data had changed. I am hoping for a non-dirty solution - otherwise I might create

Re: [API Review]: Add 'fxml.version' to System Properties (Was: FXML version number)

2013-07-09 Thread Werner Lehmann
Hi, I don't particularly prefer one way or another but the first thing which came to my mind is to use a processing instruction. Especially because it can be "used by tools somehow". XML itself shows this: My 2c. Werner On 09.07.2013 09:06, Milan Kubec wrote: This information can be then

hg: openjfx/8/graphics/rt: Android: Always skip building Web when building OpenJFX on Android. Until android-webnode is opensourced.

2013-07-09 Thread hang . vo
Changeset: d46122695c20 Author:tb115823 Date: 2013-07-09 10:10 +0200 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/d46122695c20 Android: Always skip building Web when building OpenJFX on Android. Until android-webnode is opensourced. ! buildSrc/android.gradle

hg: openjfx/8/graphics/rt: iOS: updated gradle build (fat libs, webview-closed, ...)

2013-07-09 Thread hang . vo
Changeset: 5ad23b53ce4c Author:David Pulkrabek Date: 2013-07-09 09:06 +0200 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/5ad23b53ce4c iOS: updated gradle build (fat libs, webview-closed, ...) ! build.gradle ! buildSrc/ios.gradle + buildSrc/src/main/groovy/com/sun/java

Re: [API Review]: Add 'fxml.version' to System Properties (Was: FXML version number)

2013-07-09 Thread Milan Kubec
Hello, are you suggesting to use various fx:versions on multiple elements in one FXML file? It seems very unlikely that we would want to mix more versions of the same class in one document. I've suggested to use default namespace, because JavaFX API classes basically are (default) namespace for