On Mon, 2 Mar 2020 11:25:22 GMT, Nir Lisker wrote:
>> Resubmitting from before the transition to this repo. See linked issue for
>> details.
>
> The pull request has been updated with 1 additional commit.
Marked as reviewed by arapte (Reviewer).
-
PR:
On Mon, 2 Mar 2020 12:53:21 GMT, Florian Kirmaier wrote:
>>> It's now part of the systemtests, because the memory-semantics for the
>>> tests in controls is changed due to the TestToolkit.
>>
>> just curious: does that imply that you think the tests in controls ...
>> rather useless?
>
>
Changeset: 10c9528e
Author:Jose Pereda
Committer: Johan Vos
Date: 2020-03-02 18:29:15 +
URL: https://git.openjdk.java.net/jfx/commit/10c9528e
8240265: iOS: Unnecessary logging on pinch gestures
Reviewed-by: jvos
!
Hi Kevin,
On 02.03.2020 17:51, Kevin Rushforth wrote:
> On Thu, 27 Feb 2020 14:36:17 GMT, Rony G. Flatscher
> wrote:
>
>>> Overall this looks good to me. As I mentioned in PR #123 you should fold
>>> that the unit test into this PR.
>> Removed executable bits from gradlew (which I manually
On Sun, 1 Mar 2020 19:41:44 GMT, Jose Pereda wrote:
> This PR removes unnecessary logging of the scale value during a pinch gesture
> on iOS
Looks trivial.
-
Marked as reviewed by jvos (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/131
On Thu, 27 Feb 2020 14:36:17 GMT, Rony G. Flatscher
wrote:
>> Overall this looks good to me. As I mentioned in PR #123 you should fold
>> that the unit test into this PR.
>
> Removed executable bits from gradlew (which I manually have added to become
> able to run ./gradlew) and pushed it,
On Mon, 2 Mar 2020 09:26:19 GMT, Ambarish Rapte wrote:
> The below member variables and method of class
> SelectedItemsReadOnlyObservableList are not required anymore.
> Variables: itemsList, itemsListChanged, itemsListChange, itemsListListener.
> Method: setItemsList
>
> These members were
On Mon, 2 Mar 2020 16:47:05 GMT, Kevin Rushforth wrote:
>> The below member variables and method of class
>> SelectedItemsReadOnlyObservableList are not required anymore.
>> Variables: itemsList, itemsListChanged, itemsListChange, itemsListListener.
>> Method: setItemsList
>>
>> These members
On Mon, 2 Mar 2020 11:25:22 GMT, Nir Lisker wrote:
>> Resubmitting from before the transition to this repo. See linked issue for
>> details.
>
> The pull request has been updated with 1 additional commit.
Marked as reviewed by kcr (Lead).
-
PR:
Changeset: 4c132cdf
Author:Arun Joseph
Committer: Kevin Rushforth
Date: 2020-03-02 13:04:20 +
URL: https://git.openjdk.java.net/jfx/commit/4c132cdf
8237889: Update libxml2 to version 2.9.10
Reviewed-by: kcr, jvos
! modules/javafx.web/src/main/legal/libxml2.md
!
On Mon, 2 Mar 2020 10:59:12 GMT, Jeanette Winzenburg
wrote:
>> I've now readded the unit-test. It based on the "InitialNodesMemoryLeakTest".
>>
>> Command to execute: `./gradlew -PFULL_TEST=true -PUSE_ROBOT=true
>> :systemTests:test --tests
>>
On Mon, 2 Mar 2020 08:31:47 GMT, dannygonzalez
wrote:
>> In use cases where a large number of listeners are being discarded, it may
>> be better to first consider changing the design to receive event
>> notifications on nodes whose listener registrations are not frequently
>> discarded.
>
>>
> Resubmitting from before the transition to this repo. See linked issue for
> details.
The pull request has been updated with 1 additional commit.
-
Added commits:
- 12178c7f: Renamed `put` to `entry` as per review comment
Changes:
- all:
On Mon, 2 Mar 2020 10:07:24 GMT, Florian Kirmaier wrote:
>> Rather than removing the test, I was suggesting that you create a test for
>> memory leaks using the same ad hoc approach that our other memory leak tests
>> use. This could later be modified to use the new GC test utility as part of
> Hi everyone,
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259
>
> The fix itself is quite straight forward.
> It basically just removed the listener which causes the leak.
>
> The unit-test for the fix is a bit more complicated.
>
> I added a library JMemoryBuddy
On Tue, 4 Feb 2020 23:19:17 GMT, Kevin Rushforth wrote:
>> A little bit late ...
>> I have now removed unit-test and it's dependency.
>> I will add a ticket about adding them again.
>
> Rather than removing the test, I was suggesting that you create a test for
> memory leaks using the same ad
The below member variables and method of class
SelectedItemsReadOnlyObservableList are not required anymore.
Variables: itemsList, itemsListChanged, itemsListChange, itemsListListener.
Method: setItemsList
These members were added when this class was created for
On Thu, 27 Feb 2020 03:17:14 GMT, yosbits
wrote:
>>>
>>>
>>> I think that a starting point would be to decide on a spec for the listener
>>> notification order: is it specified by their registration order, or that is
>>> it unspecified, in which case we can take advantage of this for better
18 matches
Mail list logo
