On Thu, 21 May 2020 13:15:12 GMT, Jeanette Winzenburg
wrote:
>> Update the PR description once you remove the xxTestExamples file.
>>
>> Rest all changes look OK.
>
> done - both removed the example and updated the PR comment
PR looks fine to me.
Thanks for coming up with this general test
On Thu, 21 May 2020 13:21:39 GMT, Jeanette Winzenburg
wrote:
>> It's a task to support cross-control/skin testing for recurring issues (like
>> memory leaks on switching skins)
>>
>> Basically, there's a utility class
>> - to access lists of all control/classes,
>> - to access/create all
On Wed, 20 May 2020 06:24:32 GMT, Ajit Ghaisas wrote:
> Issue : https://bugs.openjdk.java.net/browse/JDK-8245183
> Fix : Added a message to the test saying these are expected warnings. Refer
> JBS comments for more details.
This pull request has now been integrated.
Changeset: 6e0b45a3
On Thu, 21 May 2020 17:41:02 GMT, Jose Pereda wrote:
> After JDK-8242167, a JavaFX control is used for text input on iOS instead of
> the native control, on a touch enabled
> device. However, selection handles are not enabled and currently text
> selection is not possible at all.
> This PR
After JDK-8242167, a JavaFX control is used for text input on iOS instead of
the native control, on a touch enabled
device. However, selection handles are not enabled and currently text selection
is not possible at all.
This PR enables handles on iOS as in the rest of the platforms with touch
On Fri, 15 May 2020 16:36:29 GMT, Bhawesh Choudhary
wrote:
> Print function of WebEngine.java ignores page range setting and prints given
> number of pages starting from first page,
> which is the root cause of this issue. To fix it, put check for page ranges
> and if it available, use it for
On Fri, 15 May 2020 17:10:49 GMT, Kevin Rushforth wrote:
>> Print function of WebEngine.java ignores page range setting and prints given
>> number of pages starting from first page,
>> which is the root cause of this issue. To fix it, put check for page ranges
>> and if it available, use it
On Tue, 19 May 2020 10:25:24 GMT, Ajit Ghaisas wrote:
> Issue : https://bugs.openjdk.java.net/browse/JDK-8245181
>
> Root cause : The exception just gets logged and does not result in test
> failure.
>
> Fix : Added the mechanism to catch and handle UncaughtException. Test
>
On Wed, 20 May 2020 11:45:59 GMT, Ajit Ghaisas wrote:
> Issue : https://bugs.openjdk.java.net/browse/JDK-8245457
>
> Fix : It is a simple test fix. I have enabled the ignored tests from
> ButtonBaseTest & ButtonTest test classes & fixed
> them. Also removed a print to std.out.
These are
On Wed, 20 May 2020 06:24:32 GMT, Ajit Ghaisas wrote:
> Issue : https://bugs.openjdk.java.net/browse/JDK-8245183
> Fix : Added a message to the test saying these are expected warnings. Refer
> JBS comments for more details.
Marked as reviewed by arapte (Reviewer).
-
PR:
On Thu, 21 May 2020 16:47:30 GMT, Kevin Rushforth wrote:
>> As discussed
>> [here](https://github.com/openjdk/jfx/pull/201#issuecomment-621772586)
>> during #201 , This PR converts the
>> system tests in TabPanePermuteGetTabsTest.java to unit test.
>> Thanks @kleopatra , for providing the
On Thu, 21 May 2020 07:55:16 GMT, Ambarish Rapte wrote:
> As discussed
> [here](https://github.com/openjdk/jfx/pull/201#issuecomment-621772586) during
> #201 , This PR converts the
> system tests in TabPanePermuteGetTabsTest.java to unit test.
> Thanks @kleopatra , for providing the test. I
On Wed, 20 May 2020 11:45:59 GMT, Ajit Ghaisas wrote:
> Issue : https://bugs.openjdk.java.net/browse/JDK-8245457
>
> Fix : It is a simple test fix. I have enabled the ignored tests from
> ButtonBaseTest & ButtonTest test classes & fixed
> them. Also removed a print to std.out.
Marked as
On Thu, 21 May 2020 15:48:34 GMT, Kevin Rushforth wrote:
>> Issue : https://bugs.openjdk.java.net/browse/JDK-8245183
>> Fix : Added a message to the test saying these are expected warnings. Refer
>> JBS comments for more details.
>
> Marked as reviewed by kcr (Lead).
While running the FXML
On Wed, 20 May 2020 06:24:32 GMT, Ajit Ghaisas wrote:
> Issue : https://bugs.openjdk.java.net/browse/JDK-8245183
> Fix : Added a message to the test saying these are expected warnings. Refer
> JBS comments for more details.
Marked as reviewed by kcr (Lead).
-
PR:
On Wed, 20 May 2020 14:30:11 GMT, Arun Joseph wrote:
> Cause: The Window Class `RunLoopMessageWindow` is never registered (this
> happens because
> registerRunLoopMessageWindowClass() is moved to MainThreadWin.cpp while
> openjfx uses MainThreadJava.cpp) and this
> causes every SetTimer() call
On Wed, 20 May 2020 14:30:11 GMT, Arun Joseph wrote:
> Cause: The Window Class `RunLoopMessageWindow` is never registered (this
> happens because
> registerRunLoopMessageWindowClass() is moved to MainThreadWin.cpp while
> openjfx uses MainThreadJava.cpp) and this
> causes every SetTimer() call
On Thu, 21 May 2020 12:31:59 GMT, Ajit Ghaisas wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed xxTestExample
>
> Update the PR description once you remove the xxTestExamples file.
>
> Rest all
> It's a task to support cross-control/skin testing for recurring issues (like
> memory leaks on switching skins)
>
> Basically, there's a utility class
> - to access lists of all control/classes,
> - to access/create all behaviors
> - has alternative skins classes for all controls and utility
On Thu, 21 May 2020 10:45:09 GMT, Jeanette Winzenburg
wrote:
>> It's a task to support cross-control/skin testing for recurring issues (like
>> memory leaks on switching skins)
>>
>> Basically, there's a utility class
>> - to access lists of all control/classes,
>> - to access/create all
On Thu, 21 May 2020 10:47:52 GMT, Jeanette Winzenburg
wrote:
>> that's the point - they are examples of how-to use it and see our tasks :)
>>
>> Will address your other comments in a minute - and add two real tests (on
>> skin/behavior memory leaks with the
>> misbehaving classes removed:
On Thu, 21 May 2020 10:22:18 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/ControlBehaviorTestExample.java
>> line 52:
>>> 51: @RunWith(Parameterized.class)
>>> 52: public class ControlBehaviorTestExample {
>>> 53:
>>
On Thu, 21 May 2020 06:47:09 GMT, Ajit Ghaisas wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> code/doc changes as requested in review
>>
>> added Skin/BehaviorMemoryLeakTest
>
>
On Thu, 21 May 2020 10:33:27 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/ControlSkinFactoryTest.java
>> line
>> 91:
>>> 90: Control control = createControl(controlClass);
>>> 91: Skin old =
> It's a task to support cross-control/skin testing for recurring issues (like
> memory leaks on switching skins)
>
> Basically, there's a utility class
> - to access lists of all control/classes,
> - to access/create all behaviors
> - has alternative skins classes for all controls and utility
On Thu, 21 May 2020 06:56:12 GMT, Ajit Ghaisas wrote:
>> It's a task to support cross-control/skin testing for recurring issues (like
>> memory leaks on switching skins)
>>
>> Basically, there's a utility class
>> - to access lists of all control/classes,
>> - to access/create all behaviors
>>
On Thu, 21 May 2020 07:16:15 GMT, Ajit Ghaisas wrote:
>> It's a task to support cross-control/skin testing for recurring issues (like
>> memory leaks on switching skins)
>>
>> Basically, there's a utility class
>> - to access lists of all control/classes,
>> - to access/create all behaviors
>>
On Thu, 21 May 2020 10:05:25 GMT, Ajit Ghaisas wrote:
>> It's a task to support cross-control/skin testing for recurring issues (like
>> memory leaks on switching skins)
>>
>> Basically, there's a utility class
>> - to access lists of all control/classes,
>> - to access/create all behaviors
>>
On Mon, 18 May 2020 12:07:30 GMT, Jeanette Winzenburg
wrote:
> It's a task to support cross-control/skin testing for recurring issues (like
> memory leaks on switching skins)
>
> Basically, there's a utility class
> - to access lists of all control/classes,
> - to access/create all behaviors
As discussed
[here](https://github.com/openjdk/jfx/pull/201#issuecomment-621772586) during
#201 , This PR converts the
system tests in TabPanePermuteGetTabsTest.java to unit test.
Thanks @kleopatra , for providing the test. I have added few more tests and
found few failures.
On Wed, 20 May 2020 14:30:11 GMT, Arun Joseph wrote:
> Cause: The Window Class `RunLoopMessageWindow` is never registered (this
> happens because
> registerRunLoopMessageWindowClass() is moved to MainThreadWin.cpp while
> openjfx uses MainThreadJava.cpp) and this
> causes every SetTimer() call
31 matches
Mail list logo
