Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v3]

2020-07-20 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't

Re: RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v5]

2020-07-20 Thread Kevin Rushforth
On Wed, 8 Jul 2020 22:18:39 GMT, Kevin Rushforth wrote: >> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> move swt test > > The test looks good with one minor typo in the constant field name (see > below). I verified

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Davide Perini
Done it here. https://github.com/sblantipodi/JavaFastScreenCapture/blob/JavaFXJavaModule/pom.xml If you read my sources there is how to configure the maven pom. You need then create a simple class with a main that doesn't extends application that simply call the main in the class that extends

Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-20 Thread Kevin Rushforth
I filed https://bugs.openjdk.java.net/browse/JDK-8249777 to track fixing the build.gradle to not include the time stamp, at least by default. -- Kevin On 7/20/2020 3:16 PM, Kevin Rushforth wrote: On 7/20/2020 2:05 PM, Laszlo Kishalmi wrote: On 7/20/20 1:15 PM, Kevin Rushforth wrote:   

Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-20 Thread Kevin Rushforth
On 7/20/2020 2:05 PM, Laszlo Kishalmi wrote: On 7/20/20 1:15 PM, Kevin Rushforth wrote:    That could be prevented by removing line 1547: project.version =    MAVEN_VERSION from the build script. Interesting. That is only used for the maven "publishing" tasks, and shouldn't affect the main

Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-20 Thread Laszlo Kishalmi
On 7/20/20 1:15 PM, Kevin Rushforth wrote: Hi Laszlo, Thanks for reaching out to us. Neil Smith suggested that I report this on netbeans-dev, which I haven't done yet, but can do today if you still need me to. To answer some of your specific questions: 1. For some reason version

Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-20 Thread Kevin Rushforth
Hi Laszlo, Thanks for reaching out to us. Neil Smith suggested that I report this on netbeans-dev, which I haven't done yet, but can do today if you still need me to. To answer some of your specific questions: 1. For some reason version calculation is built in the script adding a    second

Re: Hello!

2020-07-20 Thread FireController#1847
Hey, Thanks for the response. I've read all of the contributing data and signed the OCA (otherwise I wouldn't be here haha). I've already got a build of JavaFX up and running, but I am completely lost on where to get started. I'd like to work on implementing this feature: JDK-8238733

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Davide Perini
PS: I add that I'm not new to maven, before java fx, I had a fat jar with gstreamer library, jna, and so on. the only problem I have is that it seems that I'm not able to bundle javafx with my fat jar. Il 20/07/2020 20.55, Davide Perini ha scritto: I agree, don't want to download a JDK. Is

Fixing NetBeans Gradle Support for OpenJFX

2020-07-20 Thread Laszlo Kishalmi
Dear OpenJFX devs, As a quick introduction, I'm the main developer behind the Gradle support in Apache NetBeans. Well, I must say they OpenJFX is using Gradle in a very original way. In order to make NetBeans to be able to be used for OpenJFX development, I need to understand some aspects

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Ty Young
Don't know anything about fat jars, but you could try this jlink plugin: https://tentackle.org/static-content/sitedocs/tentackle/latest/tentackle-jlink-maven-plugin/jlink-mojo.html It works with non-modular projects as well - everything just gets dumped into a folder and put onto the module

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Davide Perini
Ok solved it reading this stackoverflow: https://stackoverflow.com/questions/52653836/maven-shade-javafx-runtime-components-are-missing thanks to all Il 20/07/2020 20.55, Davide Perini ha scritto: I agree, don't want to download a JDK. Is there a way to simply to it the old but good way using

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Davide Perini
I agree, don't want to download a JDK. Is there a way to simply to it the old but good way using maven assembly plugin or shade plugin? I am following this guide here: https://openjfx.io/openjfx-docs/#modular I have done what they suggest in my pom file: org.openjfx javafx-controls

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Scott Palmer
jlink and jdeps are module-based, so you do have to be careful. Neither will work properly when you try to run it against a non-modular project (found that out the hard way when Java 11 broke the world by removing the EE modules from Java SE and no modules were available to replace them), but

Re: RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v6]

2020-07-20 Thread Oliver Schmidtmer
> In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and > Math.round produce different results and > EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one error > on the line width and therefore sheared > rendering. The changes were already proposed by

Re: Hello!

2020-07-20 Thread Nir Lisker
Hi, As the mailing list page [1] says, this list is for technical discussion related to the OpenJFX project. To implement a feature, see [2]. - Nir [1] https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev [2] https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md On Sun, Jul 19,

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Michael Paus
Am 20.07.20 um 19:40 schrieb Nir Lisker: In addition to the other answers, you can look into GraalVM's native image: https://www.graalvm.org/docs/reference-manual/native-image/ GraalVM native-image does not work directly with JavaFX. You would have to use the Gluon client-maven-plugin

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Nir Lisker
Hi, Unfortunantly so few dependencies supports Java Modules this day All the ones I know of do. Here's a list of modules on Maven Central: https://github.com/sormuras/modules so fat JAR is the only way I can do it. > In addition to the other answers, you can look into GraalVM's native image:

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Michael Paus
In order to create a real platform installer with jpackage and jlink/jdeps you don't have to use the java module system at all. Have a look at this tutorial which I co-autored together with Dirk Lemmermann: Michael Am 20.07.20 um 19:25 schrieb

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Davide Perini
Hi, thanks for the answer, I appreciate it. I am trying with jpackage (that bundles my fat jar with some more dlls), but when I try to run my app I get this error: Error: JavaFX runtime components are missing, and are required to run this application Any idea? Thanks Il 20/07/2020 19.30,

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Matthias Bläsing
Hi, Am Montag, den 20.07.2020, 19:25 +0200 schrieb Davide Perini: > Unfortunantly so few dependencies supports Java Modules this day, so > fat JAR is the only way I can do it. no it is not. There are seveal ways how to bundle native libraries. jpackage is one way, fat jars are another. And for

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Davide Perini
Unfortunantly so few dependencies supports Java Modules this day, so fat JAR is the only way I can do it. Thanks Il 20/07/2020 02.50, Scott Palmer ha scritto: The JavaFX classes are there, but what about the native libraries? A fat jar isn’t a good way to distribute a Java application these

Re: [jfx15] RFR: 8248381: Create a daemon thread for MonocleTimer [v2]

2020-07-20 Thread Johan Vos
On Sun, 28 Jun 2020 02:28:35 GMT, John Neffenger wrote: >> Fixes [JDK-8248381](https://bugs.openjdk.java.net/browse/JDK-8248381). > > John Neffenger has updated the pull request incrementally with one additional > commit since the last revision: > > Remove POOL_SIZE constant I'm ok with

Re: RFR: 8196079: Remove obsolete Pisces rasterizer

2020-07-20 Thread Kevin Rushforth
On Sun, 19 Jul 2020 09:35:15 GMT, Laurent Bourgès wrote: >> I think you are conflating the rasterization step with the rendering step. >> In Prism the rasterization mainly includes >> clipping the shape and generating the mask data for the filled and/or >> stroked shape (the latter possibly