RFR: 8265439: [TestBug] Enable and fix ignored unit tests in MenuItemTest

2021-04-19 Thread Ajit Ghaisas
This PR enables ignored unit tests from MenuItemTest and fixes them. 4 ignored tests are fixed. 2 ignored tests are removed. 2 new tests are added. **Before fix :** total tests = 89 failures = 0 ignored tests = 6 **After fix :** total tests = 89 failures = 0 ignored tests = 0 - C

Re: RFR: 8264010: Add Gradle dependency verification [v4]

2021-04-19 Thread Kevin Rushforth
On Sat, 17 Apr 2021 23:17:04 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure Gr

Re: RFR: 8265439: [TestBug] Enable and fix ignored unit tests in MenuItemTest

2021-04-19 Thread Kevin Rushforth
On Mon, 19 Apr 2021 12:51:06 GMT, Ajit Ghaisas wrote: > This PR enables ignored unit tests from MenuItemTest and fixes them. > 4 ignored tests are fixed. > 2 ignored tests are removed. > 2 new tests are added. > > **Before fix :** > total tests = 89 > failures = 0 > ignored tests = 6 > > **Af

Re: RFR: 8264990: WebEngine crashes with segfault when not loaded through system classloader [v3]

2021-04-19 Thread Arun Joseph
On Thu, 15 Apr 2021 16:43:08 GMT, Matthias Bläsing wrote: >> The functions from FileSystemJava are called from different threads the >> root problem manifests because the JNI FindClass function behaves >> differently when called from a context that is the ancestor of a java >> frame compared to

Re: RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-04-19 Thread Kevin Rushforth
On Mon, 15 Mar 2021 09:11:41 GMT, Robert Lichtenberger wrote: >> Reverting to the old way of showing the context menu but with application >> of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct >> size measurement of the menu. > > Yes I can try to look into this. > > On 3/1

Re: RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-04-19 Thread Robert Lichtenberger
On Mon, 15 Mar 2021 09:11:41 GMT, Robert Lichtenberger wrote: >> Reverting to the old way of showing the context menu but with application >> of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct >> size measurement of the menu. > > Yes I can try to look into this. > > On 3/1

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-19 Thread PrimosK
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. A production build using this fix doesn't solve it. Application still freezes. We

Re: RFR: 8265439: [TestBug] Enable and fix ignored unit tests in MenuItemTest

2021-04-19 Thread Ajit Ghaisas
On Mon, 19 Apr 2021 12:51:06 GMT, Ajit Ghaisas wrote: > This PR enables ignored unit tests from MenuItemTest and fixes them. > 4 ignored tests are fixed. > 2 ignored tests are removed. > 2 new tests are added. > > **Before fix :** > total tests = 89 > failures = 0 > ignored tests = 6 > > **Af

Re: RFR: 8265439: [TestBug] Enable and fix ignored unit tests in MenuItemTest

2021-04-19 Thread Kevin Rushforth
On Mon, 19 Apr 2021 12:51:06 GMT, Ajit Ghaisas wrote: > This PR enables ignored unit tests from MenuItemTest and fixes them. > 4 ignored tests are fixed. > 2 ignored tests are removed. > 2 new tests are added. > > **Before fix :** > total tests = 89 > failures = 0 > ignored tests = 6 > > **Af

Re: RFR: 8265439: [TestBug] Enable and fix ignored unit tests in MenuItemTest

2021-04-19 Thread Kevin Rushforth
On Mon, 19 Apr 2021 16:48:07 GMT, Ajit Ghaisas wrote: >> This PR enables ignored unit tests from MenuItemTest and fixes them. >> 4 ignored tests are fixed. >> 2 ignored tests are removed. >> 2 new tests are added. >> >> **Before fix :** >> total tests = 89 >> failures = 0 >> ignored tests = 6

Integrated: 8259356: MediaPlayer's seek freezes video

2021-04-19 Thread Alexander Matveev
On Sat, 17 Apr 2021 01:39:17 GMT, Alexander Matveev wrote: > This is regression (introduced) by JDK-8199527. JDK-8199527 added fix for HLS > streams (unfortunately I was not able to find repro case and more details on > why it was added) in gstappsink.c line 659-678 to store current caps which

Re: RFR: 8264990: WebEngine crashes with segfault when not loaded through system classloader [v3]

2021-04-19 Thread Matthias Bläsing
On Mon, 19 Apr 2021 14:25:36 GMT, Arun Joseph wrote: >> Matthias Bläsing has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review fix: Use correct bug id > > The test and changes looks good. @arun-Joseph @kevinrushforth thank you both for

Integrated: 8264990: WebEngine crashes with segfault when not loaded through system classloader

2021-04-19 Thread Matthias Bläsing
On Thu, 8 Apr 2021 06:58:14 GMT, Matthias Bläsing wrote: > The functions from FileSystemJava are called from different threads the > root problem manifests because the JNI FindClass function behaves > differently when called from a context that is the ancestor of a java > frame compared to when

Re: RFR: 8264990: WebEngine crashes with segfault when not loaded through system classloader [v3]

2021-04-19 Thread Johan Vos
On Thu, 15 Apr 2021 16:43:08 GMT, Matthias Bläsing wrote: >> The functions from FileSystemJava are called from different threads the >> root problem manifests because the JNI FindClass function behaves >> differently when called from a context that is the ancestor of a java >> frame compared to

RFR: 8265469: Allow to build media and webkit for Linux-AArch64

2021-04-19 Thread Johan Vos
Changes that allow to build linux configuration on Linux AArch64 This PR introduces an `IS_AARCH64` parameter in build.gradle. This PR already contains the change from PR #465 so if this one gets integrated, that change needs to removed from this PR. - Commit messages: - Changes tha

AArch64 naming conventions

2021-04-19 Thread Johan Vos
Recently, we introduced the option (or are introducing the options) to build OpenJFX for 64-bit ARM CPU's on Mac, Windows and Linux. However, those 3 platforms use different approaches to deal with this arch-specific options. Since the PR's for windows and linux are currently still open, it might b

Re: AArch64 naming conventions

2021-04-19 Thread Philip Race
FWIW I think on the JDK side folks are converging on aarch64 And also using that name as the "CPU" field in JBS (the alternative there being 'arm'). I'd find it easier if it was consistent across all these places. -phil On 4/19/21 1:06 PM, Johan Vos wrote: Recently, we introduced the option (

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-19 Thread PrimosK
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. Please discard my previous comment. After building a debug version we can't repro

Re: RFR: 8265439: [TestBug] Enable and fix ignored unit tests in MenuItemTest [v2]

2021-04-19 Thread Ajit Ghaisas
> This PR enables ignored unit tests from MenuItemTest and fixes them. > 2 ignored tests are fixed. > 4 ignored tests are removed. > 2 new tests are added. > > **Before fix :** > total tests = 89 > failures = 0 > ignored tests = 6 > > **After fix :** > total tests = 89 > failures = 0 > ignored

Re: RFR: 8265439: [TestBug] Enable and fix ignored unit tests in MenuItemTest [v2]

2021-04-19 Thread Ajit Ghaisas
On Mon, 19 Apr 2021 17:47:14 GMT, Kevin Rushforth wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/MenuItemTest.java >> line 410: >> >>> 408: >>> 409: @Test(expected=NullPointerException.class) >>> 410: public void setSpecifiedAccelerator_nullKeyCombination1()

Re: javafx-swt not deployed on maven central

2021-04-19 Thread Tom Schindl
Hi, So I deployed the Artifact in the meanwhile to our companies public maven repo [1] as I didn't want to pollute maven-central with javafx-swt in a different namespace. Tom [1] https://maven.bestsolution.at/releases/at/bestsolution/openjfx/javafx-swt/ Am 07.04.21 um 10:53 schrieb Tom Sc

Re: RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-04-19 Thread Robert Lichtenberger
On Tue, 23 Feb 2021 15:32:17 GMT, Robert Lichtenberger wrote: > Reverting to the old way of showing the context menu but with application > of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct > size measurement of the menu. I've finally managed to build JavaFX under Windows