[9] Review request : JDK-8171228 : StackOverflowError on MenuBarSkin when handling key-events and only menu is disabled

Hi Jonathan, Request you to review a fix where I have replaced an erroneous recursion (that caused StackOverflow) with a loop. Bug : https://bugs.openjdk.java.net/browse/JDK-8171228 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8171228/webrev.0/ Regards, Ajit

[9] Review request : JDK-8171071 : SplitPane is not visible after visible property changes

Hi Jonathan, Request you to review following fix : In SplitPaneSkin class, layoutChildren logic is ignored in case visibility property is set to false. I have corrected this. Bug : https://bugs.openjdk.java.net/browse/JDK-8171071 Fix : http://cr.openjdk.java.net/~aghaisas/fx/817

[9] Review request : JDK-8089875 : MenuBarSkin does not update if a menu changes its visibility.

Hi Jonathan, Request you to review following fix : Menus that were added after MenuBarSkin construction never used to trigger UI rebuilding if their visible property changed. Bug : https://bugs.openjdk.java.net/browse/JDK-8089875 Fix : http://cr.openjdk.java.net/~aghaisas/fx/80

[9] Review request : JDK-8089059 : Left padding of CheckBox doesn't only add padding to the left, but also to top.

Hi Jonathan, Kevin, Request you to review a simple fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8089059 Left padding of CheckBox doesn't only add padding to the left, but also to top. Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089059/webrev.0/ Rega

[10] Review request: JDK-8088436 : [ColorPicker] When focusing on a non 100% opacity color, the color is displayed incorrect.

Hi Jonathan, Request you to review below fix for ColorPicker control - Bug : https://bugs.openjdk.java.net/browse/JDK-8088436 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8088436/webrev.0/ I have also attached before and after screenshots to the bug in JBS. Regards

[10] Review request: JDK-8090012 : ColorPicker, undefined custom color has blank tooltip.

Hi Jonathan,     Request you to review below fix for ColorPicker control -     Bug : https://bugs.openjdk.java.net/browse/JDK-8090012     Fix : http://cr.openjdk.java.net/~aghaisas/fx/8090012/webrev.0/ Regards, Ajit

[10] Review request: JDK-8089193 : Width of menu is affected by mnemonic-identifier

Hi Jonathan,     Request you to review below fix -     Bug : https://bugs.openjdk.java.net/browse/JDK-8089193     Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089193/webrev.0/ Regards, Ajit

[10] Review request : JDK-8089875 : MenuBarSkin does not update if a menu changes its visibility.

Hi Jonathan, Request you to review following fix : Menus that were added after MenuBarSkin construction never used to trigger UI rebuilding if their visible property changed. Bug : https://bugs.openjdk.java.net/browse/JDK-8089875 Fix : http://cr.openjdk.java.net/~aghaisas/fx/80

[10] Review request : JDK-8153509 : MenuButton label padding is not ignored for ignored labels

Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8153509 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8153509/webrev.1/ Regards, Ajit

[10] Review request : JDK-8089984 : [Accessibility,CSS] Progress Indicator's Label is not visible in High Contrast

Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8089984 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089984/webrev.0/ Regards, Ajit

[10] Review request : JDK-8089840 : Disabled menu items are invisible with 100% contrast display settings

Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8089840 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089840/webrev.0/ Regards, Ajit

[10] Review request : JDK-8089310 : [ContextMenu] Disabled Menu Rollover never receives Mouse hover

Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8089310 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089310/webrev.0/ Regards, Ajit

[10] Review request: JDK-8087978 : ProgressIndicator text disappears when using a larger font

Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8087978 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8087978/webrev.1/ Regards, Ajit

[10] Review request : JDK-8177636 : Reduce frequency of CSS resetting properties temporarily to initial state

Hi Jonathan, Request you to review following change : Issue : https://bugs.openjdk.java.net/browse/JDK-8177636 Fix : http://cr.openjdk.java.net/~aghaisas/fx/e8177636/webrev.1/ Regards, Ajit

[10] Review request : JDK-8090462 : CSS performance: Link style helpers together to avoid going through parent chain looking for parent style helpers

Hi Jonathan, Request you to review following change : Issue : https://bugs.openjdk.java.net/browse/JDK-8090462 Fix : http://cr.openjdk.java.net/~aghaisas/fx/e8090462/webrev.2/ Regards, Ajit

[10] Review Request : JDK-8173301 : Provide API to exclude parts of the SceneGraph from being processed by the CSS-Engine

Hi, It is a proposed API that developers can leverage to gain performance improvements by skipping CSS processing on selective Nodes. JBS API request : https://bugs.openjdk.java.net/browse/JDK-8173301 Webrev : http://cr.openjdk.java.net/~aghaisas/fx/e8173301/webrev.0/ Request y

[10] Review request : JDK-8089265 : [ProgressIndicator] behaves itself wrong, when aligned

Hi Jonathan, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK-8089265 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089265/webrev.0/ Regards, Ajit

RE: CFV: New OpenJFX Committer: Prasanta Sadhukhan

Vote: YES -Original Message- From: Kevin Rushforth Sent: Thursday, September 28, 2017 6:40 AM To: Prasanta Sadhukhan; openjfx-dev@openjdk.java.net Subject: CFV: New OpenJFX Committer: Prasanta Sadhukhan I hereby nominate Prasanta Sadhukhan [1] to OpenJFX Committer. Prasanta is a member

[10] Review request : JDK-8155893 : Mnemonic mark misplaced in multiline button

Hi, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK-8155893 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8155893/webrev.1/ Regards, Ajit

[10] Review request : JDK-8188164 : Visual glitch / layout issue when setting pref height of table column headers

Hi, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK- 8188164 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8188164/webrev.0/ Regards, Ajit

[10] Review request : JDK-8189677 : RadioMenuItem fires extra NULL value in property

Hi, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK-8189677 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8189677/webrev.0/ Regards, Ajit

RE: CFV: New OpenJFX Committer: Ambarish Rapte

Vote : Yes Regards, Ajit -Original Message- From: Kevin Rushforth Sent: Wednesday, November 01, 2017 1:48 AM To: openjfx-dev@openjdk.java.net; Ambarish Rapte Subject: CFV: New OpenJFX Committer: Ambarish Rapte I hereby nominate Ambarish Rapte [1] to OpenJFX Committer. Ambarish is a mem

[10] [8u] Review request : JDK-8189265 : Closing stage does not free internal resources

Hi Kevin, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK-8189265 Fix for JDK 10 : http://cr.openjdk.java.net/~aghaisas/fx/8189265/10/webrev.0/ Fix for JDK 8u : http://cr.openjdk.java.net/~aghaisas/fx/8189265/8u/webrev.0/ Re

[10] Review request : JDK-8187379 : VirtualContainerBase: createVirtualFlow must be protected

Hi Kevin, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK-8187379 Fix for JDK 10 : http://cr.openjdk.java.net/~aghaisas/fx/8187379/webrev.0/ Regards, Ajit

RE: CFV: New OpenJFX Committer: Laurent Bourgès

Vote : YES Regards, Ajit -Original Message- From: Kevin Rushforth Sent: Tuesday, December 12, 2017 5:50 AM To: Laurent Bourgès; openjfx-dev@openjdk.java.net Subject: CFV: New OpenJFX Committer: Laurent Bourgès I hereby nominate Laurent Bourgès [1] to OpenJFX Committer. Laurent is the a

[10] Review request : JDK-8183100 : Styles not applied reliably after Java 8u92

Hi Kevin, Request you to review following fix : Issues : https://bugs.openjdk.java.net/browse/JDK-8183100 Fix for JDK 10 : http://cr.openjdk.java.net/~aghaisas/fx/8183100/webrev.1/ This patch reverts the patch of JDK-8151756. This fixes 3 regressions (JDK-818

[10] Review request : JDK-8193494 : Add a regression test case for JDK-8183100 changeset

Hi Kevin, Ambarish, Request you to review following test addition : Issue : https://bugs.openjdk.java.net/browse/JDK-8193494 Fix for JDK 10 : http://cr.openjdk.java.net/~aghaisas/fx/8193494/webrev.0/ Regards, Ajit

[10] Review request : JDK-8193041 : [TestBug] A new test case can be added to javafx/scene/control/ProgressIndicatorTest.java

Hi, Request you to review following test addition : Issue : https://bugs.openjdk.java.net/browse/JDK-8193041 Fix for JDK 10 : http://cr.openjdk.java.net/~aghaisas/fx/8193041/webrev.0/ Regards, Ajit

[11] Review request : JDK-8187432 : ListView: EditEvent on start has incorrect index

Hi, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK-8187432 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8187432/webrev.0/ Regards, Ajit

[11] Review request : JDK-8194913 : Focus traversal is broken if a Pane is added to a ToolBar

Hi, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK-8194913 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8194913/webrev.0/ Regards, Ajit

[8u-backport] Review request : JDK-8193494 : Add a regression test case for JDK-8183100

Hi, Request you to review following 8u backport : Issue : https://bugs.openjdk.java.net/browse/JDK-8193494 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8193494/8u/webrev.0/ Regards, Ajit

[11] Review request : JDK-8195806 : Eliminate dependency on sun.font.lookup in javafx.graphics

Hi Kevin, Phil, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK-8195806 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8195806/webrev.0/ Regards, Ajit

RE: [11] Review request : JDK-8195806 : Eliminate dependency on sun.font.lookup in javafx.graphics

your guidance in this regard. Regards, Ajit -Original Message- From: Philip Race Sent: Wednesday, February 14, 2018 12:52 PM To: Ajit Ghaisas Cc: Kevin Rushforth; openjfx-dev@openjdk.java.net Subject: Re: [11] Review request : JDK-8195806 : Eliminate dependency on

RE: Regression in 1.8.0_102

Hi Hervé, Going solely by the problem description, it is most likely due to reported issue - https://bugs.openjdk.java.net/browse/JDK-8183100 It has been resolved in upcoming JDK 10 & also in upcoming 8u172 update. You can try out early access builds at - http://jdk.java.net/ - and s

RE: [11] Review request : JDK-8195806 : Eliminate dependency on sun.font.lookup in javafx.graphics

K "https://bugs.openjdk.java.net/browse/JDK-8198752"JDK-8198752 to handle that.   Regards, Ajit   From: Phil Race Sent: Thursday, February 15, 2018 10:44 PM To: Ajit Ghaisas Cc: Kevin Rushforth; openjfx-dev@openjdk.java.net Subject: Re: [11] Review request : JDK-8195806 : Eliminate dependency on

[11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

Hi Kevin, Mandy and Daniel, Please review the changeset that removes dependency on sun.util.logging package from JavaFX code. Bug : https://bugs.openjdk.java.net/browse/JDK-8195799 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8195799/webrev.0/ Request you to review. Regards,

RE: [11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

valid suggestions from Mandy and Daniel. Request you to review the new webrev. Regards, Ajit -Original Message- From: Kevin Rushforth Sent: Saturday, March 24, 2018 3:27 AM To: Ajit Ghaisas Cc: Mandy Chung; Daniel Fuchs; openjfx-dev@openjdk.java.net Subject: Re: [11] Review request : JDK

RE: [11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

Thanks for the review. As suggested, I have added Mandy’s point about loggers map to be addressed as part of JDK-8200236.   Regards, Ajit   From: Kevin Rushforth Sent: Tuesday, March 27, 2018 2:16 AM To: mandy chung Cc: Ajit Ghaisas; Daniel Fuchs; openjfx-dev@openjdk.java.net Subject: Re

RE: CFV: New OpenJFX Committer: Rajath Kamath

Vote: Yes Regards, Ajit -Original Message- From: Kevin Rushforth Sent: Thursday, March 29, 2018 10:12 PM To: openjfx-dev@openjdk.java.net; Rajath Kamath Subject: CFV: New OpenJFX Committer: Rajath Kamath I hereby nominate Rajath Kamath [1] to OpenJFX Committer. Rajath is a member of Ja

[11] Review request : JDK-8185854 : [JavaFX 9] NPE on non-editable ComboBox in TabPane with custom Skin

Hi, Please review below fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8185854 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8185854/webrev.0/ Request you to review. Regards, Ajit

[11] Review request : JDK-8177380 : Add standard colors in ColorPicker color palette

Hi, Request you to review this simple RFE. RFE : https://bugs.openjdk.java.net/browse/JDK-8177380 Fix : http://cr.openjdk.java.net/~aghaisas/fx/e8177380/webrev.0/ Regards, Ajit

[8u-dev] Review Request : JDK-8189677 : RadioMenuItem fires extra NULL value in property

Hi Kevin, Request you to review this 8u-dev backport : Bug : https://bugs.openjdk.java.net/browse/JDK-8189677 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8189677/8u/webrev.0/ Regards, Ajit

[11] Review request : JDK-8196827 : test.javafx.scene.control.ComboBoxTest - generates NullPointerException

Hi, Please review below fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8196827 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8196827/webrev.0/ Regards, Ajit

Re: JavaFX 11 - Where is ButtonBuilder, HBoxBuilder, etc...?

Hi, Builders were removed from JavaFX since jdk9. https://bugs.openjdk.java.net/browse/JDK-8092861 There is no alternative as such but to construct the needed scene graph objects directly. Please see description of https://bugs.openjdk.java.net

Re: CFV: New OpenJFX Committer: Nir Lisker

Vote : YES Regards, Ajit > On 26-Jun-2019, at 3:14 AM, Kevin Rushforth > wrote: > > I hereby nominate Nir Lisker [1] to OpenJFX Committer. > > Nir is an OpenJFX community member, who has contributed 16 changesets [2][3] > to OpenJFX. > > Votes are due by July 13, 2019. > > Only current Ope

Re: [Approved] RFR: 8231735: gradle checkrepo is obsolete and doesn't work with git

On Wed, 2 Oct 2019 13:48:58 GMT, Kevin Rushforth wrote: > https://bugs.openjdk.java.net/browse/JDK-8231735 > > This removes the obsolete `checkrepo` and `checkrepoall` gradle tasks. They > use a script which assumes Mercurial support, and so no longer run. Also, > with `git jcheck` support now

Re: RFR: 8233040: ComboBoxPopupControl: remove eventFilter for F4

On Thu, 31 Oct 2019 21:20:55 GMT, Kevin Rushforth wrote: > On Thu, 31 Oct 2019 15:04:35 GMT, Jeanette Winzenburg > wrote: > >> https://bugs.openjdk.java.net/browse/JDK-8233040 >> >> The issue is that the eventFilter in CBPC uses F4 for toggling the popup >> _and_ consumes it. This prevents cli

Re: RFR: 8233040: Fix: ComboBoxPopupControl - remove eventFilter for F4

On Thu, 31 Oct 2019 15:04:35 GMT, Jeanette Winzenburg wrote: > https://bugs.openjdk.java.net/browse/JDK-8233040 > > The issue is that the eventFilter in CBPC uses F4 for toggling the popup > _and_ consumes it. This prevents client code to register there own filter. > > The fix was to remove the

Re: RFR: 8233040: ComboBoxPopupControl: remove eventFilter for F4

On Tue, 5 Nov 2019 10:38:24 GMT, Jeanette Winzenburg wrote: > On Mon, 4 Nov 2019 12:46:57 GMT, Ajit Ghaisas wrote: > >> On Thu, 31 Oct 2019 15:04:35 GMT, Jeanette Winzenburg >> wrote: >> >>> https://bugs.openjdk.java.net/browse/JDK-8233040 >>> >

Re: [Approved] RFR: 8233040: ComboBoxPopupControl: remove eventFilter for F4

On Thu, 31 Oct 2019 15:04:35 GMT, Jeanette Winzenburg wrote: > https://bugs.openjdk.java.net/browse/JDK-8233040 > > The issue is that the eventFilter in CBPC uses F4 for toggling the popup > _and_ consumes it. This prevents client code to register there own filter. > > The fix was to remove

Re: [Integrated] RFR: 8233040: Fix: ComboBoxPopupControl - remove eventFilter for F4

Changeset: f74f3afb Author:Jeanette Winzenburg Committer: Ajit Ghaisas Date: 2019-11-05 12:08:33 + URL: https://git.openjdk.java.net/jfx/commit/f74f3afb 8233040: ComboBoxPopupControl: remove eventFilter for F4 Reviewed-by: aghaisas ! modules/javafx.controls/src/main/java

Re: [Rev 01] RFR: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

On Tue, 5 Nov 2019 15:43:03 GMT, Jeanette Winzenburg wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 0366a0a5: added copyright header > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/20/files > - new: https://git.

Re: [Rev 02] RFR: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

On Thu, 7 Nov 2019 11:51:02 GMT, Jeanette Winzenburg wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 92cd944e: changed as requested in review > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/20/files > - new: http

Re: [Approved] RFR: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

On Fri, 8 Nov 2019 10:32:58 GMT, Jeanette Winzenburg wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - fbdea3df: changed test to compile under oldish junit > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/20/files >

Re: [Integrated] RFR: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

Changeset: 94bcf3fc Author:Jeanette Winzenburg Committer: Ajit Ghaisas Date: 2019-11-12 04:21:17 + URL: https://git.openjdk.java.net/jfx/commit/94bcf3fc 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene Reviewed-by: aghaisas ! modules

RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

**Issue :** https://bugs.openjdk.java.net/browse/JDK-8193445 **Background :** The CSS performance improvement done in [JDK-8151756](https://bugs.openjdk.java.net/browse/JDK-8151756) had to be backed out due to functional regressions reported in [JDK-8185709](https://bugs.openjdk.java.net/browse

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > **Issue :** > https://bugs.openjdk.java.net/browse/JDK-8193445 > > **Background :** > The CSS performance improvement done in > [JDK-8151756](https://bugs.openjdk.java.net/browse/JDK-8151756) had to be > backed

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas wrote: > On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > >> **Issue :** >> https://bugs.openjdk.java.net/browse/JDK-8193445 >> >> **Background :** >> The CSS performance improvement done in >> [

Re: [Approved] RFR: 8233338: FX javadoc headings are out of sequence

On Thu, 31 Oct 2019 19:40:25 GMT, Kevin Rushforth wrote: > As indicated in > [JDK-828](https://bugs.openjdk.java.net/browse/JDK-828), this fixes > all of our javadoc HTML headings to conform with the rule that all HTML > heading tags in class documents must start with `` and be nested

RFR: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest

This PR is to address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest. strategy is as follows - 1) Enable tests marked with @Ignore by removing that tag 2) Run the test 3) If test Passes - remove the @Ignore tag 4) If test fails - if test is invalid - remove it

Re: [Approved] RFR: 8234110: SwingFXUtilsTest is unsuitable for unit test framework

On Wed, 13 Nov 2019 22:54:01 GMT, Kevin Rushforth wrote: > This fixes [JDK-8234110](https://bugs.openjdk.java.net/browse/JDK-8234110) by > moving `SwingFXUtilsTest` from the `:swing` project to the `:systemTests` > project. As explained in the JBS issue, `SwingFXUtilsTest` must be run in its >

Re: RFR: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest

On Thu, 14 Nov 2019 18:49:18 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 09:33:39 GMT, Ajit Ghaisas wrote: > >> This PR is to address ignored tests in ComboBoxTest, LabeledTest, >> HyperLinkTest and TextInputControlTest. >> >> strategy is as follows - >

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: > On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > >> **Issue :** >> https://bugs.openjdk.java.net/browse/JDK-8193445 >> >> **Background :** >> The CSS performance improve

Re: [Integrated] RFR: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest

Changeset: e37cb370 Author:Ajit Ghaisas Date: 2019-11-17 17:29:26 + URL: https://git.openjdk.java.net/jfx/commit/e37cb370 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest Reviewed-by: kcr ! modules/javafx.controls/src/test

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: > On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: > >> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: >> >>> **Issue :** >>> https://bugs.openjdk.java.net/browse/JDK-8193445 &

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve wrote: > On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: > >> On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: >> >>> On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: >>> >>>>

Re: [Rev 01] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

The pull request has been updated with additional changes. Added commits: - 2054da4c: Address review comments on test - 4dade6e5: Simpler fix + System test corrections - bd4a306a: Revert commit1 and commit 2 Changes: - all: https://git.openjdk.java.net/jfx/pull/34/files -

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

On Tue, 26 Nov 2019 09:22:02 GMT, Geoff wrote: > On Tue, 26 Nov 2019 09:22:02 GMT, Ajit Ghaisas wrote: > >> On Tue, 26 Nov 2019 09:22:01 GMT, David Grieve wrote: >> >>> On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: >>> >>>>

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

On Tue, 26 Nov 2019 09:22:01 GMT, David Grieve wrote: > On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: > >> On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve >> wrote: >> >>> On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: >>> >>&

Re: [Integrated] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

Changeset: 83eb0a7c Author:Ajit Ghaisas Date: 2019-11-27 07:05:15 + URL: https://git.openjdk.java.net/jfx/commit/83eb0a7c 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation Reviewed-by: kcr, dgrieve ! modules/javafx.graphics/src/main

Re: RFR: 8221334: TableViewSkin: must initialize flow's cellCount in constructor

On Fri, 29 Nov 2019 15:08:16 GMT, Jeanette Winzenburg wrote: > This is a fix for https://bugs.openjdk.java.net/browse/JDK-8221334 > > - fixed as outlined in the bug report: added updateItemCount() in skin > constructor (that's what all sibling skins are doing) > - added test which fails for Ta

Re: [Approved] RFR: 8221334: TableViewSkin: must initialize flow's cellCount in constructor

On Fri, 29 Nov 2019 15:08:16 GMT, Jeanette Winzenburg wrote: > This is a fix for https://bugs.openjdk.java.net/browse/JDK-8221334 > > - fixed as outlined in the bug report: added updateItemCount() in skin > constructor (that's what all sibling skins are doing) > - added test which fails for Ta

Re: [Rev 01] RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

On Fri, 6 Dec 2019 09:42:05 GMT, Jeanette Winzenburg wrote: >> fix for https://bugs.openjdk.java.net/browse/JDK-8220722 >> >> - replaces the manually registered listener with registerChangeListener(...) >> - added test that's failing before and passing after the fix (plus a sanity >> test that

Re: [Integrated] RFR: 8221334: TableViewSkin: must initialize flow's cellCount in constructor

Changeset: 07af89a9 Author:Jeanette Winzenburg Committer: Ajit Ghaisas Date: 2019-12-06 11:25:18 + URL: https://git.openjdk.java.net/jfx/commit/07af89a9 8221334: TableViewSkin: must initialize flow's cellCount in constructor Reviewed-by: aghaisas ! modules/javafx.con

Re: [Integrated] RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

Changeset: 71ca899f Author:Jeanette Winzenburg Committer: Ajit Ghaisas Date: 2019-12-09 08:08:34 + URL: https://git.openjdk.java.net/jfx/commit/71ca899f 8220722: ProgressBarSkin: adds strong listener to control's width property Reviewed-by: aghaisas, arapte ! mo

Re: [Rev 01] RFR: 8207759: VK_ENTER not consumed by TextField when default Button exists

On Tue, 10 Dec 2019 12:26:27 GMT, Jeanette Winzenburg wrote: >> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759 >> >> The issue is that default/cancel button on a scene are triggered even though >> a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug >

Re: [Rev 02] RFR: 8207759: VK_ENTER not consumed by TextField when default Button exists

On Mon, 16 Dec 2019 08:53:10 GMT, Jeanette Winzenburg wrote: >> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759 >> >> The issue is that default/cancel button on a scene are triggered even though >> a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug >

Re: [Rev 07] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 16 Dec 2019 11:47:15 GMT, Hadzic Samir wrote: >> Allright, this is a fix for JDK-8207957 > > The pull request has been updated with 1 additional commit. - Marked as reviewed by aghaisas (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/6

Re: [Integrated] RFR: 8207759: VK_ENTER not consumed by TextField when default Button exists

Changeset: d2d44b4a Author:Jeanette Winzenburg Committer: Ajit Ghaisas Date: 2019-12-17 11:44:42 + URL: https://git.openjdk.java.net/jfx/commit/d2d44b4a 8207759: VK_ENTER not consumed by TextField when default Button exists Reviewed-by: aghaisas, kcr ! modules

Re: [Rev 02] RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one

On Tue, 28 Jan 2020 09:03:40 GMT, Ambarish Rapte wrote: >> This PR is a fix for >> [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824) >> This issue is regression of >> [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074). >> >> Issue. >> - `Parent.viewOrderChildren` is

Re: [Rev 01] RFR: 8237469: CssStyleHelper reuse check fixed

On Tue, 28 Jan 2020 09:08:35 GMT, Dean Wookey wrote: >> Everything passes with the fix and 5 of the new tests fail without the fix. >> >> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest >> movingBranchToDifferentBranchGetsNewCssVariableTest >> removingThenAddingNodeToDifferentBranchG

Re: [Rev 02] RFR: 8237469: CssStyleHelper reuse check fixed

On Tue, 28 Jan 2020 09:47:33 GMT, Dean Wookey wrote: >> Everything passes with the fix and 5 of the new tests fail without the fix. >> >> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest >> movingBranchToDifferentBranchGetsNewCssVariableTest >> removingThenAddingNodeToDifferentBranchG

Re: RFR: 8237453: [TabPane] Incorrect arrow key traversal through tabs after reordering

On Wed, 5 Feb 2020 11:07:39 GMT, Ambarish Rapte wrote: > Issue: > Dragging a tab and dropping it back to it's original position causes an > incorrect reordering of tabs. Incorrect order of tabs can be observed using > arrow key traversal through tabs. > > Cause: > Below mechanism of identifyi

Re: [Rev 02] RFR: 8236839: System menubar removed when other menubars are created or modified

On Fri, 7 Feb 2020 10:54:44 GMT, Johan Kaving wrote: >> This pull request fixes the sceneProperty listener in `MenuBarSkin` so that >> we leave the >> current system menubar alone when other menubars are changed. >> >> It also adds a test case that reproduces the problem before the fix. > > P

Re: RFR: 8227619: Potential memory leak in javafx.scene.control.ListView

On Fri, 10 Jan 2020 08:17:12 GMT, Ambarish Rapte wrote: > `ListView` does not get GCed because `SelectedItemsReadOnlyObservableList` > adds a `ListChangeListener` to the (`ObservableList`) items of `ListView`. > > Adding a `WeakListChangeListener` instead of `ListChangeListener` fixes the > is

RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 Fix : Added the missed out RTL checks to the key mappings in TableViewBehaviorBase class. Testing : Modified unit tests in TableViewKeyInputTest to take orientation as a parameter. The Left/Right key press tests have been modified to addres

Re: [Rev 01] RFR: 8238434: Ensemble: Update version of Lucene to 7.7.2

On Tue, 4 Feb 2020 22:47:18 GMT, Kevin Rushforth wrote: >> Update the version of Lucene used by Ensemble to the latest release of >> Lucene 7 which is version 7.7.2. >> >> Per the instructions in >> [`UPDATING-lucene.txt`](https://github.com/openjdk/jfx/blob/master/apps/samples/Ensemble8/UPDAT

Re: RFR: 8238434: Ensemble: Update version of Lucene to 7.7.2

On Tue, 4 Feb 2020 22:41:37 GMT, Kevin Rushforth wrote: >> @aghaisas can you review this? > > I pushed a new commit that reverts the changes to the stored binary index > files. There is no need to regenerate them when upgrading to a new version > where only the `bugfix` number (the third digit

Re: RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

On Sat, 15 Feb 2020 14:54:50 GMT, Kevin Rushforth wrote: >> thanks, Kevin - that's what I tried, but it refused to accept the second .. >> so sticking with single comments until I feel like digging into this >> weirdness. > > Regarding the fix, it seems that you need to eliminate the `rtl` var

Re: [Rev 01] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 > > Fix : Added the missed out RTL checks to the key mappings in > TableViewBehaviorBase class. > > Testing : Modified unit tests in TableViewKeyInputTest to take orientation as > a parameter. The Left/Right key press tests have been modi

Re: [Rev 02] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 > > Fix : Added the missed out RTL checks to the key mappings in > TableViewBehaviorBase class. > > Testing : Modified unit tests in TableViewKeyInputTest to take orientation as > a parameter. The Left/Right key press tests have been modi

Re: [Rev 02] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

On Fri, 14 Feb 2020 11:18:12 GMT, Jeanette Winzenburg wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java > line 139: > >> 138: boolean rtl = isRTL(); >> 139:

Re: [Rev 02] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

On Sat, 15 Feb 2020 14:59:30 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java > line 102: > >> 101: >> 102: private NodeOrientation orientation; >> 103:

Re: [Rev 02] RFR: 8239822: Intermittent unit test failures in RegionCSSTest

On Mon, 24 Feb 2020 19:36:47 GMT, Kevin Rushforth wrote: >> This is a fix for an intermittent test failure affecting >> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in >> `test.javafx.scene.CssStyleHelperTest`, which was added as part of >> [JDK-8237469](https://bu

Re: [Rev 02] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

On Tue, 25 Feb 2020 15:10:50 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java >> line 1141: >> >>> 1140: keyboard.doLeftArrowPress(KeyModifier.getShortcutKey()); >>> 1141: } >>> 1142: keybo

Re: [Rev 02] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

On Fri, 28 Feb 2020 12:00:23 GMT, Ajit Ghaisas wrote: >> Also, I'm a bit weary about the "else if" (vs a simple "else") - wouldn't it >> be some kind of setup error if the node orientation is neither rtl nor ltr? >> If so, I would add a test t

Re: [Rev 01] RFR: 8237926: Potential memory leak of model data in javafx.scene.control.ListView

On Tue, 3 Mar 2020 13:06:52 GMT, Ambarish Rapte wrote: >> The selection model of ListView stores a strong reference to the most >> recently changed item in >> `SelectedItemsReadOnlyObservableList.itemsListChange`, which causes a leak. >> >> Fix: >> The below member variables and method of cla

Re: [Rev 03] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 > > Fix : Added the missed out RTL checks to the key mappings in > TableViewBehaviorBase class. > > Testing : Modified unit tests in TableViewKeyInputTest to take orientation as > a parameter. The Left/Right key press tests have been modi

Re: [Rev 04] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 > > Fix : Added the missed out RTL checks to the key mappings in > TableViewBehaviorBase class. > > Testing : Modified unit tests in TableViewKeyInputTest to take orientation as > a parameter. The Left/Right key press tests have been modi

Re: [Rev 04] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

On Sun, 1 Mar 2020 12:24:06 GMT, Jeanette Winzenburg wrote: >> @kleopatra is right about the need to handle the case where the orientation >> of a node changes. As for the test, I think the idea of parameterizing it >> with LTR, RTL is good. I haven't reviewed it in detail, but added one minor

  1   2   3   4   5   >