On Thu, 19 May 2022 13:13:01 GMT, Jay Bhaskar wrote:
> This PR is new implementation of JavaEvent listener memory management.
> Issue
> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1)
>
> 1. Calling remove event listener does not free jni global refere
stener explicitly removed , JavaEventListener is being
> forwarded to EventListenerManager to clear the listener.
> 7. When WebView goes out of scope, EventListenerManager will de-registered
> all the event listeners based on the ref counts attached with WebView
> DOMWindow.
Jay Bhaskar has
On Fri, 27 May 2022 15:42:09 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change for unregisterDomWindow function and code cleanup
>
> modules/javafx.web/
On Thu, 26 May 2022 17:00:46 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding space for map include
>
> modules/javafx.web/src/main/nativ
stener explicitly removed , JavaEventListener is being
> forwarded to EventListenerManager to clear the listener.
> 7. When WebView goes out of scope, EventListenerManager will de-registered
> all the event listeners based on the ref counts attached with WebView
> DOMWindow.
Jay Bhaskar has
stener explicitly removed , JavaEventListener is being
> forwarded to EventListenerManager to clear the listener.
> 7. When WebView goes out of scope, EventListenerManager will de-registered
> all the event listeners based on the ref counts attached with WebView
> DOMWindow.
Jay Bhaskar has
stener explicitly removed , JavaEventListener is being
> forwarded to EventListenerManager to clear the listener.
> 7. When WebView goes out of scope, EventListenerManager will de-registered
> all the event listeners based on the ref counts attached with WebView
> DOMWindow.
Jay Bhaskar has
On Wed, 25 May 2022 14:57:13 GMT, Ambarish Rapte wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments applied
>
> modules/javafx.web/src/main/native/Source/WebCore/bindings
On Wed, 25 May 2022 12:45:59 GMT, Ambarish Rapte wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments applied
>
> modules/javafx.web/src/main/native/Source/WebCore/bindings
stener explicitly removed , JavaEventListener is being
> forwarded to EventListenerManager to clear the listener.
> 7. When WebView goes out of scope, EventListenerManager will de-registered
> all the event listeners based on the ref counts attached with WebView
> DOMWindow.
Jay Bhaskar has
On Tue, 24 May 2022 14:54:19 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding JGObject in plave of raw jni object
>
> modules/javafx.web/src/main/nativ
stener explicitly removed , JavaEventListener is being
> forwarded to EventListenerManager to clear the listener.
> 7. When WebView goes out of scope, EventListenerManager will de-registered
> all the event listeners based on the ref counts attached with WebView
> DOMWindow.
Jay Bhaskar has
On Thu, 19 May 2022 21:45:00 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Platform.exit() , removing code block, as it is causing other test fail
>
> modu
On Thu, 19 May 2022 21:34:54 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Platform.exit() , removing code block, as it is causing other test fail
>
> modu
stener explicitly removed , JavaEventListener is being
> forwarded to EventListenerManager to clear the listener.
> 7. When WebView goes out of scope, EventListenerManager will de-registered
> all the event listeners based on the ref counts attached with WebView
> DOMWindow.
Jay Bhaskar has
stener explicitly removed , JavaEventListener is being
> forwarded to EventListenerManager to clear the listener.
> 7. When WebView goes out of scope, EventListenerManager will de-registered
> all the event listeners based on the ref counts attached with WebView
> DOMWindow.
Jay Bhaskar has
On Thu, 19 May 2022 15:22:08 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Platform.exit() , removing code block, as it is causing other test fail
>
> modules
This PR is new implementation of JavaEvent listener memory management.
Issue [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1)
1. Calling remove event listener does not free jni global references.
2. When WebView goes out of scope (disposed from app) , its Event Listeners
On Sat, 2 Apr 2022 08:29:43 GMT, Jay Bhaskar wrote:
> Issue: Floating point overflow , when making end point for line drawing as
> FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0);
> Solution: traverse widths to calculate end point and increment start point.
This pul
On Thu, 7 Apr 2022 09:55:36 GMT, Jay Bhaskar wrote:
>> Issue: Floating point overflow , when making end point for line drawing as
>> FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0);
>> Solution: traverse widths to calculate end point and increment start poin
> Issue: Floating point overflow , when making end point for line drawing as
> FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0);
> Solution: traverse widths to calculate end point and increment start point.
Jay Bhaskar has updated the pull request incrementally with one a
On Sat, 2 Apr 2022 08:29:43 GMT, Jay Bhaskar wrote:
> Issue: Floating point overflow , when making end point for line drawing as
> FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0);
> Solution: traverse widths to calculate end point and increment start po
Issue: Floating point overflow , when making end point for line drawing as
FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0);
Solution: traverse widths to calculate end point and increment start point.
-
Commit messages:
- Merge remote-tracking branch 'upstream/master'
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote:
> The file `wtf/linux/MemoryPressureLinux.cpp` was renamed
> `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428
> . In the openjfx workspace, both files are present. I'm removing the old file.
Since there ar
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote:
> The file `wtf/linux/MemoryPressureLinux.cpp` was renamed
> `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428
> . In the openjfx workspace, both files are present. I'm removing the old file.
Yes , The PR l
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote:
> The file `wtf/linux/MemoryPressureLinux.cpp` was renamed
> `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428
> . In the openjfx workspace, both files are present. I'm removing the old file.
The patch http
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote:
> Issue: The end point of line in drawLinesForText , add thickness to the
> endPoint.y(). In this case origin which is start point and the end point
> would not be same, and line would be drawn not straight.
> Solution: Do not a
gt; Start Point(x,y) --End Point(x + width, 0)
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
formating for drawline
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/731/files
- new: https://git.openj
On Tue, 8 Feb 2022 11:13:20 GMT, Jay Bhaskar wrote:
> Issue: The DataObject uses m_availMimeTypes as Vector of strings, and
> appending mime types in pasteboard operation like setPlainText, Hence it will
> append duplicate mime types in m_availMimeTypes , in this case t
On Mon, 27 Dec 2021 09:31:08 GMT, Jay Bhaskar wrote:
> Issue: The current implementation of DOMWindow ::localStorage(..) returns
> null pointer in case of page is being closed.
> Fix: It should not return nullptr , as per the [w3c web storage
> spec](https://www.w3.org/TR/2016/RE
expire data from the local storage areas only for
> security reasons or when requested to do so by the user. User agents should
> always avoid deleting data while a script that could access that data is
> running."
Jay Bhaskar has updated the pull request incrementally with one
On Thu, 3 Mar 2022 17:08:49 GMT, Jay Bhaskar wrote:
>> Issue: The current implementation of DOMWindow ::localStorage(..) returns
>> null pointer in case of page is being closed.
>> Fix: It should not return nullptr , as per the [w3c web storage
>> spec](https:
gt; Start Point(x,y) --End Point(x + width, 0)
Jay Bhaskar has updated the pull request incrementally with two additional
commits since the last revision:
- test needs width and height , during creattion of webview
- test needs width and height , during creattion of webview
---
ata would be copied to
> clipboard target.
> Solution: Use ListHashSet data Structure instead of Vector for
> m_availMimeTypes.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
removed automated test HTMLClipBoardTest.java,
ata would be copied to
> clipboard target.
> Solution: Use ListHashSet data Structure instead of Vector for
> m_availMimeTypes.
Jay Bhaskar has updated the pull request incrementally with five additional
commits since the last revision:
- added manual test
- Add new Test case for cop
On Tue, 1 Mar 2022 10:00:58 GMT, Ambarish Rapte wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up test and fix
>
> modules/javafx.web/src/main/native/Source/WebCore/page/DOM
expire data from the local storage areas only for
> security reasons or when requested to do so by the user. User agents should
> always avoid deleting data while a script that could access that data is
> running."
Jay Bhaskar has updated the pull request incrementally with one
gt; Start Point(x,y) --End Point(x + width, 0)
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
PR review changes applied
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/731/files
- new: https://git.openj
On Mon, 28 Feb 2022 15:12:37 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> New chnages for line test
>
> tests/system/src/test/java/test/javafx/scene/web/Str
On Mon, 28 Feb 2022 15:10:27 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> New chnages for line test
>
> tests/system/src/test/java/test/javafx/scene/web/St
expire data from the local storage areas only for
> security reasons or when requested to do so by the user. User agents should
> always avoid deleting data while a script that could access that data is
> running."
Jay Bhaskar has updated the pull request incrementally with one
On Mon, 28 Feb 2022 14:53:39 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add Review Changes
>
> modules/javafx.web/src/test/java/test/javafx/scene/web/Lo
On Mon, 28 Feb 2022 13:58:03 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add Review Changes
>
> modules/javafx.web/src/main/native/Source/WebCore/page/DOM
On Fri, 25 Feb 2022 17:54:48 GMT, Hima Bindu Meda wrote:
>> Basically, buttons property is a mask which represents the button/buttons
>> clicked on the mouse.
>> It is observed that event.buttons property is set to 0 when there is
>> mouse press or drag event.This behaviour is observed only
gt; Start Point(x,y) --End Point(x + width, 0)
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
New chnages for line test
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/731/files
- new: https://git.openj
expire data from the local storage areas only for
> security reasons or when requested to do so by the user. User agents should
> always avoid deleting data while a script that could access that data is
> running."
Jay Bhaskar has updated the pull request incrementally with one
On Sat, 5 Feb 2022 14:57:50 GMT, Kevin Rushforth wrote:
>> modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line
>> 857:
>>
>>> 855: return m_localStorage.get();
>>> 856: }
>>> 857:
>>
>> This will change the behavior for the case where page is null or wher
On Sun, 27 Feb 2022 05:25:25 GMT, Jay Bhaskar wrote:
>> modules/javafx.web/src/test/java/test/javafx/scene/web/LocalStorageTest.java
>> line 55:
>>
>>> 53:
>>> 54: private static final File LOCAL_STORAGE_DIR = new
>>> File("LocalS
expire data from the local storage areas only for
> security reasons or when requested to do so by the user. User agents should
> always avoid deleting data while a script that could access that data is
> running."
Jay Bhaskar has updated the pull request incrementally with one
On Fri, 25 Feb 2022 23:15:54 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Change Dir Path and use local Dir and set data before clearing
>> locals
On Sun, 27 Feb 2022 05:30:44 GMT, Jay Bhaskar wrote:
>> Agree
>
> Agree, done
Agree
-
PR: https://git.openjdk.java.net/jfx/pull/703
On Sun, 27 Feb 2022 05:30:34 GMT, Jay Bhaskar wrote:
>> modules/javafx.web/src/test/java/test/javafx/scene/web/LocalStorageTest.java
>> line 59:
>>
>>> 57: private static RandomAccessFile preLockedRaf;
>>> 58: private static FileLock preLockedLo
On Fri, 25 Feb 2022 23:09:00 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Change Dir Path and use local Dir and set data before clearing
>> locals
expire data from the local storage areas only for
> security reasons or when requested to do so by the user. User agents should
> always avoid deleting data while a script that could access that data is
> running."
Jay Bhaskar has updated the pull request incrementally with one
On Fri, 25 Feb 2022 07:11:49 GMT, Jay Bhaskar wrote:
>> Issue: The DataObject uses m_availMimeTypes as Vector of strings, and
>> appending mime types in pasteboard operation like setPlainText, Hence it
>> will append duplicate mime types in m_availMimeTypes , in this c
ata would be copied to
> clipboard target.
> Solution: Use ListHashSet data Structure instead of Vector for
> m_availMimeTypes.
Jay Bhaskar has updated the pull request incrementally with two additional
commits since the last revision:
- formating change
- formating change
--
ata would be copied to
> clipboard target.
> Solution: Use ListHashSet data Structure instead of Vector for
> m_availMimeTypes.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Test regression according to bug
--
ata would be copied to
> clipboard target.
> Solution: Use ListHashSet data Structure instead of Vector for
> m_availMimeTypes.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Test case chnaged
-
Ch
On Thu, 24 Feb 2022 16:05:41 GMT, Jay Bhaskar wrote:
>> Issue: The DataObject uses m_availMimeTypes as Vector of strings, and
>> appending mime types in pasteboard operation like setPlainText, Hence it
>> will append duplicate mime types in m_availMimeTypes , in this c
ata would be copied to
> clipboard target.
> Solution: Use ListHashSet data Structure instead of Vector for
> m_availMimeTypes.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
PR commnets applied
-
Ch
On Thu, 24 Feb 2022 12:42:49 GMT, Ambarish Rapte wrote:
>> Issue: The DataObject uses m_availMimeTypes as Vector of strings, and
>> appending mime types in pasteboard operation like setPlainText, Hence it
>> will append duplicate mime types in m_availMimeTypes , in this case the
>> length clip
On Sat, 19 Feb 2022 11:43:00 GMT, Jay Bhaskar wrote:
> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can
> cause a JS trap in WebView
This pull request has now been integrated.
Changeset: 73963960
Author: Jay Bhaskar
Committer: Kevin Rushforth
URL:
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote:
>> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can
>> cause a JS trap in WebView
>
> Jay Bhaskar has refreshed the contents of this pull request, and previous
> commits have been removed. Incr
> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can
> cause a JS trap in WebView
Jay Bhaskar has refreshed the contents of this pull request, and previous
commits have been removed. Incremental views are not available. The pull
request now contains one
On Tue, 22 Feb 2022 10:03:30 GMT, Jay Bhaskar wrote:
>> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can
>> cause a JS trap in WebView
>
> Jay Bhaskar has updated the pull request incrementally with two additional
> commits since the last re
> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can
> cause a JS trap in WebView
Jay Bhaskar has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'public-sec-bug' of https://github.com/jay
gt; Start Point(x,y) --End Point(x + width, 0)
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Improve style and width iterartion logic
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/731/files
On Sat, 19 Feb 2022 15:03:38 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update test case for line straightness check
>
> tests/system/src/t
On Mon, 21 Feb 2022 04:19:29 GMT, Jay Bhaskar wrote:
>> tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line
>> 163:
>>
>>> 161:
>>> 162: // buttom start x position of underline ( startx + font
>>> size + thickn
On Sat, 19 Feb 2022 14:55:30 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update test case for line straightness check
>
> tests/system/src/t
On Sat, 19 Feb 2022 14:45:53 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update test case for line straightness check
>
> tests/system/src/t
On Sat, 19 Feb 2022 16:51:52 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update test case for line straightness check
>
> tests/system/src/t
On Sat, 19 Feb 2022 14:32:46 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update test case for line straightness check
>
> tests/system/src/t
Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can
cause a JS trap in WebView
-
Commit messages:
- 8282134: Certain regex can cause a JS trap in WebView
Changes: https://git.openjdk.java.net/jfx/pull/739/files
Webrev: https://webrevs.openjdk.java.net/?repo
On Sun, 13 Feb 2022 07:35:32 GMT, Jay Bhaskar wrote:
>> Issue: The end point of line in drawLinesForText , add thickness to the
>> endPoint.y(). In this case origin which is start point and the end point
>> would not be same, and line would be drawn not straight.
>&
gt; Start Point(x,y) --End Point(x + width, 0)
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Update test case for line straightness check
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/731/files
On Sun, 13 Feb 2022 07:35:32 GMT, Jay Bhaskar wrote:
>> Issue: The end point of line in drawLinesForText , add thickness to the
>> endPoint.y(). In this case origin which is start point and the end point
>> would not be same, and line would be drawn not straight.
>&
gt; Start Point(x,y) --End Point(x + width, 0)
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
adjust thickness
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/731/files
- new: https://git.openjdk.java.n
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote:
> Issue: The end point of line in drawLinesForText , add thickness to the
> endPoint.y(). In this case origin which is start point and the end point
> would not be same, and line would be drawn not straight.
> Solution: Do not a
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote:
> Issue: The end point of line in drawLinesForText , add thickness to the
> endPoint.y(). In this case origin which is start point and the end point
> would not be same, and line would be drawn not straight.
> Solution: Do not a
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote:
> Issue: The end point of line in drawLinesForText , add thickness to the
> endPoint.y(). In this case origin which is start point and the end point
> would not be same, and line would be drawn not straight.
> Solution: Do not a
Issue: The end point of line in drawLinesForText , add thickness to the
endPoint.y(). In this case origin which is start point and the end point would
not be same, and line would be drawn not straight.
Solution: Do not add thickness to the y position of end point of line.
Start Point(x,y) --
Issue: The DataObject uses m_availMimeTypes as Vector of strings, and appending
mime types in pasteboard operation like setPlainText, Hence it will append
duplicate mime types in m_availMimeTypes , in this case the length
clipboardData.types would be wrong, and duplicates data would be copied to
On Sun, 6 Feb 2022 11:54:14 GMT, Jay Bhaskar wrote:
>> No, it's not OK for two reasons:
>>
>> 1. It prevents concurrent execution of tests from two different directories
>> 2. The Java temp directory might be something other than "/tmp" on some
>>
expire data from the local storage areas only for
> security reasons or when requested to do so by the user. User agents should
> always avoid deleting data while a script that could access that data is
> running."
Jay Bhaskar has updated the pull request incrementally with three
On Sat, 5 Feb 2022 15:01:37 GMT, Kevin Rushforth wrote:
>> i think /tmp/java-store is ok, as it would not require cleanup
>
> No, it's not OK for two reasons:
>
> 1. It prevents concurrent execution of tests from two different directories
> 2. The Java temp directory might be something other tha
On Sat, 5 Feb 2022 15:17:46 GMT, Jay Bhaskar wrote:
>> Can you comment on this?
>
> yes, your are right , i would change it
i will test unit case again after your suggested chnage
-
PR: https://git.openjdk.java.net/jfx/pull/703
On Sat, 5 Feb 2022 15:02:09 GMT, Kevin Rushforth wrote:
>> modules/javafx.web/src/test/java/test/javafx/scene/web/LocalStorageTest.java
>> line 60:
>>
>>> 58: assertNotNull(webEngine.executeScript("localStorage;"));
>>> 59: getEngine().executeScript("window.close();");
>
On Sat, 5 Feb 2022 15:04:37 GMT, Kevin Rushforth wrote:
>> The test runs after testLocalStorageSet , so there would be items in
>> localstorage
>
> No, this is a common misconception when writing JUnit tests. The test
> execution order is _not_ guaranteed and will change. Each test method needs
On Sat, 5 Feb 2022 14:58:25 GMT, Kevin Rushforth wrote:
>> in recent code base (webkit upgrade)the localstorage is false ,
>> @@ -1579,7 +1579,7 @@ NeedsSiteSpecificQuirks:
>> WebKit:
>>default: true
>> WebCore:
>> - default: false
>> + default: true
>>
>> So , it nee
On Sat, 5 Feb 2022 12:51:58 GMT, Jay Bhaskar wrote:
>> modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line
>> 859:
>>
>>> 857: if (page->isClosing() && m_localStorage)
>>> 858: return m_localStorage.
On Fri, 28 Jan 2022 00:10:31 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Fri, 28 Jan 2022 00:11:40 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
expire data from the local storage areas only for
> security reasons or when requested to do so by the user. User agents should
> always avoid deleting data while a script that could access that data is
> running."
Jay Bhaskar has updated the pull request with a new target bas
Issue: The current implementation of DOMWindow ::localStorage(..) returns null
pointer in case of page is being closed.
Fix: It should not return nullptr , as per the [w3c web storage
spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/)
"User agents should expire data from the local stora
95 matches
Mail list logo
