Re: TableCell: how to find the origin of fishy code?

2021-07-06 Thread Jonathan Giles
Seeing as I wrote the code, I wish I could remember why it is that way, but I unfortunately can't. My initial instinct is that this was unintentional, but I can't discount the possibility that a reason exists. I probably have much earlier versions of the code lying around, so I could research it i

Re: CFV: New OpenJFX Reviewer: Jeanette Winzenburg

2021-05-16 Thread Jonathan Giles
Yes -- Jonathan On Sat, 15 May 2021, 3:23 am Kevin Rushforth, wrote: > I hereby nominate Jeanette Winzenburg [1] to OpenJFX Reviewer. > > Jeanette is an OpenJFX community member, who has contributed 33 commits > [2][3] to OpenJFX. Jeanette consistently participates in code reviews of > various

Re: New API to read Caps-Lock and Num-Lock state

2021-01-17 Thread Jonathan Giles
ink Frederic meant that the Optional is empty in the case where you > can't reliably get the state of the key, otherwise the true and false > values are for the on and off states. The Optional itself is never null. > > On Sun, Jan 17, 2021 at 7:31 PM Jonathan Giles > wrote: > >

Re: New API to read Caps-Lock and Num-Lock state

2021-01-17 Thread Jonathan Giles
t the equivalent AWT method > > uses. FWIW, I don't generally like checked exceptions; we don't define > > any such exceptions in JavaFX and I wouldn't want to start now. > > > > -- Kevin > > > > > > On 1/16/2021 12:46 AM, Jonathan Giles wrote:

Re: New API to read Caps-Lock and Num-Lock state

2021-01-16 Thread Jonathan Giles
Hi friends, Just to throw out an alternate API approach (which I would not go anywhere near close to saying is a better approach), we could consider a three-value enum getter API: public static KeyLockState Platform::getKeyLockState(KeyCode keyCode); Where KeyLockState = { LOCKED, NOT_LOCKED, NO

Re: CFV: New OpenJFX Committer: Jeanette Winzenburg

2020-06-01 Thread Jonathan Giles
Vote: YES -- Jonathan (Tapped on a touch device) On Tue, 2 Jun 2020, 1:53 am Kevin Rushforth, wrote: > I hereby nominate Jeanette Winzenburg [1] to OpenJFX Committer. > > Jeanette is an OpenJFX community member, who has contributed 16 > changesets [2][3] to OpenJFX. > > Votes are due by June 15

Re: CFV: New OpenJFX Committer: Jose Pereda

2020-06-01 Thread Jonathan Giles
Vote: YES -- Jonathan (Tapped on a touch device) On Tue, 2 Jun 2020, 1:53 am Kevin Rushforth, wrote: > I hereby nominate Jose Pereda [1] to OpenJFX Committer. > > Jose is an OpenJFX community member, who has contributed 16 changesets > [2][3] to OpenJFX. > > Votes are due by June 15, 2020. > >

Re: TableView slow vertical scrolling with 300+ columns

2020-01-26 Thread Jonathan Giles
It's been a wee while since I built TableView, but from memory there is code in there that virtualises the columns, such that those that are scrolled out of view are not being included in the scenegraph needlessly. >From memory, to achieve this all you needed to do was set a fixed row height on the

Re: Table data entry

2019-07-08 Thread Jonathan Giles
ntry in tables. This means: enter commits value and moves focus to > another (not necessarily the next) cell. AFAIK one of the requirements is > the TableView & CellEditor patch that Jonathan Giles discussed while he was > still working at Oracle. I was wondering if that was ever impleme

Re: CFV: New OpenJFX Committer: Prem Balakrishnan

2018-07-12 Thread Jonathan Giles
Vote: yes -- Jonathan (Tapped on a touch device) On Wed, 11 Jul 2018, 10:57 PM Arunprasad Rajkumar, < arunprasad.rajku...@oracle.com> wrote: > Vote: Yes > > > On 11-Jul-2018, at 5:11 AM, Kevin Rushforth > wrote: > > > > I hereby nominate Prem Balakrishnan [1] to OpenJFX Committer. > > > > Prem

Re: Table Input

2018-06-20 Thread Jonathan Giles
Yup, A great regret. I wish it were supported, but it isn't due to historical legacy. There are some small ways you can make some progress, e.g. add focus listeners on the editor node, but they are half solutions at best. -- Jonathan (Tapped on a touch device) On Wed, 20 Jun 2018, 10:25 AM , wr

Re: Announcing EA builds of standalone JavaFX SDK

2018-05-08 Thread Jonathan Giles
Congrats to Kevin and team on this milestone! -- Jonathan (Tapped on a touch device) On Mon, 7 May 2018, 4:01 PM Kevin Rushforth, wrote: > I am pleased to announce the first Early Access build of a standalone > JavaFX SDK [1]. You can download it and run it using OpenJDK 10 or an > OpenJDK 11 E

Re: CFV: New OpenJFX Committer: Rajath Kamath

2018-03-05 Thread Jonathan Giles
Ankit, You should zoom out a little bit and look at the bigger picture. Does OpenJFX want more or less contributors? Does OpenJFX want to make the burden to becoming a committer easier or more difficult? Does OpenJFX want to be a community that welcomes or shuns people who are ready to contribute?

Re: More community participation in JavaFX

2018-02-06 Thread Jonathan Giles
requirements too great should be encouraged to involve themselves in projects such as JFXtras, etc. -- Jonathan On Wed, Feb 7, 2018 at 3:05 PM, Tom Eugelink wrote: > Many years ago I had a discussion with Jonathan Giles about if the things > that were being made in JFXtras would eventually

Re: New OpenJFX Committer: Laurent Bourgès

2017-12-12 Thread Jonathan Giles
Vote: yes -- Jonathan On 12/12/17, 1:25 PM, "openjfx-dev on behalf of Kevin Rushforth" wrote: I hereby nominate Laurent Bourgès [1] to OpenJFX Committer. Laurent is the author of the Marlin rasterizer, which is used as the default rasterizer for both Java2D and JavaFX. He h

Re: CFV: New OpenJFX Committer: Ambarish Rapte

2017-10-31 Thread Jonathan Giles
Vote: yes -- Sent from a touch device. Please excuse my brevity. On November 1, 2017 9:18:16 AM GMT+13:00, Kevin Rushforth wrote: >I hereby nominate Ambarish Rapte [1] to OpenJFX Committer. > >Ambarish is a member of JavaFX team at Oracle, who has contributed 10 >changesets [2][3] to OpenJFX.

Re: CFV: New OpenJFX Committer: Prasanta Sadhukhan

2017-09-27 Thread Jonathan Giles
Vote: YES On September 28, 2017 2:10:09 PM GMT+13:00, Kevin Rushforth wrote: >I hereby nominate Prasanta Sadhukhan [1] to OpenJFX Committer. > >Prasanta is a member of JavaFX team at Oracle, who has contributed 12 >changesets [2] to OpenJFX. > >Votes are due by October 11, 2017. > >Only current

Re: WebView and WebGL

2017-08-25 Thread Jonathan Giles
All, WebGL is something that is currently in the planning pipeline with a relatively high priority. This means it is not under active development yet, but we already have engineers working on the research towards this feature. Once this is concluded and the scope of the work better understood

Re: Skin fields visibility changed from protected to no modifier in Java9

2017-08-04 Thread Jonathan Giles
I can appreciate your desire to have more access to skin internals. As I was going through JEP 253 to make these APIs public I tried to be as clear as possible - at conferences, on openjfx-dev, via Twitter, etc - that developers urgently need to tell me what they want, as I couldn't just do a b

[Review request] 8185767: Fix broken links in Javadocs

2017-08-03 Thread Jonathan Giles
Jon, Kevin and / or Phil, Please review the webrev below. It improves the JavaFX javadocs such that there are (hopefully) no bad links any longer. https://bugs.openjdk.java.net/browse/JDK-8185767 http://cr.openjdk.java.net/~jgiles/8185767/ Thanks, -- -- Jonathan

[Review request] 8091673: Runtime should have a published focus traversal API for use in custom controls

2017-08-02 Thread Jonathan Giles
Kevin, Phil, Could you please review the webrev below, which aims to provide new public API for focus traversal in JavaFX. https://bugs.openjdk.java.net/browse/JDK-8091673 http://cr.openjdk.java.net/~jgiles/8091673.1 -- -- Jonathan

[Review request] 8178519: Consider removing two-level focus support from UI controls

2017-08-02 Thread Jonathan Giles
Kevin, Phil, Could you please review the webrev below, which aims to remove the unused two-level focus code that presently ships in JDK 9 and earlier releases. https://bugs.openjdk.java.net/browse/JDK-8178519 http://cr.openjdk.java.net/~jgiles/8178519/ Thanks, -- -- Jonathan

Re: JDK-8092206 : TabPane renders content of all tabs even only one is active

2017-07-14 Thread Jonathan Giles
This is correct. The intent is to offer this performance improvement as part of jdk 10, and not in earlier releases such as those you mention. -- Sent from a touch device. Please excuse my brevity. On July 14, 2017 6:55:06 PM GMT+12:00, Sverre Moe wrote: >This bug has Fix Version to 10. Does t

[Review request] 8181169: Block comments mistakenly used in place of missing javadoc comments

2017-06-05 Thread Jonathan Giles
Kevin, Could you please review the javadoc fix here: https://bugs.openjdk.java.net/browse/JDK-8181169 http://cr.openjdk.java.net/~jgiles/8181169/index.html Thanks -- -- Jonathan

Re: CFV: New OpenJFX Committer: Ajit Ghaisas

2017-05-26 Thread Jonathan Giles
Vote: yes On May 26, 2017 2:20:28 AM HST, Kevin Rushforth wrote: >I hereby nominate Ajit Ghaisas [1] to OpenJFX Committer. > >Ajit is a member of JavaFX team at Oracle, who has contributed 10 >changesets to OpenJFX. A list of these changesets is available by the >following link: > >http://hg.o

Commit on focus loss in ListView, TreeView, TableView, and TreeTableView

2017-05-04 Thread Jonathan Giles
Hi all, In the next week I have two topics to discuss, both with similar names but related to quite different functionality. The topic for today is adding the necessary API to the JavaFX UI control Cell class to enable support for 'commit on focus loss', that is, the ability to automatically

Re: Should there be getter methods in LabeledSkinBase?

2017-05-02 Thread Jonathan Giles
Thorsten, Your reference to JDK-8077916 is correct here. Our first goal was to simply get the skins into the public API in a minimal form. In some cases there was then follow-up feedback from the community regarding missing API, and there were improvements made. Your feedback here is the same

Re: 8173385: spelling errors in JavaFX javadoc

2017-01-30 Thread Jonathan Giles
etainAll doc comment... :( ...jim On 1/29/17 1:31 PM, Jonathan Giles wrote: Ajit, Could you please review the following jira issue and webrev: https://bugs.openjdk.java.net/browse/JDK-8173385 http://cr.openjdk.java.net/~jgiles/8173385/ Thanks

8173385: spelling errors in JavaFX javadoc

2017-01-29 Thread Jonathan Giles
Ajit, Could you please review the following jira issue and webrev: https://bugs.openjdk.java.net/browse/JDK-8173385 http://cr.openjdk.java.net/~jgiles/8173385/ Thanks -- -- Jonathan

Re: CFV: New OpenJFX Committer: Semyon Sadetsky

2017-01-25 Thread Jonathan Giles
Vote: yes On 26/01/17 8:39 AM, David Hill wrote: I hereby nominate Semyon Sadetsky to OpenJFX Committer. Semyon Sadetsky is part of the JavaFX team focusing on glass. A list of Semyon's commits and reviews is available by the following links http://hg.openjdk.java.net/openjfx/9-dev/rt/log?

Re: Need an official way to exclude parts of the SceneGraph from CSS-Processing

2017-01-24 Thread Jonathan Giles
{ if( ! cssSensitive ) { return; } } I do understand that I'm too late in JDK9 cycle to add such an API but one could at least dream about such a thing. Tom On 24.01.17 00:15, Jonathan Giles wrote: There are two different topics here, both of which are near and dear to my heart (and als

Re: Need an official way to exclude parts of the SceneGraph from CSS-Processing

2017-01-23 Thread Jonathan Giles
There are two different topics here, both of which are near and dear to my heart (and also make me feel like I've been doing JavaFX for way too long!). The specific case of TabPane doing CSS / layout on the content of all tabs is something captured here: https://bugs.openjdk.java.net/browse/

Re: Impossible to implement custom control with a StyleableObjectProperty on JavaFX9

2017-01-18 Thread Jonathan Giles
This sounds like a reasonable issue to discuss a resolution for. Can you please file a Jira issue and we can look into our options (either making a reapplyCss() method available, or following something along the lines of your suggestion)? Also, thanks for taking the time to test JDK 9 - this i

Re: Bugs in TreeTableViewSkin. resizeColumnToFitContent() - labels always ellipsized

2017-01-16 Thread Jonathan Giles
As far as I can recall there are no bug reports on this issue. Please do file them so that TreeTableView can be improved. Thanks. -- Jonathan On 13/01/17 10:00 PM, Daniel Glöckner wrote: Hi, we recently came across some limitations (you might call them bugs) in the tree table implementation.

Re: Testing your JavaFX applications on JDK 9

2017-01-16 Thread Jonathan Giles
Platform.firePulse() never existed, you're probably thinking of Toolkit.firePulse() (which is not public API)? A close replacement is Platform.requestNextPulse(). -- Jonathan On 17/01/17 10:00 AM, Tom Eugelink wrote: One of the methods I use a lot in Tests, to make sure something has happened

[Review request] 8140504:TreeView/TreeTableView show "index exceeds maxCellCount" warning after scrolling

2017-01-11 Thread Jonathan Giles
Ajit, Ambarish, Please can you review the webrev and discussion at the following links: https://bugs.openjdk.java.net/browse/JDK-8140504 http://cr.openjdk.java.net/~jgiles/8140504/ Thanks! -- -- Jonathan

[Review request] 8171926: Minor cleanup of API docs in controls

2017-01-09 Thread Jonathan Giles
Kevin, Could you please review the documentation cleanups done here: https://bugs.openjdk.java.net/browse/JDK-8171926 http://cr.openjdk.java.net/~jgiles/8171926/ Thanks, -- Jonathan

[Review request] 8171983: Add javadoc comments to module-info.java for javafx.* modules

2017-01-08 Thread Jonathan Giles
Kevin, Please review the webrev for adding module-level javadoc comments to all JavaFX modules defined in JDK 9: https://bugs.openjdk.java.net/browse/JDK-8171983 http://cr.openjdk.java.net/~jgiles/8171983/index.html Thanks, -- Jonathan

Re: Proposed fix for JDK-8170972

2016-12-09 Thread Jonathan Giles
Thanks for sending in this patch - I have attached it to the jira issue on your behalf. -- Jonathan On 9/12/16 8:44 AM, Itai wrote: It seems to me the source of the problem is line 466 in com.sun.javafx.util.Utils: //TODO - testing for an instance of Stage seems wrong but works fo

Re: Planning for JavaFX.next

2016-12-07 Thread Jonathan Giles
as possible. On 8-12-2016 00:45, Jonathan Giles wrote: Hi folks, Development on JDK 9 is slowly starting to ramp down, and we are starting to turn our attention to the goals for JavaFX in JDK 10 and beyond. We are starting to compile our list of what we think is important, but we really want t

Planning for JavaFX.next

2016-12-07 Thread Jonathan Giles
Hi folks, Development on JDK 9 is slowly starting to ramp down, and we are starting to turn our attention to the goals for JavaFX in JDK 10 and beyond. We are starting to compile our list of what we think is important, but we really want to hear from the community about what their highest pri

[Review request] 8169642: IndexOutOfBoundsException when sorting TreeTableView with multi-selection enabled

2016-11-20 Thread Jonathan Giles
Vadim, Please review the following issue: https://bugs.openjdk.java.net/browse/JDK-8169642 http://cr.openjdk.java.net/~jgiles/8169642/ Thanks! -- -- Jonathan

[9] Review request: 8168258: Remove bad Javadoc links in skin constructors

2016-10-18 Thread Jonathan Giles
Kevin, Could you please review the following webrev. This is a docs-only change. https://bugs.openjdk.java.net/browse/JDK-8168258 http://cr.openjdk.java.net/~jgiles/8168258 Thanks. -- -- Jonathan

[9] Review request: 8165624: TreeTableView: incorrect scrolling range

2016-10-09 Thread Jonathan Giles
Vadim, Could you please review the webrev for the mentioned issue: https://bugs.openjdk.java.net/browse/JDK-8165624 http://cr.openjdk.java.net/~jgiles/8165624/ Thanks! -- -- Jonathan

[9] Review request: 8167138: Menu does not respond on the repeating mouse clicks

2016-10-04 Thread Jonathan Giles
Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167138 http://cr.openjdk.java.net/~jgiles/8167138/ Thanks! -- -- Jonathan

[9] Review request: 8167137: Keyboard navigation through collapsed menus in menubar should not show sibling menus

2016-10-04 Thread Jonathan Giles
Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167137 http://cr.openjdk.java.net/~jgiles/8167137/ Thanks! -- -- Jonathan

[9] Review request: 8167134: Keyboard navigation between menus in menubar leads to incorrect selection

2016-10-04 Thread Jonathan Giles
Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167134 http://cr.openjdk.java.net/~jgiles/8167134/ Thanks! -- -- Jonathan

[9] Review request: 8167132: Menu keyboard navigation retains previous focus index

2016-10-04 Thread Jonathan Giles
Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167132 http://cr.openjdk.java.net/~jgiles/8167132/ Thanks! -- -- Jonathan

[9] Review request: 8167055: TableViews with many columns lose alignment between headers and cells

2016-10-03 Thread Jonathan Giles
Vadim, Please review the webrev for the following issue: https://bugs.openjdk.java.net/browse/JDK-8167055 http://cr.openjdk.java.net/~jgiles/8167055/ Thanks! -- -- Jonathan

[9] Review request: 8166950,Memory Leak: MenuBar added to Tab is still referenced on tab close and is not garbage collected

2016-10-02 Thread Jonathan Giles
Kevin, Chien, Please can you review the webrev for the following issue: https://bugs.openjdk.java.net/browse/JDK-8166950 http://cr.openjdk.java.net/~jgiles/8166950 Thanks -- -- Jonathan

[9] Review request: 8166025: TableColumnHeader: loses custom style classes

2016-09-28 Thread Jonathan Giles
Kevin and / or Vadim, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8166025 http://cr.openjdk.java.net/~jgiles/8166025.3/ Thanks! -- Jonathan

[9] Review request: 8166021: NestedTableColumnHeader: package private access to skin prevents custom headers

2016-09-28 Thread Jonathan Giles
Kevin and / or Vadim, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8166021 http://cr.openjdk.java.net/~jgiles/8166021/ Thanks! -- -- Jonathan

[9] Review request: 8166013: NestedTableColumnHeader: must use factory method for header creation always

2016-09-28 Thread Jonathan Giles
Kevin and / or Vadim, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8166013 http://cr.openjdk.java.net/~jgiles/8166013.1/ Thanks! -- -- Jonathan

Re: JavaFX XYChart with CategoryAxis Performance Issue

2016-08-31 Thread Jonathan Giles
Without a small snippet of code that reproduces the problem, not really. If you can create a self-contained test that demonstrates the problem, I can take a look at it. -- Jonathan On 1/09/16 7:08 AM, Tai Hu wrote: I am using JavaFX XYChart to plot some big data set (1+ points). If both X

Re: CFV: New OpenJFX Committer: Andrey Rusakov

2016-07-24 Thread Jonathan Giles
Vote: yes -- Jonathan On 24 July 2016 02:42:39 GMT+12:00, Kevin Rushforth wrote: >I hereby nominate Andrey Rusakov [1] to OpenJFX Committer. > >Andrey is a member of JavaFX SQE team at Oracle working on test >development, who has contributed 19 changesets [5] to OpenJFX, at least > >8 of which

Re: CFV: New OpenJFX Committer: Ankit Srivastava

2016-07-19 Thread Jonathan Giles
vote: YES -- Jonathan On 20/07/16 1:37 AM, David Hill wrote: I hereby nominate Ankit Srivastava to OpenJFX Committer. Ankit Srivastava is part of the JavaFX team focusing on Web. A list of Ankit's commits and reviews is available by the following links http://hg.openjdk.java.net/openjfx/8u-

Re: ProgressIndicator indeterminate transition bugs

2016-07-13 Thread Jonathan Giles
ote: Great! In that case forget the patch I made, it doesn’t make sense until the treeVisible property is implemented. Is there any jira ticket that I could follow? Thank you Jonathan. From: Jonathan Giles [mailto:jonathan.gi...@oracle.com] Sent: Dienstag, 8. März 2016 10:01 To:

Re: Reentrent call to Control.createDefaultSkin()

2016-06-22 Thread Jonathan Giles
I think this is a reasonable expectation. Can you please file an issue and we can progress it from there? Thanks, -- Jonathan On 23/06/16 7:31 AM, Tom Schindl wrote: Hi, Take a look at the stack below. ComboBoxListViewSkin(ComboBoxBaseSkin).(ComboBoxBase, ComboBoxBaseBehavior) line: 57

[Review request] Editable ComboBox / Spinner controls need uniform 'commit on focus lost' semantics

2016-06-16 Thread Jonathan Giles
Hi all, Please review my addition of 'commitValue' / 'cancelEdit' APIs to Spinner and ComboBox. These APIs mirror the API on TextInputControl, and allows for the controls (rather than their skins) to properly commit on focus loss. Previously committing on focus loss was handled by the contro

[Review request] Handling Enter key presses on Buttons in JavaFX

2016-06-16 Thread Jonathan Giles
rowse/JDK-8159121 Thanks, -- Jonathan On 8/06/16 9:47 AM, Jonathan Giles wrote: Hi all, One thing I've been looking into recently is the issue of what the Enter key should do when it is pushed with regards to buttons in a UI where one of those buttons is a 'default' button.

Re: Handling Enter key presses on Buttons in JavaFX

2016-06-07 Thread Jonathan Giles
wrote: What about forgetting the whole notion of a "default button" and the only effect of setting the default property to true being that the button will start as focused? So I add a question: 3) Would anyone miss the "default button"? Tomas On Tue, Jun 7, 2016 a

Handling Enter key presses on Buttons in JavaFX

2016-06-07 Thread Jonathan Giles
Hi all, One thing I've been looking into recently is the issue of what the Enter key should do when it is pushed with regards to buttons in a UI where one of those buttons is a 'default' button. There are number of Jira issues on this topic, and I wanted to poll the community to understand it

Re: Regression test development: JDK-8139764

2016-06-01 Thread Jonathan Giles
Andrey, Both issues you've posted about here I have previously +1'd in the jira issue. If the webrev changes or needs more review from me, please just continue the discussion in there and clarify what is needed. -- Jonathan On 2/06/16 4:23 AM, Andrey Rusakov wrote: Please look at my regressi

Re: HEADS-UP: plan to integrate a newer WebKit into 9-dev next week.

2016-05-30 Thread Jonathan Giles
I'm not involved in WebKit work at all (so I'm no authority on this), but it sounds like what you're asking is already answered in Kevin's email that you quoted. -- Jonathan Sent from a touch device. Please excuse my brevity. On 31 May 2016 07:52:25 GMT+12:00, Matthieu BROUILLARD wrote: >Sorr

Re: Request for backport of JDK-8144501

2016-05-09 Thread Jonathan Giles
Unfortunately openjfx-dev stripped the attachment, so please send that directly to me. Are you certain that the linked changeset is the only change necessary to resolve the issue? A lot of code has changed in the selection models, and whilst the linked changeset is small enough that it can be

Re: CFV: New OpenJFX Committer: Murali Billa

2016-03-31 Thread Jonathan Giles
Vote: YES -- Jonathan On 1/04/16 10:04 AM, Kevin Rushforth wrote: I hereby nominate Murali Billa [1] to OpenJFX Committer. Murali is a member of JavaFX team at Oracle working on WebKit, who has contributed 10 changesets [5] to OpenJFX, at least 8 of which are significant. Votes are due by

Re: JavaFX Application Heat up MacBook Pro

2016-03-28 Thread Jonathan Giles
There are known issues regarding ProgressIndicator and unintended CPU usage. These will be fixed in JDK 9, but the work is pending new API in the scenegraph related to knowing exactly whether a Node is actually 'tree visible' or not. -- Jonathan On 29/03/16 8:53 AM, Tai Hu wrote: I finally p

Re: FX-9: Plans for InputMap?

2016-03-20 Thread Jonathan Giles
Jeanette, There are no plans to make this into public API for the initial release of JDK 9. Depending on time availability and priorities, it is possible it may make its way into an update release, pending community review and some degree of consensus. -- Jonathan On 18/03/16 10:45 PM, fast

RE: ProgressIndicator indeterminate transition bugs

2016-03-08 Thread Jonathan Giles
>agree and I would like to add that having in the public API would be >even better :-). > >Thank you, >Diego > >-Original Message- >From: Jonathan Giles [mailto:jonathan.gi...@oracle.com] >Sent: Sonntag, 28. Februar 2016 22:54 >To: Cirujano Cuesta, Diego; openj

Re: ProgressIndicator indeterminate transition bugs

2016-02-28 Thread Jonathan Giles
If you can, are you able to file bug reports for these? -- Jonathan On 29/02/16 10:49 AM, Cirujano Cuesta, Diego wrote: Hi all, We found two important bugs in ProgressIndicator that are related with the following tickets: https://bugs.openjdk.java.net/browse/JDK-8094829 https://bugs.openjdk.

Re: Traversal sub-system

2016-02-16 Thread Jonathan Giles
Yes, it is something that Leif is exploring for JDK 9. It is not a hard commitment, but is something we are trying to get into JDK 9. See here: https://bugs.openjdk.java.net/browse/JDK-8091673 -- Jonathan On 17/02/16 11:10 AM, Hervé Girod wrote: Hello, I'm sure this has already been answered

Re: Public API to find node at specific coordinates

2016-02-02 Thread Jonathan Giles
Check out my blog post here: http://fxexperience.com/2016/01/node-picking-in-javafx/ It might be useful -- Jonathan On 3/02/16 10:36 AM, Scott Palmer wrote: Do we have such an API yet? I found this: https://bugs.openjdk.java.net/browse/JDK-8091684 and: https://bugs.openjdk.java.net/brows

Re: TableCellSkinBase: columnVisibility/Width should be protected

2016-02-01 Thread Jonathan Giles
7;t mind keeping the overhead low until we have logical chunks of work either. -- Jonathan On 2/02/16 5:58 AM, faste...@swingempire.de wrote: Zitat von Jonathan Giles : In moving most of the skin code to public API (as part of JEP 253), I worked with the plan of minimising the API as much as possi

Re: TableCellSkinBase: columnVisibility/Width should be protected

2016-01-31 Thread Jonathan Giles
In moving most of the skin code to public API (as part of JEP 253), I worked with the plan of minimising the API as much as possible, and would then spend time this year bringing API back out in a more considered way (as opposed to dumping all skin code, warts and all, into public API and makin

Re: Committing (rather than cancelling) cell changes on focus loss

2016-01-25 Thread Jonathan Giles
g? Unfortunately I can't find a page with TableView / TreeTableView UX specification any more, but this behaviour is not specified there. It causes a problem in the application I'm working on, where the selection has a business meaning. Regards, Konstantin 2016-01

Committing (rather than cancelling) cell changes on focus loss

2016-01-25 Thread Jonathan Giles
Hi all, I've been aware for a very long time that many people would love to see the default behavior for the ListView / TreeView / TableView / TreeTableView controls change from being 'cancel edit on focus lost' to 'commit edit on focus lost' when users are editing the value of a cell. I bel

[Review request] 8090477: Customizable visibility timing for Tooltip

2016-01-20 Thread Jonathan Giles
Kevin, Please review the latest patch attached here: https://bugs.openjdk.java.net/browse/JDK-8090477 Thanks -- -- Jonathan

Re: RT-46214 - TreeTableView performance

2016-01-17 Thread Jonathan Giles
I can't look into this in depth immediately, but I do recall working on this some months back, and I'm fairly sure I resolved it for JDK 9. I just quickly run the test application attached to JBS-8147483 and can not see the cells being recreated (after the initial creation). I will follow this

Re: CFV: New OpenJFX Committer: Johan Vos

2015-12-21 Thread Jonathan Giles
Vote: YES -- Jonathan On 22/12/15 8:45 AM, David Hill wrote: I hereby nominate Johan Vos to OpenJFX Committer. Johan Vos (jvos) has been active in the OpenJFX community, and instrumental in the maturity of Monocle, the owner of the Android and IOS ports and is an OpenJFX Author. A list of

Re: [Review request] 8145143: Promote Image.impl_getUrl() to public API as Image.getUrl()

2015-12-10 Thread Jonathan Giles
ote: As i see it the url is optional so wouldn't make sense to return Optional to make this more explicit? Tom Von meinem iPhone gesendet Am 10.12.2015 um 21:54 schrieb Jonathan Giles : Hi Chien, Kevin, Please can you review the following JBS issue (and attached patch): https://bugs.o

[Review request] 8145143: Promote Image.impl_getUrl() to public API as Image.getUrl()

2015-12-10 Thread Jonathan Giles
Hi Chien, Kevin, Please can you review the following JBS issue (and attached patch): https://bugs.openjdk.java.net/browse/JDK-8145143 As the subject line states, this issue proposes to promote the Image.impl_getUrl() method to Image.getUrl(), so that it is public API. -- -- Jonathan

[Review request] 8144625: Expose code and char properties on KeyCode

2015-12-10 Thread Jonathan Giles
Hi Kevin, all, Please review the patch attached to the following JBS issue: https://bugs.openjdk.java.net/browse/JDK-8144625 This change removes the impl_getCode() and impl_getChar() methods from KeyCode, and adds in getCode() and getChar() methods. -- -- Jonathan

[Review request] Promote TableColumn reorderable property to public API

2015-12-09 Thread Jonathan Giles
Hi Kevin, all, Please review the patch attached to the following JBS issue: https://bugs.openjdk.java.net/browse/JDK-8144962 This API removes the deprecated TableColumnBase.impl_reorderable property, and replaces it with a TableColumnBase.reorderable property. Thanks, -- Jonathan

[Review Request] Provide API to expose list of showing Windows

2015-12-09 Thread Jonathan Giles
Hi Kevin, all, Please review the most recent patch attached to the following JBS issue: https://bugs.openjdk.java.net/browse/JDK-8144628 This API removes the Window.impl_getWindows() method that returned an Iterator, and replaces it with Window.getWindows(), which returns an unmodifiable Obse

Re: JavaFX on Raspberry Pi

2015-12-05 Thread Jonathan Giles
I've not tested myself, but this might help: http://gluonhq.com/gluon-supports-javafx-embedded-binary-builds-now-available/ -- Jonathan Sent from a touch device. Please excuse my brevity. On 6 December 2015 15:29:27 GMT+13:00, Scott Palmer wrote: >I seem to recall that the Arm builds of Java 8

Reviewing impl_* methods in JavaFX

2015-12-02 Thread Jonathan Giles
Hi all. As you may recall a few months back I kicked off a review of APIs that exist in com.sun.* packages that were going to be lost due to the arrival of JDK 9. This resulted in a small number of APIs being proposed and made public in the last few weeks. With JDK 9 slipping we think it is p

Re: TableCell.getTableRow() return value

2015-11-25 Thread Jonathan Giles
I have filed and attached the issue here: https://bugs.openjdk.java.net/browse/JDK-8144088 @Kevin - would you mind giving this a quick API review please? -- Jonathan On 26/11/15 10:00 AM, Jonathan Giles wrote: I found the Jira issue I was looking forunfortunately it lacks a lot of detail

Re: TableCell.getTableRow() return value

2015-11-25 Thread Jonathan Giles
e the same issue in this proposed change. -- Jonathan On 26/11/15 6:46 AM, Richard Bair wrote: You should be able to add generics compatibly, you just can't change the generics signature. One shot to get it right IIRC. On Nov 25, 2015, at 8:57 AM, Jonathan Giles wrote: It was an oversi

Re: TableCell.getTableRow() return value

2015-11-25 Thread Jonathan Giles
n 26/11/15 6:46 AM, Richard Bair wrote: You should be able to add generics compatibly, you just can't change the generics signature. One shot to get it right IIRC. On Nov 25, 2015, at 8:57 AM, Jonathan Giles wrote: It was an oversight at the time, and (from memory) is now a breaking chang

Re: TableCell.getTableRow() return value

2015-11-25 Thread Jonathan Giles
It was an oversight at the time, and (from memory) is now a breaking change to fix it, so for now it remains as it is, sadly. -- Jonathan Sent from a touch device. Please excuse my brevity. On 26 November 2015 03:33:04 GMT+13:00, Lawrence Parker wrote: >Seems like getTableRow() should return T

Re: JavaFX community site

2015-11-24 Thread Jonathan Giles
Given I've been name checked I'll respond :-) I believe the JavaFX Community site was automated - it basically aggregated a number of blogs regardless of the individual blog posts relevance. The challenge was the upfront discovery of relevant websites and adding them to the aggregator. I am a

Re: [9] API review request: 8090585: Provide an official API to start the JavaFX platform

2015-11-22 Thread Jonathan Giles
I don't believe there is any inconsistency here. We are preserving the existing semantics in PlatformImpl.startup to not prevent duplicate calls by default, whilst we are reversing the semantics for the public API in Platform, where we do prevent duplicate calls. The end result is that we have

[Review request] 8097917: add a pulse listener facility

2015-11-18 Thread Jonathan Giles
Hi all, Please review the new API proposal for a pulse listener API on Scene at the URL below. The proposed patch file is attached to the jira issue. https://bugs.openjdk.java.net/browse/JDK-8097917 Thanks, -- Jonathan

[Review request] 8090865: Please make Toolkit.enterNestedEventLoop and exitNestedEventLoop public API

2015-11-17 Thread Jonathan Giles
Hi all, Please review the new API proposal for the ability to enter and exit nested event loops at the URL below. The proposed patch file is attached to the jira issue. https://bugs.openjdk.java.net/browse/JDK-8090865 Thanks, -- Jonathan

Re: Bug when combining ListView and SortedList?

2015-11-17 Thread Jonathan Giles
If there are any that I've missed or that you think are higher priority, leave a comment in the jira issue or email me the issue IDs. -- Jonathan On 18/11/15 1:55 AM, faste...@swingempire.de wrote: Jonathan, thanks for the clarification, I indeed misunderstood the new tag. On the other hand

[REVIEW REQUEST] JDK-8143033: Performance issue with JavaFX

2015-11-16 Thread Jonathan Giles
Kevin, Leif, Could you please review the patch attached here: https://bugs.openjdk.java.net/browse/JDK-8143033 Whilst the patch itself is tiny, a sanity check that what I'm doing would be much appreciated. Refer to my comment in Jira for more context. Thanks, -- Jonathan

Re: Bug when combining ListView and SortedList?

2015-11-16 Thread Jonathan Giles
Have been reporting variants (and ranting and suggesting fixes) for ages ... and now seeing that some of those reports got tagged "nicetohave" ... dhhh Jeanette, You are misinterpreting the 'nicetohave' label as a negative. The actual fact is that the 'nicetohave' label is applied to i

Re: Accessing JavaFX's StageHelper and ContextMenuContent in Jigsaw

2015-11-06 Thread Jonathan Giles
Neither of these classes are currently planned to be moved into public API for JDK 9. You should file separate requests in bug tracker so we can discuss the feasibility of both of these classes. -- Jonathan On 6/11/15 11:48 PM, Rahman USTA wrote: Hi all; I'm trying Jigsaw build with my JavaF

Re: Lunch, dinner, anyone?

2015-10-25 Thread Jonathan Giles
I have organised a lunch as per usual. Email me off-list for the details. -- Jonathan On 25/10/2015 8:06 p.m., Mario Torre wrote: Hi all, Is there going to be a lunch/dinner/breakfast/beer/something like last year at JavaOne? I didn't see any email on the mailing list (but I've been a bit off

Re: Backport for [JDK-8131151] Pressing ESC in a nested alert closes self and parent alert

2015-10-12 Thread Jonathan Giles
FYI - this is now backported and will be in 8u72. -- Jonathan On 24/09/2015 8:37 p.m., Werner Lehmann wrote: Hi, since there seems to be an opportunity to have fixes backported to 8, I'd like to ask for a backport of the fix for [JDK-8131151] Pressing ESC in a nested alert closes self and p

  1   2   3   >